This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 26, 2024
-
-
Nicolò Pretto authored
* IS_EMBEDDING_SDK_BUILD -> IS_EMBEDDING_SDK to keep things simple, as we already have that name in other places * don't load metabase css in sdk stories * first two stories * make the store not a global "singleton" anymore * basic test for font-family styles in the SDK * allow any custom font in theme.fontFamily as we actually support it * fix tests using hardcoded default font family
-
- Aug 27, 2024
-
-
Nicolò Pretto authored
* use loki to test png exports on questions * try to put the img in the body to see if it fixes the scrollbar issues in ci * fix linting issues * let's try again in ci * Attempt to make CI wait before taking a snapshot for downloaded PNGs * Use the snapshots from CI for PNG downloads * pdf export test thanks to kelvin suggestion about just testing the png * refactored the code to extract a util function * remove pdf tests as they broke in ci
* Update frontend/src/metabase/env.ts Co-authored-by:Phoomparin Mano <poom@metabase.com> * Update frontend/src/metabase/lib/loki-utils.ts --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Aug 12, 2024
-
-
Denis Berezin authored
-
- Aug 08, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Sync storybook colors with the main app * Fix Metabase badge color * Fix wrong mixed brand colors * Add mistakenly removed colors * Update comments * Correct `brand-light` color * Fix wrong Mantine button color when passing `color` prop * Update loki snapshots
-
- Aug 05, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Update popover dark theme on part of ParameterFieldWidget (#45813) * Add filter visual tests * Simplify embed CSS colors * [WIP] theme filter popover * Move theme to global node, so it affects portal too * Fix embed colors * Theme part of ParameterFieldWidget * Add story for parameter with dropdown * Update loki snapshots * Update more popover style * Update loki snapshots * Remove outdated snapshots * Update loki snapshots with production build * Fix loki not working with `userEvent` * Theme mantine popover * Improve dark theme text-brand visibility * Update loki snapshots from master change * Fix new colors not working in SDK * Fix flaky Loki tests * Filter popover dark theme part 2 (#46284) * Theme Date all options * wip add month and year filter * Fix wrong CSS custom property declaration * Test hover state * Update Loki snapshots * Theme date month and year * Add quarter and year tests * Theme date single and date range * Style relative date * Update frontend/src/metabase/admin/datamodel/components/filters/pickers/DatePicker/DatePickerHeader.styled.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Complete theming filter popover night mode (#46365) * Style unit of time and number widget * Attempt to fix flaky Loki snapshots * Address white background checkbox on dark theme * Style search filter single value * Fix mis color * Update snapshots * Remove duplication on play functions since they're long * Milestone 2 polishing (#46382) * Matches the footer padding with header padding * Update snapshots * Add E2E to prevent further problem * Try to reduce flaky Loki tests * Remove unused color shades (#46421) * Update no results illustration to work better on dark theme * Update loki snapshots --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Jul 30, 2024
-
-
Denis Berezin authored
* Add SDK context header * Update naming * Update naming * Add client header for embedded context * Add client header for embedded context * Add sdk version header * Fix e2e * Fix storybook build * Refactor to inject version in build step * Fix unit tests * Self review * Fix e2e * Fix e2e * Fix e2e * Fix e2e * Fix e2e
-
- Jul 24, 2024
-
-
Denis Berezin authored
-
- Jul 17, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* refactor: Simplify code (#44275) * Remove dead code * Remove values same as default options * Simplify hook API: Removing unused argument * review: Remove redundant code * Update look and feel copy (#44277) * Update static embed tab name * Update copies + rearrange settings * Use Mantine Select * Fix E2E tests by applying new copies * Fix unit tests * Fix more E2E tests * review: Add a comment on Mantine `value` quirk * Adjust spacing and relevant tests * Move `transparent` theme to its own toggle option (#44362) * Reorder the function to match the visual order * Make function name consistent * Introduce the new background option (do nothing yet) * Remove redundant exports * Tighten up values to reduce confusion * Make the parameters order consistent * Only show background option on dashboads (spec) * Allow dashboard embed background to be transparent * Make filter background and header/footer transparent * Fix type error * Fix unit tests * Fix E2E tests * Fix checkerboard pattern not showing when no background * Add unit tests * Add missing copy update * Remove remnants from outdated solutions within the PR * Improve code comment references * Fix E2E tests since the last copy change * Fix type errors from merging master * Update light theme style (#44488) * Add background to dashboard filter on light theme * Make position sticky works with transparent background * Fix sticky filters not working on theme=transparent * Fix unit tests * Simplify IntersectionObserver components + fix E2E tests * Add storybook for embedded dashboard * Clarify the use of ExplicitSize context * Remove unused code * Formatting * Review: Better mock `isWithinIframe` * Update dark theme to match the new design (#45134) * Update light theme checkerboard colors * Update checkerboard colors * Consolidate dashboard light/dark border style * Use `--mb-color-text-primary` for light theme dashboard * Update embed dashboard dark theme primary color * Migrate dashboard text-secondary color * Migrate text-tertiary color * Migrate gold, axis, and split line to CSS custom properties * Fix failed e2e tests * Fix static viz not working * Update loki snapshots * Remove unnecessary CSS custom property * Make diff more consistent * Address review: reusing type * Support backward compatibility when passing `theme=transparent` (#45214) * Match preview query with the actual code query * Handle backward compatibility when `theme=transparent` on dashboard * Add unit tests * Address review: Make tests less repetitive * Update Metabase banner upsell UI (#45424) * Prepare folder for nested components * Update upsell UI - add `fullWidth` variant - align title to the left * Fix Upsell banner having horizontal scroll on full width * Add new Metabase banner upsell component * Fix unit tests * Address review: Fix typo Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> * Address review: Move upsel UI to `admin/upsells` Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> * Remove unnecessary ESLint disable comment We can remove it since the file is in admin folder, and is already excluded from the rule. * Address review: remove default value property Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Address review: Extract magic number --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * More UI updates (#45450) * Update dark theme text colors to match the new design * Update powered by metabase logo * Update loki snapshots * Fix unit tests * Fix formatting * Fix wrong dark theme metabase logo badge color * Address review: Compress SVG with svgo Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix E2E tests * Update loki snapshots * Clarify Metabase base colors with comments --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Add more tests (#45628) * Add static embed question stories * Add loki snapshots * Add transparent theme for static dashboard tests * Add transparent theme tests for static questions * Assert `background` option in analytics tests * Remove tests for logic that has been moved * Update loki snapshots * Fix failed E2E tests from merging master --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Jun 21, 2024
-
-
Denis Berezin authored
* Add global styles to storybook, fix default fonts display * Update loki testing screenshots
-
- Jun 14, 2024
-
-
Phoomparin Mano authored
* replace color-mod with color-mix * update alpha values to round to 5% * add deprecation notice to lighten, darken and alpha * update loki reference image * add alpha value css variables to storybook preview * update loki reference image
-
- Jun 10, 2024
-
-
Denis Berezin authored
feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light, text-medium, admin-navbar, `accentX` (#43687) * Migrate text-brand * Migrate text-dark * Migrate text-light * Migrate text-medium * Migrate admin-navbar * make compact formatting consistent across all series (#43472) * make compact formatting consistent across all series * fix rebase * [Browse] Show Browse models link in nav only when there are models (#43286) * Upgrade to TypeScript v5.4 (#43736) * use correct github api for CI (#43750) * update list of releases (#43754) * Multi Series Dashcards Render with Filters Applied To All Series (#43428) * Multi Series Dashcards Render with Filters Applied To All Series Fixes: #39083 Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each card in the multi-series card. * Small refactor for executing dashcards in a pulse context. - move execute-dashboard-subscription to pulse.util - this fn now will also execute all card series cards and put those results into a list on the key :series-results in the dashcard which is then used in the render multimethod to send the correct data to the javascript context A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key * Fix up render fn The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more understandable. Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes * pull :data up a level from :result in the series cards * Update src/metabase/pulse/render/body.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Remove unneeded let * set/rename-keys won't work here because we raise the :data key I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data from within the result key up to the same level (and dissoc result). I've renamed the helper function to make its purpose a bit clearer --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Hydrate can_run_adhoc_query and address review comments (#43747) This is a followup on #43625. * Consolidate dashboard-card specs (#43716) * Consolidate joins specs (#43717) * Update translations for v50 and add Danish Language Support (#43314) * update translations for v50 * add Danish * update translations for v50 release * alphabetical order is nice * Move database role to url parameters from connection properties on Snowflake (#43602) * Move role to url parameters from connection properties * Fix test * Fix width of save button in cache sidebar (#43755) * Remove dead code (#43603) * Combine search e2e specs (#43718) * Highlight the table cell data in dashboards when the cell is an ID column (#43728) * highlight id cell column * add simpletable stories * add simple table test data * add loki reference image * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Remove old repro for 39150 (#43749) * Fix remaining `tinyint` booleans in MySQL (#43296) * Correct type for `report_card.dataset` This was missed in the original migration of boolean types to ${boolean.type} in MySQL/MariaDB, and then missed again by me when I migrated `collection_preview` over a week ago. * Change all boolean types to `bit(1)` in MySQL Liquibase changed their boolean type in MySQL from `bit(1)` to `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these as booleans, so we needed to migrate them to `bit(1)`s. As discussed [here](#36964), we changed all existing `boolean` types that were in the `001_update_migrations.yml` but not the SQL initialization file. For new installations, this works: things in the SQL initialization file get created with the `bit(1)` type. However, for existing installations, there's a potential issue. Say I'm on v42 and am upgrading to v49. In v43, a new `boolean` was added. In this case, I'll get the `boolean` from the liquibase migration rather than from the SQL initialization file, and it need to be changed to a `bit(1)`. I installed Metabase v41 with MySQL, migrated the database, and then installed Metabase v49 and migrated again. I made a list of all the columns that had the type `tinyint`: ``` mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE, COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test'; +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | TABLE_SCHEMA | TABLE_NAME | COLUMN_NAME | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | metabase_test | core_user | is_datasetnewb | tinyint | 1 | NO | | metabase_test | metabase_field | database_required | tinyint | 0 | NO | | metabase_test | metabase_fieldvalues | has_more_values | tinyint | 0 | YES | | metabase_test | permissions_group_membership | is_group_manager | tinyint | 0 | NO | | metabase_test | persisted_info | active | tinyint | 0 | NO | | metabase_test | report_card | dataset | tinyint | 0 | NO | | metabase_test | timeline | archived | tinyint | 0 | NO | | metabase_test | timeline | default | tinyint | 0 | NO | | metabase_test | timeline_event | archived | tinyint | 0 | NO | | metabase_test | timeline_event | time_matters | tinyint | NULL | NO | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ 10 rows in set (0.01 sec) ``` Then wrote migrations. For each column, we: - turn it into a `bit(1)`, - re-set the previously existing default value, and - re-add the NOT NULL constraint, if applicable. * Change author and add missing `dbms` --------- Co-authored-by:
John Swanson <john.swanson@metabase.com> * Add ts-pattern library (#43752) * Add events to measure search performance (#43135) * new_search_query event * Filters in object, search click event * updating event schema * type and event schema adjustments * delete comments BE code * adjusting tests * PR feedback * typos and spacing * Fixup missing colors --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
SakuragiYoshimasa <ysrhsp@outlook.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
Denis Berezin authored
* Migrate success * Migrate summarize * Migrate warning * Migrate white * Add colors to storybook * Fix CI * Fix CI * Codereview fixes * Convert warning color
-
- Jun 07, 2024
-
-
Phoomparin Mano authored
* dashcard background color * add bg-dashboard and bg-dashboard-card * rename background-visualization to background-question * apply bg-question to embedded questions * use CSS variables along with theme object * add css variables to more places * add ability to reference design system colors for defaults * use CSS variables for defaults * fix chart skeleton test * fix legend item title
-
- Jun 06, 2024
-
-
Sloan Sparger authored
-
- Jun 05, 2024
-
-
Denis Berezin authored
* Migrate danger * Migrate dark * Migrate error * Migrate filter * Migrate focus * Migrate saturated * Migrate shadow * Fix CI * Fix CI * Fix CI
-
Denis Berezin authored
* Migrate brand * Migrate brand-light, brand-lighter * Fix unit tests * Code review fixes * Fix CI
-
Denis Berezin authored
* Migrate bg-error * Migrate bg-medium * Migrate bg-night * Migrate bg-white * Migrate border * Fix CI * Fix unit tests * Fix unit tests * Code review fixes * Code review fixes
-
- Jun 03, 2024
-
-
Denis Berezin authored
* Convert black * Convert bg-light * Convert bg-dark * Convert bg-black * Fix CI * Fix CI * Fix tests * Update visual test fixtures * Fix visual tests
-
- May 28, 2024
-
-
Romeo Van Snick authored
* Pass current values to shouldCreate * Allow comma to create new item * Simplify getAvailableSelectItems * Add unit test for MultiAutocomplete input * Use text instead of Text in paste * Handle spaces in MultiAutocomplete * Remove cast * Reuse last var * Use haveLastBeenCalledWith over haveBeenCalledWith * Handle pasting when there is text in the input already * Accept quote-delimited values * Add info icon * Handle tab as a separator * Fix test cases for unsanitized parseValues * Add csv-parse * Use csv-parse to parse values * Apply the correct color to the info icon * Rename util to utils * Break up tooltip text * Only return unique values * Be more accepting around quotes in the middle of unescaped values * provide Buffer for csv-parse package in storybook * Use browser-friendly version of csv-parse * Remove unused eslint rule * Add specital case for csv-parse to jest config * Put uniqueness check in each state update * Only add partial value if it is valid * Only add partial value if it is valid * Fix test case for FilterValuePicker * Just use Set Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Allow parsing more than one value * Use isValid everywhere it makes sense * Add test for RTL languages --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Apr 19, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate --border-* * Migrate *breadcrumb* * Migrate --color-bg-black * Migrate --color-bg-dark * Migrate --color-bg-light * Migrate --color-bg-medium * Migrate --color-bg-white * Migrate --color-border * Migrate --color-brand* * Migrate --color-error * Migrate --color-focus * Migrate --color-shadow * Migrate --color-success * Migrate --color-text-dark * Migrate --color-text-light * Migrate --color-text-medium * Migrate --color-text-white * Migrate --color-white * Migrate --default-border-radius * Migrate --default-button-border-radius * Migrate --default-font-family * Migrate --default-font-size * Migrate --default-header-margin * Migrate --gap-1 * Migrate --icon-width * Migrate --input-border-color * Migrate --input-border-radius * Migrate --margin-* * Migrate --muted-color * Migrate --padding-* * Migrate --page-header-padding * Migrate --subtitle-color * Migrate --title-color * Reset to master * Remove unused --color-text-default * Remove unused --color* * Remove unused CSS custom properties * Prefix only necessary CSS custom properties
-
- Feb 28, 2024
-
-
Denis Berezin authored
* Add local-global styles * Add local-global styles * Fix missed rules * Fix vendors styles * Revert emotion refactors * Fix vendor styles * Fix eslint * Fix e2e tests * Fix review comments * Fix * Code review fixes * Hotfix after merge
-
- Nov 14, 2023
-
-
Uladzimir Havenchyk authored
-
- Nov 09, 2023
-
-
Nick Fitzpatrick authored
* Adding Stacked Checkbox component * Switching to checkbox variant * PR Feedback * Storybook cleanup * including description
-
- Oct 27, 2023
-
-
Anton Kulyk authored
-
- Aug 15, 2023
-
-
Alexander Polyankin authored
-
- Jun 08, 2023
-
-
Alexander Polyankin authored
-
- Jun 07, 2023
-
-
Kyle Doherty authored
-
- Jun 02, 2023
-
-
Maz Ameli authored
* arrow_left * check mark * arrow_up and chevrons * add, close, contract, embed, expand, sort * change viewbox to 16 * icons in +New menu, search, and sidebar toggle * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons * fix database icon * ellipsis, person, and tweak ellipsis size in collections sidebar * home, reference or book, pencil or edit, table * dashboard action icons, and remove reference to unused ClockIcon.jsx * question action icons and related component tweaks * larger icons on HomeModelCard on homepage * dashboard and add_to_dash * snippet and variables * all the chart type icons and some field type ones * mail and groups * make sidebar icons darker blue * fix add-your-data icon * filled mail icon and use it on events modal * stars * bolt and x-rays and a bunch more * granular, metric, revision history * arrows, formula, snippets * click, cloud, boolean, unpin * return, hourglass, popover * pause, ldap, burger * gear info list pin moon sum sun verified warning * fix size of row details modal icons * fix size of left nav icons * fix size on filter widgets and some selects * set default size to 16 to fix entity menu icons etc * fix pagination icons * size and color on ItemPicker * bump up database icon in /browse to 32px * /browse bolt icon size * find and remove instances of 14px size declarations * sql editor icons * sql expand/contract button alignment * collection breadcrumbs * remove two more size 14 declarations * viz selector * fix add icon in New button * fix size of ModelDetailLink * icon for question list empty state * get rid of model_framed icon * try to fix event tick icons, replace balloons with cake * standardize size of question footer actions * fix dinosaur * switch star_outline to star, and star to star_filled * fix notebook sort action * switch data picker from table2 to table * fix slack icon * restyle HomeXrayCard * fix List icon * fix sidebar toggle icon size * fix icon size in field picker popovers * fix summarize sidebar field type icons * fix summarize sidebar Add buttons * table heading sort icons * fix filter icon, resize button icons * bulk filters icons * admin datamodel icons sizing * fix datamodel metric and segment icons, and sort icon * dashboard interactivity sidebar close icon * get rid of grabber2 * bookmark and question actions icon sizes * revert icon * Icons cleanup (#31147) * remove timeline event icon stroke * cleanup * add 16x16 viewbox to svgs that were missing it * add slack_colorized * correct the join_full_outer icon * timeline events, cleanup * fix broken icons * more cleanup * fix storybook * fix all types * add stories * try fixing arrow_split --------- Co-authored-by:
Maz Ameli <maz@metabase.com> * fix specs * fix specs * remove unused icons * use constants * increase node memory allocation * bump for chromatic too * fixes * fix arrow_split icon * fix arrow_split path attributes * fix path again and fix sizing of drillthrough menu icons * more spec fixes * prettier --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
- Feb 06, 2023
-
-
Kyle Doherty authored
-
- Feb 03, 2023
-
-
Kyle Doherty authored
-
- May 30, 2022
-
-
Alexander Polyankin authored
-
- May 26, 2022
-
-
Alexander Polyankin authored
-
- Jan 28, 2022
-
-
Alexander Polyankin authored
-
- Jan 20, 2022
-
-
Alexander Polyankin authored
-
- Jan 12, 2022
-
-
Alexander Polyankin authored
-
- Jan 04, 2022
-
-
Alexander Polyankin authored
-
- Nov 29, 2021
-
-
Alexander Polyankin authored
-
- Apr 11, 2017
-
-
Tom Robinson authored
-
- May 12, 2016
-
-
Tom Robinson authored
-
- Apr 20, 2016
-
-
Tom Robinson authored
-