This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 15, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
-
Chris Truter authored
-
- Aug 14, 2024
-
-
Nicolò Pretto authored
-
Phoomparin Mano authored
* update question state * update question state * reload metadata for runQuestionOnNavigate * fix runnable queries * fix cannot run question * extract question predicate functions to question.ts * update types * create utils subfolder for query builder * fix query builder predicate imports * naming tweaks to be more self-explanatory * document the non-intuitive loadQuestion useEffect * change imports to support metric * remove unused import * revert originalQuestion check to try to fix e2e failures --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Romeo Van Snick authored
* Add defaultTemporalBucket helper * Add helper to pick default breakout * Move breakout to the front or add one if it does not exist * Add updateQuery to AggregationPicker props * Add tests for creation and reordering of temporal breakouts * Reuse defaultTemporalBucket in withDefaultTemporalBucket * Reorder query operations to make sure the correct names get generated * Remove dependency on referential equality of breakout * Rename updateQuery to onQueryChange * Remove onAddAggregations and onUpdateAggregation for onQueryChange * Extract query update in to separate function * Remove on{Add,Update,Remove}Aggregation in favor of onQueryChange * Remove aggregations from summarize details * Fix e2e tests * Remove conflicting test * Fix recent clause in unit tests * Fix superflouous check for columnAndBucket * Future proof breakout check * Remove reliance on details in the useSummarize hook * Remove details in unit tests * Removal of default summarization should not trigger a query change
-
- Aug 13, 2024
-
-
github-automation-metabase authored
-
Phoomparin Mano authored
* add setup commands * fix settings definition * update environment variables for cli * handle instances not being ready * update error messages * add more specific loading messages * loading spinner state * improve error message * use a fixed demo setup token * remove extraneous spinner * update status checks * update container messages * update wait timing * create api keys * extract constants * remove manual steps * Add anonymous tracking + other things. will need to clean up * Modify SDK for better structure * remove line from print.ts * Update webpack.embedding-sdk-cli.config.js back to production * Add types and add quick note * Fix a typo * Add index file, simplify types, use an array * Add safer json parsing * use delay of 100ms between each setup call * Suggestions from review * ensure that cli works * Attempt to fix jest errors * Remove node-fetch from sdk code to hopefully get unit tests working again * add database connection * add connection details handling * refactor asking for database connection info * apply actual database id for syncing schema * fix failing database sync step * allow table selection * create model for each table * handle errors in model creation * fix incorrect model display name * create x-rays based on user data * consolidate instance setup message * workaround for inquirer eventemitter issue * add sample components * fix yarn.lock file * add sample components * set spinner to fail state when instance setup fails * use a transparent background by default * update cli welcome messages * add import notice * refactor imports * update snippet to add dashboard dropdown * cli add credential file to users .gitignore * add docs on quickstart * clear screen with console.clear * address code review feedback Co-authored-by:
Nicolò Pretto <info@npretto.com> * allow node 18 lts --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Chris Truter authored
-
Nicolò Pretto authored
-
Nicolò Pretto authored
-
Nicolò Pretto authored
fix(sdk): make sure generated password has at least one number, one upper case and one lower case character to avoid issues with password policies (#46737)
-
- Aug 12, 2024
-
-
Denis Berezin authored
-
Alexander Solovyov authored
-
Uladzimir Havenchyk authored
* dx: raise an error if lodash is used * fix lint errors * use ts-deepmerge * don't throw an error * use correct type * use merge form icepick
-
Alexander Solovyov authored
-
Oisin Coveney authored
-
- Aug 09, 2024
-
-
github-automation-metabase authored
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor * Fix wrong colors when passing empty SDK `colors` * Clean up CSS custom properties * Add missing color mapping to the SDK * Add missing colors to the main app * Only override additional dynamic colors when values are passed * Fix unit tests * Address review Co-authored-by:
Phoomparin Mano <poom@metabase.com> --------- Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Aug 08, 2024
-
-
Chris Truter authored
-
Chris Truter authored
-
Mahatthana (Kelvin) Nomsawadi authored
Follow-up milestone 2 for [Epic] Re-design transparent theme for static embedding and public links (#46491) * Update new Metabase base colors * Make hover and selected state consistency * Fix wrong embed frame border color * Refactor: extract props * Fix border color * Fix pivot table cell hover color * Fix smart scalar text contrast * Add smart scalar tests + update text color design * Theme dashboard card menu * Remove dashcard action menu tests since they don't work in loki * Fix storybook background color for dark theme * Update loki snapshots * Disable untestable tests * Make sure all storybook inherit all necessary base styles * Skip untestable tests * Update loki snapshots
-
github-automation-metabase authored
-
Ngoc Khuat authored
-
Phoomparin Mano authored
* add setup commands * fix settings definition * update environment variables for cli * handle instances not being ready * update error messages * add more specific loading messages * loading spinner state * improve error message * use a fixed demo setup token * remove extraneous spinner * update status checks * update container messages * update wait timing * create api keys * extract constants * remove manual steps * Add anonymous tracking + other things. will need to clean up * Modify SDK for better structure * remove line from print.ts * Update webpack.embedding-sdk-cli.config.js back to production * Add types and add quick note * Fix a typo * Add index file, simplify types, use an array * Add safer json parsing * use delay of 100ms between each setup call * Suggestions from review * ensure that cli works * Attempt to fix jest errors * Remove node-fetch from sdk code to hopefully get unit tests working again * add database connection * add connection details handling * refactor asking for database connection info * apply actual database id for syncing schema * fix failing database sync step * allow table selection * create model for each table * handle errors in model creation * fix incorrect model display name * create x-rays based on user data * consolidate instance setup message * workaround for inquirer eventemitter issue * fix yarn.lock file --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
- Aug 07, 2024
-
-
github-automation-metabase authored
-
Phoomparin Mano authored
* add setup commands * fix settings definition * update environment variables for cli * handle instances not being ready * update error messages * add more specific loading messages * loading spinner state * improve error message * use a fixed demo setup token * remove extraneous spinner * update status checks * update container messages * update wait timing * create api keys * extract constants * remove manual steps * Add anonymous tracking + other things. will need to clean up * Modify SDK for better structure * remove line from print.ts * Update webpack.embedding-sdk-cli.config.js back to production * Add types and add quick note * Fix a typo * Add index file, simplify types, use an array * Add safer json parsing * use delay of 100ms between each setup call * Suggestions from review * ensure that cli works * Attempt to fix jest errors * Remove node-fetch from sdk code to hopefully get unit tests working again * fix yarn.lock file * revert capture groups change --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Dennis Schridde authored
== Goal == Currently the config file (`MB_CONFIG_FILE_PATH`) only allows adding or changing databases, but not removing them. Since connected databases can be managed as a service by us, it becomes necessary to delete any information Metabase has about them, including any stored credentials. Since this is a destructive operation with no way to revert (without restoring from a backup), we raise the bar for accidental deletion and require not just a (boolean) flag, but a magic string to be set. == How to test == 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. 2. Start your Metabase instance. 3. Verify the database shows up in the "admin" section and it works. Create a dashboard and questions using the database. 4. Add a `delete: "DELETE_WITH_DEPENDENTS:${name}"` line to your database configuration section. 5. Restart your Metabase instance. 6. Verify the database no longer shows up in the "admin" section. Notice that questions using it are gone, too. References: https://github.com/metabase/harbormaster/issues/5173
-
- Aug 06, 2024
-
-
Raphael Krut-Landau authored
fix(webapp/browse): Fix bug where verified filter is applied to recents even when no verified models exist (#46462)
-
Anton Kulyk authored
* Add repro test * Fix selectors and getSubmittableQuestion * Add null check
-
metamben authored
-
Raphael Krut-Landau authored
-
Denis Berezin authored
-
- Aug 05, 2024
-
-
Alexander Solovyov authored
mt/with-temp opens transaction which is used by toucan to make requests, so `mt/with-db` had no impact on database used inside of mt/with-temp
-
Mahatthana (Kelvin) Nomsawadi authored
* Update popover dark theme on part of ParameterFieldWidget (#45813) * Add filter visual tests * Simplify embed CSS colors * [WIP] theme filter popover * Move theme to global node, so it affects portal too * Fix embed colors * Theme part of ParameterFieldWidget * Add story for parameter with dropdown * Update loki snapshots * Update more popover style * Update loki snapshots * Remove outdated snapshots * Update loki snapshots with production build * Fix loki not working with `userEvent` * Theme mantine popover * Improve dark theme text-brand visibility * Update loki snapshots from master change * Fix new colors not working in SDK * Fix flaky Loki tests * Filter popover dark theme part 2 (#46284) * Theme Date all options * wip add month and year filter * Fix wrong CSS custom property declaration * Test hover state * Update Loki snapshots * Theme date month and year * Add quarter and year tests * Theme date single and date range * Style relative date * Update frontend/src/metabase/admin/datamodel/components/filters/pickers/DatePicker/DatePickerHeader.styled.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Complete theming filter popover night mode (#46365) * Style unit of time and number widget * Attempt to fix flaky Loki snapshots * Address white background checkbox on dark theme * Style search filter single value * Fix mis color * Update snapshots * Remove duplication on play functions since they're long * Milestone 2 polishing (#46382) * Matches the footer padding with header padding * Update snapshots * Add E2E to prevent further problem * Try to reduce flaky Loki tests * Remove unused color shades (#46421) * Update no results illustration to work better on dark theme * Update loki snapshots --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Aug 02, 2024
-
-
Ryan Laurie authored
* YOLO * fix a lot of tests * fix more tests * fix unit tests * remove comment * update tests and formatting * add debug code * remove debug code
-
Sloan Sparger authored
-
Sloan Sparger authored
* wip * moves code to enterprise folder, adds enterprise guards, updates conditionals as to when to show the feature * impls filter date logic, improves styling, mocks out real endpoint with collection items endpoint, updates table with isLink boolean rath er than using custom item renderer, removes dead code * use the actual url for stale * so many things... updated design, custom table component, polish, misc. refactors, more correct api typing * updates to pagination component and reverts some now unused changes to the base items table * impls pr feedback * fixes * fixes failing unit test * completes pr feedback from raffi * implements second round of feedback from raffi * adds tests and couple of small fixes / feedback * migrate clean up action to enterprise plugin and fix related e2e test, also skip the collection items count query when we do not need the value * finish main base case e2e test * clean up helper code for manual testing and add OSS test to make sure feature is not available in OSS * better handling of min-height on smaller screens * adds internal undo notification for bulk archiving in the clean up modal * reset pagination when items are archived/unarchived to keep users from getting stuck on a page beyond the current view * pr feedback * further cleanup * unit test fix * fixes issue where archiving all items in the modal and then undoing does not result in the stale items list getting refetched --------- Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Ryan Laurie authored
* hide notebook button for brand new questions * test notebook button visibility for new questions * move brand new check inside shouldRender * test embedding SDK notebook button * update unit tests * add spy to shouldRender
-