Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 09, 2021
  2. Aug 07, 2021
  3. Aug 06, 2021
  4. Aug 05, 2021
  5. Aug 04, 2021
  6. Aug 03, 2021
    • dpsutton's avatar
      correct moderation review hydration (#17311) · 84f4509d
      dpsutton authored
      * remove moderation reviews hydration
      
      * Restore hydration of moderation_reviews and handle correctly
      
      nested hydration is (i think) positional. So if you get something
      handed to you you must return something in that position. Prevoiusly
      was removing nils and then returning a smaller collection of hydrated
      items (cards here). But this meant input might look like this
      
      [card1 nil card2] and return [card1 card2] and in the nested hierarchy
      things didn't get matched up correctly.
      
      In the real world application it might look like this:
      
      ```clojure
      {:ordered-cards
       [{:card-id 1}
        {:card-id nil
         :viz-settings {info-for text-card}}
        {:card-id 2}]}
      ```
      
      And the nil card comes into this function and we return them in a
      strange manner things get wonky
      Unverified
      84f4509d
    • Maz Ameli's avatar
      update strings for 0.40.2 · 730cb591
      Maz Ameli authored
      730cb591
    • Nemanja Glumac's avatar
      Update `project.clj` references (#17294) · af99fc02
      Nemanja Glumac authored
      * Remove `project.clj` from Percy workflows
      
      * Replace `project.clj` with `deps.edn` in `build-for-test` script
      
      * Update reference to the `project.clj` in the comment
      Unverified
      af99fc02
    • Howon Lee's avatar
      Make the field search do limits (whacks #17228) (#17283) · 6331c3b1
      Howon Lee authored
      We're playing this whackamole because we added the middleware to universally sorta stomp on any `limit` or `offset` params, and they got stomped on. Which, in turn, led to my PR to make the default not limited. Which, in turn, led to the other issue this PR solves which makes the search things we relied upon to not have a limit, have a limit.
      Unverified
      6331c3b1
    • Nemanja Glumac's avatar
      Use `jest-dom/extend-expect` library globally (#17292) · 84a6abd1
      Nemanja Glumac authored
      * Register `@testing-library/jest-dom/extend-expect` globally
      
      * Remove unnecessary imports from unit tests
      Unverified
      84a6abd1
    • Luis Paolini's avatar
    • Cam Saul's avatar
    • Cam Saul's avatar
      :race_car::race_car::race_car: test runner improvements :race_car::race_car::race_car: (#17286) · e1e815f8
      Cam Saul authored
      * Add some dox
      
      * Rename test-runner & cloverage -> metabase.test-runner & metabase.cloverage-runner
      
      * Move JUnit-related test runner code to separate namespace
      
      * Bespoke JUnit-output code
      
      * Delete unused .lein-classpath file
      
      * Do JUnit writes in a cached thread pool
      
      * Add failing test to make sure JUnit output works as expected...
      
      * Move bad-test to metabase.bad-test so the FAILING tests actually run
      
      * FASTER TEST LOADING :race_car:
      
      * Test CircleCI :system-out
      
      * Final cleanup (hopefully)
      
      * Sort some namespaces; allow initializing :plugins when namespaces get loaded for now.
      
      * Need those [[tags]] in docstrings
      
      * Fix bad docstring
      Unverified
      e1e815f8
Loading