This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 18, 2024
-
-
Dennis Schridde authored
Store API can handle higher load and customers might want to see changes earlier. Fixes: cc28ee60
-
Nick Fitzpatrick authored
* cleaning up links, adjusting tests * guard rails * linter fix
-
Aleksandr Lesnenko authored
-
Oisin Coveney authored
-
- Oct 17, 2024
-
-
Phoomparin Mano authored
* debug pdf export styling * apply sdk theme background overrides * add overflow override * tweak style overrides * move WithThemeBackground outside of data-metabase-theme selector * move EmbedFrame css rule up * remove fallback mb-color-background
-
Phoomparin Mano authored
* remove defaultProps from Modal * bump patch version of react-markdown * fix isOpen prop
-
Phoomparin Mano authored
* hide downloads by default in the sdk * update readme to reflect withDownloads prop * update readme formatting * update tests
-
Noah Moss authored
-
Nick Fitzpatrick authored
* adding webhook counter to AlertListItem * PR feedback
-
lbrdnk authored
* Fix expression stage * Add test * Parallel test * Adjust test * Adjust test
-
lbrdnk authored
* Use metric's aggregation :name * Add test
-
Alexander Polyankin authored
-
Case Nelson authored
* fix: Always cast json number types as decimal Fixes #48507 * Fix tests * Fix tests * Fix test
-
Mahatthana (Kelvin) Nomsawadi authored
-
Alexander Polyankin authored
-
Kamil Mielnik authored
-
metamben authored
Fixes #48639
-
Alexander Solovyov authored
-
github-automation-metabase authored
-
- Oct 16, 2024
-
-
dpsutton authored
* Let non-admins see tables in recents ```shell ❯ http get "localhost:3000/api/activity/recents?context=views" Cookie:"metabase.SESSION=ba..3d" -pb { "recents": [ { "can_write": false, "database": { "id": 6, "initial_sync_status": "complete", "name": "pg restaurants" }, "description": null, "display_name": "Restaurants", "id": 112, "model": "table", "name": "restaurants", "table_schema": "public", "timestamp": "2024-10-15T22:11:39.412100Z" }, { "can_write": false, "database": { "id": 6, "initial_sync_status": "complete", "name": "pg restaurants" }, "description": null, "display_name": "Reviews", "id": 110, "model": "table", "name": "reviews", "table_schema": "public", "timestamp": "2024-10-15T19:53:19.999445Z" } ] } ``` We were getting permissions of a "fake" table. Instead, let the db select it and get the proper stuff. Worked for admins because mi/can-read? is presumably always true for tables, and worked in tests because we mocked mi/can-read? * bump ci
-
appleby authored
* Add new promethues counter for :metabase-metrics/adjust-errors To record errors in metabase.query-processor.middleware.metrics/adjust * Add prometheus metrics test to metrics middleware tests * Also inc :metabase-metrics/adjust-errors when throwing an exception * Make splice-compatible-metrics private It doesn't seem to be used outside of metabase.query-processor.middleware.metrics. * Add test for :metabase-metrics/adjust-errors when exception is thrown * Move inc-and-throw! helper into metabase.analytics.prometheus * Add inc-and-throw! test to prometheus tests * Rename inc-test to inc!-test and use approx= and metric-value helpers * Add try/catch to metrics adjust and record metric errors in a single place Record promethues metrics in a single place in metabase.query-processor.middleware.metrics and ensure we record failures for any exception throw. * Improve testing description string * Rename :metabase-metrics/adjust-errors to :metabase-query-processor/metrics-errors * Move metrics adjustment try/catch into a new helper This ensures we count all exceptions generated by adjust-metric-stages. * Add new prometheus metric to count number of MB metrics seen by the QP This new metric is intended to count the number of metrics that the query processor metrics middleware sees and attempts to adjust. * Add more metrics metrics tests - Ensure that queries with no metrics do not incremement either counter - Ensure that successful calls to adjust do not increment the error counter - Ensure that exceptions throw from other libs also increment the error counter * Rename test to adjust-prometheus-metrics-test and add helper to reduce code dup * If no metrics are found immediately return query in metrics middleware adjust Don't attempt to adjust query if we don't find any :metric clauses. * Appease cljfmt * Improve metric description Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Improve epsilon test in approx= Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Remove adjust-metric-stages-counting-errors This function was an attempt to avoid double-counting errors, but probably not worth the effort. See https://github.com/metabase/metabase/pull/48598#discussion_r1800197964 https://github.com/metabase/metabase/pull/48598#discussion_r1800200421 * Count metrics directly when mocking prometheus/inc! Based on PR feedback here: https://github.com/metabase/metabase/pull/48598#discussion_r1800207674 * Remove prometheus/inc-and-throw! Value prop was always questionable, but now that it's only called from a single place, just remove it and inline the call to prometheus/inc!. Easy to add back later if it proves generally useful. PR discussion thread https://github.com/metabase/metabase/pull/48598#discussion_r1799728596 * Rename match-one-metric to find-first-metric https://github.com/metabase/metabase/pull/48598#discussion_r1803321025 * Rename :metabase-query-processor/metrics-errors to metric-errors https://github.com/metabase/metabase/pull/48598#discussion_r1803313818 * Throw an exception rather than logging a warning if we fail to adjust a metric https://github.com/metabase/metabase/pull/48598#discussion_r1803328482 --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
bryan authored
* add prometheus tracking for sdk-embedding * indentation * improve track-sdk-response api * register :metabase-sdk/response-{ok,error} + test * avoid cyclic dependency whe nusing prometheus fixes: [ /metabase/api/common ] <- /metabase/models/setting <- /metabase/analytics/settings <- /metabase/analytics/prometheus <- /metabase/analytics/sdk <- /metabase/models/view_log <- /metabase/events/schema <- /metabase/events <- [ /metabase/api/common ] <- /metabase/public_settings/premium_features <- /metabase/auth_provider <- /metabase/driver <- /dev/debug_qp <- /dev * nix dependency: events.schema --> models.view-log - make them both read context from view-log-impl instead * cljfmt
-
bryan authored
-
Chris Truter authored
-
metamben authored
-
github-automation-metabase authored
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Noah Moss authored
-
Nicolò Pretto authored
* faster --watch command for the sdk * apparently we want an empty line at the end of jsons, but prettier removes it? * format tasks.json with prettier
* vscods tasks, move watch task from webpack config to the fixup script * cleanup webpack config * adds clean + waits for dist folder when not existing * minimal doc for the sdk commands -
Anton Kulyk authored
* Don't assert dynamic value * Restart CI
-
Mahatthana (Kelvin) Nomsawadi authored
-
Alexander Solovyov authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Don't open sidesheet on SDK dashboards * Add E2E test * Fix `className` not passed * Fix unit tests * Fix E2E tests
-
Ngoc Khuat authored
-
- Oct 15, 2024
-
-
Raphael Krut-Landau authored
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
bryan authored
* adds data + schema for metrics stats ping * remove comment * annotate todos * fill in the rest of the metrics values - and add defaults * fix some definitions + use a single timestamp * shuffle stuff around to appease the namespace linter - we aren't reaching into the api API, so the linter is more of a formality here. * update docstring * fix jsonschema, maybe * review responses - revert changes to 1-0-0 - add metrics section to new file: 1-0-1 - bump ::instance_stats to "1-0-1" - add tags into 1-0-1 - make the code return tags (empty for now until we know what to tag things.) - also fix test that broke from shuffling settings around * remove a footgun * add tags to metrics, add grouped_metrics to jsonschema 1-0-1 format 1-0-1 * indent * cljfmt * version should match filename * update instance stats 1-0-1 schema * require `tags` in grouped_metric + snowcat comment * fix formatting noise * update schema to make it valid * remove grouped_metrics from instance_stats schema * cljfmt appeasement * unbin cache_num_queries_cached value - alphabetize metrics generation * we can now guarantee metric values will be ints * jsonschema for instance_uuid, settings, and grouped_metrics * add analytics_uuid and make it required * lint + alphabetize instance stats json schema * update setting key type - add maxLength to some strings * lint jsonschema - Add description to setting.items.tags - add maxLength, and {min,max}imum to setting.items.value * Bump instance stats to 2-0-0 - remove analytics_uuid string length == 36 check - adds assertion to ensure required fields are set (and it passes) - adds info for embedding settings * adds a grouped-metric to stats ping - adds length info to the schema to pass jsonschema linting * cljfmt
-
Aleksandr Lesnenko authored
-
Anton Kulyk authored
* Add default value for `hiddenIndices` * Add e2e test
-