Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 15, 2021
  2. Oct 22, 2021
  3. Jul 12, 2021
  4. May 13, 2021
  5. Jan 07, 2021
  6. Dec 09, 2020
    • Robert Roland's avatar
      Dashboard subscriptions work, squashed (#13390) · dd2ecc51
      Robert Roland authored
      
      * Dashboard subscriptions work, squashed
      
      This test namespace differs in EE and OSS
      
      Without other changes from EE, this won't work
      
      so, for now, I've restored the pure OSS version of this test
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      links to configure pulse types
      
      Display a link to configure email or slack when they aren't already
      
      Fix the am/pm picker
      
      set up a new schedule tooltip
      
      The sidebar can appear and disappear from the Sharing popover
      
      run prettier on everything
      
      email recipients now does the "name [and n other]" thing
      
      Dashboard subscriptions work, squashed
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      styling for email not configured state
      
      add styling for slack unconfigured state
      
      disable cursor-pointer if email or slack isn't configured
      
      Implement cancel button for the sidebar (#13741)
      
      Dashboard subscription UX enhancements:
      
      * Implement cancel button for the sidebar
      
      * Don't return duplicate dashboard subscriptions
      
      * Move sidebar cancellation into Redux
      
      * Add close icon
      
      * Fix popover behavior
      
      Dashboard Subscriptions: Fix build (#13859)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Subscribe to dashboards send test email (#13886)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      * uggh cypress
      
      * Add button to send test email for dashboard subscriptions
      
      * Disable test email with no recipients
      
      * Refactor SendTestEmail
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Fix failing collection tests (#13891)
      
      * Move dashboard embedding button (#13928)
      
      * Revert migration 277 (as in master)
      
      styling and hover tweaks for subscription cards (#14003)
      
      Fix positioning of create and close buttons (#13999)
      
      * fix positioning of create and close buttons
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * import Flex
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      Co-authored-by: default avatarKyle Doherty <kyle.l.doherty@gmail.com>
      
      Add deprecation warning to Pulse create/edit page (#13954)
      
      * add pulse deprecation warning
      
      * remove unused Link component
      
      * kyle comments
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      More dash subscription styling tweaks (#14006)
      
      * change hovers for email and slack delivery options
      
      * calm down, delete button
      
      * style csv and xlsx options as buttongroup
      
      * settings spacing tweaks
      
      Dashboard subscription attachment question selection (#13950)
      
      * Move email attachment into its own component
      
      Add appropriate checkbox behavior
      
      Set pulseCards appropriately
      
      * Delete PulseCards when dashboard card removed
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      dd2ecc51
  7. Oct 23, 2020
  8. Aug 13, 2020
  9. Jul 20, 2020
  10. Feb 18, 2020
  11. Jan 09, 2020
  12. Dec 06, 2019
  13. Oct 01, 2019
    • Kyle Doherty's avatar
      Bundle fonts (#10963) · 869356c9
      Kyle Doherty authored
      * remove Google Fonts usage
      
      * local Lato in resources/frontend_client/app/fonts
      
      * create assets/fonts aliases, update publicPath, use absolute paths in css
      
      * add svg to extensions
      
      * update flow config to account for frontend_client assets
      
      * add explicit .svg extension to no_results usage
      
      * remove google fonts references from CSP headers
      Unverified
      869356c9
  14. Sep 27, 2019
  15. Aug 15, 2019
    • Cam Saul's avatar
      Merge master -> release-0.33.x (#10604) · fc60d633
      Cam Saul authored
      * Compute Content-Security-Policy hashes for inline JS (#10504)
      
      * Split out inline JS from index/init templates to separate files
      
      * Read inline JS from resources at run time
      
      * Calculate inline JS hashes for CSP header from content
      
      * Move inline JS to resource sub-directory
      
      * Update and memoize inline JS loading
      
      * Revert debug code
      
      * Deduplicate `resp/response` calls
      
      * Fix paths to moved inline JS resources
      
      * Force creation of test data DB so things don't get left in the cache
      
      This fix was provided by @camsaul.
      
      * Combine and `defonce` inline JS hashes
      
      * s/inlinejs/inline-js/
      
      * Ensure that Metabase JAR is readable by `metabase` container user (#10510)
      
      If the umask of the user that builds the image is xx7, the JAR will not be
      world readable in the resulting image.
      
      * Remove `--add-modules=java.xml.bind` Java option (#10521)
      
      Fixes #10244. @camsaul confirmed that it is no longer needed.
      
      * Join on collection table's ID, not the joining table's `collection_id` (#10481)
      
      * Join on collection table's ID, not the joining table's `collection_id`
      
      This caused each record that joins on collection, to be duplicated for each
      existing collection:
      
      `LEFT JOIN collection collection ON card.collection_id = collection_id`
      
      should be
      
      `LEFT JOIN collection collection ON card.collection_id = collection.id`
      
      * Test fixes from @cam on EE
      
      * Insights: correctly handle infinities in results (#10502)
      
      Filter out models with infinities
      
      * Transfer log events as JSON objects and allow filtering on front-end (#10522)
      
      * Return log events as JSON objects from API; render on front-end
      
      Site UUID added to log events.
      
      * Remove superfluous memoization of site UUID retrieval
      
      Settings are already cached.
      
      * Transfer timestamps in ISO-8601 format
      
      * Move `metabase.metabot.instance/local-process-uuid` to `metabase.public-settings`
      
      * Use `local-process-uuid` in stead of `site-uuid`
      
      `site-uuid` is not unique across processes, which is what we want to
      associate with log events.
      
      * Remove unused import
      
      * Allow log events to be filtered by process UUID on front-end
      
      * Move process selector out of loading wrapper
      
      Otherwise, if there are process UUIDs with no log events, the selector is
      removed with the log event list.
      
      * Figured out how to add docs to `defonce`
      
      * Fix ns declaration
      
      * Linter appeasement
      
      * Merge log events received from back-end with previously received ones
      
      This allows responses from multiple back-end instances to be spliced
      together.
      
      * Use MB components in stead of plain, styled HTML tags
      
      The select is only displayed if more than one process UUID was found.
      
      * Linter appeasement
      
      * Move `metabase.public-settings/local-process-uuid` to `metabase.config`
      
      * Fix sorting on multiple log event fields
      
      * Flatten `Select` children to allow nested arrays of children
      
      * Generate options directly under parent Select
      
      * Limit the number of log events that we render
      
      * Docstring and style updates
      
      * Update editor config with Clojure files max line length
      
      * Ensure that `NumericWrapper` is imported before use
      
      * Cleanup layout
      
      * Bump HoneySQL version (#10559)
      
      The new version (0.9.5) includes @camsaul's Turkish upper case fix:
      jkk/honeysql#237
      
      * Factor out test for access to localStorage (#10533)
      
      * Factor out test for access to localStorage
      
      This allows code that uses localStorage to test against
      `window.hasLocalStorage`, in stead of handling exceptions generated when
      access to localStorage is denied.
      
      * Move check for localStorage to metabase/lib/dom
      
      * Fix typo in warning message (#10556)
      
      * revert text color to #74838f (#10560)
      
      * revert text-medium color to #74838f
      
      * use light instead of medium on preview button
      
      * MBTL (#10105)
      
      Add transforms and domain models
      
      * Added page about maps and updated nav (#10495)
      
      * Added page about maps and updated nav
      
      * Clarified step 1
      
      * Added more details throughout
      
      * Quick URL change
      
      * Added additional resource!
      
      * fix typo: 'sdisplay' to 'display'
      
      * Add message with link to docs for fields without any filter widgets (#10340)
      
      * Correct proxy command line [ci skip] (#10430)
      
      * Bump Toucan version to include Turkish lower case fix (#10581)
      
      * Wrap `tru` and `trs` macro results in `str` (#10571)
      
      * Add versions of `trs` and `tru` that wrap results in `str`
      
      The pre-existing `trs` and `tru` were renamed to `lazy-trs` and `lazy-tru`
      respectively, and new `trs` and `tru` funcs were added, wrapping the result
      of its lazy counterpart in `str`.
      
      This way the normal use case of `trs` and `tru` is improved by no longer
      requiring that it be wrapped in `str`.
      
      Cases where the translated result is passed to `str` anyway, the lazy
      version can be used.
      
      * `(str (trs ...))` → `(trs ...)`
      
      And the same for `tru`.
      
      * Allow `defsetting` descriptions to use lazy versions of `trs`/`tru`
      
      * Use `lazy-trs`/`lazy-tru` where `str` is applied separately
      
      * Remove unnecessary `vec` from `tru`/`trs` macros
      
      * puppetlabs.i18n does not have a `lazy-tru`
      
      * Missed some settings that now need to use `lazy-tru`
      
      * Only use `lazy-tru` in top-level `def`s
      
      If the localized strings are looked up on module import, before locales are
      loaded, the lookup will fail and the original input string will be used.
      
      * Fix bad usages of `tru` that should be `lazy-tru`
      
      * s/lazy-tr/deferred-tr/g
      
      * Avoid `tr*` macros being used in top-level (compile time) statements
      
      Because localizations are not yet loaded at compile time.
      
      * Add type hint for `str*` wrapping of `trs`/`tru`
      
      * Fix assigned function's return type hint
      
      * Expand docstrings for `i18n/tr[su]`
      
      * Use `trs` and `tru` from metabase.util.i18n instead of puppetlabs.i18n.core
      
      * Defer compile time translation lookups
      
      These changes were pointed out by exceptions generated by `i18n/str*`.
      
      * Remove unused `require`d function
      
      * New compile time `trs` usages caught by `lein uberjar`
      
      * Ensure that error message from db driver is a string
      
      It is necessary to ensure that the error message is a string, because some
      db driver errors come from statically declared error messages, using
      `deferred-tru`. Like those in
      `metabase.driver.common/connection-error-messages`.
      
      Fixes #10347 and #10473.
      
      * Remove string type hint from `humanize-connect-error-message`
      
      * Don't disable preview for fields with non-trivial type  (#9687)
      
      * Don't create API callback if no database is associated with card (#10573)
      
      * Don't create API callback if no database is associated with card
      
      Fixes #10538
      
      * Return empty array to avoid mapping over null
      Unverified
      fc60d633
  16. Aug 06, 2019
    • Walter Leibbrandt's avatar
      Compute Content-Security-Policy hashes for inline JS (#10504) · 45881866
      Walter Leibbrandt authored
      * Split out inline JS from index/init templates to separate files
      
      * Read inline JS from resources at run time
      
      * Calculate inline JS hashes for CSP header from content
      
      * Move inline JS to resource sub-directory
      
      * Update and memoize inline JS loading
      
      * Revert debug code
      
      * Deduplicate `resp/response` calls
      
      * Fix paths to moved inline JS resources
      
      * Force creation of test data DB so things don't get left in the cache
      
      This fix was provided by @camsaul.
      
      * Combine and `defonce` inline JS hashes
      
      * s/inlinejs/inline-js/
      Unverified
      45881866
  17. Jul 30, 2019
  18. Jun 27, 2019
  19. May 07, 2019
  20. May 06, 2019
  21. Apr 06, 2019
  22. Jan 09, 2019
  23. Jan 04, 2019
  24. Dec 05, 2018
  25. Nov 29, 2018
  26. Jul 23, 2018
  27. Jul 20, 2018
  28. May 29, 2018
    • Kyle Doherty's avatar
      Merge Collections project into master (#7752) · 1051eba6
      Kyle Doherty authored
      * Entity pages (courtesy @kdoh)
      
      * Add collection_id to Dashboards & Pulses (#7358)
      
      * add search to top nav
      
      * flip homepage, updated collections
      
      * make recent views self contained, add to home
      
      * recent items style, add some new colors
      
      * adjust default text color
      
      * add js colors to style guide
      
      * add copy color
      
      * segment loader
      
      * move to landings
      
      * landing nav
      
      * segment list + loader
      
      * clean up landing nav
      
      * metric + segment listing
      
      * mucking around with selectable stuff
      
      * layout tweaks
      
      * other loaders
      
      * stronger left sidebar
      
      * left sidebar
      
      * fix landing
      
      * layout port
      
      * more tweaks
      
      * nav tweaks
      
      * explore
      
      * collection wrap
      
      * Add collection_id to Dashboards & Pulses
      
      * GET /api/collection/:id default to returning everything. Wow!
      
      * colleciton items loader
      
      * dashboard move modal + cleanup
      
      * currentCollection and items
      
      * Add GET /api/collection/root endpoint
      
      * pulse move modal
      
      * MASSIVE ALERTS/PULSES/NOTIFICATIONS OVERHAUL
      
      * move activity feed
      
      * all items, cards
      
      * link
      
      * Filter out stuff you're not allowed to see from the so-called "Root" Collection
      
      * Tests for GET /api/collection/root
      
      * fix query builder and login layout
      
      * lint + test fixes
      
      * filter collection landing
      
      * create dash modal
      
      * new collection modal
      
      * Tests for Dashboard + Collection permissions
      
      * Tests for Pulse + Collection permissions
      
      * Add new Pulse/Alert perms tests & lots of cleanup :shower:
      
      * Test fixes :wrench:
      
      * tweak grid, add system to icon
      
      * truncate long titles
      
      * remove duplicate file
      
      * add collection to create dashboard
      
      * add collection selection to pulse edit
      
      * icon spacing
      
      * use site name for landing
      
      * clean up routes
      
      * include required pulse card keys
      
      * fix entity menu action / link and add to collection landing
      
      * update jest snapshots changed by icon
      
      * use entity loader for collections
      
      * use object loader for collection items
      
      * fix colleciton edit and permissions
      
      * remove unused file
      
      * add key to collection grid items
      
      * link to pulse edit
      
      * use named list for collections
      
      * Increase nav z-index Fixes #7523
      
      * tweak z-index level
      
      * fix filters
      
      * fitViewport component and application
      
      * add fitViewport to setup and post setup
      
      * add root collection to dashboard move modal
      
      * move to id for loading collections
      
      * fix permission editor
      
      * fix other instances of collection slug
      
      * fix unit tests
      
      * flow fixes
      
      * dep flow fixes
      
      * Fix admin routes not loading currentUser before checking auth
      
      * Add id: root to Root Collection
      
      * root collection items
      
      * temporary archive links
      
      * fix up question archive route
      
      * redirect to collection on pulse creation
      
      * use fitClasses on /explore
      
      * Fix NavBar popover and modal interactions
      
      * Fix comments about when migrations were added
      
      * fix lint
      
      * style updates
      
      * fix recent views
      
      * collection empty state
      
      * Make FitViewPort more robust
      
      * Fix side bar link states
      
      * fix snapshot
      
      * Fix alerts
      
      * update link and landing nav style
      
      * add archive collection route / modal
      
      * add modal
      
      * Disable onboarding integration test
      
      * Fix disabling of dashbaord tests
      
      * Update snapshots and lint error
      
      * Fix collection archiving
      
      * lint
      
      * revert text color
      
      * Reload collection list each time it's shown to ensure it's in the correct state:
      
      * fix empty state image
      
      * only show permissions edit option for the root collection
      
      * nav
      
      * simple layout
      
      * fix grid
      
      * grid component
      
      * fix translation
      
      * fitClassNames > fitClasses
      
      * fix up collection items loader
      
      * remove unused files
      
      * remove type filter
      
      * qb lives
      
      * default to qb
      
      * collection landing and components
      
      * hoverable card
      
      * placeholder search bar
      
      * flip collection / content order on landing
      
      * fix padding
      
      * dashboards first in the list
      
      * Merge master into collections-project
      
      * only show sidebar if exists
      
      * Add collection_position column to Card/Dashboard/Notification (#7675)
      
      * add first version of pins
      
      * Fix memory leak found using RedShift JDBC Metadata methods
      
      Running sync calls several JDBC metadata methods that return
      `ResultSet` objects. According to the JDBC spec, when the connection
      associated to the JDBC ResultSet has been closed, it should free the
      resources used by the ResultSets that were left open in that
      connection. That doesn't look to be happening in RedShift. Closing the
      ResutSet instance ourselves before the connection closes will ensure
      that these resources are freed and doesn't allow the RedShift bug to
      occur.
      
      * use entity update instead of raw api
      
      * Fix tests :wrench::unamused:
      
      * Unified archive, search, schema data browsing, and refactor of entities
      
      * Fix create dashboard modal
      
      * Collections overworld (#7687)
      
      * add overworld
      
      * layout tweaks
      
      * remove navbar browsing link
      
      * table item cards
      
      * search page layout and item icon colors
      
      * search bar active style
      
      * Remove Label & CardLabel models & endpoints
      
      * DO NOT RUN TESTS ON SHUTDOWN! EVER!
      
      * remove navbar browsing link
      
      * table item cards
      
      * search page layout and item icon colors
      
      * search bar active style
      
      * archive page changes
      
      * Merge master into collections-project :flushed:
      
      * activity style updates
      
      * match search bar width to content
      
      * schema grid
      
      * greet with name
      
      * type sync
      
      * pin icon
      
      * be round now
      
      * search spacing and entitiy item last child border
      
      * collection text color
      
      * collection pinned item size / text
      
      * better root collection name
      
      * something styled
      
      * init search empty state
      
      * lint fix
      
      * fix colleciton links. fixes #7716 (#7720)
      
      * Merge master into collections-project :flushed:
      
      * database card styling
      
      * tweak hex value
      
      * prettier
      
      * fix overlap (#7737)
      
      * Reload collections list in question save modal, and collections items list as stopgap until it's more automatic (#7731)
      
      * Fix public question layout (#7732)
      
      * Change Urls.collection() to take an ID, default to 'root', and use when creating pulse
      
      * Collections project bg sync (#7740)
      
      * default to bg-slate-extra-light color
      
      * admin routes
      
      * fix question archive redirect and archived message (#7730)
      Unverified
      1051eba6
  29. Apr 13, 2018
  30. Mar 21, 2018
  31. Mar 02, 2018
  32. Mar 01, 2018
  33. Jan 25, 2018
    • Ryan Senior's avatar
      Add CSV/XLS Pulse attachment support to the backend · f3631c49
      Ryan Senior authored
      This commit adds the backend pieces needed to attach CSV and XLS files
      of query results to Pulses. Attachment support is also there for
      Alerts. This is an opt-in feature for pulses and alerts. Users can
      update existing Pulses to include attachments or add them to a new
      pulse. The file(s) will only be attached when there are results.
      
      Fixes #6587, fixes #3894, fixes #2623
      f3631c49
  34. Nov 14, 2017
    • Atte Keinänen's avatar
      Alerts Frontend · 6f0bd39a
      Atte Keinänen authored
      This commit has the UI for users to add alerts to a question. Admins
      are able to setup alerts for questions and modify alerts that users
      have setup.
      6f0bd39a
  35. Nov 13, 2017
  36. Nov 08, 2017
    • Cam Saul's avatar
      MetaStore integration (#6315) · fb63cc38
      Cam Saul authored
      * MetaStore integration
      
      * Fix lint error
      
      * restructure embedding levels
      
      * Rename updateSetting in setting widgets to onChange, add onChangeSetting
      
      * embed flow images / spacing
      
      * lint fix
      fb63cc38
Loading