This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 19, 2021
-
-
Alexander Lesnenko authored
-
Anton Kulyk authored
-
- Nov 18, 2021
-
-
Anton Kulyk authored
-
Dalton authored
* add tippy and react-is * add tippy styles to vendor.css we'll probably override most things but it handles apply the triangle to tooltips * reimplement Tooltip using tippy * reimplement ChartTooltip using Tooltip * add tooltip theme styling * fix StoreLink styling * remove TooltipPopover * add util for easy mapping to innerRef * use innerRef util with StoreLink target * react-is type defs * convert Tooltip into tsx * convert styled-components util into typescript * fix Tooltip fallback return * use Tooltip in Icon over Tooltipify * remove Tooltipify * pass ref all the way through Icon * fix DimensionListItem styling caused by missing ref * fix ChartTooltip event target bug * fix unit test by making Icon.tsx grosser * replace popover() util with tooltip() in cy tests * fix random broken e2e test * improve types in Tooltip * move everything to a separate folder + add tests * add more examples * rmv accidental deps * fix run button styling * add Link tooltip prop to avoid tooltip on icon * wrap MetabotLogo in forwardRef * support reduced motion * remove flow type from dom.js so we can use in ts files * pass isEnabled prop to tippy's disabled prop once you've activated "control mode" in tippy you can't turn it off so using "visible" as a toggle doesn't work. instead, use disabled. * fix uncentered tooltip the right way tippy includes padding/margin in its centering calculations, unlike tether, so we will need to be careful about adding one-sides padding/margins to a tooltip target, otherwise the tooltip will appear offcenter * workaround for absolutely positioned element the tooltip appeared on the far end of the target because of a child div that is absolutely positioned. quick fix is to instead target the icon * fix positioning of HintIcon tooltip * lint fix * add placement prop * fix styled component tooltip target styling * place QuestionNotebookButton tooltip below * Make the NativeQueryButton an actual button * set tooltip placement to bottom * lint fix warning
-
Dalton authored
* enable webpack caching * only enable in devMode * invalidate cache when build deps change
-
Anton Kulyk authored
-
Anton Kulyk authored
* Display dataset model name in recent searches * Fix dataset URLs in activity * Fix icons in activity recent views * Distinguish datesets from questions in activity * Fix message
-
- Nov 17, 2021
-
-
dpsutton authored
Had wanted to make a heuristic that would look at timestamp of the bundle and timestamps of the sources and compare. But this could fail when switching branches. Simpler and easier to just throw a warning on all failures ```clojure js-svg-test=> (binding [*test-out* *out*] (run-tests)) Testing metabase.pulse.render.js-svg-test FAIL in (foo) (js_svg_test.clj:28) [PRO TIP] If this test fails, you may need to rebuild the bundle with `yarn build-static-viz` expected: 1 actual: 2 diff: - 1 + 2 Ran 8 tests containing 29 assertions. 1 failures, 0 errors. {:test 8, :pass 28, :fail 1, :error 0, :type :summary} ``` For posterity, attempt using timestamps was ```clojure (deftest bundle-up-to-date-test (let [js-bundle (io/file (io/resource js-svg/bundle-path)) to-date (fn [epoch] (java.time.Instant/ofEpochMilli epoch))] (is (.exists js-bundle) bundle-recreate-warning) (when (.exists js-bundle) (let [source-files (file-seq (io/file "frontend/src/metabase/static-viz")) most-recent-source (apply max-key #(.lastModified %) source-files)] (is (.isAfter (to-date (.lastModified js-bundle)) (to-date (.lastModified most-recent-source))) bundle-recreate-warning))))) ```
-
dpsutton authored
Docstring for `regex-email-bodies` states: > "Return messages in the fake inbox whose body matches the regex(es). The body will be replaced by a map with the stringified regex as it's key and a boolean indicated that the regex returned results." But it does ont return messages in the fake inbox whose body matches any of the regex. It returns them all regardless, with information if they match or not. Simply correct this behavior to match the docstring ```clojure {"rasta@metabase.com" ({:from "notifications@metabase.com", :to #{"rasta@metabase.com"}, :subject "We've Noticed a New Metabase Login, Rasta", :body {"https://metabase.com/testmb" false, "has any results" false, "My question" false}} {:from "notifications@metabase.com", :to #{"rasta@metabase.com"}, :subject "We've Noticed a New Metabase Login, Rasta", :body {"https://metabase.com/testmb" false, "has any results" false, "My question" false}} {:from "notifications@metabase.com", :to #{"rasta@metabase.com"}, :subject "You set up an alert", :body {"https://metabase.com/testmb" true, "has any results" true, "My question" true}})} ```
-
Jeff Evans authored
* Add SSL keystore and truststore secret properties to Oracle driver YAML files Update Oracle driver to set keystore and truststore connection options from secret values Adding new `select-keys-sequentially` helper function for dealing with assertions on transformed conn props Add new function to the secret namespace to return a lighter weight "secret map", and remove that functionality from the `handle-db-details-secret-prop!`, so that it can be reused from connection testing Modifying CircleCI to set the corresponding truststore secret conn prop vars instead of JVM-level truststore settings, as the test had been doing previously Expand Oracle test connection details to incorporate all SSL related properties, and also make it a function instead of delayed def (so changes can be picked up later) Misc. fixes in Oracle driver YAML files Update `exception-classes-not-to-retry` to include SSLHandshakeException Fix misc issues in secret and database model code Update CircleCI config to use correct secret based env var keys and values Add *database-name-override* dynamic var in `metabase.test.data.interface` to allow for DB name overriding Fix up ssl connectivity test so all parts pass successfully Get rid of crazy with-redefs to swap in the existing test-data's schema, and instead, just dropping the DB if it was created under a different schema (similar to what H2 does) Co-authored-by:
Gustavo Saiani <gustavo@poe.ma>
-
frannietrempe authored
* added links and edited headings * documented getCallerClass error * Added create directory section * Wording and spacing edits per Jeff feedback * Fixing error in ToC from last commit * punctuation and spacing Co-authored-by:
ft-metabase <ft-metabase@ft-metabases-MacBook-Pro.local> Co-authored-by:
Jeff Bruemmer <jeff@metabase.com>
-
Alexander Polyankin authored
-
- Nov 16, 2021
-
-
Ariya Hidayat authored
-
Dalton authored
* add BooleanPicker component * add BooleanPicker unit test * fix typo * fix bool filter cy tests * fix button styling * remove 'admin' colorScheme and tweak design a lil
-
Dalton authored
* add fn that maps from our locale string to moment's * use moment with locales * add a require for the specific locale * don't require en * ensure locale is lowercased for moment more generally * default locale to a string
-
Maz Ameli authored
-
Maz Ameli authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Nov 15, 2021
-
-
Cam Saul authored
* New logging utility functions for REPL usage * Test fix
* Add support for `:off` and `:fatal` levels. * Remove NOCOMMIT -
Dalton authored
-
Alexander Polyankin authored
-
john-metabase authored
-
dpsutton authored
* Get rid of the n-queries old logic: select last view logs, and then for each one, select its associated model (card, table, etc). new logic: get the last view logs, and do three batch queries, one each to card, dashboard, table, for the ids from the view logs * Mark datasets in api/activity/recent_views * Get rid of `(db/delete! Activity)` in tests * Handle datasets in activity list
-
Alexander Lesnenko authored
-
Ariya Hidayat authored
-
Alexander Polyankin authored
-
Howon Lee authored
Static viz waterfall needs BE bits. Here are the BE bits. Color and total summation coming...
-
Alexander Lesnenko authored
* add show total setting to the waterfall static viz * specs
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Remove not used `noLink` prop * Namespace URL generators * Fix HeaderBreadcrumbs font-size in "head" mode * Add unit-tests for QuestionDataSource * Allow using react nodes in breadcrumbs * Use func declaration for QuestionDataSource * Add prop-types * Simplify query assignment expr * Don't swallow errors in QuestionDataSource tests * Add repro for #17961 (unit) * Allow passing custom divider for HeaderBreadcrumbs * Fix join tables breadcrumb links * Add extra saved question utils * Add tests for nested questions * Fix source question link * Don't show source question's schema * Fix breadcrumb colors * Fix tests * Fix breadcrumb colors * Use saved-questions lib utils for DataSelector
-
Pawit Pornkitprasan authored
-
Alexander Polyankin authored
-
- Nov 12, 2021
-
-
Dalton authored
* pass 'noEvent' api option to prevent unauthed event * unskip repro
-
Dalton authored
-
Jeff Bruemmer authored
* update sql parameter page * Flamber edits Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * revisions * add mongo example Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Noah Moss authored
-
Alexander Polyankin authored
-
Noah Moss authored
-