This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 08, 2024
-
-
Chris Truter authored
-
Chris Truter authored
-
Nick Fitzpatrick authored
* update deps * adjusting tests to work with new RTL * removing testing-library/no-unnecessary-act:off
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Display sql preview on sizes less than 1280px * Handle min notebook width using Mantine responsitve style prop * Display the resizable sidebar on sizes >= 1280px * Set sidebar width on resize * Add custom handle * Simplify window resizing with `useWindowSize` hook * Use "white" from the theme colors * Improve sidebar semantics with `aside` * Define the `NativeQueryPreviewSidebar` as `aside` * Use Mantine style props instead of CSS module * Run the E2E test again using regular browser We removed the nested media query that ReplayIO doesn't support. Now this test can run using Replay Chromium as all other tests do. * Add some breathing room between the scrollbar and the resizable sidebar
-
Oisin Coveney authored
-
Tim Macdonald authored
[Fixes #13922]
-
Alexander Solovyov authored
-
Oisin Coveney authored
-
- Apr 06, 2024
-
-
Noah Moss authored
-
- Apr 05, 2024
-
-
Cam Saul authored
* MLv2 normalization: add :lib/uuid automatically to options maps if it's missing * Remove unneeded normalization code in QP * Fix
* Ignore invalid metadata providers when passed in from the REST API -
Nicolò Pretto authored
* create ui for the full embedding homepage, without any logic (#40251) * wip ui for the full embedding homepage * adds missing link + fix keys * remove done TODO * Update frontend/src/metabase/home/components/EmbedHomepage/InteractiveTabContent.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * destructure props in the function arguments * rename customerFacingAnalyticsDocsUrl to analyticsDocsUrl --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * add new settings for embedding homepage (#40455) * remove old minimal version * adds new embedding homepage settings and sets them at the end of the setup * comment e2e test * add tests for embedding homepage flags * more tests * remove unit tests related to old minimal version * fixes flags descriptions * :keyword for embedding-homepage Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * replace reloadSettings and refreshSettingsList with initializeSettings * `value => value === true` -> `Boolean` * toMatchObject -> toEqual for more strict tests * remove useless undefined check for settings, the component is conditionally rendered based on a setting so it means they're loaded anyway * fix: use :hidden as we changed the type to :keyword * specifically check for the `embedding` feature in the tokenFeatures object instead of checking if any feature is active * remove double \n Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * connect settings to the embed homepage and show it (#40528) * fix nested a warnings in browser console * connect settings to the embed homepage and show it * fix stories * remove localStorage.clear() as we're not using it in the logic anymore * dismiss without feedback for the embedding homepage (#40587) * feat: add dismiss functionality to the embed homepage * update setup e2e to check for the dismissal of embedding homepage * use List from metabase/ui (#40638) * set embedding-secret-key when embedding is enabled (#40813) * set embedding-secret-key when embedding is enabled * use "named" setters and getters as suggested by Noah * Fix tests for ms1 after updating on master (#41069) --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Cam Saul authored
* Use window functions for SQL drivers for cumulative count and sum * H2/Snowflake/Redshift implementation * Test fixes
* Use SELECT expression positions as the default window function implementation * Some test fixes. * Fix bugs in add-alias-info * MongoDB fixes * Another pass * BigQuery should use positions? * Disable tests for the failing drivers, we can fix in follow-on PRs. * Extra info * Add GH issue numbers * Update more GH issue numbers * Fix SQL Server!!!! wooo * I THOUGHT WE WERE DISABLING SPARK SQL!!!!!!!!!!1 * Cleanup to get things ready for review. * Snowflake + Vertica shouldn't use output column numbers for ORDER BY in OVER * Code cleanup * Test fix? -
Uladzimir Havenchyk authored
-
Cam Saul authored
-
Romeo Van Snick authored
* Correctly pass an error string to Vizualization * Fix error layout for preview vizualization * Do not animate preview vizualization height * Add reproduction for #40724 * Fix test description Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Rename coerceError to getErrorMessage --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Alexander Polyankin authored
-
Chris Truter authored
-
Alexander Polyankin authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Moved a CSS rule, so we could only migrate 1 CSS file * Migrate .ListSectionHeader * Migrate .ListItem * Migrate .ListItemArrow * Migrate .ListSectionHeaderCursor * Migrate .ListSectionToggleAble * Migrate .ListSectionTitle * Migrate .ListSectionExpanded * Migrate .ListSectionIcon * Migrate .ListItemCursor * Migrate .ListItemDisabled * Migrate .ListItemSelected * Migrate .ListItemTitle * Migrate .ListItemDescription * Migrate a CSS class used in tests * Fix tests from migrating global CSS classes
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .LineAreaBarChart * Migrated .LineAreaBarChartRenderer * Migrate .mute-* * Fix tests that rely on a static class * Fix wrong DOM query selector syntax * Address review: Remove CSS comment noise
-
Jeff Bruemmer authored
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Jeff Bruemmer authored
-
dependabot[bot] authored
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6 ) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
- Apr 04, 2024
-
-
Braden Shepherdson authored
Goal is to properly document the interface between MLv2 and the FE. In particular I want to call out the health and fate of each function. Some of them only exist to support legacy compatibility, for example, and that should be documented to discourage new usage and make clear the conditions for removing the functions.
-
Romeo Van Snick authored
* Hide info icons when no description exists * Move defaults for InfoIcon to separate file * Add open delay to popover * Remove inverted background from type label * Fix margin on semantic type label * Make semantic type not be bold * Fix unit tests for hidden info icons * Rename file to constants * Remove unused showIfEmpty prop altogether * Fix the height of the expression suggestions that don't have an info icon * Fix padding on filter modal * Fix the height on dataref
-
Aleksandr Lesnenko authored
-
Jeff Bruemmer authored
-
Denis Berezin authored
* Add manual imports fixup * Fixes * Fixes * Review fixes * Review fixes
-
lbrdnk authored
* Enable not emptyable arguments for is-empty and not-empty clauses * Add review remarks * Shorten dataset name so it is usable with some drivers * Disable test for Athena * Handle possibly missing base type * Update comment * Missing base type field is treated as not emptyable * Update desugar middleware Now middleware adds base type to fields with integer id that are missing that first. This ensures correct function of is-empty expansion. * Update desugar middleware Cleanup base types necessary for desugaring is-empty * Update desugar middleware cleanup * Update test * Adjust tests * Remove now redundant e2e test * Update comment
-
Nicolò Pretto authored
This reverts commit 88a36a6a.
-
Kamil Mielnik authored
* Repro #23103 - Wrong number of distinct values in a native model * Fix flake
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
The first time you zoom in on a bin in a binned query, it works fine. For example, Orders COUNT by SUBTOTAL auto-binned has a bin for 40-60. If you zoom in on that, it correctly shows the range 40 to 60 broken down into smaller bins which are 2.5 units wide. If you then try to zoom in on one of these smaller bins, say 50-52.5, there are two problems: 1. The filters from the first zoom (`>= 40` and `< 60`) are still there, and so are the new ones (`>= 50` and `< 52.5`). 2. The new filter is actually wrong; it uses the big width (20) from the original bins, not the width of the nested bins (2.5), so the new filters are `>= 50` and `< 70`. This PR fixes both issues, so nested bins (1) remove the old filters, and (2) use the correct width for the nested bins.
-
Alexander Solovyov authored
-
Chris Truter authored
-
Chris Truter authored
-