Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 06, 2024
  2. Nov 05, 2024
  3. Oct 18, 2024
    • Cam Saul's avatar
      Modularize metabase.pulse; add metabase.pulse.core API namespace (#48640) · c92e8c99
      Cam Saul authored
      * Modularize metabase.pulse; add metabase.pulse.core API namespace
      
      * Rename metabase.pulse.send-test
      
      * Split email result attachment stuff into its own namespace
      
      * Update dashboard-subscription-test
      
      * Allow metabase.email.result-attachment externally... for now
      
      * More code cleanup
      
      * Decouple models.card and email.messages
      
      * Decouple models.collection and metabase.email.messages
      
      * Hopefully the last fix :wrench:
      
      * Fix #48647 :slight_frown:
      
      * Fix event handler
      
      * :render/text, not :pulse/text
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * RESPECT the modules
      
      * Remove unused namespace
      Unverified
      c92e8c99
  4. Oct 10, 2024
    • Ngoc Khuat's avatar
      [Notification] System event notification (#47857) · fc43d3cd
      Ngoc Khuat authored
      * [Notification] Notification and subscription (#47707)
      
      * [Notification] Notification and subscription (#47707)
      
      * [Notification] Handlers + recipients (#47759)
      
      * [Notification] Channel template table and model (#47782)
      
      * [Notification] Render system event emails (#47859)
      
      * [Notification] Strict type for channel template and notification recipient (#47910)
      
      * [Notification] Event hydration (#47953)
      
      * [Notification] Send asynchronously (#48200)
      Unverified
      fc43d3cd
  5. Oct 09, 2024
  6. Sep 26, 2024
  7. Sep 24, 2024
  8. Sep 18, 2024
  9. Sep 12, 2024
  10. Sep 10, 2024
  11. Aug 30, 2024
    • Ngoc Khuat's avatar
      [notification] webhook for alert (#45201) · d897f201
      Ngoc Khuat authored
      
      * [notification] New method: `channel/can-connect?` (#44955)
      
      * [notification] Channel APIs (#45207)
      
      * [notification] namespaced channel type (#45527)
      
      * [Notification] Render alert for http channel (#45545)
      
      * [notification] Add channel description (#45840)
      
      * [notification] update API to enable http channels for alert (#45839)
      
      * [Notification] Remove channel details for users without write perms (#46034)
      
      * [Notification] Serdes channel (#46031)
      
      * [Notification] Update http details schema (#45960)
      
      * [Notification] Deactivate channels will delete PulseChannel (#46115)
      
      * [Notification] audit log for channel create and update (#46113)
      
      * [Notification] Disallow undefined key for http channel details (#46712)
      
      * [Notification] Handle channel name conflicts (#46818)
      
      * Webhooks Admin Section (#46194)
      
      * [notification] Fix test pulse endpoint does not work properly for http channels (#46474) (#47050)
      
      * [Notification] Fix unable to update multiple channels per type (#47111)
      
      * [Notification] Record Task History when pulse sends channel message (#46218)
      
      * Enabling Webhook Alerts (#47022)
      
      * [Notification] fix cyclic deps (#47379)
      
      * [notification] channel serdes spec (#47386)
      
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      d897f201
  12. Aug 21, 2024
  13. Aug 20, 2024
  14. Aug 19, 2024
  15. Aug 13, 2024
  16. Aug 12, 2024
  17. Aug 06, 2024
  18. Jul 25, 2024
    • bryan's avatar
      Saving SDK data for embedding statistics (#45954) · 2febfbb4
      bryan authored
      * Adds a middleware that sets 2 dynamic vars
      
      - These vars will be used to insert context for embedding analytics
      
      * migration adding embedding_client and embedding_version to qe and vl tables
      
      * clarify function api
      
      * headers come in -> dynamic vars -> written to db
      
      When the vars are set we insert their values into query execution and
      query_log under embedding_client and embedding_version.
      
      * update update migrations
      
      * add predconditions to migrations
      
      * fix tablenames + dataset_test
      
      * Code Review responses
      
      - remove commented out requires
      - clarify test for merge-count-maps
      Unverified
      2febfbb4
    • John Swanson's avatar
      Loosen N+1 query detection again (#46081) · f9e27201
      John Swanson authored
      I tightened this up by removing the condition here, thinking that CI
      would catch it if it was necessary - but I'm getting failures in
      development. Oops - didn't realize that this defmethod wasn't actually
      applied during CI runs.
      Unverified
      f9e27201
  19. Jul 24, 2024
    • John Swanson's avatar
      Improve N+1 detection for simple hydration methods (#45848) · 50d0c35a
      John Swanson authored
      We have N+1 detection for simple hydration methods that checks to see
      whether the hydration method made any DB queries at all. This makes
      sense, because a simple hydration method is called on each instance
      individually - if we make database calls *each time*, we're in trouble.
      
      Where this runs into issues is with cached data, where the simple
      hydration method is populating the cache - e.g. `:can_read` or
      `:can_write` dereferencing `api/*current-user-permissions-set*`.
      Currently we specifically exclude those hydration methods from the
      check.
      
      But after running into this again for a different simple hydration
      method, I think there's a more robust approach:
      
      - first, run the hydration method without counting DB queries
      
      - then, run it again and make sure we don't make any additional DB
      queries.
      
      There is a potential downside here: if someone wrote a simple hydration
      method with side effects, they'd potentially be very confused (in
      development - this doesn't run in prod!) when those side effects
      happened twice for a single hydration. But I *think* that's fairly
      unlikely.
      Unverified
      50d0c35a
  20. Jul 22, 2024
  21. Jul 18, 2024
    • Cam Saul's avatar
      Use single connection for test data loading & big test data loading improvements (#45268) · bab905c0
      Cam Saul authored
      * Reuse connection for test data loading & JDBC data loading overhaul
      
      * Revert silly change
      
      * Remove unneeded logic for recording which datasets are loaded or not-yet-loaded
      
      * Ok so I guess we do need the code to detect duplicate dataset loading after all
      
      * B I G  improvements
      
      * Appease Kondo
      
      * Test fixes :wrench:
      
      * More test fixes :wrench:
      
      * Fix dataset-already-loaded?-test
      
      * Fix test
      
      * Fix Presto JDBC and greatly improve test data load speed for it
      
      * Postgres test fix :wrench:
      
      * Fix compilation errors
      
      * MySQL fixes :wrench:
      
      * Fix syntax error
      
      * MySQL fixes :wrench:
      
      * Implement `dataset-already-loaded?` for Athena and cache the set of existing databases
      
      * Fix Redshift
      
      * Fix Presto JDBC
      
      * Vertica test fix :wrench:
      
      * Fix Oracle dataset-already-loaded?
      
      * Test fixes and parallelize some API tests.
      
      * Test fixes :wrench:
      
      * Oracle test fix? :wrench:
      
      * Another test fix :wrench:
      
      * Stop putting random spaces in code bodies this is not JavaScript code
      
      * with-temp-vals-in-db should merge in original value of Database settings
      
      * The most test fixes :wrench:
      
      * 3 or 4 test fixes :wrench:
      
      * Add schemas around stuff to catch errors
      
      * Appease Kondo
      
      * Implement dataset-already-loaded? for vertica
      
      * Implement dataset-already-loaded? for SQLite and Snowflake
      Unverified
      bab905c0
  22. Jul 16, 2024
  23. Jul 09, 2024
  24. Jul 02, 2024
  25. Jul 01, 2024
  26. Jun 21, 2024
    • John Swanson's avatar
      Fix dev `migrate!` command (#44545) · 0637fefa
      John Swanson authored
      There were two problems here:
      
      - wrong args to `mdb/migrate!` (passing the db-type as well as the data
      source), and
      
      - in MySQL, the changelog table name is not `:databasechangelog`. Use
      `metabase.db.liquibase/changelog-table-name` to get the actual table name.
      Unverified
      0637fefa
  27. Jun 19, 2024
  28. Jun 18, 2024
  29. May 30, 2024
    • bryan's avatar
      CRU card events will log recent-views, and get returned through the API (#43037) · 3b2736c2
      bryan authored
      * Handles card events for CRU (not D) => recent view
      
      * add tests
      
      * avoid some errors in dev
      
      We expect recent-views/post-process to return nil occasionally (for
      permissions reasons, or more), so let's filter those out instead of
      printing a noisy unactionable warning
      
      * uncomment and fix test
      
      * fix some cypress tests + docs improvements
      
      * update more cypress tests
      
      * more cypress test updates
      
      * adding a card puts it into your recents now
      
      * fix notebook-data-source
      
      * fix notebook-data-source
      
      * fixing more e2e tests
      
      * fix command palette e2e tests
      
      * run prettier
      
      * fix style issue
      
      * update notebook-data-source tests
      
      * update homepage e2e tests
      
      * Next question is in recents, now
      
      * update command palette: skip the first pagedown, since it is a noop
      
      * check the buttons for their respective names
      
      * ensure that the model is there, and no questions are
      Unverified
      3b2736c2
  30. May 10, 2024
  31. May 09, 2024
  32. May 08, 2024
  33. Apr 26, 2024
  34. Apr 08, 2024
  35. Mar 26, 2024
  36. Mar 22, 2024
Loading