Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 20, 2024
    • Kamil Mielnik's avatar
      Align paths in Prettier & ESLint scripts (#38951) · 750638e4
      Kamil Mielnik authored
      * Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json
      
      * Handle ts files in e2e tests
      
      * Manually fix ESLint-reported issues
      
      * Format "lint-prettier-pure" script the same way as "prettier"
      
      * Run "yarn eslint-fix"
      
      * Manually fix remaining issues
      
      * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally
      
      * Remove duplicated eslint call
      Unverified
      750638e4
  2. Feb 13, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Add ESLint rule for Metabase strings (#38553) · 279b3721
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix case where Metabase links are render inside template strings
      
      * Add `no-literal-metabase-strings` ESLint rule
      
      * Fix all Metabase string errors
      
      * Address review: Fix the rule
      
      The rule was checking if we have imported the selector
      `getApplicationName` then ignore all Metabase strings. This is different
      than `no-unconditional-metabase-links-render` because in that rule, when
      fixed the Documentation URLs are still in the file, but in this rule,
      when fixed, there should be no Metabase strings left in the file.
      
      * Fix errors from the new lint rule
      Unverified
      279b3721
  3. Jan 26, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      ESLint for detecting the use of Metabase links (#37738) · 13e6ebe9
      Mahatthana (Kelvin) Nomsawadi authored
      * [WIP] ESLint for detecting the use of Metabase links
      
      * Add a rule to detect the use of Metabase links
      
      * Add tests to the new eslint lint rule that detect Metabase links
      
      * Fix all places where errors are caused by the new ESLint rule
      
      * Review: Disable rule for admin folder
      
      * Review: Remove rule disable reason from files under admin folder
      Unverified
      13e6ebe9
  4. May 11, 2023
  5. Jul 06, 2022
  6. Oct 23, 2020
  7. Jul 06, 2018
Loading