Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 03, 2024
    • Raphael Krut-Landau's avatar
      Basic cache admin UI (#39234) · c1f4bff8
      Raphael Krut-Landau authored
      Adds:
      * Performance tab 
      * Data caching settings tab
      * Two-panel strategy editor
      * "Don't cache" strategy
      * "TTL" strategy
      * "Duration" strategy
      * "Use default" option for databases
      * OSS page
      * Unit tests
      
      [Loom](https://www.loom.com/share/b1b173a52be9401588ffb63f718e052a?sid=bed4bdf5-f967-4d93-af55-9b96b6b52730)
      Unverified
      c1f4bff8
    • Nemanja Glumac's avatar
      Add analytics events for the native code preview in a notebook (#40962) · 9a8e0a08
      Nemanja Glumac authored
      * Bump the question schema and update it with the new events
      
      * Enable snowplow tracking on the frontend
      
      * Add E2E test for tracking snowplow events related to native preview sidebar
      
      * Fix question id type in the schema
      Unverified
      9a8e0a08
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Fix embedding (#40841) · a583764b
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix overflow static dashboard
      
      * Fix `frame` event's height for interactive dashboards
      
      * Fix E2E tests
      
      * Fix test names to match the correct GitHub issue numbers
      
      * Use `data-element-id` for consistency
      
      * Make the test selector more consistent
      Unverified
      a583764b
    • Nick Fitzpatrick's avatar
      Command Palette UI adjustments (#40650) · 9c477a75
      Nick Fitzpatrick authored
      * Command Palette UI adjustments
      
      * move search to end of results list
      
      * ellipsis long command palette items, min icon size and showing debounced text
      
      * setting fixed width. adjusting admin result icons and text
      
      * fixing e2e test
      Unverified
      9c477a75
    • Alexander Polyankin's avatar
      Deprecate MLv1 metadata (#40947) · 1235d9a8
      Alexander Polyankin authored
      Unverified
      1235d9a8
    • Uladzimir Havenchyk's avatar
      Fix row id mapping in object detail modal displaying (#40874) · 54ed7544
      Uladzimir Havenchyk authored
      * Map row id on object detail id
      
      * Add a fallback
      
      * Add e2e test
      
      * Add a limit
      
      * Provide a fix for #34070
      
      * Simplify test
      Unverified
      54ed7544
    • Nemanja Glumac's avatar
      Use MLv2 to determine whether a query can be previewed (#40609) · 2cf94320
      Nemanja Glumac authored
      * Use MLv2 to determine whether a query can be previewed
      
      * Add E2E repro for #40608
      
      * Expand E2E repro
      
      * Fix test
      
      * Make sure the step is active and visible before offering to preview its query
      
      * Expand E2E test
      
      * Address review comment - use `getNotebookStep` helper
      Unverified
      2cf94320
    • Uladzimir Havenchyk's avatar
      Do not put js code into page title (#40901) · d12c549a
      Uladzimir Havenchyk authored
      
      * Do not put js code into page title
      
      * Typecheck
      
      * Add e2e test
      
      * Update e2e/test/scenarios/question/document-title.cy.spec.js
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      d12c549a
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [MS2] 1. Analytics (#40681) · af54379a
      Mahatthana (Kelvin) Nomsawadi authored
      * Remove old config + fix typo
      
      * Add new analytics for 4 new illustration settings
      Unverified
      af54379a
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Migrate `dashboard.module.css` (#40918) · f94ec2cc
      Mahatthana (Kelvin) Nomsawadi authored
      * Migrate .DashEditing
      
      * Migrate .CardTitle
      
      * Migrate .PinMap
      
      * Migrate .PinMapUpdateButtonDisabled
      
      * Migrate .BrandColorResizeHandle
      
      * Migrate .VisualizationSlowSpinner
      
      * Migrate .AddSeriesModal
      
      * Migrate 2 more classes
      Unverified
      f94ec2cc
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Remove unused CSS files (#40908) · 1299f251
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix default export
      
      * Remove unused classes
      
      * Remove unused components
      Unverified
      1299f251
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [M1] Metabase illustration settings (#40219) · 715174d3
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Add login page illustration (#39299)
      
      * Move Metabot setting to a new place
      
      * Add setting for login page illustration
      
      * fix UI styling
      
      * Fix not able to upload the same file twice
      
      * Update the admin > appearance > conceal metabase copy
      
      * Prepare the component for tests
      
      * Add some unit tests
      
      * Prevent settings not saved sometimes
      
      After setting the value to/from `custom` one of the setting could be
      failed to save, I suspect this happens because the race condition from
      trying to save the setting values relatively at the same time.
      
      * Make unit tests easier to read
      
      * Add all unit test test cases
      
      * Add basic E2E test
      
      * Show fallback icon for broken images
      
      * Make use of the proper component
      
      * Update the comment to affect the reality
      
      * Add an error message when file size is over 2MB
      
      * Show an error message when the file size > 2MB
      
      * Add the error message tests
      
      * Preserve the preview image aspect-ratio
      
      * Detect corrupted images
      
      * Fix failing unit tests
      
      * Address feedback: Type
      
      * Feedback: Create meaningful variables
      
      * Feedback: Make selector API more sensible
      
      * Prevent race condition
      
      Makes sure we save the settings completely before making other actions
      that also change settings otherwise, there could be race conditions.
      
      * Feedback: tighten up a type
      
      * Feedback: Fix inconsistency callback calls
      
      * 2. Add the rest 3 illustration settings (#40487)
      
      * Add the rest 3 illustration settings
      
      * Don't make the X icon feel lonely
      
      * Fix illustration widget saving
      
      * Fix type error
      
      * 3. Update the select UX to match new design (#40491)
      
      * Update the select UX to match new design
      
      * Move info dot next to file upload button
      
      * Simplify IllustrationWidget API
      
      * Update setting title copy
      
      * Clean up test comments
      
      * Feedback: Clarify `any` type
      
      * Feedback: Use shorthand object creation
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Use global CSS glass instead of inlining values
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Remove unnecessary curly brackets in JSX
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * 4. Connect illustrations to new setting values (#40139)
      
      * Wire landing page illustration to the setting value
      
      * Wire the unsubscribe page to the setting value
      
      * Prepare no rows error to be wired to the setting value
      
      * Wire no question results illustration to the setting value
      
      * Wire no search results illustration to setting value
      
      * Fix error from fixing conflict
      
      * Fix required unnecsseary prop on Image
      
      * Use Image component
      
      * Link dashboard card no results image to the setting value
      
      * Move the no data results to more a generic directory
      
      * Link collection picker no results image to the setting value
      
      * Make illustrations more accessible
      
      * Fix failed tests
      
      * Test unscribe page illustration + test no illustration
      
      * Add landing page tests
      
      * Simplify Cypress selectors
      
      * Refactor: Rename settings to match the new requirements
      
      No question data -> No Data
      No search results -> No object
      
      These changes are made so, these 2 settings are generic enough to
      include other illustrations later on.
      
      * Add no data illustration test
      
      * Add no object illustration tests
      
      * Fix unsubscribe page background style
      
      * Fix not able to build static viz
      
      * 5. Follow-up on milestone 1 (#40710)
      
      * Update custom background illustration scale behavior
      
      * Remove the need to put an SVG file in static folder
      
      * Fix test from rebasing off master with @testing-library/user-event upgrade
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      715174d3
  2. Apr 02, 2024
  3. Apr 01, 2024
  4. Mar 29, 2024
  5. Mar 28, 2024
    • Nick Fitzpatrick's avatar
      Fix for userEvents 14 on Master (#40761) · 589a665e
      Nick Fitzpatrick authored
      * Nick is sad
      
      * tests passing
      Unverified
      589a665e
    • Sloan Sparger's avatar
      Upgrade @testing-library/user-event to v14 (#40269) · 3522a5cc
      Sloan Sparger authored
      
      * upgrades @testing-library/user-event to v14, updates test to accomidate events always returning promises and other breaking API changes
      
      * Fixing up broken suites. Half way
      
      * rest of tests
      
      * green plz
      
      * Fix new entries of userEvent usage
      
      * unit test adjustments
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Co-authored-by: default avatarUladzimir Havenchyk <uladzimir.dev@gmail.com>
      Unverified
      3522a5cc
    • adam-james's avatar
      Make format export optional (#40606) · 347c5ef4
      adam-james authored
      
      * Make Formatting on Exports Optional
      
      Formatting on exports can be turned off via a middleware key:
      
      `:format-export?` which will control if the 'app style' formatting will be applied to the exported results.
      `:format-export? false` will return the file as in previous Metabase versions.
      
      * format_export's default value provided in the QP middleware
      
      Should still default to formatted for v. 49, as the formatting is intended as a feature. This default value should be
      provided in a central place, so is added to the middleware and is therefore not necessary for the API to provide a default.
      
      * weird indentation
      
      * Add format_export param to dashboard dashcard query endpoint
      
      * Add format_export option to embedded dashboard downloads endpoint
      
      * Move default true value to the streaming-results-writer impls
      
      * Default true but for real this time
      
      * Add format_export to the public Question endpoint
      
      * Add test to card api
      
      * Dashboard exports endpoint test
      
      * Add test to dashboard embeds
      
      Test still fails and I don't know why yet
      
      * the dangers of println debugging....
      
      Well, I was passing a string false the whole time. Turns out the problem was me
      
      * Public Card downloads endpoint now has format_export and test
      
      * export_format also works for adhoc queries using api/dataset
      
      * Let defendpoint do the boolean parsing
      
      * Embed endpoint should now work too.
      
      * Unify format-rows and format-export middlewares
      
      * Sneaky endpoint!
      
      * In xlsx, always parse temporal strings so that viz-settings formatting is applied
      
      * Snuck in an incomplete change by accident. removed it.
      
      * Can now specify format/no format on subscriptions
      
      * Fix and move migration
      
      * default format rows to true in attachments
      
      * Ok, I think that should actually work for subscriptions.
      
      * Change endpoints to use format_rows instead of confusing format_export
      
      * format_rows everywhere
      
      * Fix more test failures
      
      * redef'd function had wrong signature
      
      * Make format export optional (FE part) (#40643)
      
      * Refactor download URL builder code
      
      Need to handle query `params` and request `body` separately
      
      * Export `useHover` from `metabase/ui`
      
      * Add unformatted export for dashboard cards
      
      * Add unformatted export for saved questions
      
      * Fix POST body encoding
      
      * Add unformatted export for ad-hoc questions
      
      * Ensure `format_export` is always false for Excel
      
      * Add unformatted export to public questions
      
      * Add unformatted export to embedded questions and dashboards
      
      * Fix behavior for PNG format
      
      * Add tests for `QueryDownloadPopover`
      
      * Fix e2e downloads helper (allow URL query params)
      
      * Rework alt key handling
      
      * Add e2e test
      
      * Switch to `format_rows` instead of `format_export`
      
      * Add unformatted export option to subscriptions
      
      * Fix `isHoldingAltKey` initial state
      
      * Rework e2e test to use Total column
      
      * Fix initial checkbox state for subscriptions
      
      * Use "Alt" in tooltip label for Windows/Linux
      
      * Show the subscriptions toggle only for CSV attachments
      
      ---------
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      
      * Address review feedback
      
      ---------
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      347c5ef4
    • Oisin Coveney's avatar
      Fix wrong icon (#40738) · dac5a001
      Oisin Coveney authored
      Unverified
      dac5a001
Loading