This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 06, 2024
-
-
Jeff Bruemmer authored
-
- Jan 31, 2024
-
-
Vamsi Peri authored
Updated the Global Bundle with the content of https://truststore.pki.rds.amazonaws.com/global/global-bundle.pem -O rds-combined-ca-bundle.pem This is the new URL to be used, as described on https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL.html The new bundle: - removes expired root certificates - keeps certificates for `rds-ca-2019` - adds certificates for all regions for - `rds-ca-rsa2048-g1`: certificate authority with RSA 2048 private key algorithm and SHA256 signing algorithm - `rds-ca-rsa4096-g1`: certificate authority with RSA 4096 private key algorithm and SHA384 signing algorithm - `rds-ca-ecc384-g1`: certificate authority with ECC 384 private key algorithm and SHA384 signing algorithm It fixes #32017 and #27790 Co-authored-by:
Théophile Helleboid <theophile.helleboid.ext@qonto.com>
-
- Jan 18, 2024
-
-
John Swanson authored
Just add a comment warning that the file is autogenerated and not to edit it by hand.
-
- Jan 17, 2024
-
-
Ryan Laurie authored
-
- Jan 09, 2024
-
-
Ngoc Khuat authored
-
- Jan 04, 2024
-
-
Chris Truter authored
-
- Jan 03, 2024
-
-
Ngoc Khuat authored
-
- Dec 20, 2023
-
-
Noah Moss authored
Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
- Dec 08, 2023
-
-
Cam Saul authored
Use `sorted-set` for `locales.clj` so order doesn't change every time we add a new language (#36617)
-
- Nov 15, 2023
-
-
Cam Saul authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Add fonts in Dockerfile to fix pulses (#31764) Add Noto fonts in Alpine Dockerfile * Fix Docker build command --------- Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
Nemanja Glumac authored
This reverts commit 44de976d.
-
Ngoc Khuat authored
-
- Nov 14, 2023
-
-
Mark Bastian authored
* Adding linter and formatter to staged BE files. Note that `.cljfmt/indents.clj` tries to capture our indent rules and, so far, seems to get things right. There are still some inconsistencies in some of our nses in how we indent assoc(-in) and some t2 functions when it comes to key-value pairs on following lines. Should the keys align with the function call or be indented. Aesthetically, people seem to like indents, but these are functions, so should align with the first argument. IDK that it really matters as long as we have agreement. We may, as we adopt this, have some files be reformatted in unexpected ways for items that have been missed. If so, the developer can simply update the .cljfmt/indents.clj file, rerun the hook, and commit that along with their other changes. * Added whitespace linter. * Updating husky commit hook * Updated hook scripts to be exclusively for staged files. Updated cljfmt to use the latest and greatest along with the new format of config file. * Commenting out the actual formatting hook in .husky/pre-commit until we come up with a globally happy solution to forms that don't have good formatting rules, like defprotocol+ in a reader conditional. * Reverting formatting * Moving pre-commit hooks from .husky/pre-commit to the package.json's lint-staged section. Note that we're still not calling the cljfmt file (.bin/cljfmt_staged.sh) until we get agreement on formatting. One thing we might do since we're using lint-staged is we can probably exclude the "bad" files that go sideways with linting and format everything else automatically. This might be a good follow-on PR.
-
Luis Paolini authored
Add Noto fonts in Alpine Dockerfile
-
- Nov 08, 2023
-
-
Noah Moss authored
Co-authored-by:
Ryan Laurie <iethree@gmail.com> Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
- Nov 07, 2023
-
-
Ryan Kienstra authored
Co-authored-by:
Cam Saul <github@camsaul.com>
-
- Oct 17, 2023
-
-
Nemanja Glumac authored
* Remove `branch` from version.properties file * Remove branch from logs * Remove `branch` from `application-name` The `application-name` string is needed for Google drivers. See: https://github.com/metabase/metabase/issues/2627
-
- Oct 04, 2023
-
-
Nemanja Glumac authored
It was deprecated and left in a codebase for backwards compatibility. But it seems we've migrated all references to the new method `delete-file-if-exists`. The last time this was touched was three years ago. Should be safe to remove.
-
- Sep 28, 2023
-
-
Ryan Laurie authored
-
- Sep 20, 2023
-
-
Mark Bastian authored
* Fix clj-kondo was getting an error: ```clojure user=> (require ’[clj-kondo.hooks-api :as hooks]) Syntax error compiling at (clj_kondo/impl/analysis/java.clj:61:6). Unable to find static field: ASM9 in interface org.objectweb.asm.Opcodes ``` checking where the bad version comes from: ```clojure user=> (io/resource "org/objectweb/asm/Opcodes.class") "0x37e9d2e2" "jar:file:/Users/dan/.m2/repository/org/ow2/asm/asm-all/5.2/asm-all-5.2.jar!/org/objectweb/asm/Opcodes.class"] ``` and running ``` > clj -X:deps tree :aliases '[:dev :ee :ee-dev :drivers :drivers-dev :alpha :socket :morse :reveal]' > deps ❯ grep asm deps X org.ow2.asm/asm 9.4 :superseded . org.ow2.asm/asm-all 5.2 . org.ow2.asm/asm 9.5 :newer-version . org.ow2.asm/asm-commons 9.5 . org.ow2.asm/asm 9.5 . org.ow2.asm/asm-tree 9.5 . org.ow2.asm/asm 9.5 X org.ow2.asm/asm 9.2 :older-version ``` The 9.4 and 9.5s are all close to each other. But the asm-all 5.2 is far too old. That's brought in by eastwood. So i'll exclude it and see if it works * Can't throw error in api endpoint for linked entities x-ray `create-linked-dashboard` creates a dashboard if there are no linked entities, so this is unreachable code * unify card and query code pathways. now it's quite clear how card and query diverge: ```clojure (defmethod automagic-analysis Card [card {:keys [cell-query] :as opts}] (let [root (->root card) cell-url (format "%squestion/%s/cell/%s" public-endpoint (u/the-id card) (encode-base64-json cell-query))] (query-based-analysis root opts (when cell-query {:cell-query cell-query :cell-url cell-url})))) (defmethod automagic-analysis Query [query {:keys [cell-query] :as opts}] (let [root (->root query) cell-query (when cell-query (mbql.normalize/normalize-fragment [:query :filter] cell-query)) opts (cond-> opts cell-query (assoc :cell-query cell-query)) cell-url (format "%sadhoc/%s/cell/%s" public-endpoint (encode-base64-json (:dataset_query query)) (encode-base64-json cell-query))] (query-based-analysis root opts (when cell-query {:cell-query cell-query :cell-url cell-url})))) ``` * Adding frequencies to a test to prevent non-deterministic behavior * Fixing linter check and ordering issue in test. * Adding TODO future task to replace /rule/ with /dashboard-template/ in paths. * Added large ns block to metabase.automagic-dashboards.core * Fixing spelling mistakes * Some docstrings and renaming for clarity. * Added ->field and ->root (covering source) tests * TODO - Fix minumum spelling error on standalone PR. * Breaking up tests to understand what is on with bulk failures * Broke make-cards into several logical steps so that the code is more readable. Added tests for each stage. * Updating references to rules.clj for i18n generation. * Inlined make-context into apply-dashboard-template. This makes the steps of creating dimensions, metrics, and filters more explicit. ATM we still need to resolve the logic around inject-root as this has dependence on the context and not the individual dimensions. * put build stuff on classpath for lsp * calculate base-context once before template loop * Removed the inject-root multimethod in favor of simple functions. Introducing the idea of removing metric and filter candidates that claim dimensions that don't exist. * Adding logic to pre-emptively remove unsatisfied metrics, filters, and dimensions. In `card-candidates` the check: ``` (and (every? context-dimensions (map ffirst card-dimensions)) (every? context-metrics card-metrics) (every? context-filters card-filters)) ``` is now performed to ensure that the card is satisfied before moving forward. * Renamed common-dimensions, common-metrics, and common-filters to satisfied-* for clarity. In card-candidates also changed context-* and card-* bindings to available-* and required-* for clarity. * Teasing out the generated dimensions, metrics, and filters from the big-ball-of-mud context. `make-cards` now takes the base context as well as the available computed dimensions, metrics, and filters as a separate argument. Additionally, tests were added for the `(comp #(filter-tables % tables) dashboard-templates/->entity)` branch of `some-fn` in `potential-card-dimension-bindings`. However, I am not confident that this is ever called outside of the tests. In order to be called, the entity type for the table has to be a named dimension in a card, which I can't find any examples of in the templates. * Pushing mega-context down to return value of apply-dashboard-template. Just need to take it apart where it is used downstream. * apply-dashboard-template now just returns generated values and does not build up the base context. * Adding tests for cases in which dimensions are defined in a native query on the dashcard template. The only case where this happens is in the resources/automagic_dashboards/table/example.yaml and, prior to this PR, had no test coverage. It does add some weird complexities to the system (including bringing in dimensions from a different approach vector) so perhaps we want to re-evaluate if we want this as a feature or not. --------- Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Sep 05, 2023
-
-
Nemanja Glumac authored
[ci skip]
-
- Sep 02, 2023
-
-
Cam Saul authored
Migrate QP/drivers code to use MLv2 metadata directly; make another 100+ tests parallel and shave 12 seconds off test suite (#33429) * QP MLv2 Metadata Provider follow-ons * Update lots of stuff to use MLv2 metadata instead of legacy metadata * Fix lint warnings * B I G cleanup * Everything is neat * Mention new test pattern in driver dev changelog * Appease Cljs by renaming a bunch of namespaces * Move more stuff over * Fix kondo errors * Fix even more things * Test fixes * Fix JS export * Test fixes
* Fix final MongoDB test -
metamben authored
* Bump simple changes * Account for changed exception message * Add buddy-sign license * Use maven coordinates to select tools.build version
-
- Aug 22, 2023
-
-
Cam Saul authored
* Parallel QP tests; linter improvements; move QP test fns * Cleanup * Move query->expected-cols * Fix QP test namespace * Test fix
* Fix merge issues * Revert unrelated changes * Test fix * Fix some things that are actually ^:parallel safe * Remove Oracle logic for destroying DBs from different sessions since we don't test on AWS anymore * Use ReentrantReadWriteLock for getting + creating test datasets to avoid race conditions * Add non-`metabase.test` versions of things to the disallowed list for `^:parallel` tests
-
- Aug 18, 2023
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
We have to sets of functions that deal with the information about Metabase version. 1. During build process we create `version.properties` file 2. During release we create new `version-info.json` or `version-info-ee.json` files that we store in AWS The first contains the information about the current Metabase version. It's used to generate info in "About Metabase" window, among others. Calling both namespaces `version-info` leads to unnecessary confusion. This commit should make the disctinction between the two more obvious and clear.
-
- Aug 07, 2023
-
-
Ngoc Khuat authored
-
- Jul 21, 2023
-
-
Cam Saul authored
-
- Jul 04, 2023
-
-
john-metabase authored
This reverts commit 9da0bd76.
-
- Jun 26, 2023
-
-
Noah Moss authored
-
- Jun 21, 2023
-
-
Dennis Schridde authored
Revert "Compile with direct_link=true (#28357)" and "Respect MB_COLORIZE_LOGS and MB_EMOJI_IN_LOGS environment variables (#31612)" (#31732) This can cause environment variables set at compile time to affect runtime, cf. https://github.com/metabase/metabase/issues/30518. We keep the changes to JVM options and logging startup time, since they were independently useful. This reverts commit e3285698 and commit 380cd8a3.
-
- Jun 20, 2023
-
-
john-metabase authored
-
- Jun 10, 2023
-
-
Ariya Hidayat authored
-
- Jun 09, 2023
-
-
Noah Moss authored
-
- Jun 07, 2023
-
-
Nemanja Glumac authored
-
- Jun 04, 2023
-
-
Nemanja Glumac authored
We migrated from CircleCI a long time ago and are now using GitHub Actions. But even without that CircleCI, like many other CI providers, sets the `CI` environment variable to `true` or to `1` by default. This PR updates the `interactive?` check to use that env var as fallback.
-
- Apr 28, 2023
-
-
Jeff Bruemmer authored
-
- Apr 26, 2023
-
-
Tim Macdonald authored
* allow formData uploads * basic CSV uploads from collections * add dropzone support for collections * Add CSV uploads feature and have postgres and H2 support it (#29636) * Add csv uploads feature and have postgres support it * Add h2 support * CSV: schema detection (#29650) * CSV / Admin Upload Settings (#29709) * allow formData uploads * basic CSV uploads from collections * add dropzone support for collections * allow formData uploads * basic CSV uploads from collections * add dropzone support for collections * Add CSV uploads feature and have postgres and H2 support it (#29636) * Add csv uploads feature and have postgres support it * Add h2 support * Add defsettings * Add table prefix setting * add data upload settings * Add newline * update settings mock * Whether or not uploads are enabled --------- Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Callum Herries <hi@callumherries.com> * Create table and insert rows from CSV uploads for postgres (#29677) * WIP create table and insert rows * Add newline * Use multimethods * WIP * Fix postgres * Fix postgres impl * Use detect-schema and add test * Fix load-from-csv arglists * Undo whitespace change * Use empty db instead * Add table and field tests * Remove prn * Uniquify names * newline * Add test for float * Add a test for the table contents * Tidy load-from-csv * Drop the table if loading the csv fails * Drop the table only if loading the csv fails * whitespace * Address SQL injection vulnerability * Use the slugified file-name as the table-name * Fix kondo * Using absolute path instead of relative * Fix kondo * Detect types for empty CSV files appropriately (#29754) * Create models from CSV uploads (#29966) * Wire up CSV uploads, sync the new table Still need to create a model * Check database support for CSV uploads better * Another test * Create model after sync * Fix request with formData * Fix tests * Fix tests * Revert "Fix request with formData" This reverts commit 66f146a41cf42feb34dbb03ed8566fa4220d0642. * Add whitespace --------- Co-authored-by:
Tim Macdonald <tim@tsmacdonald.com> * Fix postgres support for uploads (#29922) * Check write perms for collection (#29976) * Rename metabase.csv -> metabase.upload (#29975) * Rename metabase.csv -> metabase.upload * Add docstring * Rename alias for release.common.upload --------- Co-authored-by:
Callum Herries <hi@callumherries.com> * WIP - 29598 csv status toast (#29757) * temp * generalize StatusListing types * Putting a pin in this for now * poorly done typing * generalizing upload function names * point to real API * Fixing Storybook * Permissions for Status Listing * use formdata and fix types --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com> * Don't support redshift (#29981) * Handle uploads to the root collection (#29985) * Allow the uploads schema to be nil (for MySQL, etc.) (#29987) * CSV upload: fix stack overflow in detect-schema (#29983) * Fix stack overflow error on detect schema * map + vec -> mapv --------- Co-authored-by:
Tim Macdonald <tim@metabase.com> * reload collection data after upload (#30009) * MySQL support for uploads (#29829) * Add MySQL support for uploads * Rename arg to upload-type * Use new ns name * Allow no table-name prefix to be specified and fix tests --------- Co-authored-by:
Tim Macdonald <tim@tsmacdonald.com> * Fix setting descriptions (#30023) * Batch CSV insertion for better performance (#30028) * CSV upload e2e tests (#30005) * add CSV upload e2e tests * update tests * H2 support for uploads (#29828) * Add uploads support for H2 * Rename arg * whitespace * Use new metabase.upload ns name * Fix tests for H2 * Make table and field matching case insensitive * Fix kondo error --------- Co-authored-by:
Tim Macdonald <tim@tsmacdonald.com> * Clear CSV upload state after a while (#30014) * clear upload status after 5s * make async behavior clearer * CSV Upload Dates and Datetimes Types (#30076) * Simple dates * Simple datetimes * Fix coalesce for date and datetime * Add mysql and h2 types * Fix test * Misc cleanup * Fix test --------- Co-authored-by:
Tim Macdonald <tim@tsmacdonald.com> * Fix Kondo (rebase gone wrong) * MySQL test fix * Fix order of Metabot setting * adding unit tests to upload actions and reducers (#30161) * adding unit tests to upload actions and reducers * use fetch-mock * Adding component unit test * Check CSV Upload permissions on the frontend (#30094) * CSV / Admin Upload Settings (#29709) * allow formData uploads * basic CSV uploads from collections * add dropzone support for collections * allow formData uploads * basic CSV uploads from collections * add dropzone support for collections * Add CSV uploads feature and have postgres and H2 support it (#29636) * Add csv uploads feature and have postgres support it * Add h2 support * Add defsettings * Add table prefix setting * add data upload settings * Add newline * update settings mock * Whether or not uploads are enabled --------- Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Callum Herries <hi@callumherries.com> * properly check if user can upload to a collection * do some db checking * don't check admin status for upload notification * misc cleanup * fix rebase * add loggedin check to statusListing also combines container + view component into a single file * update unit tests * update tests --------- Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Callum Herries <hi@callumherries.com> * Csv/misc bugfixes (#30219) * Support empty header names * Handle long CSV names more appropriately Handle duplicate column names in CSVs * Test fix * Partition CSV inserts a little more intelligently * Test fix * Remove 'duplicate' from duplicated column names * More intelligent sampling * Add comment re. Postgres table-name-length-limit * Quote column names, clean up tests When unquoted, we couldn't use reserved words (true, false, group, etc.) as column names * Fix test Now that we quote things, H2 is case-sensitive * Use dialect-appropriate quoting Also clean up some card-filtering tests so they work with a dirty DB * Fix deduplication * Remove use of setting/get * Remove unneeded migration --------- Co-authored-by:
Callum Herries <hi@callumherries.com> * Fix test (#30383) --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Callum Herries <hi@callumherries.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Apr 18, 2023
-
-
Ariya Hidayat authored
The core logic is still from the release script in bin/release. The change here mostly wiring it up to GitHub Action so that it can be trigged upon a new git tag (during the release process).
-