* adding hasMultipleDimensions check to hasLegend clause

* Adding queryBuilderMain helper

* PR Feedback

* remove only

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* fix exclude date filter serialization

* review

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

* Allow linkviz to show recent item suggestions

* unit test recent link adding

* oops

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

* Users can execute actions if they can read the model and the DB is not blocked

[Fixes #28425]

Co-authored-by: Tim Macdonald <tim@metabase.com>

* Optimize average case DB calls

* Typo

* Fix test

* Remove duplicate require

* Return nil

* Fixes

* Fix docstring

* Remove unused require

* Avoid hydrating ordered_cards on the dashboard again

* Tidy

* Update docstring

* Move transaction

* Move comment

* Remove dashboard->param-field-ids

* whitespace

* Tidy update-dashcards!

* Updates from suggestions

* Update test

* Update test description



---------

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

* Use icon helpers

* Remove redundant export

* Use top-level component in tests, keep clean state

* Remove redundant `findBy*` lookups

* Extract IDs to constants

* Reduce repetitive code

* Always mock execution endpoint

* Get back changes lost while rebasing

* Don't repeat exec mock URL everywhere

* Remove retrieve-dashboard-card call

* Have `update-dashboard-card!` return nil, not true

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

* try fixing collections flake

* update spec

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

* Add migration for deleting the abandonment email task

* Start+stop scheduler around the migration

* Update clj-kondo

* Rename migration

* Change to 46

* Fix define-migration

* Add test

* Update ns description

* Remove stop-scheduler! from migration

* Remove migration dependency on metabase.task

* Restore mdb.connection -> mdb

* Update custom-migrations ns docstring

* Remove unused code

* Fix comment

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

Co-authored-by: Gustavo Saiani <gus@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Natalie <nat@metabase.com>

* Fix flaky test and test for a new case

flaky test was annoying. It would timeout after 45 seconds. And
annoyingly, it times out on the _client_, not the server. So we don't
get the proper error message we expect.

And what's happening is that the backend just hooks up the pipe from
it's request to the response. And if no bytes ever come across, we just
twiddle our thumbs until the http request in the test gives up.

The only reliable way i could think of to fix this is to spin up a
webserver that just accepts and then ignores requests (which is what
github did to us in the flaky test).

Had to bump the ring adapter to get the newly exposed `:async-timeout
60000` parameter. By default the webserver in the test has a timeout of
30 seconds, which is shorter than the 45 second timeout for the test's
request to the geojson endpoint.

* add comment

* clean up test server logic

---------

Co-authored-by: dpsutton <dan@dpsutton.com>
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* only save changed dashboards

* test early return from save action

* remove problematic api wait for dashboard save

* deeply compare cards and add better tests

* update failing e2e test

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

Fixes #25378

When using a relative filter with a starting from n units ago on an
aggregation with the same units, we were incorrectly assuming that we
would be working with a field ref at the top level. However, in this
scenario the field is nested such as `[:+ [:field $created_at
{:temporal-unit :month}] [:interval 1 :month]]`. This change makes sure
that we are altering the field-ref.

Co-authored-by: Case Nelson <case@metabase.com>

* composite key object detail test

* add tests for no primary keys

* fix rebase

* allow db sync to wait on the presence of a specific table

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

* Adding Show Total toggle, adding unit tests

* adjusting unit test, fixing logic

* Adding Static Viz test. PR Feedback

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Fixes #19501

Redshift jdbc driver wraps intervals in a special class whereas postgres
simply returns strings. This unwraps the special redshift class into the
same string representation.

Co-authored-by: Case Nelson <case@metabase.com>

* Handle models with joins

We had been using the metadata from the query to get column names, and
then `select (column-names) from persisted-table`.

But joins affect how columns are emitted.

For this tests, using orders join to products, selecting order.total and
product.category. And the metadata from running this query uses the
normal names `:name "total"`, and `:name "category"`. _BUT_ the emitted
sql does not use these names:

```sql
SELECT "public"."orders"."total" AS "total",
       "products"."category" AS "products__category" -- <--------
FROM "public"."orders"
LEFT JOIN "public"."products" AS "products"
       ON "public"."orders"."product_id" = "products"."id"
```

When we persist, we do `create table as <(qp/compile query)> so we were
creating a column named `products__category` _NOT_ "category". But later
on we would select "category" and this would blow up.

```sql
select "total", "category" -- <- category doesn't exist in this table
from "metabase_cache_424a9_8"."model_1105_txbhmkrnoy"
```

Now a query of `{:source-table "card__<model-id>"}' emits the following
query when the persisted cache is substituted:

```sql
SELECT "source"."total" AS "total",
       "source"."products__category" AS "products__category"
FROM (select * from "metabase_cache_424a9_8"."model_1152_lecqfzcjke") AS
"source"
LIMIT 1048575
```

* Test and lint fixes

Co-authored-by: dpsutton <dan@dpsutton.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

* WIP for better axes grouping in static viz.

Double x-axis and single x-axis are different, but both can have situations where grouping might occur, so the
implementation is a tad confusing. I'm trying to build test cases that represent both scenarios reasonably, and build
an implementation that's not too confusing.

* Fix reflection warnings in render test utils

* Overlap calcs don't fail with BigDecimal inputs now.

* Continuing to clean up overlaps calcs and impl for single/double in progress

* WIP version that works for single-x multi-series and double-x multi

There's a lot to think about here...

But basically, handle rows of shape:

double-x:

[[x1 x2] [y]]

and single-x:

[[x] [y1 y2 y3]]

* Single and Multi X axis now use same axes grouping strategy

* Cover some overlap scoring cases.

This may need improving in future still, but the overlap calculation is at least used for both single-x and multi-x
axis scenarios now, which is a definitie improvement.

* Missed these unused bindings in test let body

* overlap calc won't fail if we pass in `[nil nil]`

* Clean up grouping axes implementation addressing review feedback.

- overlap and nearness split into two functions
- add the fn 'axis-group-score' to call overlap/nearness appropriately, and handle condition checks (eg. nil vals)
- removed old group-axes and now unnecessasry default-y-axis-pos fn -> handled by group-axes-at-once fn
- axis group threshold not passed as arg anymore

* Fixed some alignment mistakes

Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>

Co-authored-by: Natalie <nat@metabase.com>

* List all actions

previously `api/action` required `?model-id=<model-id>`. This caused the
FE to DOS the backend looping over each action. On stats I found 350 or
so sequential requests, with app-db saturation leading to requests
taking from 400ms near the beginning to 7seconds near the end.

This makes `model-id` option and now returns actions on all models the
user can see.

```
❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb
[
    {
        "archived": false,
        "creator": {...},
        "creator_id": 1,
        "database_id": 3,
        "dataset_query": {...},
        "id": 1,
        "model_id": 1,
        "name": "source = foo",
        "parameter_mappings": null,
        "parameters": [...],
        ...
    }
    ...
]
```

* update frontend for action picker to support single action list endpoint

* list actions tests

* update actions e2e tests

* Return empty vector if no results

Running tests locally might return some extra actions not asserted on in
the tests. And there you might expect a 200. But CI runs with an empty
database and returns no response so you get a 204. Quite annoying and
there's no good way to expect a "2xx" status code at the moment. So just
return the empty vector so it's always a 200 code.

* update actions endpoint unit test mocks

* Simplify logic a little

* docstring tweak

* schema with better error message

* update mocks to accept optional modelId

* simplify sorting and grouping

* make sort case-insensitive

* simplify action api test mocks

---------

Co-authored-by: dpsutton <dan@dpsutton.com>
Co-authored-by: Ryan Laurie <iethree@gmail.com>

* Remove personal collections from collection detail page

https://github.com/metabase/metabase/pull/28023

 Added "sub collections"
to the collection detail page. Makes sense. The problem is that personal
collections started appearing in this view. We have traditionally
treated personal collections as siblings to the "Our Analytics" root of
collections. So this was an impedence mismatch.

This PR just removes all personal collections from the items returned
from `"api/collection/root/items"`. The personal collection is still
visible in the sidebar (returned from
`api/collection/tree?tree=true&exclude-other-user-collections=true&exclude-archived=true`
. Furthermore, all personal collections are still visible from the
"three dots" menu on the sidebar.

* poke ci

* remove last personal collections from tests

* e2e tests

don't include a personal collection in the details page.

* off by one from removing personal collections

* Can't select personal collections if they aren't there

Co-authored-by: dpsutton <dan@dpsutton.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* pulling out column title logic and sharing with settings

* Pivot Table Custom Column Names

* removing cyclic dependency

* adjusting tests

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* Exclude non-required PKs from implicit create actions

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

* Adding classname prop to ObjectDetail

* making className optional

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* Don't ignore manually entered parameters on clean

* Validate options for numeric fields with dropdown input

* Clear `valueOptions` when switching field and input types

* Remove sample options for inputs with options

* Rename `getValidationError`

* Bring sample options back

* Minor rename for clarity

* Fix `InputOptionsMap` type

* Keep `inputType` on field type change if possible

* Extract `FieldValueOptions` type

* Use less aggressive value options clean logic

* Simplify tests

* Test value options reset for option-less field types

* Fix `OptionEditor` value gets out of sync

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>