This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 05, 2023
-
-
Anton Kulyk authored
* Make bucket pickers more customizable * Allow hiding expressions in `AggregationPicker` * Migrate `SummarizeSidebar` to MLv2 * Delegate more stuff to aggregation components * Polish for breakout components * Don't copy queries into sidebar state * Use two breakouts in sidebar tests * Use long display name for pinned breakouts * Fix "replace column" used instead of "add column" * Fix extra spacing * Fix tooltip position * Fix pinned breakouts display * Fix E2E test * Clean up bucket pickers * Fix types * Fix border width * Simplify `BreakoutColumnList` * Add `withDefaultBucket` helper * Avoid `byRole` queries in sidebar tests * Fix UI jumps while searching * Hide "Custom expression" option
-
Kamil Mielnik authored
* Fix #31339 * Add an e2e for horizontal scrollbar presence * Add an e2e test for the originally reported issue #31339 * Remove inline headerCells * Format tests * Remove redundant code * Move tests to table visualization scenarios tests suite
-
Kamil Mielnik authored
Adding filter of summarized field grouped by latitude and longitude on a map changes visualization type (#31646) * Take sourceQuery into account if StructuredQuery does not have any aggregations or breakouts when determining Question's default display - It's an attempt to fix #30057 * Don't check source query for models * Use source query breakouts and aggregations to determine default display only if the question does not have any breakouts, aggregations, and joins - Make the condition to always use "table" display for Models more prominent * Revert first attempt * Introduce CardObject and fix displayIsLocked typing * Refactor maybeUnlockDisplay into maybeResetDisplay * Revert "Introduce CardObject and fix displayIsLocked typing" This reverts commit 770e7a50d3b9f381741ba7cb1655c1d9be5f295c. * Improve diff * Update unit tests after maybeUnlockDisplay to maybeResetDisplay refactoring * Update maybeResetDisplay unit tests * Improve test case names * Add tag for the test that reproduces the issue * Add test for issue #30057 - use visualize() helper - extract addCountGreaterThan2Filter() * Add a test case for adding columns * Add a test case for removing columns (resetting to default value) * Add a test case for adding aggregations * Add another test case * Reuse e2e helpers - add missing "field" parameter support in addSummaryGroupingField - add removeSummaryGroupingField * Remove redundant condition * Update issue id in tests after extracting separate GitHub issue
-
- Jul 04, 2023
-
-
john-metabase authored
This reverts commit 9da0bd76.
-
Nemanja Glumac authored
* Generate conditional `describe` blocks * Distinguish between premium features and enterprise artifact --- This is the first step in series of commits that should allow us to test our feature flags in a more granular fashion. We first need to remove the confusion around the words "enterprise" and "premium". ## Before - `isEE` helper was used to mark setup with the premium token that has all feature-flags enabled. - `isOSS` was used as the negation of the previous helper and as such wasn't strictly always true. - For example, isOSS would have resolved to true on enterprise instances without a token This didn't backfire simply because we're running all EE instances with the token by default ## Now There is a clear distinction between: - OSS (literal open-source instance running on OSS artifract) - EE (enterprise artifact without a token) - PREMIUM (enterprise artifact with active premium token, with all feature flags enabled)
-
shaun authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Jul 03, 2023
-
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
-
Nick Fitzpatrick authored
-
Ryan Laurie authored
* update row chart measuring function * add test to check if the line chart retnders
-
- Jun 30, 2023
-
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
* Fix TextWidget inconsistent behavior when all chars are removed * Revert "Fix TextWidget inconsistent behavior when all chars are removed" This reverts commit d17b530ab0d85b7d1fde5dc0566ebf0641bd5a46. * Add normalization for value in field filters * Add normalization for default value * Update frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.jsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Add e2e test --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Alexander Polyankin authored
-
Kamil Mielnik authored
Fix - Adding filter of summarized field grouped by latitude and longitude on a map causes table visualization error (#31952) * Fix #30058 * Add missing setting key * Add a unit test attempt at #30058 * Mock store instead of using deprecated MetabaseSettings.set * Remove LeafletGridHeatMap unit tests * Add e2e test for #30058 * Fix typing * Don't allow undefined "map-tile-server-url" * Tag the test with repo and issue id
-
- Jun 29, 2023
-
-
Nick Fitzpatrick authored
* remove disabled columns from isValid check * Applying column indexes before filtering * Adding test to GH 29140, updating test helpers in settings.cy.spec.js * Adjusting indexes when sorting via table header * e2e test adjustments
-
Ryan Laurie authored
-
Kamil Mielnik authored
* Fix component name * Show only 1 title line on small SmartScalars * Style PreviousValueVariation and the separator - Get rid of flexbox so that the default browser text-wrapping algorithm is used - Be pixel-perfect about margin-left * Bring back height calculation based on number of lines * Format change * Fix ellipsis in ScalarValue * Make spacing consistent * Style VariationIcon and VariationValue - get rid of a utility class and inline CSS * Add ellipsis to previous value, style tooltip * Ensure consistent width of SmartScalar children * Update JS to match CSS * Refactor measureText to return the whole TextMetrics object * Extract hardcoded padding out of ScalarValue * Update measure text to return height explicitly * Account for height in the findSize function * Improve spacing * Improve styling * Fix build, bring back removed styling * Make previous value responsive * Revert #31724 * Fix typing - Introduce TextWidthMeasurer type * Remove redundant CSS and elements * Rename formatChangeSmart to formatChangeAutoPrecision * Fix ellipsis on previous value * Improve 2 lines threshold value and introduce explanatory constant * Format code * Remove redundant code * Update findSize tests * Fix overflow in Scalars * Add overflow test boilerplate * Include more sizes in the test * Format code * Add tests for scalar - add scalar-description to assertions * Extract assertDescendantNotOverflowsContainer * Remove redundant check * Extract setupDashboardWithQuestionInCards * Reorder cards from biggest to lowest horizontally * Extract assertDescendantsNotOverflowDashcards * Add test case for when sidebar is open * Format code * Ignore elements without dimensions in assertions * Reorder cards from biggest to smallest vertically * Add 1x cards in tests for scalars * Add tests for various viewports * Improve naming * Format code * Fix cursor: pointer being shown on container hover instead of icon hover * Improve vertical icon alignment, make ScalarDescriptionPlaceholder padding consistent with ScalarDescriptionContainer * Account for title lines count in Scalar * Refactor tests to allow better test case descriptons * Use useful viewports * Find a testable way to fix ellipsis * Adjust test data * Add assertion messages * Fix tooltip not shown on value when ellipsis is applied * Add test for tooltips in 1x2 card * Add tests for 2x2 & 5x3 cards - fix CSS issues breaking tests * Add tests for 2x2 card * Add tests for more card sizes * Assert ellipsis is applied * Fix assertions * Update unit tests * Rename TITLE_2_LINES_THRESHOLD to TITLE_2_LINES_HEIGHT_THRESHOLD * Fix typo * Make mock data reflect real data a bit more * Fix cursor: pointer being applied on the container hover instead of icon * Don't assume the "space" function will return values in pixels * Move Scalar to its own directory * Extract constants.ts and utils.ts from Scalar * Move SmartScalar to its own directory * Extract constants.ts and utils.ts from SmartScalar * Extract styles computation out of SmartScalar * Extract getValueWidth & getValueHeight to utils * Update value height computation * Update typing * Make capitalization work as intended * Fix inversed calculation * Add missing gridSize prop * Remove capitalization logic and improve breakpoints - I believe the original intention was to capitalize only the first character, but every word is capitalized and it looks weird * Extract createCardsRow * Break down the tests into more suites because cypress can't consistently handle loading 20 dashboard card simultaneously * Improve names * Remove mistakenly added size 1 smart cards from tests * Sort props to see differences * Fix vertical center alignment in Scalar - this change also affects SmartScalar, see discussion: https://metaboat.slack.com/archives/C057T1QTB3L/p1688020307409629?thread_ts=1687997714.132239&cid=C057T1QTB3L * Replace within() + contains() with findByText() * Don't export getTitleHeight - move it to below where it's used * Remove unused gridSize prop * Use consistent code style * Simplify separators logic * Remove concatRecursively * Fix typo * Optimize test suite * Fix typo * Add unit tests for Scalar utils: getValueHeight & getValueWidth * Add unit tests for SmartScalar utils * Fix e2e tests - update card width in test caes - wrap cases requiring cy.viewport() in it to prevent test issues
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Migrate notebook aggregations to MLv2 — Operators (1) (#31527) * Add aggregation types * Add aggregation TypeScript wrappers * Move `AggregateStep` to its own directory * Port basic features to MLv2 * Deprecate `AggregationPopover` * Fix MLv1's aggregation clause validation * Fix import * `requiresField` → `requiresColumn` * Add basic tests for `AggregationPicker` * Add `findAggregationOperator` test utility * Add basic tests for `AggregateStep` * Make stage index explicit * Highlight selections, add picker back button * Use long display name for aggregation clauses * Remove `React` imports * Enable temporal bucketing * Use aggregation JS wrappers * Fix `Icon` import * Patch unit test according to BE changes * Fix E2E test * Simplify `Aggregation's` `dimension` method * Fix formatting * Migrate notebook aggregations to MLv2 — Metrics (2) (#31528) * Add basic legacy metrics support * Don't show archived metrics * Highlight selected metric * Extract `AggregationPopover` in notebook step * Fix `onClose` prop * Fix icon * Add missing metric types * Use MLv2 to manage metrics * Remove legacy query logic * Add `Aggregatable` type * Migrate notebook aggregations to MLv2 — Inline expressions (3) (#31529) * Revert "Remove legacy query logic" This reverts commit 722804d3a6684762701351c658625b5439c75c2b. * Use HTML labels in `ExpressionWidget` * Support inline expressions for aggregations * Fix import * Fix picker navigation * Fix type error * Remove `ts-expect-error` * Migrate notebook aggregations to MLv2 — Disable MLv1 validation (4) (#31530)
-
Mahatthana (Kelvin) Nomsawadi authored
* Add full-app embedding tests * Clean up unnecessary `within` call * Clarify code comments * Improve clarity on test utils
-
- Jun 28, 2023
-
-
Ryan Laurie authored
* don't navigate away from the current model if the user searches for an item in that model
-
Roman Abdulmanov authored
-
Ryan Laurie authored
fix object detail record nav for non-integer keys\ndont allow navigation past the end of the object detail data with the keyboard (#31912)
-
john-metabase authored
-
Noah Moss authored
-
Alexander Polyankin authored
-
- Jun 27, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
-
Aleksandr Lesnenko authored
-
Alexander Polyankin authored
-
Ryan Laurie authored
* track dashcard events
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
-
Anton Kulyk authored
-
- Jun 26, 2023
-
-
Noah Moss authored
* read is-metabot-enabled setting from env var only * change visibility back to public * skip metabot specs * skip one more spec * fix BE tests * fix indentation * more indentation --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Emmad Usmani authored
* only load cards and metadata for current dashboard tab * add e2e test * refactor * more refactoring * fix filters not working * update e2e test * fix bug with x-rays * add dashboard_tab_id to automagic-dashboard response * use schema check instead * fix on public dashboards * remove FE x-ray fix now that BE is fixed * add test for public dashboards * fix duplicate request for public dashboards * fix notification bug * fix failing unit tests in `reducers.unit.spec.js` --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Nick Fitzpatrick authored
* changing chart settings labels to use htmlFor * updating table test to use findByLabelText * Updating tests to use findByLabelText * adjusting test
-
Nick Fitzpatrick authored
* Adding snowplow events for custom homepage and dashboard pdf downloads * PR Feedback * rebase fix
-
Mahatthana (Kelvin) Nomsawadi authored
* Group tests to make it easier to follow * Add the first parameter with default values test * Modify a test util API to make it easier to understand * Make the assertion more concise * Add more tests to cover default parameter values * Address review: cleanup + fix typo Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Jun 25, 2023
-
-
Uladzimir Havenchyk authored
-