Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 30, 2018
    • Ryan Senior's avatar
      Switch jest maxWorkers to 8, fix nested Jest tests · d97a083b
      Ryan Senior authored
      This commit reduces the number of test runner workers for Jest tests
      from 10 to 8. This will use less memory and hopefully avoid Circle CI
      4GB memory limit test failures. It also fixes some tests that have
      nested `it` clauses. This doesn't run correctly on older versions of
      Jest and will fail fast on newer versions of Jest.
      
      Fixes #6790
      d97a083b
  2. Jan 26, 2018
    • Ryan Senior's avatar
      Merge pull request #6791 from metabase/fix-dashcard-series-perms · c952a60a
      Ryan Senior authored
      Ensure collection_id is included in series dashcards
      Unverified
      c952a60a
    • Ryan Senior's avatar
      Ensure collection_id is included in series dashcards · 5f3e5bea
      Ryan Senior authored
      Hydrating series dashcards wasn't including the related collection
      id. The collection id is one way in which permissions are
      checked. This would manifest itself in the user having access to
      something they shouldn't. As an example, if a dashboard had a single
      card that was part of a collection the user wouldn't have access to,
      and the user attempted to access it, they would get a 403. If a second
      card was added and that card contained multiple (i.e. a series) due to
      this bug, the second card wouldn't have a collection_id and thus we'd
      assume the user has access to it. The permissions checking on the
      dashboard only checks whether or not the user has access to at least
      one card in the dashboard, thus giving user access to the dashboard.
      
      Fixes #5266
      5f3e5bea
  3. Jan 25, 2018
  4. Jan 24, 2018
  5. Jan 23, 2018
  6. Jan 22, 2018
  7. Jan 19, 2018
  8. Jan 18, 2018
    • Ryan Senior's avatar
      On export, format dates to not include times · 2f8bd112
      Ryan Senior authored
      Currently all :type/DateTime values, including :type/Date values are
      serialized as ISO timestamps, which includes the time and
      timezone. This commit handles :type/Date fields differently, emitting
      only the date (year, month and day).
      
      Fixes #5828
      2f8bd112
  9. Jan 17, 2018
Loading