This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Dec 13, 2022
- Dec 12, 2022
-
-
Cam Saul authored
* Remove unused `metabase.models.table` `metrics` and `segments` functions * Remove more unused
-
Cal Herries authored
* Add quarter for postgres * Add quarter to schema * Add quarter tests * Add quarter for mysql * Add quarter for bigquery * Add quarter for snowflake * Add quarter for redshift * Add quarter for vertica * Add quarter for sqlserver * Add quarter to docs * Fix snowflake implementation * Make time zone dataset smaller * Revert "Make time zone dataset smaller" This reverts commit 4c97048d6c01e0f83b259a00c39d34169036fe77. * Revert "Revert "Make time zone dataset smaller"" This reverts commit d1b8fc49c8bf86fecd9897a7c4f496dbdb1b9b06. * Fix test for drivers not supporting set-timezone
-
metamben authored
This is to enable _ as field name.
-
Noah Moss authored
* update token check URL, using the current one as the fallback * update comment * fix tests * update docstring * update doc string again
-
- Dec 09, 2022
-
-
Cam Saul authored
-
- Dec 08, 2022
-
-
Cam Saul authored
* Add import and export (SerDes v2) commands * Allow use of deprecated dump/load in EE tests
-
metamben authored
* Store DBMS version in Database * Add DBMS version to anonymous stats * Add dbms_version sync tests * Add test for DBMS versions in anonymous stats
-
Bryan Maass authored
* memoize snowflake describe-database w/ 5 min ttl * pass in db-metadata where it is used, - rather than querying for it in random functions * update callsite of sync-tables-and-database! * let sync-metabase-metadata! look up db-metadata - only when needed * pass catalog (db), and schema to .getPrimaryKeys * let describe-table* add in the nil table-name * cleanup * use :snowflake instead of driver for inheritance * concurrent-sync-test should call describe-database once * cleaning up * call add-table-pks with 3 args * call add-table-pks with 3 args * try escaping entity names to appease Oracle Driver - Oracle wants the table-name to be escaped - escape is usually a no-op * pass driver to escape entity * pull get-table-pks into a multimethod, - handle the discrepancy directly in Oracle driver * remove inline def * fix colliding consistent-namespace linting - metabase.driver.sql-jdbc.common and metabase.driver.sql-jdbc.sync.common were mapped to sql-jdbc.common - metabase.driver.sql-jdbc.sync.common is now mapped to sql-jdbc.sync.common * fix reflection warnings * apply fix for getting oracle pks * nix an unused arg
-
metamben authored
* Fingerprint bigquery by previewing tables * Address review comments
-
Cam Saul authored
* MongoDB test data config should not hardcode the user and password we use in CI * Minor test data interface dox improvements * Support standard deviation and variance for MongoDB * Oops I got :expressions mixed up with :expression-aggregations * Note about calculating variance * `connection-type` instead of `db-or-server`
-
- Dec 07, 2022
-
-
dpsutton authored
* Fix numeric parameter values in jwt Don't call `seq` on numbers. If its a string, assert it isn't blank, otherwise check that it is non-null. * bind (:value request-param)
-
- Dec 06, 2022
-
-
Case Nelson authored
* Disable field value scanning for inactive fields Fixes #26863 Adds `last-used-at` to `metabase_fieldvalues` table. This is used to track when full FieldValues are fetched, which should always happen through `get-or-create-full-field-values!` If an inactive FieldValues is queried, they will be updated immediately to be returned to the user and a new last-used-at will be set so that sync will start picking it up. During field values sync, if `last-used-at` occurred more than 14 days ago, then we will no longer query and synchronize this field until it is queried for again. * Fix flaky test by waiting half a second for last-used-at to change * Updates from review * Remove flakiness from test by checking sync
-
Braden Shepherdson authored
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
- Dec 05, 2022
-
-
Cam Saul authored
-
Braden Shepherdson authored
It could generate Dimensions which depend on their own parent Fields, which causes the Fields to have circular deps and fail to load. This prevents Fields from allowing dependencies on themselves.
-
- Dec 02, 2022
-
-
Cam Saul authored
* Fix `has-user-setup` Setting not being cached correctly * Fix Kondo error
-
Aleksandr Lesnenko authored
* pie percent switch * review * Migrate to card viz-settings v.2 (#26798) * Migrate to card viz-settings v.2 This uses the new :pie.percent_visibility key (an enum) instead of a collection of booleans [#26776] * Move to def-json-migration * Don't migrate empty values * fix specs Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
- Dec 01, 2022
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor so static combo chart is ready for reordering * Correct test names * Clean up static viz combo chart BE API * sort static combo chart * Order static funnel chart * Remove unused import and function * Fix BE tests * Remove custom column name tests since logic is moved to FE * Remove graph.series_order when changing dimensions (#26842) * review Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Cal Herries authored
* Implement now for sql drivers * Remove unused import * Add tests * Add more tests * Implement bigquery, mysql, postgres * Test now as argument * Fix FE type inferencer * Change feature flag to date-arithmetics * Implement h2 driver * Fix tests for sqlite * Add snowflake implementation * Remove type test * Fix test for sqlite * Update how we handle autocomplete and format for zero-arity functions in ExpressionEditor (#26563) * Update suggestionText function * Suggest with closing parens if zero-arity * Format zero-arity functions with () * Refactor formatFunction * Remove unused imports * Add presto implementation * Add sqlserver implementation * Test in multiple timezones * Remove setting test driver * Add sparksql implementation * Fix count() fe unit test * Add fe MBQL unit test for now() * Fix sparksql implementation * Add vertica implementation * Add oracle implementation * Add vertica implementation * Remove accidental form * Fix vertica implementation for report timezones * Remove unused multimethod * Remove unused feature * Update sparksql * Fix fe unit tests * Fix fe unit tests * Update hive implementation * Revert "Fix fe unit tests" This reverts commit fde4dd0d. * Revert "Fix fe unit tests" This reverts commit 7b7429ea. * Revert "Fix count() fe unit test" This reverts commit c5c6f6f9. * Revert "Refactor formatFunction" This reverts commit ac50e73e. * Revert "Update how we handle autocomplete and format for zero-arity functions in ExpressionEditor (#26563)" This reverts commit cf39634e. * Update hive * snowflake: convert type to timestamptz * sqlserver: rename date-trunc to zeroed-date-part * Wrap with database type info * Change fe unit test back to now without parens * Change MBQL clauses config for now to return type "datetime" * Fix presto * Add some fe unit tests for parsing and resolving * Update helper-text-strings * Change from second to millisecond precision * Remove test for second precision * presto: Change from second to millisecond precision * vertica: Change from second to millisecond precision * vertica: Change from second to millisecond precision * Change feature flag from date-arithmetics to now * Change feature flag from date-arithmetics to now, mbql schema * Allow now to be used in filter clauses * Add test for filter * Implement driver/database-supports? for each driver that implements :now * Tidy tests * Add back default sql implementation * Add sqlite feature flag * Add mongo implementation * Fix mongo * Format rows * Change vertica to return timestamp with time zone * Fix presto tests * Remove unused require * Update h2 function to return timestamp with time zone * mongo: calculate now during query execution, not processing, for versions >=4.2 (#26822) * replace with $$NOW * Remove unused import * Add back previous now implementation for versions <4.2 * Throw an error if version is <4.2 * Add i18n * Ignore patch version * Clean up `SchedulePicker` component (#26839) * Move `SchedulePicker` to its own directory * Sort imports * Do basic clean up * Extract `DEFAULT_DAY` to a constant * Extract styled components * Convert `SchedulePicker` to TypeScript * Add `SchedulePicker` container * Export `SchedulePicker` options * Add basic `SchedulePicker` story * Fix `SchedulePicker` crashes Storybook * Tweak Storybook file * Build datetime filters as datetime before question is saved (#26679) * Revert "Update h2 function to return timestamp with time zone" This reverts commit f7cce3ea7ccbbfc886d0942d66b1f8f60feb6aba. Co-authored-by:
Gustavo Saiani <gus@metabase.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Noah Moss authored
* initial implementation * some refactor and improved error handling * another refactor * fix reflection warning * add test and more refactor * another test * misc comment improvements and formatting * fix tests * small refactor * fix function call * address tamas's comments
-
Braden Shepherdson authored
There are now three top-level trees: - regular `collections/path/to/collection/...` - `:namespace :snippet` collections in `snippets/path/to/collection/...` - `databases/mydb/schemas/PUBLIC/tables/customers/fields/name.yaml` The path for any given entity is determined by the `serdes.base/storage-path` multimethod. On the ingestion side, things are a bit tricky because the paths don't map directly to `:serdes/meta` hierarchies anymore. Instead each model registers a function to turn a file path into either a `:serdes/meta` hierarcy or nil for a bad match. Ingestion will fetch all these functions once and then try them all in arbitrary order until one matches.
-
Ngoc Khuat authored
* datetime-add, datetime-subtract, temporal-extract, convert-timezone now can takes datetime literal as argument * fix vertica
-
- Nov 30, 2022
-
-
Ngoc Khuat authored
* convert-timezone for mysql, mariadb, sqlserver, oracle * sqlserver doesn't understand Asia/Ho_Chi_Minh * vertica * skip report-tz tests for sqlserver * use the util fn to check args for convert-timezone * fix for vertica not formatting in report-tz
-
- Nov 29, 2022
-
-
Cam Saul authored
* Include Amazon Athena support for dacort/metabase-athena-driver * Use Metabase Maven repo to fetch Athena driver * Copy test extensions from Damon's Athena driver repo * Some code cleanup. * Move namespaces => metabase.driver.athena * Clean up the test extensions namespace * 42 failures, 16 errors * Fix regex support; disable a few tests * Minor tweaks * Fix data-source-name * Fix :week and :day-of-week impls (mostly): 2 failures, 3 errors * Fix OFFSET, :week-of-year; skip test that has TIME column * Add Athena to CircleCI config. Don't wait for Java 11 tests to finish before driver tests. * ALL TESTS ARE PASSING! <3 * Copy fixes for https://github.com/dacort/metabase-athena-driver/issues/115; add test * We don't need to prep source files or fetch dependencies before running backend tests. * Fix Eastwood error. * Tweak CircleCI config. * Fix TIMESTAMP WITH TIME ZONE * Include the Athena/Redshift repos in the build-drivers deps.edn * Build and release scripts need to have the :mvn/repos as well * Revert change that enabled test for Presto * Un-enable failing test for Snowflake as well. * moves all is clauses into the test - previously only the first few tests were being run * Sort ns in `metabase.driver.athena-test` * Prevent athena's log4j2.properties file from becoming log config athena includes log4j2.properties top-level with the properties: ``` status = debug rootLogger.level=debug ``` And this kills our beautifully crafted logging. Set "log4j2.configurationFile" in bootstrap to our own log4j2.xml. Log4j2 looks in a few places for its logging config, the first of which is the properties file. So when the jar is loaded, log4j2 considers this a logging config change and we lose our logging. Co-authored-by:
Damon P. Cortesi <d.lifehacker@gmail.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Braden Shepherdson authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Match static combo chart colors with app viz colors * Match colors when individual series color is set * Remove tests that test colors Since colors is now determined in FE * Fix static viz Series type * Match static progress bar colors with app viz colors * Simplify Clojure code, makes it more idiomatic * Fix certain combo charts don't respect whitelabel colors * Make Clojure code more idiomatic * Fix Series type * Add colors back to static internal page * Simplify type predicate * fix colors matching for multiple series with mulitple metrics or dimensions * Handle legends not formatted in static viz in some cases * Fix failed BE tests after BE API changed * Fix failed BE tests after BE API changed * Add multiple series dashcard test to `getSeriesWithColors` test * Add `getSeriesWithLegends` tests * Fix URL `/_internal/static-viz` not loading due to API change * Correctly render legend when having dashcard title set * Simplify combo-chart API don't really need `settings-seqs` yet * Make static combo chart component type easier to understand * Address review: refactor `render-multiple-lab-chart` * Make variable names easier to understand * Simplify color API * Address review on `body.clj` * Address review, make parameter name more consistent * Fix multiple scalars not rendering * Remove unused imports
-
- Nov 28, 2022
-
-
Ngoc Khuat authored
convert-timezone now requires source-timezone if the input column doesn't have timezone
-
john-metabase authored
* Adds rollback where necessary to v45 migrations * Adds linter for migrations requiring rollback key * Removes unused writeback table migrations * Removes migrate down-one subcommand
-
Bryan Maass authored
-
- Nov 22, 2022
-
-
adam-james authored
* Fix bug where grouping strategy would NPE when fingerprint was `nil` The axes grouping relies on fingerprint data existing, AND for now only works on :type/Number columns, so this bugfix guards against those situations where the logic would fail. The bug that brought this to my attention came up when there was a Custom column. This set the col-meta count to be one greater than the count of the 'real' columns, which threw off my old assumptions, where if the grouped-columns count was less than the total col-meta count, you had a potential grouping. This broke in part because some custom columns are essentially derived from a real column, and so will most likely be groupable with the column they're derived from. Anyway, this filters out columns that won't work, so we hopefully eliminate the problem. * Update src/metabase/pulse/render/body.clj Co-authored-by:
Tim Macdonald <tim@metabase.com> * Fix some broken logic Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Ngoc Khuat authored
-
Braden Shepherdson authored
This was breaking Metabase's understanding of foreign keys after deserialization.
-
Cal Herries authored
-
- Nov 18, 2022
-
-
adam-james authored
* First pass at grouping axes This PR uses the results_metadata key to look at fingerprints for numerical axes to try determine if each series on the Y axis can be sanely represented on the same axis. This is done by calculating an overlap (some value between 0 and 1) and grouping all axes on the LEFT if they pass the threshold, which is some value between 0 and 1. The overlap is always calculated when there is SOME overlap between the ranges of each axis, and is calculated as: ```clojure (/ (- (max maximums) (min minimums)) (- (min maxiumums) (max minimums))) ``` This is done to try catch situations where one column's range is entirely inside the other, but is much smaller (- max min); such a case would have a small percent overlap by the above calculation, and implies that it might be better to split the axes. * Address feedback. * Fix shape of data in tests of 2 private fns * Add test for split axes * Fixed error in test util * render-utils does with-redef, disallows parallel tests. Makes sense
-
Braden Shepherdson authored
Card, Dashboard, Dimension, Metric, NativeQuerySnippet, Segment and Timeline all now using their `:name` fields for the file label. File names should now be more human-friendly.
-
- Nov 17, 2022
-
-
Alexander Polyankin authored
-