Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 22, 2024
  2. Oct 21, 2024
  3. Oct 18, 2024
    • Cam Saul's avatar
      Modularize metabase.pulse; add metabase.pulse.core API namespace (#48640) · c92e8c99
      Cam Saul authored
      * Modularize metabase.pulse; add metabase.pulse.core API namespace
      
      * Rename metabase.pulse.send-test
      
      * Split email result attachment stuff into its own namespace
      
      * Update dashboard-subscription-test
      
      * Allow metabase.email.result-attachment externally... for now
      
      * More code cleanup
      
      * Decouple models.card and email.messages
      
      * Decouple models.collection and metabase.email.messages
      
      * Hopefully the last fix :wrench:
      
      * Fix #48647 :slight_frown:
      
      * Fix event handler
      
      * :render/text, not :pulse/text
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * RESPECT the modules
      
      * Remove unused namespace
      c92e8c99
    • lbrdnk's avatar
      Use case expression type inference logic similar to annotate middleware in MLv2 (#47902) · 63a3b4b3
      lbrdnk authored
      * Use type date for case expression when there are Date and DateTime args
      
      * Use logic for getting case expr type from annotate middleware
      
      * Add e2e test
      
      * Add bigquery test
      
      * Update test
      
      * cljfmt and comment
      
      * Adjust e2e test
      63a3b4b3
    • Nick Fitzpatrick's avatar
      Fixing broken Configure Slack links (#48758) · b853f9d0
      Nick Fitzpatrick authored
      * cleaning up links, adjusting tests
      
      * guard rails
      
      * linter fix
      b853f9d0
  4. Oct 17, 2024
  5. Oct 16, 2024
  6. Oct 15, 2024
    • Raphael Krut-Landau's avatar
    • Aleksandr Lesnenko's avatar
    • Anton Kulyk's avatar
      Fix maps visualization crashing on x-rays (#48742) · 54b141c7
      Anton Kulyk authored
      * Add default value for `hiddenIndices`
      
      * Add e2e test
      54b141c7
    • adam-james's avatar
      Incremental Pivot Processing for Exports (#46995) · 8d52a03f
      adam-james authored
      
      * Incremental Pivot Processing for Exports
      
      WIP
      
      Fixes pivot exports for CSV and xlsx.
      
      The CSV export should use less memory by incrementally building up the data structure and aggregating necessary row
      data right away, so the memory overhead becomes only as large as the total pivot result.
      
      In cases where the pivot rows/cols do combine into many many columns and rows, this can still be a large set of data,
      but it should behave much better now in most cases.
      
      The Excel export is a little more straightforward: create the export rows in the same fashion, streaming one row at a
      time, and just post-process the sheet to add the pivot table in one shot at the end.
      
      * WIP adding row totals.
      
      * aggregate totals as rows are added
      
      Row, column, section, and grand totals are all aggregated as each row is added.
      This means the final step of building pivot output becomes just an exercise of lookups/arrangement, no further
      aggregation is needed.
      
      * CSV pivot works per-row, export respects formatting
      
      This is a big step forward; we don't need to hold the entire dataset in memory, we instead aggregate a row's data into
      the pivot datastructure, which only holds onto:
      
      - unique values for each pivot-row in a sorted set
      - unique values for each pivot-col in a sorted set
      - grand total for each measure N values, where N is number of measures, ususally 1 or 2
      - row totals for each combination of each pivot-row * N measures
      - col totals for each combination of each pivot-col * N measures
      - totals for each 'section', determined by unique values of first pivot-row * N measures
      - values for each measure in every 'cell'; Row Combos * Col Combos * N Measures
      
      So, there can still be a decent amount of data to store; but it will never hold onto all of the 'raw rows' from the
      dataset.
      
      We can never completely guarantee that Row Combos * Col Combos * N Measures remains small, but two things let us move
      forward anyway:
      
      - there's now visible feedback in the app that the download is running (or if it's failed)
      - Pivot table utility diminishes rapidly with huge output anyway; users still need to curate/set up their data
      - effectively to improve the table's utility, so we can assume that a slow-to-download pivot table is also slow to
      - use/less effective, and will likely be something the user doesn't want (as often).
      
      * some test fixes
      
      * now, if we export 'raw pivot rows', they don't show pivot-grouping
      
      and they also don't include the 'extra' rows for totals/subtotals/grand totals (any row with pivot-grouping > 0).
      
      This means that now the non-pivot version of a pivot table export will match what a user sees if they change the viz
      to a regular table.
      
      * remove old test
      
      * re-incorporate some changes from master
      
      * fix csv for non-pivots due to oversight in my changes
      
      This is just a temporary change, I think I should clean up this bit of the code a little, I can probably make it a
      little more readable and use some cleaner logic regarding if the rows are 'raw pivot rows' or not.
      
      * start moving format_rows to POST bod, add pivot_results too
      
      There's still wiring work to do, but this starts to add format_rows and pivot_results to POST body for the various API
      endpoints. Also modify tests to improve coverage/consistency across downloads and alerts/subscriptions.
      
      The tests will not pass on this commit, but fixes will be incoming
      
      * native pivot tables in xlsx
      
      * add precondition to pass migration linter
      
      * try to get migrations fixed
      
      * pasing pivot-results through api and attachments
      
      * fix tests for format_rows in BODY vs query param
      
      * tests!
      
      * might have the tests all fixed now
      
      * the pivoted export now respects col/row totals settings
      
      * add test coverage for public questions and dashboards
      
      * col and row totals work as expected
      
      * build-pivot refactor for clarity
      
      * docstring change + tiny refactor in helper fn
      
      * see if dashcard download works with format_rows
      
      * csv pivot handles nil values
      
      * pass format_rows and pivot_results in :params not :body
      
      * fix some other tests
      
      * pivot-grouping col filtered out of xlsx
      
      * pivot-grouping-col removed for all rows
      
      * configurable pivot exports and attachments (#47880)
      
      * exports fe
      
      * specs
      
      * ui
      
      * specs
      
      * format/unformatted now works for xlsx
      
      * format test changes for xlsx formatting
      
      * embedding endpoints accept pivot_results
      
      * cljfmt and eslint fix
      
      * empty
      
      * embedding test should have formatting defaulted to true
      
      * embed test fixes
      
      * Use `Chip` for export settings widget
      
      * downloads e2e test fix
      
      * fix public download limit test
      
      * public card download defaults
      
      * fix public download defaults in some tests
      
      * Fix visual test
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      8d52a03f
    • Romeo Van Snick's avatar
      Remove "Replace or save question" UI when saving and edited question from a metric (#48669) · b8997a1e
      Romeo Van Snick authored
      * Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question
      
      * Allow visitQuestion to work for metrics
      
      * Use visitQuestion in metric test
      
      * Add test for #48555 (showing the 'Save as new?' ui for metrics)
      
      * Add issue info to repro
      
      * Use visitMetric, visitModel and visitQuestion helpers in createQuestion
      
      * Move check to make it more clear what the save ui does
      
      * Use cy.button for Done button
      
      * Remove unnecessary .within
      
      * Sign in as normal user
      
      * Add missing dataset alias
      b8997a1e
    • Uladzimir Havenchyk's avatar
      caf42840
    • Kamil Mielnik's avatar
      Refactor remaining e2e API commands to TS helper functions (#48672) · 46af3b4c
      Kamil Mielnik authored
      * Refactor createDashboardWithQuestions, createQuestionAndAddToDashboard and editDashboardCard to TS function helpers
      
      * Fix createNativeQuestionAndDashboard that got out of sync
      46af3b4c
    • Nicolò Pretto's avatar
      fix flaky test on embed share behaviour snowplow events (#48665) · dcb843bf
      Nicolò Pretto authored
      
      * increase time tolerance to make tests less flaky on ci when CPU is under heavy load
      
      * Update e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      dcb843bf
    • Romeo Van Snick's avatar
      Change Metrics and Summaries copy (#48451) · 86ff88a1
      Romeo Van Snick authored
      * Rename Common Metrics to Metrics
      
      * Rename Basic Metrics to Summaries
      
      * Update chill mode button copy to 'Add a summary or metric'
      
      * Rename 'Pick the metric you want to see' button to include summary
      
      * Fix type in test
      
      * Rename Summaries to Basic functions
      
      * Fix test
      
      * Undo cross-version test changes
      86ff88a1
  7. Oct 14, 2024
  8. Oct 11, 2024
  9. Oct 10, 2024
  10. Oct 09, 2024
  11. Oct 08, 2024
    • Aleksandr Lesnenko's avatar
      add iframe dashcards tracking (#48382) · 291384d1
      Aleksandr Lesnenko authored
      
      * track iframe creation
      
      * Update Loki Snapshots
      
      * Update frontend/src/metabase/visualizations/visualizations/IFrameViz/utils.unit.spec.ts
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      291384d1
    • Nick Fitzpatrick's avatar
      Collection of UI updates to the alert modal (#48431) · 372d529b
      Nick Fitzpatrick authored
      * collection of UI updates to the alert modal
      
      * remiving unused es lint directive
      
      * adding tag to cypress test
      372d529b
    • Nemanja Glumac's avatar
      [MS1] Better Onboarding: Educational Section in the Main Sidebar (#48369) · 662bf17c
      Nemanja Glumac authored
      * [MS 1.1] Better Onboarding via First-Time UX (#48202)
      
      * Add new `learn` icon
      
      * Add initial visual elements WIP
      
      * Add a menu WIP
      
      * Use named export instead of a named one
      
      * Encapsulate the menu item logic
      
      * Redo the styling
      
      * Add todo notes
      
      * Get rid of the `style` prop where possible
      
      * Fix CSS logic for the container
      
      * Collapse section when the sidebar is closed
      
      * Use Mantine prop instead of the `style`
      
      * Fix the translation issue
      
      * Collapse section completely when the sidebar is closed
      
      * Remove hard coded color reference from SVG
      
      * Simplify element positioning
      
      * Collapse sidebar when closed
      
      * Fix E2E tests unscoped selectors
      
      * Rename props
      
      * Extract `SidebarOnboardingSection` logic into a separate component
      
      * Allow only admins to add data
      
      * Remove "Add your own data" button
      
      * Simplify menuitem component
      
      * Add initial unit tests
      
      * Use predefined vars for the CSV button subtitle
      
      * Show Upload CSV modal
      
      * Enable file uploads
      
      * Improve file organization
      
      * Tidy up types
      
      * Add analytics
      
      * Remove "Upload CSV" button from the sidebar
      
      * Fix "unmocked GET request"
      
      * Make menu usable on small screens
      
      * Make sure sidebar is scrollable
      662bf17c
    • Alexander Polyankin's avatar
      Native query drill (#48232) · 4aa67506
      Alexander Polyankin authored
      4aa67506
Loading