This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 15, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Add show metabase links toggle admin setting * Hide Metabase links * Fix type error * Add selector tests * Hide a link in HomeHelpCard * Make test names more consistent with existing test suites * Add tests to `NewModelOptions` * Prepare `VisualizationError` for testing * Add tests to `VisualizationError` * Hide link and add tests to `PreviewQueryModal` * Extract components to make it easier to test * Move the new component into its own folder * Hide Metabase link in `ActionDashcardSettings` * Prepare `EmptyFormPlaceholder` for testing * Hide Metabase link in `EmptyFormPlaceholder` * Extract Metabase link from `FormCreator` for testing * Hide Metabase link in `FormCreator` * Extract link from `DashCardCardParameterMapper` to prepare for testing * Hide Metabase link in `DashCardParameterMapper` * Clean up the test setup function * Hide Metabase link in `ExpressionEditorHelpText` * Hide Metabase link in `TagEditorHelp` * Hide Metabase links in `MetricList` * Hide Metabase link in `SegmentList` * Prepare `CaveatMessage` for testing * Hide Metabase link in `CaveatMessage` * Hide Metabase link in `CustomMapFooter` * Hide Metabase link in `ImpossibleToCreateModelModal` * Hide Metabase link in `ExpressionWidget` * Hide Metabase link in `ExpressionWidget` * Add BE tests * Update sample database description * Fix TypeScript type-check * Fix failed unit tests * Fix wrong test names * Add missing translations * Make tests looks like tests from other components * Update enterprise/frontend/src/metabase-enterprise/whitelabel/components/MetabaseLinksToggleWidget/MetabaseLinksToggleWidget.tsx Co-authored-by:
Nicolò Pretto <info@npretto.com> * Simplify the change * Fix weird import directory * Fix wrapped translation copy * Fix test name * Move comment next to the component * Fix test names * Review: Make code easier to review * Fix wrong document link * Update src/metabase/public_settings.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Update src/metabase/public_settings.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Address review: BE changes --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Jul 07, 2023
-
-
Alexander Polyankin authored
-
- Apr 10, 2023
-
-
Cal Herries authored
* Add safe DDL commands to the whitelist for actions * Run 'GRANT ALTER ANY SCHEMA TO GUEST;' on sample database * Grant permissions for test databases and add test for sample database * Fix test * Fix test * Add test for adding/removing columns
-
- Feb 24, 2023
-
-
Nick Fitzpatrick authored
* open chart settings when clicking active display type * adjusting tendline e2e test
-
- Feb 23, 2023
-
-
Cal Herries authored
* Decouple checking ddl from classifying h2 stmts - should enable followup for easily blocking more kinds of queries - check all statements to make sure they aren't "ddl". * fix classify-query * linter fixes + get-field refactor * return the CommandInterface values as ints Reach into the CommandList when needed * docstring wording * catch invalid queries -- they can't be classified * Remove action subtypes from inlined-models * Add ddl check for `execute-write-query!` * Remove ACCESS_MODE_DATA * Check queries are single select statements * Add test for sample database privileges * Fix single-select check * Add single-select test * Rename and add more tests for checking read only commands * commands -> statements * Fix check-disallow-ddl-commands * new line * Add more read-only statements to the tests * Update error text * Use are * Add integration test for executing actions with disallowed commands * Add test before inserting row * Run GRANT ALL ON SCHEMA "PUBLIC" TO GUEST * Restore classify-query * whitespace --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
- Dec 13, 2022
-
-
john-metabase authored
Updates embedded H2 driver to v2.1.212. When a local H2 v1 file-based application database is detected, it will be automatically updated in-place at startup. Migrations and tests have been updated to account for changes in H2 behavior. Sample data and test harness database files in the repo have all been updated to H2 v2 file format. Co-authored-by:
Braden Shepherdson <braden@metabase.com> Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
- Nov 15, 2022
-
-
Alexander Polyankin authored
-
- Aug 23, 2022
-
-
Alexander Polyankin authored
-
- Aug 22, 2022
-
-
Alexander Polyankin authored
-
- Feb 03, 2022
-
-
Noah Moss authored
-
- Jan 14, 2022
-
-
Noah Moss authored
-
- Mar 15, 2021
-
-
dpsutton authored
* First pass using coercions * Coercions * Handle effective_type coercion_strategy in test data sets * special-type -> semantic type in sample db ```clojure user> (def config (metabase.db.spec/h2 {:db (str "/Users/dan/projects/clojure/metabase/resources/sample-dataset.db" ";UNDO_LOG=0;CACHE_SIZE=131072;QUERY_CACHE_SIZE=128;COMPRESS=TRUE;" "MULTI_THREADED=TRUE;MVCC=TRUE;DEFRAG_ALWAYS=TRUE;MAX_COMPACT_TIME=5000;" "ANALYZE_AUTO=100")})) user> (jdbc/execute! config ["UPDATE _metabase_metadata SET keypath = 'PEOPLE.ZIP.semantic_type' WHERE keypath = 'PEOPLE.ZIP.special_type'" ]) [1] user> (jdbc/execute! config ["UPDATE _metabase_metadata SET keypath = 'REVIEWS.BODY.semantic_type' WHERE keypath = 'REVIEWS.BODY.special_type'" ]) [1] ``` * Correct mismatch in validation preventing sync * fixing up alternative date tests * More passing tests * Tests for values, nested queries, fetch metadata * tests * tests passing * Fixup mongo qp for coercions locally i have some failing tests that are off by 1 errors: Fail in compile-time-interval-test [36m:mongo[0m Make sure time-intervals work the way they're supposed to. [:time-interval $date -4 :month] should give us something like Oct 01 2020 - Feb 01 2021 if today is Feb 17 2021 expected: [{$match {$and [{:$expr {$gte [$date {:$dateFromString {:dateString 2020-10-01T00:00Z}}]}} {:$expr {$lt [$date {:$dateFromString {:dateString 2021-02-01T00:00Z}}]}}]}} {$group {_id {date~~~day {:$let {:vars {:parts {:$dateToParts {:date $date}}}, :in {:$dateFromParts {:year $$parts.year, :month $$parts.month, :day $$parts.day}}}}}}} {$sort {_id 1}} {$project {_id false, date~~~day $_id.date~~~day}} {$sort {date~~~day 1}} {$limit 1048576}] actual: [{"$match" {"$and" [{:$expr {"$gte" ["$date" {:$dateFromString {:dateString "2020-11-01T00:00Z"}}]}} {:$expr {"$lt" ["$date" {:$dateFromString {:dateString "2021-03-01T00:00Z"}}]}}]}} {"$group" {"_id" {"date~~~day" {:$let {:vars {:parts {:$dateToParts {:date "$date"}}}, :in {:$dateFromParts {:year "$$parts.year", :month "$$parts.month", :day "$$parts.day"}}}}}}} {"$sort" {"_id" 1}} {"$project" {"_id" false, "date~~~day" "$_id.date~~~day"}} {"$sort" {"date~~~day" 1}} {"$limit" 1048576}] diff: - [{"$match" {"$and" [{:$expr {"$gte" [nil {:$dateFromString {:dateString "2020-10-01T00:00Z"}}]}} {:$expr {"$lt" [nil {:$dateFromString {:dateString "2021-02-01T00:00Z"}}]}}]}}] + [{"$match" {"$and" [{:$expr {"$gte" [nil {:$dateFromString {:dateString "2020-11-01T00:00Z"}}]}} {:$expr {"$lt" [nil {:$dateFromString {:dateString "2021-03-01T00:00Z"}}]}}]}}] * ee fixes * UI to set coercion type * Don't need to populate effective-type here it actually has knock on effects: - does more work now as almost every field has an update to do in `add-extra-metadata` - we have databases that have state that we don't create. druid for example has stuff to mimic the dataset in tqpt/with-flattened-dbdef on checkins but we don't actually create this. And our dbdef has a field called "date" that is not present in the druid db, so if we attempt to add metadata it fails and kills the rest of the metadata that we add. - tests need this metadata to be present and the error causes field visibilities (for example) to not be set * Docstrings on shared lib * Add effective and coercion to redshift expectations * Fixup google analytics * Derecordize instead of recordize the expectation object details didn't work out well here. they added way more stuff from the db than what is flowing through here. ```clojure actual: {:field {:name "DATE", :parent_id nil, :table_id 69, :base_type :type/Date, :effective_type :type/Date, :coercion_strategy nil, :semantic_type nil}, :value {:type :date/all-options, :value "past5days"}} diff: - {:field {:description nil, :database_type "VARCHAR", :fingerprint_version 0, :has_field_values nil, :settings nil, :caveats nil, :fk_target_field_id nil, :custom_position 0, :active true, :last_analyzed nil, :position 1, :visibility_type :normal, :preview_display true, :database_position 0, :fingerprint nil, :points_of_interest nil}} ``` Object defaults adds quite a bit of stuff such that we'd be dissoc'ing more than we are currently adding in Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
- Jan 29, 2021
-
-
Jeff Evans authored
Fixing total for all order records in sample data EDN file Making same update in sample-dataset H2 file, via: UPDATE ORDERS SET TOTAL=SUBTOTAL+TAX-IFNULL(DISCOUNT,0);
-
- Apr 19, 2018
-
-
Cam Saul authored
-
- Nov 02, 2017
-
-
Simon Belak authored
-
- Nov 01, 2017
-
-
Simon Belak authored
-
- Oct 30, 2017
-
-
Simon Belak authored
-
- Oct 29, 2017
-
-
Simon Belak authored
-
- Oct 27, 2017
-
-
Simon Belak authored
-
- Sep 09, 2016
-
-
Cam Saül authored
-
- Feb 10, 2016
-
-
Cam Saül authored
-
- Jan 18, 2016
-
-
Cam Saül authored
-
- Sep 23, 2015
-
-
Cam Saul authored
New functionality to sync data included in a _metabase_metadata table.
-
- Aug 04, 2015
-
-
Cam Saül authored
-