Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 30, 2024
  2. Jul 29, 2024
  3. Jul 25, 2024
  4. Jul 24, 2024
  5. Jul 22, 2024
    • Uladzimir Havenchyk's avatar
      replace babel-loader with swc-loader (#45843) · e02589a3
      Uladzimir Havenchyk authored
      - babel is kept to transpile fonts file as swc emotion plugin doesn't handle our case correctly. I didn't find a root cause of wrong behaviour, but the safe past is to keep using babel + emotion plugin for one file and all others can be transpiled with swc
      - react fast-refresh now handled by swc
      - swc-loader can't read browserslist config from package.json, so we had to manually specify supported browsers in webpack
      Unverified
      e02589a3
    • Nemanja Glumac's avatar
      ci: Run without Replay (#45799) · 62688d78
      Nemanja Glumac authored
      * Uninstall ReplayIO
      
      * Remove Replay config
      
      * Install and use custom Chrome v111
      
      * Simplify comment
      
      * Set a specific Chrome version commit
      
      * Skip repro for #22517
      Unverified
      62688d78
  6. Jul 17, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [Milestone 1] Re-design transparent theme for static embedding and public links (#45633) · ffa54f0f
      Mahatthana (Kelvin) Nomsawadi authored
      
      * refactor: Simplify code (#44275)
      
      * Remove dead code
      
      * Remove values same as default options
      
      * Simplify hook API: Removing unused argument
      
      * review: Remove redundant code
      
      * Update look and feel copy (#44277)
      
      * Update static embed tab name
      
      * Update copies + rearrange settings
      
      * Use Mantine Select
      
      * Fix E2E tests by applying new copies
      
      * Fix unit tests
      
      * Fix more E2E tests
      
      * review: Add a comment on Mantine `value` quirk
      
      * Adjust spacing and relevant tests
      
      * Move `transparent` theme to its own toggle option (#44362)
      
      * Reorder the function to match the visual order
      
      * Make function name consistent
      
      * Introduce the new background option (do nothing yet)
      
      * Remove redundant exports
      
      * Tighten up values to reduce confusion
      
      * Make the parameters order consistent
      
      * Only show background option on dashboads (spec)
      
      * Allow dashboard embed background to be transparent
      
      * Make filter background and header/footer transparent
      
      * Fix type error
      
      * Fix unit tests
      
      * Fix E2E tests
      
      * Fix checkerboard pattern not showing when no background
      
      * Add unit tests
      
      * Add missing copy update
      
      * Remove remnants from outdated solutions within the PR
      
      * Improve code comment references
      
      * Fix E2E tests since the last copy change
      
      * Fix type errors from merging master
      
      * Update light theme style (#44488)
      
      * Add background to dashboard filter on light theme
      
      * Make position sticky works with transparent background
      
      * Fix sticky filters not working on theme=transparent
      
      * Fix unit tests
      
      * Simplify IntersectionObserver components + fix E2E tests
      
      * Add storybook for embedded dashboard
      
      * Clarify the use of ExplicitSize context
      
      * Remove unused code
      
      * Formatting
      
      * Review: Better mock `isWithinIframe`
      
      * Update dark theme to match the new design (#45134)
      
      * Update light theme checkerboard colors
      
      * Update checkerboard colors
      
      * Consolidate dashboard light/dark border style
      
      * Use `--mb-color-text-primary` for light theme dashboard
      
      * Update embed dashboard dark theme primary color
      
      * Migrate dashboard text-secondary color
      
      * Migrate text-tertiary color
      
      * Migrate gold, axis, and split line to CSS custom properties
      
      * Fix failed e2e tests
      
      * Fix static viz not working
      
      * Update loki snapshots
      
      * Remove unnecessary CSS custom property
      
      * Make diff more consistent
      
      * Address review: reusing type
      
      * Support backward compatibility when passing `theme=transparent` (#45214)
      
      * Match preview query with the actual code query
      
      * Handle backward compatibility when `theme=transparent` on dashboard
      
      * Add unit tests
      
      * Address review: Make tests less repetitive
      
      * Update Metabase banner upsell UI (#45424)
      
      * Prepare folder for nested components
      
      * Update upsell UI
      
      - add `fullWidth` variant
      - align title to the left
      
      * Fix Upsell banner having horizontal scroll on full width
      
      * Add new Metabase banner upsell component
      
      * Fix unit tests
      
      * Address review: Fix typo
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Address review: Move upsel UI to `admin/upsells`
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Remove unnecessary ESLint disable comment
      
      We can remove it since the file is in admin folder, and is already excluded from the rule.
      
      * Address review: remove default value property
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Address review: Extract magic number
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * More UI updates (#45450)
      
      * Update dark theme text colors to match the new design
      
      * Update powered by metabase logo
      
      * Update loki snapshots
      
      * Fix unit tests
      
      * Fix formatting
      
      * Fix wrong dark theme metabase logo badge color
      
      * Address review: Compress SVG with svgo
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Fix E2E tests
      
      * Update loki snapshots
      
      * Clarify Metabase base colors with comments
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Add more tests (#45628)
      
      * Add static embed question stories
      
      * Add loki snapshots
      
      * Add transparent theme for static dashboard tests
      
      * Add transparent theme tests for static questions
      
      * Assert `background` option in analytics tests
      
      * Remove tests for logic that has been moved
      
      * Update loki snapshots
      
      * Fix failed E2E tests from merging master
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      ffa54f0f
  7. Jul 15, 2024
  8. Jul 12, 2024
  9. Jul 11, 2024
  10. Jul 05, 2024
    • Uladzimir Havenchyk's avatar
      lint: add stylelint support for emotion components (#45132) · c168b34e
      Uladzimir Havenchyk authored
      
      * lint: add stylelint support for emotion components
      
      * drop comment
      
      * fix pattern order
      
      * Use one version of typescript
      
      * use :focus not :outline
      
      * Use the logical CSS property "inset-inline-start:" (not "inline-start:" which doesn't exist) as replacement for the physical css property "left:"
      
      * Use mb-color-focus for focus color
      
      * Drop dead code
      
      ---------
      
      Co-authored-by: default avatarRaphael Krut-Landau <raphael.kl@gmail.com>
      Unverified
      c168b34e
    • Romeo Van Snick's avatar
      Allow setting labels for filters (#44352) · 0d5bc020
      Romeo Van Snick authored
      
      * Add csv-stringify package
      
      * Split values at comma
      
      WIP: Parse values using json
      
      * Add label to ParameterValue and add ParameterValue to value config
      
      * Use custom label in FieldValuesWidget
      
      * Allow passing displayValue from outside of RemappedValue
      
      * Allow passing displayValue in ParameterFieldWidgetValue
      
      * Get custom value label in FormatterParameterValue
      
      * Allow rendering custom displayValue in FieldValuesWidget
      
      * Add custom ParameterValue types
      
      * Fix ParameterValuePicker type
      
      * Fix jest import for csv-stringify
      
      * Add missing RTKQ exports for paramters
      
      * Use direct implementation of useGetParameterValues
      
      * Fix ValueSourceModal tests
      
      * Add tests for value parsing and stringifying
      
      * Use custom label in list too
      
      * Render the custom label in a parameter value
      
      * Setup parameter mocks in embed test
      
      * Add info about splitting values with comma
      
      * Add model hint when user is using labels
      
      * Add test for cusom labels on dashboards
      
      * Handle label-value pairs in test
      
      * Test custom labels in parameter search input
      
      * Use the label to parse the value for text inputs
      
      * Fix comma's to commas
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Use strong instead of styling link
      
      * Use getInput instead of ignoring eslint rule
      
      * Use arrow function
      
      * Add newlines between tests
      
      * Use uppercase for test value
      
      * Name value
      
      * Use getLabel and getValue helpers to avoid indexing confusion
      
      * Pull out confusing condition
      
      * Move out getLabel helper
      
      * Be more explicit about non-existent config values
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      * Move setupParameterValuesEndpoints to setup
      
      * Add loading state
      
      * Do not use alert to implement info box
      
      * Fix formatting
      
      * Remove undefined from getValue signature
      
      * Use getLearnUrl
      
      * Remove dependency on column
      
      * Make custom field labels work in the absence of fields
      
      * Support custom values for non-field parameters
      
      * Add test for native question parameters
      
      * Add newline in test
      
      * Add test case for when show-metabase-links is false
      
      * Just fall back to rendering value when fetching label, or in case it failed
      
      * Add test for loading state of FormattedParameterValue
      
      * Do not fetch custom label for FormattedParameterValue
      
      * Add table with ip addresses
      
      * Add test for IPAddress filter with custom labels
      
      * Add test for custom labels on type/Quantity fields
      
      * Remove getInput helper in test
      
      * Remove unused hasCustomLabel value
      
      * Split up into common and premium tests
      
      * Make fieldValues a map for performance
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      Unverified
      0d5bc020
  11. Jul 01, 2024
  12. Jun 28, 2024
  13. Jun 26, 2024
  14. Jun 25, 2024
  15. Jun 21, 2024
  16. Jun 20, 2024
  17. Jun 19, 2024
  18. Jun 07, 2024
  19. Jun 06, 2024
  20. Jun 04, 2024
  21. May 31, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      ci(sdk): Autogenerate changelog on build (#43364) · 78db8c49
      Mahatthana (Kelvin) Nomsawadi authored
      * Auto tag embedding team for PR review + dry run npm publish
      
      * Install changelog generation package
      
      * Add the initial changelog
      
      * feat(sdk): This is an empty commit. For testing purposes.
      
      * Update SDk build script to include changelog
      
      * Check if a tag exists
      
      * Ensure changelog is in the released package
      
      * Fix workflow
      
      * Remove unnecessary step
      
      * Ensure we can have access to release utils script when checking out master
      
      * Fix the step to create a PR updating readme and changelog
      
      * Fix changelog generation
      
      * Fix couldn't download changelog
      
      * Clean up steps
      Unverified
      78db8c49
    • Nick Fitzpatrick's avatar
      React 18 (#41975) · ead905b1
      Nick Fitzpatrick authored
      
      * initial commit with most types sorted
      
      * admin, binning, collections, custom-column and dashboard-cards suites
      
      * Filters, Joins, Metrics, Models, Native and Native filters suites
      
      * rest of e2e specs
      
      * filters, actions, onboarding and custom column will hopfully be green?
      
      * fixing static viz, brush filtering, login redirecting, and a few other tests
      
      * types green
      
      * linter green
      
      * hopefully fixes filter tests
      
      * I don't often cry, but when I do it's because of filter-types
      
      * hopfully sorted the last test that's failing CI
      
      * PR Feedback
      
      * yarn prettier
      
      * React 18 Upgrade - Unit Tests (#41577)
      
      * fixes for most unit tests to work with react 18 + upgraded rtl to v15
      
      * fixes all unit tests locally
      
      * fixes from rebasing
      
      * linter shames me
      
      * fix flake in maps.cy.spec.js
      
      ---------
      
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      Unverified
      ead905b1
  22. May 28, 2024
    • Romeo Van Snick's avatar
      Allow creating new items by inserting comma in MultiAutocomplete (#42824) · b6bb9d18
      Romeo Van Snick authored
      
      * Pass current values to shouldCreate
      
      * Allow comma to create new item
      
      * Simplify getAvailableSelectItems
      
      * Add unit test for MultiAutocomplete input
      
      * Use text instead of Text in paste
      
      * Handle spaces in MultiAutocomplete
      
      * Remove cast
      
      * Reuse last var
      
      * Use haveLastBeenCalledWith over haveBeenCalledWith
      
      * Handle pasting when there is text in the input already
      
      * Accept quote-delimited values
      
      * Add info icon
      
      * Handle tab as a separator
      
      * Fix test cases for unsanitized parseValues
      
      * Add csv-parse
      
      * Use csv-parse to parse values
      
      * Apply the correct color to the info icon
      
      * Rename util to utils
      
      * Break up tooltip text
      
      * Only return unique values
      
      * Be more accepting around quotes in the middle of unescaped values
      
      * provide Buffer for csv-parse package in storybook
      
      * Use browser-friendly version of csv-parse
      
      * Remove unused eslint rule
      
      * Add specital case for csv-parse to jest config
      
      * Put uniqueness check in each state update
      
      * Only add partial value if it is valid
      
      * Only add partial value if it is valid
      
      * Fix test case for FilterValuePicker
      
      * Just use Set
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Allow parsing more than one value
      
      * Use isValid everywhere it makes sense
      
      * Add test for RTL languages
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      b6bb9d18
  23. May 17, 2024
  24. May 16, 2024
  25. May 14, 2024
  26. May 13, 2024
  27. May 09, 2024
  28. Apr 26, 2024
Loading