Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>

* Updating to cypress 12

* updating deps

* Updating Tests. Be Green Plz

* removing custom test id from select button

* Select Button Tuning

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Add a reproduction for dashboard sticky filter incorrectly positioned when moving between dashboards (#29497) (#29596)

* Add a repro for #26230

* Move the prep phase to the `beforeEach`

* Use `visitDashboard` helper

* Wait for the second dashboard to load

* You don't have to use `within` here

* Add a comment

* Add main repro assertion

* Greatly simplify creation of the markdown card

* Update the test title

---------

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>

* Revert "Fix zoom in drilldown for FKs (#28022)" (#29551)

---------

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>

* keep standalone values when collapsing column

* adjusting unit test

* PR Feedback

* adding space

* removing only

* Adjusting behavior and tests

* adjusting data_grid unit tests

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* Add action.dataset_query to search results

* Add action.database_id to search results

* Unskip repro

* better FE error handling for action query display

* update repro

---------

Co-authored-by: Tim Macdonald <tim@metabase.com>
Co-authored-by: Ryan Laurie <iethree@gmail.com>

* Remove usages of `cy.addFilterToDashboard` custom command

* Fully remove `cy.addFilterToDashboard` custom command

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* Actions/e2e model actions tests (#29295)

* extract model creation helper

* update model actions test to actually mutate data

* fix merge conflicts and clean up
# Conflicts:
#	e2e/test/scenarios/models/model-actions.cy.spec.js

* don't assert not found

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* show all subscriptions in notification management page regardless of collection perms

* strip cards and recipients if necessary

* indentation tweak

* add backend tests

* add cypress repro

* fix permissions check

* slightly different approach

* fix cypress test

* fix test

* address comment

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>

* make object detail work for non-logged-in users

* update types to account for optional params

* test public object detail viz

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

* fix missing group by columns from joined tables

* fix spec

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

* Fix custom field type aggregation not showing

When the origin table don't have that field type.

* Add tests

* Remove puzzle driven development comments

* Make `getAggregationOperators` API more apparent

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

* Extract `parseArguments` into utils

* Allow custom browser for Cypress snapshots generation

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* Updating graph.metrics when column is removed

* updating logic and adding unit tests

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Fix empty database picker state

* Remove redundant `requireWriteback` occurrences

* Update test

* Update test

* Use clearer names

* Don't show query language message for actions

* Use database `hasActionsEnabled` method

* Remove `requireWriteback` prop

* Respect `readOnly` prop in `DataSourceSelectors`

* Extend e2e test coverage

* Use `setActionsEnabledForDB` in Cypress

* Fix data picker behavior

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

* adding hasMultipleDimensions check to hasLegend clause

* Adding queryBuilderMain helper

* PR Feedback

* remove only

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* fix exclude date filter serialization

* review

Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

* try fixing collections flake

* update spec

Co-authored-by: Gustavo Saiani <gus@metabase.com>

* only save changed dashboards

* test early return from save action

* remove problematic api wait for dashboard save

* deeply compare cards and add better tests

* update failing e2e test

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

Fixes #25378

When using a relative filter with a starting from n units ago on an
aggregation with the same units, we were incorrectly assuming that we
would be working with a field ref at the top level. However, in this
scenario the field is nested such as `[:+ [:field $created_at
{:temporal-unit :month}] [:interval 1 :month]]`. This change makes sure
that we are altering the field-ref.

Co-authored-by: Case Nelson <case@metabase.com>

* composite key object detail test

* add tests for no primary keys

* fix rebase

* allow db sync to wait on the presence of a specific table

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

* Adding Show Total toggle, adding unit tests

* adjusting unit test, fixing logic

* Adding Static Viz test. PR Feedback

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* List all actions

previously `api/action` required `?model-id=<model-id>`. This caused the
FE to DOS the backend looping over each action. On stats I found 350 or
so sequential requests, with app-db saturation leading to requests
taking from 400ms near the beginning to 7seconds near the end.

This makes `model-id` option and now returns actions on all models the
user can see.

```
❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb
[
    {
        "archived": false,
        "creator": {...},
        "creator_id": 1,
        "database_id": 3,
        "dataset_query": {...},
        "id": 1,
        "model_id": 1,
        "name": "source = foo",
        "parameter_mappings": null,
        "parameters": [...],
        ...
    }
    ...
]
```

* update frontend for action picker to support single action list endpoint

* list actions tests

* update actions e2e tests

* Return empty vector if no results

Running tests locally might return some extra actions not asserted on in
the tests. And there you might expect a 200. But CI runs with an empty
database and returns no response so you get a 204. Quite annoying and
there's no good way to expect a "2xx" status code at the moment. So just
return the empty vector so it's always a 200 code.

* update actions endpoint unit test mocks

* Simplify logic a little

* docstring tweak

* schema with better error message

* update mocks to accept optional modelId

* simplify sorting and grouping

* make sort case-insensitive

* simplify action api test mocks

---------

Co-authored-by: dpsutton <dan@dpsutton.com>
Co-authored-by: Ryan Laurie <iethree@gmail.com>

* Remove personal collections from collection detail page

https://github.com/metabase/metabase/pull/28023

 Added "sub collections"
to the collection detail page. Makes sense. The problem is that personal
collections started appearing in this view. We have traditionally
treated personal collections as siblings to the "Our Analytics" root of
collections. So this was an impedence mismatch.

This PR just removes all personal collections from the items returned
from `"api/collection/root/items"`. The personal collection is still
visible in the sidebar (returned from
`api/collection/tree?tree=true&exclude-other-user-collections=true&exclude-archived=true`
. Furthermore, all personal collections are still visible from the
"three dots" menu on the sidebar.

* poke ci

* remove last personal collections from tests

* e2e tests

don't include a personal collection in the details page.

* off by one from removing personal collections

* Can't select personal collections if they aren't there

Co-authored-by: dpsutton <dan@dpsutton.com>

* pulling out column title logic and sharing with settings

* Pivot Table Custom Column Names

* removing cyclic dependency

* adjusting tests

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>