Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 25, 2023
  2. Jun 23, 2023
  3. Jun 22, 2023
  4. Jun 21, 2023
    • Emmad Usmani's avatar
      add urls for dashboard tabs (#31411) · 10a0e4a0
      Emmad Usmani authored
      * add distinct urls for dashboard tabs
      
      * switch to using useEffect
      
      * refactor separate hook useSyncURLSlug
      
      * add to public dashboards
      
      * fix bug when saving
      
      * rename hooks to match codebase convention
      
      * don't show slug in url when only one tab remains
      
      * update DashboardTabs unit test to include slug logic
      
      * refactor test to use findSlug helper method
      
      * replace history entry when initializing tab
      
      * more unit tests
      
      * another unit test
      
      * add e2e tests
      Unverified
      10a0e4a0
    • Aleksandr Lesnenko's avatar
      update permissions help (#31422) · af59d6d5
      Aleksandr Lesnenko authored
      Unverified
      af59d6d5
    • Cal Herries's avatar
    • Alexander Polyankin's avatar
    • Aleksandr Lesnenko's avatar
      Hide metabot (#31750) · d7efdd90
      Aleksandr Lesnenko authored
      Unverified
      d7efdd90
    • Cal Herries's avatar
    • Alexander Polyankin's avatar
    • Kamil Mielnik's avatar
      Markdown support in the pinned items (#31251) · b92caa60
      Kamil Mielnik authored
      * Allow ReactNode as tooltip in Ellipsified
      - Consistently destructure all imports from react package
      
      * Introduce getMarkdownFirstLine
      
      * - Extract markdownToHtml
      - Refactor getMarkdownFirstLine into getLeadingText
      
      * Render description as markdown in StaticSkeleton
      
      * Cover getLeadingText with tests
      
      * Consolidate tests
      
      * Extract test-utils
      
      * Add initial markdownToHtml tests
      
      * Add a test case for a mix of h1 and p
      
      * Rename markdownToHtml to convertMarkdownToHtml
      
      * Rename convertMarkdownToHtml to renderMarkdownToHtml
      
      * Rename renderMarkdownToHtml to renderMarkdown
      
      * Add a test case for alt text of an image
      - e.g. Gmail does this and it's not the desired behavior
      
      * Place the tooltip at the bottom (as per design)
      
      * Add StaticSkeleton initial test suite
      
      * Add test case for not showing description tooltip when description is fully rendered
      
      * Rename renderMarkdown to parseMarkdown
      
      * Format code
      
      * Add an e2e test for markdown rendering in pinned models
      - Introduce changeCardDescription helper in e2e-collection-helpers
      - Move openRootCollection to e2e-collection-helpers
      
      * Add an e2e test for markdown rendering in pinned native questions
      
      * Remove redundant assertions
      
      * Add an e2e test for markdown rendering in pinned dashboards
      
      * Remove exact: false
      
      * Move getLeadingText & parseMarkdown to metabase/lib/markdown
      
      * Add markdown tooltip to PinnedItemCard
      
      * Add missing import
      
      * Add disallowHeading & unstyleLinks props to markdown rendered in tooltips
      
      * Add test for markdown tooltip in question visualizations
      
      * Support markdown formatting in Skeleton tooltip
      - add an e2e test case for it
      - rename changeCardDescription to changePinnedCardDescription
      
      * Fix skeleton test
      
      * Add an e2e test for model description tooltip on hover
      
      * Consolidate pinned model description tooltip tests
      
      * Wrap pinned dashboard test in describe
      
      * Add an e2e test for dashboard description tooltip on hover
      
      * Add an e2e test for pinned native question description tooltip on hover
      
      * Add an e2e test for pinned model question description tooltip when ellpsis is and isn't applied
      
      * Add an e2e test for pinned dashboard question description tooltip when ellipsis is and isn't applied
      
      * Remove unit tests for StaticSkeleton as these cases are covered in e2e tests
      
      * Rename changeDashboardDescription to changePinnedDashboardDescription
      
      * Update parseMarkdown to use remark instead of react-dom/server
      - We need to add remark-parse, remark-hype, and unified to package.json but these are not new - they are dependencies of react-markdown
      - Tests will be updated in subsequent commits
      
      * Remove rehype-filter from parseMarkdown
      
      * Bring rehypeFilter back as it fixes typing errors in getLeadingText
      
      * Remove unit tests for getLeadingText and parseMarkdown
      - remark-parse used by parseMarkdown is an ESM without a minified
        commonjs-compliant bundle. We'd have to mock it to make it work
        but it'd defy the purpose of these tests. They're trivial enough with
        the usage of remark anyway.
      
      * Remove unused test-utils
      
      * Merge markdown module into a single file
      
      * Optimize getLeadingText
      
      * Optimize getLeadingText
      
      * Remove dead link to Source Sans Pro font
      - it caused markdown check to fail during CI, this fixes it
      - it seems that the font has been removed from Google Fonts
      - users can still choose this font in Metabase settings
      - removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW
      
      * Don't export types from markdown.ts
      - and format code
      
      * Configure transformIgnorePatterns to allow transforming ESM-based markdown-related dependencies
      
      * Add unit tests for parseMarkdown
      
      * Add unit tests for getLeadingText
      
      * Remove redundant joins
      
      * Add description-related unit tests to PinnedItemCard
      
      * Add tests for ellipsis
      
      * Add tests for description in StaticSkeleton
      
      * Revert e2e tests
      
      * Revert redundant change
      
      * Add a SkeletonCaption test suite with test for markdown support in tooltip
      
      * Make SkeletonCaption tooltip placement consistent with the one in StaticSkeleton
      
      * Remove metabase/lib/markdown usage from PinnedItemCard
      
      * Remove metabase/lib/markdown usage from StaticSkeleton
      
      * Remove metabase/lib/markdown and related changes
      
      * Update PinnedItemCard unit tests
      
      * Add extra assertion to SkeletonCaption tests
      
      * Update StaticSkeleton unit tests
      
      * Remove unused attribute
      
      * Extract MarkdownPreview component
      
      * Require children in MarkdownPreview
      
      * Fix build
      
      * Move detailed markdown tests into new, dedicated MarkdownPreview test suite
      Unverified
      b92caa60
  5. Jun 20, 2023
  6. Jun 19, 2023
Loading