This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 25, 2023
-
-
Uladzimir Havenchyk authored
-
- Jun 23, 2023
-
-
Nick Fitzpatrick authored
* changing ChartSettingOrderedColumns to functional component * Adding e2e test * PR Feedback
-
metamben authored
Part of #30093.
-
Aleksandr Lesnenko authored
-
Jesse Devaney authored
* fix parameter mapping bug * add regression test for text card variable content --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Denis Berezin authored
* Fix automatic insights drill cause a full page reload * Refactor solution based on review suggestions
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
- Jun 22, 2023
-
-
Nick Fitzpatrick authored
-
Cal Herries authored
-
Ryan Laurie authored
* limit uploads to 50mb * make limit stinrg more i8n friendly * update test
-
Aleksandr Lesnenko authored
-
Alexander Polyankin authored
-
Cal Herries authored
-
Oisin Coveney authored
-
- Jun 21, 2023
-
-
Emmad Usmani authored
* add distinct urls for dashboard tabs * switch to using useEffect * refactor separate hook useSyncURLSlug * add to public dashboards * fix bug when saving * rename hooks to match codebase convention * don't show slug in url when only one tab remains * update DashboardTabs unit test to include slug logic * refactor test to use findSlug helper method * replace history entry when initializing tab * more unit tests * another unit test * add e2e tests
-
Aleksandr Lesnenko authored
-
Cal Herries authored
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
-
Cal Herries authored
-
Alexander Polyankin authored
-
Kamil Mielnik authored
* Allow ReactNode as tooltip in Ellipsified - Consistently destructure all imports from react package * Introduce getMarkdownFirstLine * - Extract markdownToHtml - Refactor getMarkdownFirstLine into getLeadingText * Render description as markdown in StaticSkeleton * Cover getLeadingText with tests * Consolidate tests * Extract test-utils * Add initial markdownToHtml tests * Add a test case for a mix of h1 and p * Rename markdownToHtml to convertMarkdownToHtml * Rename convertMarkdownToHtml to renderMarkdownToHtml * Rename renderMarkdownToHtml to renderMarkdown * Add a test case for alt text of an image - e.g. Gmail does this and it's not the desired behavior * Place the tooltip at the bottom (as per design) * Add StaticSkeleton initial test suite * Add test case for not showing description tooltip when description is fully rendered * Rename renderMarkdown to parseMarkdown * Format code * Add an e2e test for markdown rendering in pinned models - Introduce changeCardDescription helper in e2e-collection-helpers - Move openRootCollection to e2e-collection-helpers * Add an e2e test for markdown rendering in pinned native questions * Remove redundant assertions * Add an e2e test for markdown rendering in pinned dashboards * Remove exact: false * Move getLeadingText & parseMarkdown to metabase/lib/markdown * Add markdown tooltip to PinnedItemCard * Add missing import * Add disallowHeading & unstyleLinks props to markdown rendered in tooltips * Add test for markdown tooltip in question visualizations * Support markdown formatting in Skeleton tooltip - add an e2e test case for it - rename changeCardDescription to changePinnedCardDescription * Fix skeleton test * Add an e2e test for model description tooltip on hover * Consolidate pinned model description tooltip tests * Wrap pinned dashboard test in describe * Add an e2e test for dashboard description tooltip on hover * Add an e2e test for pinned native question description tooltip on hover * Add an e2e test for pinned model question description tooltip when ellpsis is and isn't applied * Add an e2e test for pinned dashboard question description tooltip when ellipsis is and isn't applied * Remove unit tests for StaticSkeleton as these cases are covered in e2e tests * Rename changeDashboardDescription to changePinnedDashboardDescription * Update parseMarkdown to use remark instead of react-dom/server - We need to add remark-parse, remark-hype, and unified to package.json but these are not new - they are dependencies of react-markdown - Tests will be updated in subsequent commits * Remove rehype-filter from parseMarkdown * Bring rehypeFilter back as it fixes typing errors in getLeadingText * Remove unit tests for getLeadingText and parseMarkdown - remark-parse used by parseMarkdown is an ESM without a minified commonjs-compliant bundle. We'd have to mock it to make it work but it'd defy the purpose of these tests. They're trivial enough with the usage of remark anyway. * Remove unused test-utils * Merge markdown module into a single file * Optimize getLeadingText * Optimize getLeadingText * Remove dead link to Source Sans Pro font - it caused markdown check to fail during CI, this fixes it - it seems that the font has been removed from Google Fonts - users can still choose this font in Metabase settings - removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW * Don't export types from markdown.ts - and format code * Configure transformIgnorePatterns to allow transforming ESM-based markdown-related dependencies * Add unit tests for parseMarkdown * Add unit tests for getLeadingText * Remove redundant joins * Add description-related unit tests to PinnedItemCard * Add tests for ellipsis * Add tests for description in StaticSkeleton * Revert e2e tests * Revert redundant change * Add a SkeletonCaption test suite with test for markdown support in tooltip * Make SkeletonCaption tooltip placement consistent with the one in StaticSkeleton * Remove metabase/lib/markdown usage from PinnedItemCard * Remove metabase/lib/markdown usage from StaticSkeleton * Remove metabase/lib/markdown and related changes * Update PinnedItemCard unit tests * Add extra assertion to SkeletonCaption tests * Update StaticSkeleton unit tests * Remove unused attribute * Extract MarkdownPreview component * Require children in MarkdownPreview * Fix build * Move detailed markdown tests into new, dedicated MarkdownPreview test suite
-
- Jun 20, 2023
-
-
Aleksandr Lesnenko authored
-
Maz Ameli authored
* change Data Model to Table Metadata * update doc references to the page * change name of manage data model permission * fix lint error * fix tests
-
Cam Saul authored
* Implement `suggested-join-condition` * Update docstring * OOOF fix typo in `filter-clause` * Fix premature i18n lookup * Address PR feedback * MLv2 JS join function wrappers * PR feedback from #31590 * `join-conditions` returns raw MBQL clauses! * WIP * Simplify `with-join-alias` and `with-join-fields` * Simplify join and add with-join-conditions * Un-revert dev * Wow! Remove unresolved nonsense. * Remove dev * Remove dev * Test fixes
* PR feedback * WIP * defop doesn't need query or stage-number anymore * Fix Cljs tests for base PR * Test fixes * Test fix * Update JS wrappers -
metamben authored
Fixes #31677.
-
shaun authored
Place a nudge card below admin people sidebar if managing over 50 users without a pro account
-
Cam Saul authored
MLv2 Join API Simplification; implement `with-join-conditions`; make join `:alias` required (#31679) * Implement `suggested-join-condition` * Update docstring * OOOF fix typo in `filter-clause` * Fix premature i18n lookup * Address PR feedback * MLv2 JS join function wrappers * PR feedback from #31590 * `join-conditions` returns raw MBQL clauses! * WIP * Simplify `with-join-alias` and `with-join-fields` * Simplify join and add with-join-conditions * Un-revert dev * Test fixes
-
Alexander Polyankin authored
-
Cam Saul authored
* Implement `suggested-join-condition` * Update docstring * OOOF fix typo in `filter-clause` * Fix premature i18n lookup * Address PR feedback * MLv2 JS join function wrappers * PR feedback from #31590 * `join-conditions` returns raw MBQL clauses!
-
john-metabase authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix dashboard grid doesn't resize in Firefox * Fix wrong test name * Add FireFox E2E test
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove unused prop Dashboard's `isEditable` doesn't seem to be passed anywhere expect from the hard-coded `defaultProps`, so it'd better be removed. * Prevent users without dashboard permission to perform Toggling auto-apply filters * Prevent auto-apply filters toast from appearing without curate permission
-
- Jun 19, 2023
-
-
Nick Fitzpatrick authored
* updating chart settings popover logic * updating CI tests
-
metamben authored
Fixes #31673
-
Nick Fitzpatrick authored
* Custom Homepage Dashboard Polish * adding missed mock
-
Oisin Coveney authored
-
Ngoc Khuat authored
* Adding new db trigger full scan by default * Add DatabaseForm unit test --------- Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Encourage admin users to connect to a database (#31210) * Encourage admin users to connect to a database * Only render either payment banner or database prompt banner Discussed here: https://metaboat.slack.com/archives/C057T1QTB3L/p1685549180307149?thread_ts=1685547913.580079&cid=C057T1QTB3L * Improve mobile view layout * Address review: Remove `withRouter` HoC * Address review: Remove optional chaining * Address review: Refactor a component's deprecated `shouldRender` property * Add an e2e test to cover happy path * Remove new translation in `aria-label` * Fix sticky parameter widgets when showing database prompt banner * Fix E2E tests * Address review: Add missing unit tests * Fix a failed E2E test from rebasing off `master` branch * Add analytics (#31470) * 2/x Add analytics * Fix a failed E2E test from merging code from master * Prevent rendering the database prompt banner when white labeling (#31471) * 3/x Convert enterpise settings selectors to TypeScript * Add missing enterprise settings selectors tests * Don't render db prompt banner when white labeling * Reorganize the test to make an EE test more standing out * Address review: Remove unused function * 4/x Follow up reviews and tests (#31545) * 4/x Address review: Simplify code structure * Address review: Fix variable name collision * Move logic to display database banner to a hook * Remove unnecessary await * Restructure AppBanner tests * Swap test position to match the defined test matrix * Address review: removed outdated comment * Address review: Make `useShouldShowDatabasePromptBanner` hook tests clearer * Address review: Make conditions easier to follow Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * 5/x Add embedding tests (#31557) * 5/x Add embedding tests * Clean up: Fix a selector signature * Address review: Using existing utility * Ensures that embedding pages are loaded before asserting UI not existing * Ready to write PublicQuestion tests * Move public and signed embeds tests to unit tests * Removed outdated eslint comment --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-