Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 16, 2018
  2. Jul 13, 2018
  3. Jul 11, 2018
  4. Jul 10, 2018
    • Kyle Doherty's avatar
      Collection layout polish (#8008) · ceac04d2
      Kyle Doherty authored
      * initial type filtering bar
      
      * use filter for items in collection landing
      
      * filter search by type
      
      * remove redundant heading
      
      * prettier
      
      * 1/3 2/3 red third blue third
      
      * handle no non collection items state
      
      * prettier
      
      * merge fix
      
      * don't drop existing query items when changing type
      
      * move personal items on root
      
      * use modal and proper route for collection edit
      
      * breadcrumb hover state
      
      * redirect to parent collection on archive
      
      * stay on current collection when creating child collection
      
      * return to previous url when canceling pulse creation
      
      * hide reset button on forms by default
      
      * lint fix
      
      * add collection filter for search
      
      * return and show display in card items for collections
      
      * dont log
      
      * use gear instead of person
      
      * test fixes
      
      * cr
      
      * fix typo / expectation
      Unverified
      ceac04d2
    • Ryan Senior's avatar
      Don't include dimension options for nested PK/FK fields [ci drivers] · ace993b3
      Ryan Senior authored
      There was code to remove the special_type from the field before
      returning the metadata. That code was in place so that the frontend
      doesn't treat that field like a real PK/FK (since it's a nested
      query). That special_type was being removed before the code to added
      dimension options was ran, causing it to add dimension options for
      PK/FK values (which it shouldn't). This commit just separates out the
      code that clears the special type so it can run after dimension
      options are added.
      ace993b3
    • Ryan Senior's avatar
      Add support for binning of nested queries [ci drivers] · 4ffed3bf
      Ryan Senior authored
      To support this Cards now include fingerprints in the
      result_metadata. That fingerprint is included in the query dictionary
      and is available to the query pipeline. The expand/resolve/binning
      middleware can make use of that fingerprint data to build the binned
      query. Dimension options for these kinds of queries will also now be
      available.
      
      Note that binning is only available on questions that have result
      metadata. If no result metadata (and thus no fingerprint) is
      available, no dimensions options will be included and an exception
      will be thrown if a binned query is attempted. In most cases, just
      running a card once will populate that data.
      
      Originally this work was done via f49e32a6 and 7977fd45, but those
      commits were reverted as some test fixes were needed on a few drivers.
      4ffed3bf
    • Ryan Senior's avatar
      Fix nested query issue with SparkSQL driver [ci drivers] · 99ddc1da
      Ryan Senior authored
      Previously the driver was only looking one and two levels deep for the
      source table. In the case of nested and binned queries, this could be
      buried deeper in the MBQL query. This commit switches form an `or`
      clause and a couple of `get-in`s to a `postwalk` that will find the
      table however it's nested in the query.
      99ddc1da
  5. Jul 09, 2018
  6. Jul 08, 2018
  7. Jul 06, 2018
  8. Jul 04, 2018
  9. Jul 03, 2018
  10. Jun 29, 2018
  11. Jun 28, 2018
  12. Jun 27, 2018
  13. Jun 26, 2018
    • Cam Saul's avatar
    • Ryan Senior's avatar
      Add support for binning of nested queries · 7977fd45
      Ryan Senior authored
      To support this Cards now include fingerprints in the
      result_metadata. That fingerprint is included in the query dictionary
      and is available to the query pipeline. The expand/resolve/binning
      middleware can make use of that fingerprint data to build the binned
      query. Dimension options for these kinds of queries will also now be
      available.
      
      Note that binning is only available on questions that have result
      metadata. If no result metadata (and thus no fingerprint) is
      available, no dimensions options will be included and an exception
      will be thrown if a binned query is attempted. In most cases, just
      running a card once will populate that data.
      
      Fixes #5938
      7977fd45
  14. Jun 25, 2018
  15. Jun 21, 2018
    • Ryan Senior's avatar
      Change the Pulse API to accept a CardRef or HybridPulseCard · c9b8e9ba
      Ryan Senior authored
      The pulse GET responses include a PulseCard that isn't exactly a
      PulseCard. It includes some extra information from the underlying card
      useful for the FE to include in the display. When adding a card to an
      existing pulse that has one or more cards already, the PUT include a
      mixture of these HybridPulseCards (the existing cards for the pulse)
      and CardRefs (for newly added cards). This commit changes the schema
      to allow either and updates the tests accordingly.
      
      This also adds similar flexibility to the POST so that it is
      consistent with the PUT.
      
      Fixes #7789
      c9b8e9ba
  16. Jun 20, 2018
  17. Jun 19, 2018
  18. Jun 18, 2018
    • Ryan Senior's avatar
      Fix transient issue with pulse search test · 6f8dd952
      Ryan Senior authored
      The test query to ensure alerts aren't returned with pulse search, and
      just filtering out the id of the pulse to ensure it's not in the
      results. That test can fail if there happens to be a search result
      with the same id as the (missing) pulse. Adding another predicate to
      ensure it's only looking for pulses.
      6f8dd952
    • Ryan Senior's avatar
      Add collection position reconcilliation to cards/dashboards/pulses · ee4a9002
      Ryan Senior authored
      Anytime a new card/dashboard/pulse is created with a collection
      position, or a card/dashboard/pulses has it's collection or collection
      position updated, it's possible that other items in the collection
      will need to have their collection position adjusted. This commit adds
      a check to the PUT and POST routes of cards/dashboards/pulses to check
      to see if the change impacts the position of other
      cards/dashboards/pulses in the collection.
      
      This also uses the same logic for the bulk card collection updates and
      will adjust impacted cards as needed.
      ee4a9002
  19. Jun 15, 2018
Loading