This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 16, 2023
-
-
Cam Saul authored
* MLv2 cleanup: import more lib.metadata.calculation stuff; more test helpers * Update QP code * Test fix
* Fix bad :require * Fix bad :require -
Tim Macdonald authored
-
Tim Macdonald authored
[Fixes #33193]
-
- Aug 15, 2023
-
-
metamben authored
Fixes #32948.
-
Cam Saul authored
-
Tim Macdonald authored
* Remove obsolete CLI flags for `export`; fix collection specification [Fixes #33168] * Allow comma-separated IDs
-
Cam Saul authored
-
Case Nelson authored
* Improve sql parameter mismatch error message It is possible to write native sql queries that try to hide parameters within comments or identifiers. Unfortunately PreparedStatement will almost always explode in these cases since you can only parameterize values in sql caluses. The error message of various drivers is quite poor, so we add a heuristic to look for these poor messages and replace it with a message prompting the user to look for a misuse of parameters. * Address review comments * Exclude drivers that do not support getParameterCount
-
Cam Saul authored
* Remove `:metabase.lib.*` keys from field refs when converting refs to legacy * Fix hardcoded database ID
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
metamben authored
Porting fix alias of joined column LHS of standard join conditions (#32987) * Check if the LHS has the alias of the current join before stripping its alias. * Remove dependent joins when removing a join
-
- Aug 14, 2023
-
-
Cam Saul authored
* Simplified impl. * Fix kondo errors * Cljs test fix
-
Alexander Polyankin authored
-
Tim Macdonald authored
* Search by table description [Fixes #25792]
-
Alexander Polyankin authored
-
- Aug 11, 2023
-
-
Nemanja Glumac authored
Fixes #33080
-
- Aug 10, 2023
-
-
Cam Saul authored
* Test metadata helper function consolidation * More code consolidation
-
lbrdnk authored
* Unify semicolon and comment handling in nested native queries * Use different comment and semicolon removal approach * Apply suggestions from code review Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update base and effective type verification for oracle * Avoid running test with snowflake and bigquery * Update `breakout-results` and test 1. In `breakout-results` case driver statement was redundant. Original code had field name and types hardcoded. During further examination, I've realized name and types are available thanks to the use of `qp.test/col`, so are just "unhardcoded" :) 2. `card-id-native-source-queries-test` is altered, so instead of hardcoding native sub-queries, roughly equivalent* mbql query is compiled and its native form is used. This way I can hopefully avoid problems with extraction of cloud databases' table names for testing purposes. * By roughly equivalent I mean instead of using * for selecting fields, mbql is compiled selecting fields explicitly. Also limit is added in some cases, but local testing showed no problems with that. --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
lbrdnk authored
Modify `:contains`, `:starts-with` and `:ends-with` so field or expression can be used as the second argument (#32446) * Update `LIKE` to handle fields and expressions Previously only string could be used with like clause, ie. as second argument of `:starts-with`, `:ends-with` or `:contains`. This commit modifies translation of those functions, so fields or expressions can be used in place of second argument. * Make only expression or field args use `concat` Using concat with values unnecessarily complects generated sql. * Update tests * Extend mongo string matching capabilities Make mongo filter compilation use `$regexMatch` for `:contains`, `:starts-with` and `:ends-with` so expressions and fields can be matched against. * Adjust mongo specific tests * Update druid Druid's filters work with `:contains`, `:starts-with` and `:ends-with`, but only if second argument is literal pattern. This commit updates existing code, so expection is thrown if `pattern` has different form than `[:value ...]`. * Address review comments - sql * Address review comments - mongo * Use mbql `:concat` instead of `hx/call :concat` Vertica, orcacle and sqlite handle concat differently than other drivers. To overcome this limitation, `pre`, `post` and `arg` are wrapped into mbql's concat expression which is then translated with regards to the specifics of particular driver. * Update according to the review feedback --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
- Aug 09, 2023
- Aug 08, 2023
-
-
Ngoc Khuat authored
-
- Aug 07, 2023
-
-
Tim Macdonald authored
* Fully hydrate PUT-ed collections, which the FE depends on [Fixes #30235] * Add repro test for #30235 * Set token features properly --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Aug 06, 2023
-
-
Cam Saul authored
* QP: use Malli * Fix schema names * Fix missing namespaces * Fix busted stuff * Simplify the new schema * Test fix
* Test fixes * MongoDB fixes * FAST mu/defn * Malli registry * Misc fixes * Some cleanup * Misc cleanup and test fixes * mu/disable-enforcement * Test fix * Fix Cljs version of `disable-enforcement` * Misc improvements * Update tests * Fix Kondo warnings * Fix Kondo warnings * Fix busted Malli schema * PR feedback * Fix busted schema * Kondo fixx * Test fixes * Use Malli version of `describe` now that PR was merged * Work around https://github.com/metosin/malli/issues/924 * Test fixes * Improvements * Test fix -
Cam Saul authored
-
- Aug 04, 2023
-
-
Case Nelson authored
* [MLv2] Add function to sync join-condition temporal bucketing options * Return the modified join-condition instead of the whole query * Adding tests * Fix linter
-
- Aug 03, 2023
-
-
Cam Saul authored
* Prevent malicious H2 connection string properties * Disallow new H2 connections * Prevent mismatches between engine and details (#151) Co-authored-by:
Cam Saul <github@camsaul.com> * Fix Kondo lint warning * Test fix
* Fix E2E tests in `setup` spec * Fix E2E tests in `add-new-database` spec * Improved test --------- Co-authored-by:dan sutton <dan@dpsutton.com> Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Jerry Huang authored
* replace nils initial code * add test
-
Cal Herries authored
-
Cam Saul authored
* Migrate collection and permissions namespaces to Malli * Fix docstring * Fix Kondo warnings
-
Cam Saul authored
* FAST mu/defn * Malli registry * Misc fixes * Some cleanup * Misc cleanup and test fixes
* mu/disable-enforcement * Test fix * Fix Cljs version of `disable-enforcement` -
Ngoc Khuat authored
-
Noah Moss authored
* get rid of backfill query for user-recent-views * clean ns
-
Vamsi Peri authored
* Use the custom qualified-name function to retain the slash in the name * qualified the name in the error message as well * Added a test case
-
- Aug 02, 2023
-
-
Cam Saul authored
* `join-condition-lhs-display-name` should use join condition LHS * Revert testing context changes * Appease the whitespace linter
-
Cam Saul authored
-
Jesse Devaney authored
* add parameter mapping to heading cards * update unit tests for new props * memoize parameter mapped content * add heading card tests to text parameters spec * update test descriptions * add BE for params/substitute_tags * fix tests * fix test * update FE parameter substitution to use optional flag * heading cards should not escape characters * add test for dashboard sub * remove invalid specs -> desired behavior changed - enabled parameter mapping for heading cards - in parameter editing mode, we should display the option to map a parameter to a heading text variable, so we should not display the original text * fix react hook dependencies * improve parameterValues type * refactor E2E test to a unit test * address nits * fix spacing * update types and add unit tests * fix type errors --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com>
-