This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 15, 2024
-
-
github-automation-metabase authored
* Clean up serdes v2 exceptions (#46577) * Add missing field to exception * fix indentation * Inline helper that doesn't exist yet --------- Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
- Aug 14, 2024
-
-
github-automation-metabase authored
* Show loading state while fetching data in a new model page (#46694) * Show new model loading state while fetching * Show new model loading state while fetching * Add unit test * Use `DelayedLoadingSpinner` instead * Update the test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Prettier --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Fix the test --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Enable type info computation for fields coming from model source query * Add test * Add handling for fields coming from joins Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
github-automation-metabase authored
I didn't consider that we might not have permissions necessary to disable triggers. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
metabase-bot[bot] authored
Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
github-automation-metabase authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
github-automation-metabase authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
-
github-automation-metabase authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
- Aug 13, 2024
-
-
github-automation-metabase authored
* Add v0.50.20 to the list of releases * Update releases.md --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
Repro #46756: Add/remove a single column in a model with tables joined by themselves adds/removes all columns (#46757) (#46764) Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
github-automation-metabase authored
fix(admin/performance): Ensure that the tab's title (e.g. Database caching) and 'Performance' are visible in document title (#46602) (#46685) Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* Export Formatting Correctness WIP Several bugs exist around the correctness of export formatting, this aims to fix them. Fixes #27374 When a model has viz settings/metadata changed after save, the download won't incorporate said changes. At least it's clear that scale doesn't work. * number formatter merges settings from columns too * column formatting on aggregated cols works in xlsx now too * fixes 43040 by grabbing global-type-settings in csv formatter Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
backported "fix(webapp/sidenav): Move Browse sidebar section in between Trash and other collections" (#46604) * fix(webapp/sidenav): Move Browse sidebar section in between Trash and other collections (#46457) * wip * restore mainnavbarview * fix(webapp/sidenav): Move Browse sidebar section below collections (#46457) --------- Co-authored-by:Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* new version of data_access migration + run ANALYZE beforehand * relax constraints on migration timestamps * more migration rewrites * fix bug in migration * fix another bug and remove extraneous logging * reorder migrations to fix ID validation * start adapting the changes to mysql as well * wip * add more ANALYZE calls * revert logging changes * finish duplicating work for mysql + a bit of clean up * create H2 versions of migrations without the ANALYZE calls * remove ANALYZE call from view_data.sql (probably not necessary) * fix mysql syntax * fix another mysql bug * another mysql fix * Don't exclude inactive tables for data_access * Don't write rows for Administrators group * Don't write rows for Admins (H2/MySQL) * disable triggers before perms migration --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Denis Berezin authored
* Manual backport 46160 * e2e tests fix
-
github-automation-metabase authored
Fixes: #46558 In #45575 we introduced casting uuid fields for drilldowns. However we failed to include a check that the rhs was itself another field of uuid type and so no casting should occur. This broke joins on models when the database_type of the field may not be known. Co-authored-by:
Case Nelson <case@metabase.com>
-
John Swanson authored
* Nicer error messages for linting migrations In general, just throw exceptions instead of using clojure spec here. You'll only get one error per run, but that seems fine. I did keep some specs around, but run them slightly differently. Rather than validating the whole collection of changeSets at once with `s/+`, just `doseq` through the changeSets and validate each one separately. That way, the value that's presented as erroneous is much smaller (a single changeSet) and it's easier to see what went wrong. * Update bin/lint-migrations-file/test/lint_migrations_file_test.clj * Update bin/lint-migrations-file/src/lint_migrations_file.clj * Require preConditions for certain liquibase change types to encourage idempotence (#44578) * remove `!`s from non-side-effecty fns * add preConditions to a few v51 migrations --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
* Refactor filter utils to TS * Remove type casts * Improve dimension instantiation * Fix typing Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Aug 12, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Nemanja Glumac authored
* Fix relative date options popover * Add repro for #46342 * Revert "Fix relative date options popover" This reverts commit ceaf62d9. * Use the Mantine Popover z-index
-
github-automation-metabase authored
* conditional dismissal step * check for download status in the container * try fixing flakes again * try again * chartPathWithFillColor already verifies chart has been rendered Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
* Dowload Row Limit Env Var Adds `MB_DOWNLOAD_ROW_LIMIT` to enable changing the row limit on downloads and alert/subscription attachments (not the rendered tables, but the .csv, etc.). Based on: #44982 (Thanks, @r-kot) Partially implements: #28144 The difference in this PR compared to #44982 is that the download limit applies to all downloads, the only exception being when the limit is above `qp.i/absolute-max-results` (1048575, based on Excel's limitation); in such a case, the user supplied limit is only used if the download is csv or json, and `qp.i/absolute-max-results` is used for xlsx. This PR also fixes alert/subscription attachment limits; prior to this, they were set to the in-app limit of 2000 rows, but now they will follow the user supplied download-row-limit. This PR also adds a test to the downloads-and-exports test namespace, confirming that they follow the supplied limit, or the max limit if none is supplied. * add test confirming the default limit works * fix test to use the download-row-limit * address review feedback * Update src/metabase/public_settings.clj * add test covering case where download-row-limit is unset --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
github-automation-metabase authored
* Revert "Remove unused humanizeCoercionStrategy and its test suite (#36136)" This reverts commit 5375347e. * humanize coercion strategies, add e2e test * unit test adjustment * pr feedback Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
Alexander Solovyov authored
Also OpenAPI generation now handles parameter renaming, like in `{c :count}` destructuring.
-
github-automation-metabase authored
* Fix oom during sync field values (#46524) Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Aug 08, 2024
-
-
github-automation-metabase authored
* Last Used Param Value doesn't fill in with default value if cleared Fixes #46368 The Last used parameter value is cleared when the frontend sends `nil` as the parameter's value. This works except in cases where a user clears a parameter with a default value. In this case, we want to indicate that the parameter is cleared, so we store `nil` in the appdb in such a case. * Update src/metabase/query_processor/dashboard.clj * add assertion showing that 'nil' with default is still stored --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
backported "fix(webapp/browse): Fix bug where verified filter is applied to recents even when no verified models exist" (#46559) This is a backport of three PRs: #46462, #46487, and #46571. The last of these corrects a broken e2e test introduced when the other two were combined -
github-automation-metabase authored
* Convert `AlertListPopoverContent` to TS (#46413) * Fix backport test, hopefully --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
* make series style settings tab first * spec Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* e2e: add cypress-terminal-report * enable video recording * revert error * add a comment * Update e2e/support/cypress.js --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-