This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 03, 2024
-
-
Kamil Mielnik authored
* Optimize: compute chart title href only on mouseenter and focus * Improve comment * Improve comment * Format code * Update existing tests * Extract helpers * Update unit tests * Make getHref argument-less
-
Jeff Bruemmer authored
-
Aleksandr Lesnenko authored
* include dark background to PNG exports when night theme is enabled * fix css * override border for png downloads
-
Ngoc Khuat authored
-
Noah Moss authored
-
Braden Shepherdson authored
`Lib.diagnoseExpression` is stricter about this than the QP or FE expression parser, making it reject expressions that tried to compare datetimes to strings like `2024-07-02 14:34:17Z`. Those used to work in 49.x, but a new `Lib.diagnoseExpression` call while editing expressions caused it to regress. Fixes #44916.
-
Braden Shepherdson authored
**MetadataProvider cache** The reusable MetadataProviders is a generally useful thing - within some dynamic scope like an API request, a `clojure.core.cache` instance can be provided as `lib.metadata.jvm/*metadata-provider-cache*`, and that will be used to cache the provider for each `database-id`. Reusing those providers can significantly reduce appdb traffic, re-fetching the same metadata in different `MetadataProvider` instances. **Dashboard loads** The FE can supply `?dashboard_load_id=uuid_string` on requests for a dashboard load: - `/api/dashboard/:id` - `/api/dashboard/:id/query_metadata` - `/api/dashboard/:id/dashcard/:dashcard_id/card/:card_id/query` That provides a good cache key across that burst of N+2 API requests that are part of a single load. Currently it is used for two things: - Caching `get-dashboard` (used by the first two requests) - Selecting the `clojure.core.cache` for `*metadata-provider-cache*` Both use a TTL of 10 seconds, which is generally enough for the first screenful of a dashboard load, if not the whole thing. (Browsers will only issue a handful of requests at once, so a few long-running queries might delay later parts of the dashboard from loading until after the TTL expires.)
-
Chris Truter authored
-
Oisin Coveney authored
-
Kamil Mielnik authored
* Fix #39771 * Add repro for #39771 * Add explanatory comment * Fix z-index * Use Mantine Tooltip in Ellipsified to fix z-index issues * Revert "Fix z-index" This reverts commit 951e3dca86be73ba2123930fbfaaae45c5fa1f0e. * Revert "Fix #39771" This reverts commit 4165da5022d566253e875938a84bd1f137c92357. * Update repro to new tooltip * Update assertions
-
Kamil Mielnik authored
-
Romeo Van Snick authored
-
Oisin Coveney authored
-
Kamil Mielnik authored
-
- Jul 02, 2024
-
-
Cam Saul authored
-
Denis Berezin authored
-
Cam Saul authored
-
Uladzimir Havenchyk authored
* Add e2e tests for basic field remapping logic * await for PUT
-
Cam Saul authored
* Debug QP 2.0 * Update for the ensure-legacy and ensure-pmbql wrappers
-
Nemanja Glumac authored
Fix #35954: SQL-converted question with field filter breaks filtered dashboard if reverted back to its editor version (#44987) * Make sure the query is native * Convert the comment to JSDoc * Add E2E reproduction * Fix mapping * Add test scenarios for the public sharing and embedding * Simplify API payload * Extract and significantly expand the reproduction scope --------- Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
-
Jeff Bruemmer authored
* clarify driver vs database reqs * note
-
Sloan Sparger authored
* only send permissions updates for groups that have been modified in the graph * Support partial permission graph updates on the BE (#44797) * handles keeping track of advanced permissions changes to send relevant group data when updating the graph, merges response * tests and optimizations * respect group-ids set when fetching connection impersonations, sandboxes, and admin group perms * fix typo * add e2e test * fix BE test * impls pr feedback, reduces code needed since advanced permissions state is always reset on save * last fixes --------- Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by: Noah Moss <noahbmoss@gmail.com>
-
Sloan Sparger authored
-
John Swanson authored
* recent views sometimes don't show special colls colls with a non-null namespace are special: they can't interact with normal collections, dashboards, cards, etc at all. (Currently the only use for these we have is snippets.) At some point we could add a `namespace` argument to this endpoint to support looking at recent collections in a different namespace, but that'd be a bigger refactor without a whole lot to gain. For now we can just exclude these completely, which is what we want for current usages of the recents endpoint anyway. We won't exclude non-null types across the board, because sometimes we'll want to see these. But we will be particular about when to display them. We'll never display the `trash` collection, but will display the instance analytics collection when we're not trying to make selections. * Hack an e2e test around an existing bug So, the entity picker that pops up when you're selecting a collection to put a Snippet into shows you "Recent" collections - which previously included snippet collections. We should either make the Recents API support a namespace parameter for collections so it could actually support this case, or the entity picker shouldn't show a recents tab here (realistically, how many collections are people going to have for snippets that they would need this tab anyway).
-
Cam Saul authored
* Calculate metadata without running queries [JDBC] * Appease Kondo * Test fixes
🔧 * Overhauled Card metadata calculation code * Test fixes🔧 * Kondo fix🔧 * Ok maybe I fixed stuff * Work around https://github.com/aws/amazon-redshift-jdbc-driver/issues/118 * Maybe fixx the Cypress tests * Experimental possible e2e test fix🔧 * Test fixes🔧 * Do things a little differently. * Try re-enabling the field refs -
Alex Yarosh authored
* question marks * remove all question mark notes except about json
-
Kamil Mielnik authored
Fix - Invalid join clause does not disappear after changing query source to use a different database (#45025) * Reset JoinDraft state on database change (fixes metabase#42385) * Add repro for #42385 * Use admin user
-
Alexander Polyankin authored
-
Ryan Laurie authored
-
Jeff Bruemmer authored
-
Ryan Laurie authored
-
Phoomparin Mano authored
* add default font family * use metabase provider internal component for tests
-
Kamil Mielnik authored
* Add repro for #34350 * Reduce diff
-
Ryan Laurie authored
* make ad-hoc changelog generation actually useful * add github action * remove test code * fix whitespace * fix formatting
-
Ryan Laurie authored
-
Uladzimir Havenchyk authored
Add a repro for 'Permission error before finishing referencing a question in the native query' (#44995)
-
Ryan Laurie authored
* Create new release note sections * add explanatory text
-
Alexander Solovyov authored
-
- Jul 01, 2024
-
-
bryan authored
* return data about the proper billing status * fix copy * fix the tests
-
Cal Herries authored
-