This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 09, 2024
-
-
Phoomparin Mano authored
* remove legacy queries from static question in sdk * remove second query argument * remove the databaseSupportsPivotTables check from isSensible
-
Anton Kulyk authored
* Add repro * Update `isValid` check for metrics and dimensions * Fix unit test
-
Phoomparin Mano authored
-
Romeo Van Snick authored
* Add custom image for empty metrics * Add useFetchMetrics helper * Copy browse models page to metrics page * Add route for browse metrics page * Add useHasMetrics hook * Add link to browse metrics page to the sidebar * Simplify MetricsTable component * Render description markdown in table too * Add unit tests for browse metrics page * Remove custom padding * Fix line height of markdown cell * Add e2e tests for browse page * Fix metrics sorting * Fix types * Fix column widths and cell padding * Typo Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Remove name check * Simplify alphabet * Remove resetSnowplow * Use helper to get metric in table * Use MouseEvent from React directly * Use --mb-color-icon-primary * Test ellipsification of description * Simplify useHasMetrics * Move useHasMetrics MainNavBar * Merge sortMetrics and sortModels into sortCards * Fix metric default description * Extract SidebarSkeleton to a separate component * Test sorting via Collection too * Use ModelTableRow to fix cursor * Share more components between ModelsTable and MetricsTable * Use the same simplified structure in ModelsTable as for MetricsTable * Render block-level elements as inline so ellipsis detection works * Pick better testid for metric name * Remove delay * Avoid type specificty error in sortCards * Add test for not opening in new tab * Remove useFetchMetrics defaults * Fix unit test import * Test meta-click with cypress * Add comment on inline markdown elements * Use model-name test id * Use correct colors for icon * Remove delay from browse models page too * Make meta key in test platform-dependent * Fix hover color on metrics table * Add focus styling for celss in the models and metrics table * Use MarkdownPreview for table cells * Define --mb-color-icon-primary * Make the collection link take up the whole height of the cell * Remove tabIndex from table rows * Rename ModelsTable.module.css to BrowseTable.module.css * Rename CardsTable to BrowseTable * Remove single module.css class in favor of styled components * Allow customising allowed elements * Allow forcing all markdown on one line * Render bold and italics in markdown descriptions and move content onto one line * Fix legacy tooltip in test * Make sure getValueForSorting returns a string * Remove empty file * Remove icon for metrics in the table * Remove else statement. Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Remove async findBy where possible * Add github issue link for TODO item * Disambiguate between getMetricDescription type * Be explicit with sortModelOrMetric --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Alexander Solovyov authored
-
- Sep 07, 2024
-
-
Oisin Coveney authored
* Fix entity ID status * bump ci --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
- Sep 06, 2024
-
-
Oisin Coveney authored
-
Noah Moss authored
-
Ryan Laurie authored
* Basic Sidesheet Components * sidesheet samples and storybook stories * add unit tests and fix more imports * small styling updates * small styling updates * fix tests * Update frontend/src/metabase/common/components/Sidesheet/SidesheetCard.tsx Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> * fix type problem --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
-
Noah Moss authored
-
Alexander Polyankin authored
-
Oisin Coveney authored
-
Alexander Polyankin authored
* Add metric sidebar * Add tests * Rename ResizableNotebook to DatasetNotebook * Add tests * Add tests * Add tests * Add tests
-
bryan authored
-
Nicolò Pretto authored
* fix(sdk) default font on not working * fix initial state for the sdk
-
Ryan Laurie authored
* reduce release status messages * fix comment
-
Alexander Solovyov authored
-
Ryan Laurie authored
* make custom disabled state more specific than transparent style * make it less nesty
-
Oleksandr Yakushev authored
* perf: [metabase.util.performance] Faster mapv for small collections * perf: Optimize some query processor functions
-
Chris Truter authored
* Fix miss * Another spot, plus clean up
-
Mahatthana (Kelvin) Nomsawadi authored
* Always allow localhost:* on CORS * Use `embedding-app-origin-sdk` method for the headers * Fix BE code formatting * Fix BE formatting
-
Alexander Solovyov authored
-
- Sep 05, 2024
-
-
Oisin Coveney authored
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
John Swanson authored
We had a security issue where it was possible to query timelines without having the requisite permissions on the collection. This test checks to make sure this doesn't happen again.
-
Alexander Polyankin authored
-
adam-james authored
* walk the error to remove any visualization settings Thanks Dan for the patch, this approach is nice because it doesn't require changing all 3 streaming-response-writer implementations (json csv and xlsx). It keeps behaviour basically the same, but just cleans up the output to not include potentially sensitive column/dataset details. * add a test that confirms json/csv errors are cleaned * walk the error to remove any visualization settings Thanks Dan for the patch, this approach is nice because it doesn't require changing all 3 streaming-response-writer implementations (json csv and xlsx). It keeps behaviour basically the same, but just cleans up the output to not include potentially sensitive column/dataset details. * add a test that confirms json/csv errors are cleaned * fix dataset error test * cljfmt * try to be a little more surgical with what we take out of the error * formatting again, oops * pass export format, only modify the obj for file exports In the case of errors being saved to files, the obj is a map with a :status :failed key assoc'd by the qp somewhere along the way. The format-exception cond branch is not used in this case, so we can't rely on modifying `format-exception` to just dissoc ex-data. Instead, I've kept the obj modification, but it excludes the query and the preprocessed keys, which are the only 2 keys where we see :viz-settings. This doesn't eliminate the problem of needing to exclude other keys in the future, but it does improve the surface area - the query and viz settings are the most likely candidates for holding potentially sensitive info. I'd prefer to stick with this solution, as we can get a fix for the security concern in quicker, and perhaps a non-security bug can be opened regarding the most correct way to indicate errors to users whose downloads have failed. * keep format-exception the same * cleaner passing of export-format to write-error!
-
Alexander Polyankin authored
-
metamben authored
* Support field remapping in pivot queries * Generate breakouts without inversions
-
Oleksandr Yakushev authored
* perf: Optimize reading rows into vectors in JDBC driver * perf: Use direct interop when computing with-time-zone-same-instant
-
Phoomparin Mano authored
* replace plain embedding-sdk imports * fix direct module imports
-
Cam Saul authored
-
Cam Saul authored
-
Oleksandr Yakushev authored
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
* newsletter-toggle-clicked event * use ValidateEvent, * rename event -> simple_event and trackEvent -> trackSimpleEvent * use the renamed trackSimpleEvent function
-
Chris Truter authored
-
Ngoc Khuat authored
-