Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 26, 2024
  2. Sep 24, 2024
  3. Sep 18, 2024
  4. Sep 12, 2024
  5. Sep 10, 2024
  6. Aug 30, 2024
    • Ngoc Khuat's avatar
      [notification] webhook for alert (#45201) · d897f201
      Ngoc Khuat authored
      
      * [notification] New method: `channel/can-connect?` (#44955)
      
      * [notification] Channel APIs (#45207)
      
      * [notification] namespaced channel type (#45527)
      
      * [Notification] Render alert for http channel (#45545)
      
      * [notification] Add channel description (#45840)
      
      * [notification] update API to enable http channels for alert (#45839)
      
      * [Notification] Remove channel details for users without write perms (#46034)
      
      * [Notification] Serdes channel (#46031)
      
      * [Notification] Update http details schema (#45960)
      
      * [Notification] Deactivate channels will delete PulseChannel (#46115)
      
      * [Notification] audit log for channel create and update (#46113)
      
      * [Notification] Disallow undefined key for http channel details (#46712)
      
      * [Notification] Handle channel name conflicts (#46818)
      
      * Webhooks Admin Section (#46194)
      
      * [notification] Fix test pulse endpoint does not work properly for http channels (#46474) (#47050)
      
      * [Notification] Fix unable to update multiple channels per type (#47111)
      
      * [Notification] Record Task History when pulse sends channel message (#46218)
      
      * Enabling Webhook Alerts (#47022)
      
      * [Notification] fix cyclic deps (#47379)
      
      * [notification] channel serdes spec (#47386)
      
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      d897f201
  7. Aug 21, 2024
  8. Aug 20, 2024
  9. Aug 19, 2024
  10. Aug 13, 2024
  11. Aug 12, 2024
  12. Aug 06, 2024
  13. Jul 25, 2024
    • bryan's avatar
      Saving SDK data for embedding statistics (#45954) · 2febfbb4
      bryan authored
      * Adds a middleware that sets 2 dynamic vars
      
      - These vars will be used to insert context for embedding analytics
      
      * migration adding embedding_client and embedding_version to qe and vl tables
      
      * clarify function api
      
      * headers come in -> dynamic vars -> written to db
      
      When the vars are set we insert their values into query execution and
      query_log under embedding_client and embedding_version.
      
      * update update migrations
      
      * add predconditions to migrations
      
      * fix tablenames + dataset_test
      
      * Code Review responses
      
      - remove commented out requires
      - clarify test for merge-count-maps
      Unverified
      2febfbb4
    • John Swanson's avatar
      Loosen N+1 query detection again (#46081) · f9e27201
      John Swanson authored
      I tightened this up by removing the condition here, thinking that CI
      would catch it if it was necessary - but I'm getting failures in
      development. Oops - didn't realize that this defmethod wasn't actually
      applied during CI runs.
      Unverified
      f9e27201
  14. Jul 24, 2024
    • John Swanson's avatar
      Improve N+1 detection for simple hydration methods (#45848) · 50d0c35a
      John Swanson authored
      We have N+1 detection for simple hydration methods that checks to see
      whether the hydration method made any DB queries at all. This makes
      sense, because a simple hydration method is called on each instance
      individually - if we make database calls *each time*, we're in trouble.
      
      Where this runs into issues is with cached data, where the simple
      hydration method is populating the cache - e.g. `:can_read` or
      `:can_write` dereferencing `api/*current-user-permissions-set*`.
      Currently we specifically exclude those hydration methods from the
      check.
      
      But after running into this again for a different simple hydration
      method, I think there's a more robust approach:
      
      - first, run the hydration method without counting DB queries
      
      - then, run it again and make sure we don't make any additional DB
      queries.
      
      There is a potential downside here: if someone wrote a simple hydration
      method with side effects, they'd potentially be very confused (in
      development - this doesn't run in prod!) when those side effects
      happened twice for a single hydration. But I *think* that's fairly
      unlikely.
      Unverified
      50d0c35a
  15. Jul 22, 2024
  16. Jul 18, 2024
    • Cam Saul's avatar
      Use single connection for test data loading & big test data loading improvements (#45268) · bab905c0
      Cam Saul authored
      * Reuse connection for test data loading & JDBC data loading overhaul
      
      * Revert silly change
      
      * Remove unneeded logic for recording which datasets are loaded or not-yet-loaded
      
      * Ok so I guess we do need the code to detect duplicate dataset loading after all
      
      * B I G  improvements
      
      * Appease Kondo
      
      * Test fixes :wrench:
      
      * More test fixes :wrench:
      
      * Fix dataset-already-loaded?-test
      
      * Fix test
      
      * Fix Presto JDBC and greatly improve test data load speed for it
      
      * Postgres test fix :wrench:
      
      * Fix compilation errors
      
      * MySQL fixes :wrench:
      
      * Fix syntax error
      
      * MySQL fixes :wrench:
      
      * Implement `dataset-already-loaded?` for Athena and cache the set of existing databases
      
      * Fix Redshift
      
      * Fix Presto JDBC
      
      * Vertica test fix :wrench:
      
      * Fix Oracle dataset-already-loaded?
      
      * Test fixes and parallelize some API tests.
      
      * Test fixes :wrench:
      
      * Oracle test fix? :wrench:
      
      * Another test fix :wrench:
      
      * Stop putting random spaces in code bodies this is not JavaScript code
      
      * with-temp-vals-in-db should merge in original value of Database settings
      
      * The most test fixes :wrench:
      
      * 3 or 4 test fixes :wrench:
      
      * Add schemas around stuff to catch errors
      
      * Appease Kondo
      
      * Implement dataset-already-loaded? for vertica
      
      * Implement dataset-already-loaded? for SQLite and Snowflake
      Unverified
      bab905c0
  17. Jul 16, 2024
  18. Jul 09, 2024
  19. Jul 02, 2024
  20. Jul 01, 2024
  21. Jun 21, 2024
    • John Swanson's avatar
      Fix dev `migrate!` command (#44545) · 0637fefa
      John Swanson authored
      There were two problems here:
      
      - wrong args to `mdb/migrate!` (passing the db-type as well as the data
      source), and
      
      - in MySQL, the changelog table name is not `:databasechangelog`. Use
      `metabase.db.liquibase/changelog-table-name` to get the actual table name.
      Unverified
      0637fefa
  22. Jun 19, 2024
  23. Jun 18, 2024
  24. May 30, 2024
    • bryan's avatar
      CRU card events will log recent-views, and get returned through the API (#43037) · 3b2736c2
      bryan authored
      * Handles card events for CRU (not D) => recent view
      
      * add tests
      
      * avoid some errors in dev
      
      We expect recent-views/post-process to return nil occasionally (for
      permissions reasons, or more), so let's filter those out instead of
      printing a noisy unactionable warning
      
      * uncomment and fix test
      
      * fix some cypress tests + docs improvements
      
      * update more cypress tests
      
      * more cypress test updates
      
      * adding a card puts it into your recents now
      
      * fix notebook-data-source
      
      * fix notebook-data-source
      
      * fixing more e2e tests
      
      * fix command palette e2e tests
      
      * run prettier
      
      * fix style issue
      
      * update notebook-data-source tests
      
      * update homepage e2e tests
      
      * Next question is in recents, now
      
      * update command palette: skip the first pagedown, since it is a noop
      
      * check the buttons for their respective names
      
      * ensure that the model is there, and no questions are
      Unverified
      3b2736c2
  25. May 10, 2024
  26. May 09, 2024
  27. May 08, 2024
  28. Apr 26, 2024
  29. Apr 08, 2024
  30. Mar 26, 2024
  31. Mar 22, 2024
  32. Mar 21, 2024
    • Cam Saul's avatar
      Rename `metabase.mbql` to `metabase.legacy-mbql` (#40158) · 0a15637f
      Cam Saul authored
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Rename `metabase.mbql` to `metabase.legacy-mbql`
      
      * Fix Kondo warnings
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      
      * Remove the normalization tests
      
      * Test fixes :wrench:
      
      * Fix kondo
      
      * Fix import
      
      * Another fix :wrench:
      
      * Merge
      
      * FIXES
      
      * Add another missing REQUIRE
      Unverified
      0a15637f
  33. Mar 20, 2024
  34. Mar 14, 2024
  35. Mar 11, 2024
    • dpsutton's avatar
      Db api (#39731) · 1e7823d1
      dpsutton authored
      * first move to a db api
      
      * mdb.spec into mdb
      
      * mdb.u/isa -> mdb.query/isa
      
      * mdb.u/qualify -> mdb.query/qualify
      
      * last of mbql.u -> mbql.query and :gun:mbql.u:sparkler:
      
      * remove last of the mdb.connection/db-type and use from mdb/db-type
      
      * remove the last non-cmd usages of mdb.connection
      
      had some circularity in
      
      models.interface requires mdb/db-type for sql flavored "now"
      mdb requires db/setup
      which requires db/custom_migrations to ensure they are on cp
      custom migration requires json functions in models.interface
      
      so had to do a dynamic require for the db-type
      
      * get db-type from mdb not mdb.env
      
      * invoke `(mdb/app-db)` and not pass a var. lots of things fail
      
      * mdb.setup/migrate! into mdb with potemkin
      
      * remove get-connection. call .getConnection on the app-db
      
      perhaps invites clumsy usage outside of `with-open` if it's a top level
      function
      
      * namespace docstrings
      
      * last few and grab db.env/db-file into api ns
      
      * lint cleanup
      
      * addresses PR comments
      Unverified
      1e7823d1
  36. Mar 06, 2024
Loading