This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 23, 2022
-
-
Aleksandr Lesnenko authored
* fix row chart bugs * review
-
Mahatthana (Kelvin) Nomsawadi authored
-
Maz Ameli authored
* make it clearer you're creating a new question * fix the function
-
- Nov 22, 2022
-
-
adam-james authored
* Fix bug where grouping strategy would NPE when fingerprint was `nil` The axes grouping relies on fingerprint data existing, AND for now only works on :type/Number columns, so this bugfix guards against those situations where the logic would fail. The bug that brought this to my attention came up when there was a Custom column. This set the col-meta count to be one greater than the count of the 'real' columns, which threw off my old assumptions, where if the grouped-columns count was less than the total col-meta count, you had a potential grouping. This broke in part because some custom columns are essentially derived from a real column, and so will most likely be groupable with the column they're derived from. Anyway, this filters out columns that won't work, so we hopefully eliminate the problem. * Update src/metabase/pulse/render/body.clj Co-authored-by:
Tim Macdonald <tim@metabase.com> * Fix some broken logic Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Gustavo Saiani authored
-
Anton Kulyk authored
* Move collection entity tests to entity directory * Simplify `normalizedCollection` helper * Remove nested ternaries in `getCollectionType` * Simplify list endpoint code * Remove comment * Simplify null check * Fix collection's `authority_level` types * Convert collection utils to TypeScript * Convert `index` file to TypeScript * Move `getInitialCollectionId` to its own file * Move `getExpandedCollectionsById` to its own file * Simplify `getExpandedCollectionsById` usage * Convert collections entity to TypeScript * Add missing type * Fix type errors * Remove embarrassing backticks
-
Ngoc Khuat authored
-
Braden Shepherdson authored
This was breaking Metabase's understanding of foreign keys after deserialization.
-
Cal Herries authored
-
Ariya Hidayat authored
-
Nemanja Glumac authored
-
- Nov 21, 2022
-
-
Nemanja Glumac authored
* Remove `cy2` (SorryCypress library) * Stop recording Cypress tests using Currents dashboard service
-
Nemanja Glumac authored
* Fix pre-release config typo * Fix conditional containing environment variable
-
Tom Hallett authored
* Adding instructions for increasing EB Timeout If you host your metabase application on Elastic Beanstalk and a query takes longer than 60 seconds, you will get a "Your query took too long" error. This section documents how to increase that timeout value. * Updating readme based on PR feedback. Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Ariya Hidayat authored
* Retrofit the release workflow to be useful for doing a pre-release * Distinguish between `metabase` main repo and the custom ones * Truncate commit id to specific hash length We need to make sure all images are tagged with exactly the same hash length in order to avoid having multiple images for the same commit. * Enforce full commit SHA-1 hash is used for an input `actions/checkout@v3` will fail if full SHA-1 hash is not provided. We want to use this implicit mechanism as an enforcing function for uniform manual inputs. * Never run script from the main repo - This greatly simplifies things. - The script is meant to be run from forks of Metabase for testing purposes and/or for custom builds. * Safeguard against missing `CUSTOM_RELEASE_REPO` Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Nemanja Glumac authored
- run all EE tests against EE uberjar and only a small subset of OSS-specific tests against OSS uberjar
-
Anton Kulyk authored
* Convert settings selectors to TypeScript * Add missing settings types * Make `getSettings` a `reselect` selector
-
Nemanja Glumac authored
* Upgrade `jest` to the latest version (29.3.1) * Add `jest-environment-jsdom` as a separate package This was a breaking change since the version 28 * Upgrade `@types/jest` to the latest version * Upgrade `babel-jest` to the latest version * Upgrade `@testing-library/jest-dom` to the latest version * Upgrade `@types/testing-library__jest-dom` to the latest version * Upgrade `jest-localstorage-mock` to the latest version * Upgrade `jest-watch-typeahead` to the latest version * fix jest config for v29 * fix specs Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Anton Kulyk authored
* Add `DashboardState` to `metabase-types/store` * Add `createMockDashboardState` * Use no dashboard state by default
-
- Nov 19, 2022
-
-
Nemanja Glumac authored
-
- Nov 18, 2022
-
-
adam-james authored
* First pass at grouping axes This PR uses the results_metadata key to look at fingerprints for numerical axes to try determine if each series on the Y axis can be sanely represented on the same axis. This is done by calculating an overlap (some value between 0 and 1) and grouping all axes on the LEFT if they pass the threshold, which is some value between 0 and 1. The overlap is always calculated when there is SOME overlap between the ranges of each axis, and is calculated as: ```clojure (/ (- (max maximums) (min minimums)) (- (min maxiumums) (max minimums))) ``` This is done to try catch situations where one column's range is entirely inside the other, but is much smaller (- max min); such a case would have a small percent overlap by the above calculation, and implies that it might be better to split the axes. * Address feedback. * Fix shape of data in tests of 2 private fns * Add test for split axes * Fixed error in test util * render-utils does with-redef, disallows parallel tests. Makes sense
-
Braden Shepherdson authored
Card, Dashboard, Dimension, Metric, NativeQuerySnippet, Segment and Timeline all now using their `:name` fields for the file label. File names should now be more human-friendly.
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
- Nov 17, 2022
-
-
Ngoc Khuat authored
-
Anton Kulyk authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
* Fix resetting inputs on data model page * Fix for failing test
-
Aleksandr Lesnenko authored
-
- Nov 16, 2022
-
-
Nick Fitzpatrick authored
-
Natalie authored
-
Nemanja Glumac authored
-
Cam Saul authored
* Move the config-from-file code into the advanced-config directory since that's the feature we want to flag on * Always apply the :settings section first in the config file * Apply suggestions from code review Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
dpsutton authored
* Initial support for pg for `date-diff` * Make the useful-dates closer to one day * Add simple FE stuff * shorter test bodies * Ensure we can use datediff functions in arithmetic expressions * Correctly disable datediff for redshift * simplify var names * Support week * cleanup test * :datediff -> :datetimediff * ngoc's suggestions * Better acceptance test for datetimediff * sort ns * embrace the different cases for results * bigquery day month year * Reverse args * Update test * Centralize tests * Change postgres day, month, year behaviour * Refactor keep identity * Tidy tests * Tidy * Fix bigquery week * Add week tests * Fix bigquery week * Change mysql day, month, year behaviour * Add test for hour, minute, second * Fix postgres hour minute second * Formatting * Fix bigquery hour, minute, second * Formatting * Fix postgres timestamptz * WIP * Allow literals in datediff clauses * Uncomment tests * Fix bigquery when reporting timezone is not UTC * Linting * Moving away from dataset based tests * Add timezone tests for week and tidy * Remove unused import * Consolidate tests * Remove with-time-column dataset * Remove more-useful-dates defdataset * Remove redshift driver WIP * Typo * Move DatetimeLiteral clause into DateTimeExpressionArg * Try changing test order * Remove mt/with-report-timezone-id nil * Add year report timezone tests * Rename * Rename * Remove unused tables from useful-dates * Remove useful-dates * Update helper-text-strings * Tidy * Swap order of mt/with-report-timezone-id * Change with-report-timezone-id; notify databases after running test * Use temp setting for report-timezone instead * Update helper-test-strings * Handle literals in `datetimediff-base-base` * Update src/metabase/driver/postgres.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Simplify postgres second * Tidy: prefer hx arithmetic functions * Drop coercion for string timestamp args for now * Extract helper * Revert "Change with-report-timezone-id; notify databases after running test" This reverts commit 7abb543bed13d9d13295d0e00ad1293a40e40d53. * Use ->timestamptz * Use hx/->timestamp * Rename dataset * Undo changes to datetime-arithmetics? as these will not match by default * Use proper format for offset datetime literals * Shorten datetime literals in tests * Removing notify-all-databases-updated from report-timezone setting * Fix datetime-arithmetics test * Revert "Fix datetime-arithmetics test" This reverts commit 9141582508170bdbe99c4aa74bc4444e41475be6. * Revert "Undo changes to datetime-arithmetics? as these will not match by default" This reverts commit 9cb05f5475b24a78cb89601c918f3440606cc525. * Add UTC timezone to tests * Coerce strings to datetimes for ISO formats * Revert "Removing notify-all-databases-updated from report-timezone setting" This reverts commit 37356435a2e3981deca9ae76118d857babb2aada. * Add comment to postgres driver implementation * Formatting * Disable datediff from redshift for the moment (for ever?) * Override redshift driver/database-supports? * Fix comments mixed up by refactoring * Fix comments mixed up by refactoring 2 * Tidy comment * Rename datetimediff to datetime-diff/datetimeDiff * date-add -> datetime-add * Linting * add datetime-subtract to `datetime-arithmetics?` rework tests a bit as well. * Update docstring * Use ->temporal-type and trunc to handle report-timezone for bigquery * Log errors caught during sync steps (#26306) * log errors caught during sync steps * remove accidental extra parens * Errors combining datetime interval addition with datetime functions (#26279) * Add failing tests * Fix failing tests * Update shared/src/metabase/mbql/util.cljc Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * datetime-add and datetime subtract should annotate type by col type * Fix infer-expression-type for datetime-add/subtract with second, minute, hour * Undo last commit; they actually always return :type/DateTime * Fix test based on last commit * Undo unrelated refactor * Only test drivers that support expressions * Only test drivers that support expressions, again * Update tests from legacy mbql * Change infered-col-type to be a function again, not macro * Fix test Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * whitespace * Remove comments * Add explanation for datetime_diff * Refactor: replace cast and add `mt/with-driver :bigquery-cloud-sdk` where report-timezone is relevant * Add failing tests * Fix failing tests * Technically it should be bigquery-type * Update modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * Move documentation to metabase.mbql.schema * Update DatetimeDiffUnits Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * Add error type and optimize case expressions to driver implementations * refactor for brevity * Fix error with postgres * Fix error with postgres * Handle string literal parsing in wrap-value-literals * Remove ->timestamptz * Add comments + TODOs showing arithmetic expressions should return numeric values * Add explanation of arithmetic expression as docstring * Add test for normalize-mbql-clause-tokens * Remove unused import * Remove unused form * Switch tests to use attempted-murders dataset * Undo optimization that broke tests * Validate non-temporal types for bigquery * Add error handling for incorrect types * Fix mysql type checking * Fix mysql type checking * invalid-parameter -> invalid-query * Use date-trunc and extract * Remove unit error handling * DatetimeLiteral -> DateOrDatetimeLiteral * Remove unused binding * Fix mysql type checking Co-authored-by:
Callum Herries <hi@callumherries.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Gustavo Saiani authored
-
Gustavo Saiani authored
-
Noah Moss authored
* add app DB and version to common snowplow event context * use .getDatabaseProductName for db type * fix kondo error * add new instance schema with app db type and version fields * add maxLength to new fields * address cam's feedback
-
Nick Fitzpatrick authored
* Adding Color Picker for Metrics * Adding support for breakout charts * Addressing some PR Feedback * Adding pillSize to color picker components * Moving updateSeriesColor logic to visualizations/lib * Typing viz/lib/series * Final PR Feedback adjustments
-