Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 28, 2021
  2. Aug 27, 2021
  3. Aug 26, 2021
  4. Aug 25, 2021
    • Ariya Hidayat's avatar
    • Cam Saul's avatar
      Block permissions backend (#17428) · bf2ba1f3
      Cam Saul authored
      * :no_entry: B L O C K :warning: permissions :white_check_mark:
      
      * Fix test failure in OSS since EE namespace doesn't exist.
      
      * Remove unused var
      
      * Oops, uncomment a commented-out test
      
      * Clean up the new perms documentation a bit
      Unverified
      bf2ba1f3
    • Ariya Hidayat's avatar
    • Noah Moss's avatar
    • Jeff Evans's avatar
      Update Presto JDBC lib version (#17591) · 0023987f
      Jeff Evans authored
      0.254 -> 0.260
      Unverified
      0023987f
    • Alexander Lesnenko's avatar
    • Alexander Lesnenko's avatar
    • Alexander Polyankin's avatar
    • Anton Kulyk's avatar
      Fix run overlay not going away on GUI questions (#17590) · 548358a4
      Anton Kulyk authored
      * Enable repro tests
      
      * Don't sync stuctured questions on query complete
      Unverified
      548358a4
    • dpsutton's avatar
      User details on moderation review (#17482) · c8c984fe
      dpsutton authored
      ```bash
      
      % curl 'http://localhost:3000/api/card/760' -H <stuff omitted> | jq
        % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                       Dload  Upload   Total   Spent    Left  Speed
      100  2003    0  2003    0     0   102k      0 --:--:-- --:--:-- --:--:--  102k
      {
        "description": null,
        "archived": false,
        "collection_position": null,
        "table_id": 2,
        "creator_id": 1,
        "moderation_reviews": [
          {
            "most_recent": true,
            "moderator_id": 1,
            "updated_at": "2021-08-16T21:30:00.665952Z",
            "status": "verified",
            "id": 1026,
            "user": {
              "email": "dan@metabase.com",
              "first_name": "dan",
              "last_login": "2021-08-10T21:17:35.366176Z",
              "is_qbnewb": false,
              "is_superuser": true,
              "id": 1,
              "last_name": "sutton",
              "date_joined": "2021-03-15T20:42:55.751834Z",
              "common_name": "dan sutton"
            },
            "moderated_item_id": 760,
            "created_at": "2021-08-16T21:30:00.665952Z",
            "moderated_item_type": "card",
            "text": null
          }
        ],
        "dataset_query": {
          "database": 1,
          "query": {
            "source-table": 2
          },
          "type": "query"
        },
        "id": 760,
        "display": "table",
        "last-edit-info": {
          "id": 1,
          "email": "dan@metabase.com",
          "first_name": "dan",
          "last_name": "sutton",
          "timestamp": "2021-05-12T22:04:57.205978Z"
        },
        ...
      }
      ```
      Unverified
      c8c984fe
    • dpsutton's avatar
      Effective type in result cols (#17533) · 32a0d6cb
      dpsutton authored
      * Include the results base type as the cols effective type
      
      previously was merged the effective type from the col which caused
      issues with dates when selecting a particular temporal unit, ie month.
      
      Queries like this return months as integers so the base and effective
      types are :type/Integer, and something somewhere else is responsible
      for the unit conversion of `1` to January (or feb, months get weird i
      think)
      
      ```clojure
      
      ;; after
      {:description "The date and time an order was submitted.",
       :unit :month-of-year,
       :name "CREATED_AT",
       :field_ref [:field 4 {:temporal-unit :month-of-year}],
       :effective_type :type/Integer, ;; we have the proper effective type
       :display_name "Created At",
       :base_type :type/Integer}
      
      ;; before:
      {:description "The date and time an order was submitted.",
       :unit :month-of-year,
       :name "CREATED_AT",
       :field_ref [:field 4 {:temporal-unit :month-of-year}],
       :effective_type :type/DateTime, ;; included effective type from db
       :display_name "Created At",
       :base_type :type/Integer}
      ```
      
      * tests
      
      * Driver tests
      
      * Ignore effective/base types in breakout tests
      
      sparksql is weird and its totally unrelated to the file under test
      
      * Use correct options for datetimes that are projected to month, etc
      
      When aggregating by a datetime column, you can choose a unit: month,
      hour-of-day, week, etc. You often (always?) end up with an
      integer. Previously the base_type was (inexplicably) :type/Integer and
      the effective_type was :type/DateTime which really just didn't make
      sense. The ideal solution is :type/DateTime as the base_type and
      :type/Integer as the effective_type. But this breaks the frontend as
      it expects to treat these columns in a special way. But it expected
      them to report as date columns.
      
      I've changed it only here. I thought about making isDate understand
      the `column.unit` attribute and recognize that these are in fact
      dates, but that seems wrong. These are integers that are special
      cases. It seems that the contexts that need to talk about dates should
      understand integers in a special way than all date code needs to be
      aware that integers might flow through.
      
      This might mean extra work but ultimately feels better as the correct
      solution.
      
      * unit is not default
      Unverified
      32a0d6cb
    • Nemanja Glumac's avatar
    • Anton Kulyk's avatar
      Update notebook editor's join step UI (#17523) · 79ea2d32
      Anton Kulyk authored
      * Move JoinStep's NotebookCell down to JoinClause
      
      * Break JoinClause into two NotebookCells
      
      * Update labels
      
      * Use `space` helper function
      
      * Simplify conditional statement
      
      * Fix not translated string
      Unverified
      79ea2d32
    • Alexander Polyankin's avatar
  5. Aug 24, 2021
Loading