Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 22, 2021
  2. Oct 21, 2021
  3. Oct 20, 2021
  4. Oct 19, 2021
    • Pawit Pornkitprasan's avatar
      fix wrong drill down query when using nested query (#17942) · ff9b99d0
      Pawit Pornkitprasan authored
      * qp: fetch_source_query: store card-id for each query
      
      we want to be able to determine further in the pipeline
      whether a query came from a card (i.e. saved question)
      or not
      
      * qp: annotate: remove join-alias if source is a card
      
      If the source is a card, the front-end should be able to treat it
      similar to a database view so we should not expose the join
      aliases outside.
      
      If the card is on the right side of the join though, the alias
      should still exists and refers to the current-level join alias.
      ff9b99d0
    • Jeff Evans's avatar
      Support encryption of binary data (#17646) · 2e891f1d
      Jeff Evans authored
      Update encryption code to be able to operate on byte arrays directly (without dealing in base64 String representation), delegating existing methods to point to these new ones
      
      Adding test
      2e891f1d
    • Jeff Evans's avatar
      Prevent duplicate connection properties (#18359) · 22d23a98
      Jeff Evans authored
      Removing duplicate property declaration from presto-jdbc driver YAML
      
      Add test that executes against all drivers to confirm that no duplicate names come out of connection-properties
      
      Change the way the test runs to avoid needing to initialize test data namespace (to make googleanalytics happy)
      
      Unskip repro Cypress test
      22d23a98
    • Dennis Schridde's avatar
      Fix precondition of change set 97 (#16095) · 2d88ae48
      Dennis Schridde authored
      * Fix precondition of change set 97
      
      Without the `type` and with the space Liquibase is unable to parse this
      precondition.
      
      During `lein test` it outputs:
      ```
      [clojure-agent-send-off-pool-0] DEBUG liquibase.changelog - Running Changeset:migrations/000_migrations.yaml::97::senior
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - Changeset migrations/000_migrations.yaml::97::senior
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - Added 0.32.0
      [clojure-agent-send-off-pool-0] INFO  liquibase.changelog - Marking ChangeSet: migrations/000_migrations.yaml::97::senior ran despite precondition failure due to onFail='MARK_RAN':
                liquibase.yaml : DBMS Precondition failed: expected null, got h2
      
      [clojure-agent-send-off-pool-0] DEBUG liquibase.changelog - Skipping ChangeSet: migrations/000_migrations.yaml::97::senior
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - Executing with the 'jdbc' executor
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - 1 row(s) affected
      ```
      
      After this change the output changes to:
      ```
      [clojure-agent-send-off-pool-0] DEBUG liquibase.changelog - Running Changeset:migrations/000_migrations.yaml::97::senior
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - Changeset migrations/000_migrations.yaml::97::senior
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - Added 0.32.0
      [clojure-agent-send-off-pool-0] INFO  liquibase.changelog - Marking ChangeSet: migrations/000_migrations.yaml::97::senior ran despite precondition failure due to onFail='MARK_RAN':
                liquibase.yaml : DBMS Precondition failed: expected mysql,mariadb, got h2
      
      [clojure-agent-send-off-pool-0] DEBUG liquibase.changelog - Skipping ChangeSet: migrations/000_migrations.yaml::97::senior
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - Executing with the 'jdbc' executor
      [clojure-agent-send-off-pool-0] DEBUG liquibase.executor - 1 row(s) affected
      ```
      
      For documentation of the syntax cf.
       https://docs.liquibase.com/concepts/advanced/preconditions.html
      
      
      
      * Extend migration linter to check dbms preconditions
      
      * Also validate the `type` field of the `dbms` precondition
      
      Co-authored-by: default avatardpsutton <dan@dpsutton.com>
      2d88ae48
    • Noah Moss's avatar
      Normalize field refs in viz settings, rework column ordering approach, and... · 423236a1
      Noah Moss authored
      Normalize field refs in viz settings, rework column ordering approach, and expand test coverage (#18490)
      
      423236a1
    • Howon Lee's avatar
      Coalesce audit question query runs to be 0 if no query executions (#18559) · 1feb52e7
      Howon Lee authored
      Null query runs show up at the top previously. This is because they are a null set. This is a thing that there is an affordance to happen, because you can just create cards without running them in the notebook builder. Coalesces the null to 0 to make things sort right.
      1feb52e7
    • Alexander Lesnenko's avatar
      Fix no databases on embedded new question page (#18556) · 8ad622da
      Alexander Lesnenko authored
      * Fix no databases on embedded new question page
      
      * Add an explanation just in case, replace lifecycle method
      8ad622da
    • Eric Dallo's avatar
      0499ddfe
    • Ariya Hidayat's avatar
      Circle CI: build a complete Uberjar on a release branch (#18550) · c8b22c46
      Ariya Hidayat authored
      Make sure that the built Uberjar contains translations etc.
      Also, build with "large" resource_class on Circle CI.
      c8b22c46
    • Howon Lee's avatar
      Audit cards data display problem (#18527) · 4bd2c5b1
      Howon Lee authored
      Underlying problem was that the cardinality of dates were getting limited by the default 1000 limit imposed by EE queries. Whack it for this specific instance. I think if we see it ever again we just remove the 1000 limit instead.
      4bd2c5b1
    • Dalton's avatar
      add more parameters unit tests (#18308) · bef09e29
      Dalton authored
      * add more parameters unit tests
      
      * add a few meta/Dashboard tests
      
      * remove some old, unnecessary comments
      
      * fix assertions in tests
      
      * fix getParameterTargetField tests
      
      * delete nonsensical test
      bef09e29
  5. Oct 18, 2021
Loading