This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 17, 2024
-
-
metamben authored
Fixes #48639
-
Alexander Solovyov authored
-
github-automation-metabase authored
-
- Oct 16, 2024
-
-
dpsutton authored
* Let non-admins see tables in recents ```shell ❯ http get "localhost:3000/api/activity/recents?context=views" Cookie:"metabase.SESSION=ba..3d" -pb { "recents": [ { "can_write": false, "database": { "id": 6, "initial_sync_status": "complete", "name": "pg restaurants" }, "description": null, "display_name": "Restaurants", "id": 112, "model": "table", "name": "restaurants", "table_schema": "public", "timestamp": "2024-10-15T22:11:39.412100Z" }, { "can_write": false, "database": { "id": 6, "initial_sync_status": "complete", "name": "pg restaurants" }, "description": null, "display_name": "Reviews", "id": 110, "model": "table", "name": "reviews", "table_schema": "public", "timestamp": "2024-10-15T19:53:19.999445Z" } ] } ``` We were getting permissions of a "fake" table. Instead, let the db select it and get the proper stuff. Worked for admins because mi/can-read? is presumably always true for tables, and worked in tests because we mocked mi/can-read? * bump ci
-
appleby authored
* Add new promethues counter for :metabase-metrics/adjust-errors To record errors in metabase.query-processor.middleware.metrics/adjust * Add prometheus metrics test to metrics middleware tests * Also inc :metabase-metrics/adjust-errors when throwing an exception * Make splice-compatible-metrics private It doesn't seem to be used outside of metabase.query-processor.middleware.metrics. * Add test for :metabase-metrics/adjust-errors when exception is thrown * Move inc-and-throw! helper into metabase.analytics.prometheus * Add inc-and-throw! test to prometheus tests * Rename inc-test to inc!-test and use approx= and metric-value helpers * Add try/catch to metrics adjust and record metric errors in a single place Record promethues metrics in a single place in metabase.query-processor.middleware.metrics and ensure we record failures for any exception throw. * Improve testing description string * Rename :metabase-metrics/adjust-errors to :metabase-query-processor/metrics-errors * Move metrics adjustment try/catch into a new helper This ensures we count all exceptions generated by adjust-metric-stages. * Add new prometheus metric to count number of MB metrics seen by the QP This new metric is intended to count the number of metrics that the query processor metrics middleware sees and attempts to adjust. * Add more metrics metrics tests - Ensure that queries with no metrics do not incremement either counter - Ensure that successful calls to adjust do not increment the error counter - Ensure that exceptions throw from other libs also increment the error counter * Rename test to adjust-prometheus-metrics-test and add helper to reduce code dup * If no metrics are found immediately return query in metrics middleware adjust Don't attempt to adjust query if we don't find any :metric clauses. * Appease cljfmt * Improve metric description Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Improve epsilon test in approx= Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Remove adjust-metric-stages-counting-errors This function was an attempt to avoid double-counting errors, but probably not worth the effort. See https://github.com/metabase/metabase/pull/48598#discussion_r1800197964 https://github.com/metabase/metabase/pull/48598#discussion_r1800200421 * Count metrics directly when mocking prometheus/inc! Based on PR feedback here: https://github.com/metabase/metabase/pull/48598#discussion_r1800207674 * Remove prometheus/inc-and-throw! Value prop was always questionable, but now that it's only called from a single place, just remove it and inline the call to prometheus/inc!. Easy to add back later if it proves generally useful. PR discussion thread https://github.com/metabase/metabase/pull/48598#discussion_r1799728596 * Rename match-one-metric to find-first-metric https://github.com/metabase/metabase/pull/48598#discussion_r1803321025 * Rename :metabase-query-processor/metrics-errors to metric-errors https://github.com/metabase/metabase/pull/48598#discussion_r1803313818 * Throw an exception rather than logging a warning if we fail to adjust a metric https://github.com/metabase/metabase/pull/48598#discussion_r1803328482 --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
bryan authored
* add prometheus tracking for sdk-embedding * indentation * improve track-sdk-response api * register :metabase-sdk/response-{ok,error} + test * avoid cyclic dependency whe nusing prometheus fixes: [ /metabase/api/common ] <- /metabase/models/setting <- /metabase/analytics/settings <- /metabase/analytics/prometheus <- /metabase/analytics/sdk <- /metabase/models/view_log <- /metabase/events/schema <- /metabase/events <- [ /metabase/api/common ] <- /metabase/public_settings/premium_features <- /metabase/auth_provider <- /metabase/driver <- /dev/debug_qp <- /dev * nix dependency: events.schema --> models.view-log - make them both read context from view-log-impl instead * cljfmt
-
bryan authored
-
Chris Truter authored
-
metamben authored
-
github-automation-metabase authored
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Noah Moss authored
-
Nicolò Pretto authored
* faster --watch command for the sdk * apparently we want an empty line at the end of jsons, but prettier removes it? * format tasks.json with prettier
* vscods tasks, move watch task from webpack config to the fixup script * cleanup webpack config * adds clean + waits for dist folder when not existing * minimal doc for the sdk commands -
Anton Kulyk authored
* Don't assert dynamic value * Restart CI
-
Mahatthana (Kelvin) Nomsawadi authored
-
Alexander Solovyov authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Don't open sidesheet on SDK dashboards * Add E2E test * Fix `className` not passed * Fix unit tests * Fix E2E tests
-
Ngoc Khuat authored
-
- Oct 15, 2024
-
-
Raphael Krut-Landau authored
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
bryan authored
* adds data + schema for metrics stats ping * remove comment * annotate todos * fill in the rest of the metrics values - and add defaults * fix some definitions + use a single timestamp * shuffle stuff around to appease the namespace linter - we aren't reaching into the api API, so the linter is more of a formality here. * update docstring * fix jsonschema, maybe * review responses - revert changes to 1-0-0 - add metrics section to new file: 1-0-1 - bump ::instance_stats to "1-0-1" - add tags into 1-0-1 - make the code return tags (empty for now until we know what to tag things.) - also fix test that broke from shuffling settings around * remove a footgun * add tags to metrics, add grouped_metrics to jsonschema 1-0-1 format 1-0-1 * indent * cljfmt * version should match filename * update instance stats 1-0-1 schema * require `tags` in grouped_metric + snowcat comment * fix formatting noise * update schema to make it valid * remove grouped_metrics from instance_stats schema * cljfmt appeasement * unbin cache_num_queries_cached value - alphabetize metrics generation * we can now guarantee metric values will be ints * jsonschema for instance_uuid, settings, and grouped_metrics * add analytics_uuid and make it required * lint + alphabetize instance stats json schema * update setting key type - add maxLength to some strings * lint jsonschema - Add description to setting.items.tags - add maxLength, and {min,max}imum to setting.items.value * Bump instance stats to 2-0-0 - remove analytics_uuid string length == 36 check - adds assertion to ensure required fields are set (and it passes) - adds info for embedding settings * adds a grouped-metric to stats ping - adds length info to the schema to pass jsonschema linting * cljfmt
-
Aleksandr Lesnenko authored
-
Anton Kulyk authored
* Add default value for `hiddenIndices` * Add e2e test
-
Uladzimir Havenchyk authored
* fix circular deps in query_builder/components * js -> ts
-
adam-james authored
* Incremental Pivot Processing for Exports WIP Fixes pivot exports for CSV and xlsx. The CSV export should use less memory by incrementally building up the data structure and aggregating necessary row data right away, so the memory overhead becomes only as large as the total pivot result. In cases where the pivot rows/cols do combine into many many columns and rows, this can still be a large set of data, but it should behave much better now in most cases. The Excel export is a little more straightforward: create the export rows in the same fashion, streaming one row at a time, and just post-process the sheet to add the pivot table in one shot at the end. * WIP adding row totals. * aggregate totals as rows are added Row, column, section, and grand totals are all aggregated as each row is added. This means the final step of building pivot output becomes just an exercise of lookups/arrangement, no further aggregation is needed. * CSV pivot works per-row, export respects formatting This is a big step forward; we don't need to hold the entire dataset in memory, we instead aggregate a row's data into the pivot datastructure, which only holds onto: - unique values for each pivot-row in a sorted set - unique values for each pivot-col in a sorted set - grand total for each measure N values, where N is number of measures, ususally 1 or 2 - row totals for each combination of each pivot-row * N measures - col totals for each combination of each pivot-col * N measures - totals for each 'section', determined by unique values of first pivot-row * N measures - values for each measure in every 'cell'; Row Combos * Col Combos * N Measures So, there can still be a decent amount of data to store; but it will never hold onto all of the 'raw rows' from the dataset. We can never completely guarantee that Row Combos * Col Combos * N Measures remains small, but two things let us move forward anyway: - there's now visible feedback in the app that the download is running (or if it's failed) - Pivot table utility diminishes rapidly with huge output anyway; users still need to curate/set up their data - effectively to improve the table's utility, so we can assume that a slow-to-download pivot table is also slow to - use/less effective, and will likely be something the user doesn't want (as often). * some test fixes * now, if we export 'raw pivot rows', they don't show pivot-grouping and they also don't include the 'extra' rows for totals/subtotals/grand totals (any row with pivot-grouping > 0). This means that now the non-pivot version of a pivot table export will match what a user sees if they change the viz to a regular table. * remove old test * re-incorporate some changes from master * fix csv for non-pivots due to oversight in my changes This is just a temporary change, I think I should clean up this bit of the code a little, I can probably make it a little more readable and use some cleaner logic regarding if the rows are 'raw pivot rows' or not. * start moving format_rows to POST bod, add pivot_results too There's still wiring work to do, but this starts to add format_rows and pivot_results to POST body for the various API endpoints. Also modify tests to improve coverage/consistency across downloads and alerts/subscriptions. The tests will not pass on this commit, but fixes will be incoming * native pivot tables in xlsx * add precondition to pass migration linter * try to get migrations fixed * pasing pivot-results through api and attachments * fix tests for format_rows in BODY vs query param * tests! * might have the tests all fixed now * the pivoted export now respects col/row totals settings * add test coverage for public questions and dashboards * col and row totals work as expected * build-pivot refactor for clarity * docstring change + tiny refactor in helper fn * see if dashcard download works with format_rows * csv pivot handles nil values * pass format_rows and pivot_results in :params not :body * fix some other tests * pivot-grouping col filtered out of xlsx * pivot-grouping-col removed for all rows * configurable pivot exports and attachments (#47880) * exports fe * specs * ui * specs * format/unformatted now works for xlsx * format test changes for xlsx formatting * embedding endpoints accept pivot_results * cljfmt and eslint fix * empty * embedding test should have formatting defaulted to true * embed test fixes * Use `Chip` for export settings widget * downloads e2e test fix * fix public download limit test * public card download defaults * fix public download defaults in some tests * Fix visual test --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Aleksandr Lesnenko authored
* fix iframe dashcards crash subscriptions * add a test to ensure iframes are filtered out of subscriptions --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
Romeo Van Snick authored
* Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question * Allow visitQuestion to work for metrics * Use visitQuestion in metric test * Add test for #48555 (showing the 'Save as new?' ui for metrics) * Add issue info to repro * Use visitMetric, visitModel and visitQuestion helpers in createQuestion * Move check to make it more clear what the save ui does * Use cy.button for Done button * Remove unnecessary .within * Sign in as normal user * Add missing dataset alias
-
Uladzimir Havenchyk authored
-
Kamil Mielnik authored
* Refactor createDashboardWithQuestions, createQuestionAndAddToDashboard and editDashboardCard to TS function helpers * Fix createNativeQuestionAndDashboard that got out of sync
-
Ngoc Khuat authored
-
Nicolò Pretto authored
* increase time tolerance to make tests less flaky on ci when CPU is under heavy load * Update e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> --------- Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Romeo Van Snick authored
* Rename Common Metrics to Metrics * Rename Basic Metrics to Summaries * Update chill mode button copy to 'Add a summary or metric' * Rename 'Pick the metric you want to see' button to include summary * Fix type in test * Rename Summaries to Basic functions * Fix test * Undo cross-version test changes
-
- Oct 14, 2024
-
-
Ngoc Khuat authored
* [Notification] Migrate user invited email (#48215) * [Notification] Migrate alert create email (#48292) * [Notification] Migrate slack token error email (#48333)
-
Raphael Krut-Landau authored
-
metamben authored
* Implement inactive field removal
-
lbrdnk authored
* Use information_schema for describe-database * Unrelated fix: set dynamic-dataset-loading defaults to true * cljfmt * Fix test
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Uladzimir Havenchyk authored
-