Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 05, 2023
    • Kamil Mielnik's avatar
      Fix - Native editor buttons are incorrectly rendering on top of model metadata screen (#31142) · f7377e8b
      Kamil Mielnik authored
      * Make NativeQueryEditor testable
      - Mock just NativeQueryEditor.prototype.loadAceEditor instead of entire NativeQueryEditor
      
      * Fix invalid propTypes
      
      * Fix DatasetQueryEditor not re-rendering when props change
      - remove custom arePropsEqual argument from React.memo() on NativeQueryEditor
      - Fixes #30680
      
      * Add a dirty initial NativeQueryEditor test setup
      
      * Add DatasetQueryEditor tests
      
      * Revert "Add a dirty initial NativeQueryEditor test setup"
      
      This reverts commit 0f985db272a2e8f1be755bda07c3b642fdf90f83.
      
      * Get rid of test errors
      
      * Clean up DatasetQueryEditor test
      
      * Add a test case for re-rendering of DatasetQueryEditor
      
      * Make setup function more reusable
      
      * Add 2 more test cases
      
      * Bring back global NativeQueryEditor mock as many tests depend on it
      
      * Add an e2e test for #30680
      
      * Optimize DatasetEditor by conditionally rendering DatasetQueryEditor only when it can be seen
      
      * Remove redundant code
      
      * ESLint
      
      * Use createMockCollection instead of a cast
      
      * Move all Native Query creation to createMockNativeDatasetQuery
      
      * Use setupCollectionsEndpoints
      
      * Introduce setupNativeQuerySnippetEndpoints and use it in DatasetQueryEditor.unit.spec.tsx
      
      * Extract explanatory importDatasetQueryEditor
      
      * Remove file accidentally added when merging master
      
      * Add missing data-testid that got lost during a merge
      f7377e8b
  2. Jun 04, 2023
  3. Jun 03, 2023
  4. Jun 02, 2023
    • Case Nelson's avatar
      [MLv2] Add expressionable-columns (#31304) · 1d7dcbe4
      Case Nelson authored
      * [MLv2] Add expressionable-columns
      
      * Fix test
      1d7dcbe4
    • Maz Ameli's avatar
      New icons (#31096) · a1b09db0
      Maz Ameli authored
      
      * arrow_left
      
      * check mark
      
      * arrow_up and chevrons
      
      * add, close, contract, embed, expand, sort
      
      * change viewbox to 16
      
      * icons in +New menu, search, and sidebar toggle
      
      * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons
      
      * fix database icon
      
      * ellipsis, person, and tweak ellipsis size in collections sidebar
      
      * home, reference or book, pencil or edit, table
      
      * dashboard action icons, and remove reference to unused ClockIcon.jsx
      
      * question action icons and related component tweaks
      
      * larger icons on HomeModelCard on homepage
      
      * dashboard and add_to_dash
      
      * snippet and variables
      
      * all the chart type icons and some field type ones
      
      * mail and groups
      
      * make sidebar icons darker blue
      
      * fix add-your-data icon
      
      * filled mail icon and use it on events modal
      
      * stars
      
      * bolt and x-rays and a bunch more
      
      * granular, metric, revision history
      
      * arrows, formula, snippets
      
      * click, cloud, boolean, unpin
      
      * return, hourglass, popover
      
      * pause, ldap, burger
      
      * gear info list pin moon sum sun verified warning
      
      * fix size of row details modal icons
      
      * fix size of left nav icons
      
      * fix size on filter widgets and some selects
      
      * set default size to 16 to fix entity menu icons etc
      
      * fix pagination icons
      
      * size and color on ItemPicker
      
      * bump up database icon in /browse to 32px
      
      * /browse bolt icon size
      
      * find and remove instances of 14px size declarations
      
      * sql editor icons
      
      * sql expand/contract button alignment
      
      * collection breadcrumbs
      
      * remove two more size 14 declarations
      
      * viz selector
      
      * fix add icon in New button
      
      * fix size of ModelDetailLink
      
      * icon for question list empty state
      
      * get rid of model_framed icon
      
      * try to fix event tick icons, replace balloons with cake
      
      * standardize size of question footer actions
      
      * fix dinosaur
      
      * switch star_outline to star, and star to star_filled
      
      * fix notebook sort action
      
      * switch data picker from table2 to table
      
      * fix slack icon
      
      * restyle HomeXrayCard
      
      * fix List icon
      
      * fix sidebar toggle icon size
      
      * fix icon size in field picker popovers
      
      * fix summarize sidebar field type icons
      
      * fix summarize sidebar Add buttons
      
      * table heading sort icons
      
      * fix filter icon, resize button icons
      
      * bulk filters icons
      
      * admin datamodel icons sizing
      
      * fix datamodel metric and segment icons, and sort icon
      
      * dashboard interactivity sidebar close icon
      
      * get rid of grabber2
      
      * bookmark and question actions icon sizes
      
      * revert icon
      
      * Icons cleanup (#31147)
      
      * remove timeline event icon stroke
      
      * cleanup
      
      * add 16x16 viewbox to svgs that were missing it
      
      * add slack_colorized
      
      * correct the join_full_outer icon
      
      * timeline events, cleanup
      
      * fix broken icons
      
      * more cleanup
      
      * fix storybook
      
      * fix all types
      
      * add stories
      
      * try fixing arrow_split
      
      ---------
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * fix specs
      
      * fix specs
      
      * remove unused icons
      
      * use constants
      
      * increase node memory allocation
      
      * bump for chromatic too
      
      * fixes
      
      * fix arrow_split icon
      
      * fix arrow_split path attributes
      
      * fix path again and fix sizing of drillthrough menu icons
      
      * more spec fixes
      
      * prettier
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      a1b09db0
    • Cam Saul's avatar
      Use MLv2 for metadata calculation in QP (part 1); make column name calculation... · d96c318d
      Cam Saul authored
      Use MLv2 for metadata calculation in QP (part 1); make column name calculation consistent with QP (#29583)
      
      * Simplified impl
      
      * Add #31266 test
      
      * Yay
      
      * Very nice
      
      * Test fixes
      
      * Fix Kondo warnings
      d96c318d
    • Natalie's avatar
      docs - feedback (#31270) · 2d1eed13
      Natalie authored
      2d1eed13
    • Nemanja Glumac's avatar
      Pre-build the specific version and edition of MB (#31296) · 37a8b947
      Nemanja Glumac authored
      Simply invoking `.bin/build.sh` will produce the uberjar without a
      version. This is why @ariya created #30915 in the first place.
      
      But the build script already takes `:version` and `:edition` arguments.
      That is exactly what this PR is doing rather than manually unzipping the
      uberjar in order to tweak its `version.properties` file.
      37a8b947
    • Cam Saul's avatar
      Ban `mt/with-temp` and replace usages with `t2.with-temp/with-temp` (#31235) · 15026099
      Cam Saul authored
      * Ban `tt/with-temp` and convert usages to Toucan 2
      
      * Ban `tt/with-temp*` and convert usages to Toucan 2
      
      * Revert changes not meant for this PR
      
      * Ban `mt/with-temp` and replace usages with `t2.with-temp/with-temp`
      
      * Fixes :wrench:
      
      
      
      * Fix indentation
      
      * fix syntax in models.secret_test
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      15026099
    • Oisin Coveney's avatar
      remove null from test (#31298) · f45d268d
      Oisin Coveney authored
      f45d268d
    • Ryan Laurie's avatar
      Model Index Bugfixes (#31048) (#31049) (#31094) · 9a2c0190
      Ryan Laurie authored
      * [Model Indexes] Use model metadata to determine indexability (#31048)
      * [Model Indexes] Allow Updating Metadata at the same time as adding an index (#31049)
      * [Model Indexes] Fix Model Index Front End Cache Invalidation (#31094)
      9a2c0190
    • john-metabase's avatar
    • john-metabase's avatar
    • Oisin Coveney's avatar
    • Braden Shepherdson's avatar
      [MLv2] Fix `type-of` (both of them) for datetime arithmetic functions (#31172) · 528f4101
      Braden Shepherdson authored
      That's `:datetime-add`, `:datetime-subtract`, and `:convert-timezone`.
      
      Fixes #29910
      528f4101
    • Anton Kulyk's avatar
    • Cal Herries's avatar
      Add missing reverse migration for AddJoinAliasToVisualizationSettingsFieldRefs (#31150) · 96bbf025
      Cal Herries authored
      * Add reverse migration for AddJoinAliasToVisualizationSettingsFieldRefs
      
      * Limit selections to query_type="query"
      
      * Make like strings more specific
      
      * Fix where clause
      
      * Further optimize where clause
      
      * Rename and refactor
      
      * Update test name
      
      * Fix indentation and naming consistency
      96bbf025
    • Cam Saul's avatar
    • Cam Saul's avatar
      Ban `tt/with-temp*` and convert usages to Toucan 2 (#31233) · e01bcd33
      Cam Saul authored
      * Ban `tt/with-temp` and convert usages to Toucan 2
      
      * Ban `tt/with-temp*` and convert usages to Toucan 2
      
      * Revert changes not meant for this PR
      e01bcd33
  5. Jun 01, 2023
Loading