Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 17, 2018
  2. Sep 14, 2018
  3. Sep 13, 2018
  4. Sep 12, 2018
  5. Sep 11, 2018
  6. Sep 10, 2018
    • Ryan Senior's avatar
      Add UserLocalizedString and SystemLocalizedString for i18n · 96b77169
      Ryan Senior authored
      Currently i18n'd strings that are defined at compile time only return
      english text. This occurs with both system and user locale
      strings. For system locale, the locale can be changed via setting, so
      we can't rely on the JVM locale on startup to be correct as it may
      have changed. For the user locale, it could be different for every
      request.
      
      This commit adds two new `tru` and `trs` macros that have the same
      name as the `puppetlabs.i18n.core` macros (and thus will be extracted
      similarly) but will return a defrecord with a `toString` method. This
      delays the conversion of the english text to the translated text until
      `str` is invoked. All of the code hasn't been flipped to use the new
      i18n macros yet, but this gets it in place and tested for the rest of
      the application to be migrated to.
      
      Fixes #8245
      96b77169
  7. Sep 04, 2018
  8. Sep 03, 2018
  9. Aug 31, 2018
    • Ryan Senior's avatar
      Add new flag for BigQuery to use JVM timezone [ci drivers] · 4a1be8a8
      Ryan Senior authored
      This commit adds a flag to allow dates parsed from BigQuery to be
      parsed in the JVM's timezone rather than UTC. By default all BigQuery
      dates are in UTC but it's possible to modify the timezone via a
      function invocation. This flag allows installs that have all of their
      queries modifying the timezone in that way to match the actual and
      expected timezones via setting the JVM's timezone.
      4a1be8a8
  10. Aug 30, 2018
    • Ryan Senior's avatar
      Add TaskHistory for storage sync and background task metadata · 921d3751
      Ryan Senior authored
      This adds a new table for storing sync metrics and a quartz task for
      cleaning up old entries in the table.
      
      For now this only stores sync metrics and metadata for the task
      history cleanup task. Going forward our other background tasks would
      store information as well to help with debugging/troubleshooting those
      tasks.
      
      Fixes #7611
      921d3751
  11. Aug 22, 2018
    • Ryan Senior's avatar
      Ensure we handle no git Metadata for BQ startup [ci drivers] · 72a6b3fb
      Ryan Senior authored
      When connecting to a Google service, we identify ourselves with a
      string that includes version, hash and branch information. If a user
      downloads a Metabase tarball from Github, it won't have that Git
      metadata and we will throw a NullPointerException on startup.
      
      This commit just ensures we always have a value for that string, even
      when there is no git metadata available.
      
      Fixes #8368
      72a6b3fb
    • Ryan Senior's avatar
      Fix FK remappings with a user included fields clause [ci drivers] · cb11b2ef
      Ryan Senior authored
      Our existing remappings code didn't work when an MBQL fields clause is
      present. Typically that fields clause is populated by the
      `add-implicit` middleware, but that doesn't happens with the user
      included fields.
      
      Fixes #8270
      cb11b2ef
  12. Aug 17, 2018
    • Ryan Senior's avatar
      Dataset exports should check for nested queries · 771ad77c
      Ryan Senior authored
      When POSTing to the `/dataset` endoint, there was code that if the
      database was our fake database id (used for nested queries) but that
      same check wasn't present for the dataset exports. This commit adds
      that check and a test that validates it.
      
      Fixes #8256
      771ad77c
    • Simon Belak's avatar
      Add test · 49cc444d
      Simon Belak authored
      49cc444d
    • Ryan Senior's avatar
      Fix bug with MySQL date tz conversion for native queries [ci drivers] · 988a75d3
      Ryan Senior authored
      The issue was around our usage of `du/format-date` with a built-in
      date format (`:date-hour-minute-second-ms`). Those Joda Time date
      formatters don't default to the system timezone, which the code
      assumed. Instead it defaults to UTC. We have code in the MySQL driver
      that works around a MySQL driver bug by converting the date to a
      string and then using the MySQL `convert_tz()` function. That code was
      converting the date from the system timezone to the report timezone,
      rather than UTC, which is what the Joda Time date formatter was
      returning.
      
      Fixes #8262
      988a75d3
  13. Aug 16, 2018
    • Ryan Senior's avatar
      Pulse graphs should skip nil value rows · 1ee398df
      Ryan Senior authored
      Previously an NullPointerException would be thrown if the Pulse was a
      bar graph and the resultset contained a nil value for the x or y
      axis. This commit just omits those rows so that it doesn't fail and
      renders the data it does have.
      
      Fixes #8260
      1ee398df
  14. Aug 13, 2018
  15. Aug 09, 2018
  16. Aug 08, 2018
  17. Aug 07, 2018
  18. Aug 06, 2018
  19. Aug 01, 2018
  20. Jul 31, 2018
    • Ryan Senior's avatar
      Don't decrypt obviously not encrypted strings · 7c10f1aa
      Ryan Senior authored
      When `MB_ENCRYPTION_SECRET_KEY` is set, we assume that all settings
      have been encrypted. If a setting has not been encrypted, decryption
      fails, but the original setting is returned. This causes Metabase to
      behave correctly but have very noisy logging as when the decrypt fails
      an error is logged.
      
      This commit changes the `maybe-decrypt` behavior to more closely
      examine the ciphertext to ensure it is something that can be
      decrypted. If it looks like something that can be decrypted, but
      decription fails (i.e. what if an unencrypted string is multiple of
      the cipher block size) then log a warning as it's probably not an
      issue, but could be.
      
      Fixes #8151
      7c10f1aa
  21. Jul 30, 2018
Loading