Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 06, 2021
    • Nemanja Glumac's avatar
      Cypress email setup (#18247) · f94c3c96
      Nemanja Glumac authored
      * Add `setupSMTP` helper function
      
      * Remove deprecated `setupDummySMTP` helper
      
      * Re-use `setupSMTP` helper in tests
      
      * Always clear Webmail's inbox after setting up the SMTP
      Unverified
      f94c3c96
    • Pawit Pornkitprasan's avatar
    • Howon Lee's avatar
      Erroring question page nits (#18190) · 384218e6
      Howon Lee authored
      Previous PRs for error cards page were laser focused on getting everything to work, as opposed to actually conforming to spec. This one gets it closer to spec, although product wants reloading animations which are not there yet. To wit,
      
      - Indicates to end user what the current running state is. Given the many orders of magnitude in DB query run times I think something robust and non-ephemeral is necessary here (looking at some sort of expanded QE model) but Maz suggested expedient method and I took it
      - No more left nav on the table page
      - Page heading for table page
      - Independent scroll-x behavior on the table
      - Styling for the error section on the table page
      - Select-all component. Note that the interaction behavior with pagination is fiddly. (but less fiddly now that it's all based on card id's instead of row numbers)
      - Coalescing default behavior for Our Analytics collection (default collection) and null number of dashboards
      Rename error name to error content search
      Unverified
      384218e6
  2. Oct 05, 2021
  3. Oct 04, 2021
  4. Oct 03, 2021
  5. Oct 01, 2021
    • Alexander Lesnenko's avatar
      Show permissions for hidden tables (#18171) · 8c085863
      Alexander Lesnenko authored
      * Show hidden tables permissions, load tables only when needed
      
      * fix padding
      
      * remove loader div wrapper
      
      * remove redundant wrappers
      Unverified
      8c085863
    • Dalton's avatar
      Fetch and use fields associated with a parameter to parse parameter values... · 9588033b
      Dalton authored
      Fetch and use fields associated with a parameter to parse parameter values found in URL query (#18104)
      
      * move logic in dashboard selectors to meta/Dashboard
      
      * rmv usage of syncQueryParamsWithURL
      
      * add syncQueryParamsWithURL logic to meta/Parameters.js
      
      * Fix public questions
      
      * fix dashboards
      
      * fix query builder
      
      * don't normalize when value is empty string
      
      * rmv unused setMultipleParameterValues fn
      
      * replace selector logic with meta/Dashboard fn
      
      * filter out nil fields
      
      we need to do more work before we can properly use
      fields from nested questions when parsing parameter values.
      
      * add field to dash parameter so we can correctly type nested native query fields
      
      * fix tests
      
      * code style tweaks per review
      Unverified
      9588033b
    • Nemanja Glumac's avatar
      Cypress E2E MySQL snapshot (#18193) · de22490d
      Nemanja Glumac authored
      * Create `mysql-8` snapshot
      
      * Use `mysql-8` snapshot in tests
      
      * Extract repro for #15342
      
      * Relocate mysql `add` spec
      
      * Extract mysql GUI query tests
      
      * Relocate mysql `query` spec
      
      * Extract repro for #12445
      
      * Remove `metabase-db` from Cypress
      
      * Update Cypress README
      Unverified
      de22490d
    • Noah Moss's avatar
    • Nemanja Glumac's avatar
      Cypress E2E Mongo snapshot (#18184) · 2cf6dc55
      Nemanja Glumac authored
      * Create `mongo-4` snapshot
      
      * Use `mongo-4` snapshot in tests
      
      * Restore and authenticate
      
      * Relocate mongo `line` spec
      
      * Relocate mongo `native` spec
      
      * Relocate mongo `add` spec
      
      * Extract repro for #13097
      
      * Relocate mongo `query` spec
      
      * Remove mongo from `metabase-db`
      Unverified
      2cf6dc55
    • Nemanja Glumac's avatar
      Separate qa db snapshots (#18179) · 170a2b84
      Nemanja Glumac authored
      - a56b640d broke Percy workflow on master and introduced a major inconvenience for developers who wish to run Cypress locally. In both cases, it's required to have all supported QA DB docker images running at all times. Otherwise, the Cypress snapshot creation phase breaks.
      
      This PR:
      - uses the existing ENV var to conditionally skip qa db snapshots
      - this doesn't affect CircleCI workflow - it merely makes life easier for developers running Cypress locally and for a Percy workflow that runs on GitHub Actions (where we still don't have QA docker images available)
      Unverified
      170a2b84
    • Alexander Polyankin's avatar
  6. Sep 30, 2021
    • Jeff Evans's avatar
      Fix errors from disallowed characters in BigQuery custom expression names (#18055) · cb05523b
      Jeff Evans authored
      Add `escape-alias` multimethod to `sql.qp` to handle translating an alias (whether for a field or expression) into something supported by the driver in quesion
      
      Add default impl that is essentially identity
      
      Marking `sql.qp/field->alias` as deprecated, and changing its default implementation to invoke the new `sql.qp/escape-alias` on the field's `:name` (with the intention of removing it in a future release, since individual driver won't need to override this, so much as they'll need to override `escape-alias` itself).
      
      Override `sql.qp/escape-alias` method for both BigQuery drivers to run through the same `->valid-field-identifier` function already defined for this purpose
      
      Add test for a custom expression with weird characters
      Unverified
      cb05523b
    • Nemanja Glumac's avatar
      Translate Whitelabel color options (#18170) · 6978a836
      Nemanja Glumac authored
      Closes #18168.
      Unverified
      6978a836
    • Nemanja Glumac's avatar
      Cypress E2E postgres snapshot (#18106) · a56b640d
      Nemanja Glumac authored
      * Create `postgres-12` snapshot
      
      * Use `postgres-12` snapshot in tests
      
      * Relocate postgres `add` spec
      
      * Relocate postgres `sandboxes` spec
      
      * Relocate postgres `native` spec
      
      This actually didn't have anything to do with the native questions.
      We simply used native editor because it was easier to reproduce the issue.
      
      * Relocate postgres `permissions` spec
      
      * Relocate postgres `query` spec
      
      * Relocate postgres `custom-column` spec
      
      * Remove postgres from `metabase-db`
      Unverified
      a56b640d
Loading