This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 26, 2024
-
-
Denis Berezin authored
* Button * Reset button * Skip failing unit test * Fixes after merge
-
Oisin Coveney authored
-
- Apr 25, 2024
-
-
Oisin Coveney authored
-
Noah Moss authored
-
Oisin Coveney authored
-
- Apr 24, 2024
-
-
Denis Berezin authored
* Isolate click actions * Self review fixes * Add global plugin config * Review fixes * Drill with custom view * Review fixes
-
- Apr 23, 2024
-
-
Nemanja Glumac authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
- Apr 22, 2024
-
-
Noah Moss authored
-
Oisin Coveney authored
-
- Apr 19, 2024
-
-
Noah Moss authored
-
Noah Moss authored
Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate --border-* * Migrate *breadcrumb* * Migrate --color-bg-black * Migrate --color-bg-dark * Migrate --color-bg-light * Migrate --color-bg-medium * Migrate --color-bg-white * Migrate --color-border * Migrate --color-brand* * Migrate --color-error * Migrate --color-focus * Migrate --color-shadow * Migrate --color-success * Migrate --color-text-dark * Migrate --color-text-light * Migrate --color-text-medium * Migrate --color-text-white * Migrate --color-white * Migrate --default-border-radius * Migrate --default-button-border-radius * Migrate --default-font-family * Migrate --default-font-size * Migrate --default-header-margin * Migrate --gap-1 * Migrate --icon-width * Migrate --input-border-color * Migrate --input-border-radius * Migrate --margin-* * Migrate --muted-color * Migrate --padding-* * Migrate --page-header-padding * Migrate --subtitle-color * Migrate --title-color * Reset to master * Remove unused --color-text-default * Remove unused --color* * Remove unused CSS custom properties * Prefix only necessary CSS custom properties
-
Oisin Coveney authored
-
- Apr 18, 2024
-
-
Raphael Krut-Landau authored
-
Ryan Laurie authored
* WIP questionpicker * use to replace dashcard content * much better stuff * question picker * values source card modal * create action form * awesome hacky fix for crashing model detail page * use entity picker in sandboxing modal * deprecate ye olde question picker * keep old question picker in add-card dashboard sidebar * better last level check * update types * make stuff better * fix rebase conflicts * better initial value handling * update e2e tests * sweet sweet unit tests * fix sandbox tests * fix tests * type fix * fixes * search style improvements * remove unused prop * safer path detection * delayed loading spinner * change confirm default * set default collection for placeholder card * address review comments * update unit tests * update e2e tests * fix re-rebase * add some happy little comments
-
Alexander Solovyov authored
-
Chris Truter authored
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Apr 17, 2024
-
-
Ngoc Khuat authored
-
-
Chris Truter authored
-
Noah Moss authored
Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .floatLeft, .floatRight * Remove unused components
-
- Apr 16, 2024
-
-
Denis Berezin authored
* Fix table styles calculation * Review fixes * Fix unit tests
-
Braden Shepherdson authored
This improves our Malli performance substantially! Many of our code paths were calling vanilla `malli.core/validate` or `malli.core/explain`; these redo the (possibly expensive) compilation of the schema into a validator or explainer for every call. We should use the caching versions in `metabase.util.malli.registry` everywhere, and our runtime performance will be much improved. However when I started using these cached versions, I found that the memory use was growing out of control. Eventually I tracked this down to `:fn` schemas. Functions are only comparable by pointer equality, so they make poor cache keys. `(fn ...)` or `comp` calls in a schema on a `mu/defn` function **get re-created for every call of the `mu/defn`'d function**! That's a big time sink recompiling the schemas if we're *not* caching, and a huge memory sink if we *are* caching! This PR pulls every such schema I could find out into a `def` so it uses the same closure and is cacheable. I'd like to automate that in some part of the Malli pipeline, or maybe a linter rule, but I haven't found a good way to do it yet. Part of #39946.
-
Nemanja Glumac authored
* Define the types for the `create` user request * First draft for the create user API using RTK Query * Export RTK user API * Define explicit `create` api for the user entity * Define `updatePassword` mutation * Wire users entity `resetPasswordManual` to use RTK under the hood * Use `updatePassword` mutation * Wire users list calls * Remove unused `update_password` from services * Fix the dispatch used to list users * Dispatch the action type and the payload * Wire `deactivateUser` to work with RTK * Wire `reactivateUser` to work with RTK * Delete unused entries from `UserApi` * Convert the reducer to use `switch` statement * Remove unused user `send_invite` endpoint from FE * Wire `resetPasswordEmail` in users entity to work with RTK * Provide cache invalidation for the `userApi` * Add `provideUserListTags` helper * Pass `email` as a sole argument * Throw on `get` a user This endpoint hasn't been used in a long itme. Removed in https://github.com/metabase/metabase/pull/41334/files#diff-241e0afa11f03a0942eb322aa47695e58496379b0b6d42e6e59ecf6a20fe623cL448 * Use RTK Query to `updateUser` * Fix wrong syntax * Use RTK Query to `getUser` It was used by `.load` and `fetch` after all. * Export `useUpdateUserMutation` * Refactor `getRecipientsList` * Fix response type for the `getUser` * Pass user id as a sole argument instead of in an object * Fix users entity `get` method * Fix the user update password form * Fix unit tests * Fix deactivate and reactivate query invocations See e949812. * Adjust types according to the feedback * Order utils alphabetically * Throw on `delete` * Revert "Fix unit tests" This reverts commit 2c329e836427010ad08bfd0511eb1a9df4ba95d6. * Fix FE unit test mocks * Rename imports to use plural for consistency * Fix one last remaining FE unit test
-
- Apr 15, 2024
-
-
Ngoc Khuat authored
-
- Apr 12, 2024
-
-
Raphael Krut-Landau authored
Adds a Schedule strategy to the Admin / Performance page  [Loom](https://www.loom.com/share/5623cd5d772e417ba2e58c29ae1b8c14?sid=9844f0db-5bb1-4d35-af9b-206d263f5516) As discussed with @luizarakaki, rather than modify the legacy `SchedulePicker` to work with this use case, I made a new version of it - a `Schedule` component - that uses Mantine and a better (though imperfect) approach to localization. For now, the dropdowns are not vertically aligned in this Schedule picker - something I can try to remedy later if that is important. Tests for the Schedule component will be added in a follow-up PR.
-
Denis Berezin authored
* Add interactive question component * Remove excess click actions for embedding * Disable non-working drills * Cleaner components api * Clean up * Review fixes * Fix lint error * Review fixes --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Cal Herries authored
-
Nick Fitzpatrick authored
* no implicit any on callbacks * cleaning up use of any * small adjustments * PR feedback and unit test adjustment * typing click handler
-
- Apr 11, 2024
-
-
Raphael Krut-Landau authored
-
Cam Saul authored
* Convert `auto-bucket-datetimes` middleware to MLv2 * New Kondo rule time. * Test & lint fixes
* Fix typos * Apply suggestions from code review Co-authored-by:metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Oisin Coveney authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Oisin Coveney authored
-
Nicolò Pretto authored
* .eslintrc -> .eslintrc.js * This might work? * add env for linting css modules class names * avoid extending postcss-modules/recommended, specify just the used rule instead * add missing . on comment * Remove unused .detailName references * Fix ManageApiKeys and GuiQueryEditor * Fix SettingText and DashboardControls * fix missing textUnspaced class * remove usave of S.headerButton, that's actually never used because we never pass headerLink to ReferenceHeader * Remove flexNoShrink --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
- Apr 10, 2024
-
-
dpsutton authored
* Fix #39138 again Fixes #40934 Got unfixed somehow in #40578. seems like some file renames caught it off guard But the long and short is that its possible for a persisted model to end up in the state "refreshing" (possible an instance restart during refreshing). The refreshing job doesn't look for these so they become effectively invisible. Since the job to refresh them will only run one at a time cluster wide, any jobs that are in the "refreshing" state when the refresher begins to refresh are necessarilly stuck (no one else could currently be refreshing them). So we can just add them to the queue of models to refresh. ```clojure (jobs/defjob ^{org.quartz.DisallowConcurrentExecution true ;; <---- :doc "Refresh persisted tables job"} PersistenceRefresh [job-context] (refresh-job-fn! job-context)) ``` * Ensure ee/oss pathways are taken in tests Annoying little footgun here. CI does not run with an ee token, so in order to ensure that test pathway goes through ee version of a defenterprise we _must_ use the `mt/with-premium-features {:cache-granular-controls}`, but we also want to ensure that it goes through the oss version. So two options, a `doseq` on both features (empty set and the feature that triggers this). But want a test in the enterprise folder as well to ensure. The real trickiness comes from running tests at a repl and CLI. My REPL always has an ee token in it. My command line always lacks that as well. So want to be explicit about the token features in effect at test time. That's why I'm essentially duplicating tests (ee in ee folder, oss in regular pathway)
-