Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 30, 2020
  2. Oct 29, 2020
  3. Oct 28, 2020
  4. Oct 27, 2020
    • Nemanja Glumac's avatar
      Fix failing Cypress test in `dashboard-drill` spec file (#13612) · cb4371e9
      Nemanja Glumac authored
      * Fix failing Cypress test in `dashboard-drill` spec file
      
      * Assert that the page content rendered (as per @dacort 's suggestion)
      Unverified
      cb4371e9
    • Tim Macdonald's avatar
      [Fixes #11879] [Fixes #8410] Don't wrap email attachment filenames (#13563) · 91ff78a2
      Tim Macdonald authored
      * [Fixes #11879] [Fixes #8410] Don't wrap email attachment filenames
      
      * Non-ASCII characters in filenames are encoded [as per IETF RFC
        2047](https://tools.ietf.org/html/rfc2047) (c.f. #8410)
      * Sufficiently-long _encoded_ filenames are sent over multiple lines
          as per [RFC 2184 section
          3](https://tools.ietf.org/html/rfc2184#section-3), for example:
      
          ```
          Content-Disposition: attachment;
            filename*0="=?UTF-8?Q?T=C3=A9=C5=BFting_non-ASCII_=C4=8D=C4=A5=C3=A4ract";
            filename*1="ers.xlsx?="
          ```
      * Many mail clients do the right thing, but Gmail does not
      
      This commit therefore turns off wrapping, as per [Bill Shannon's
      Stack Overflow answer re. an undocumented system
      property](https://stackoverflow.com/a/53344141/220529)
      (Bill Shannon co-wrote the Java email library, which is used by postal
      (the Clojure wrapper we use).
      
      * (Hopefully) fix race condition in dashboard drill Cypress spec
      
      Suggested by @flamber
      
      * Skip flaky Cypress tests (per Nemanja)
      
      * Only set `mail.mime.splitlongparameters` once
      Unverified
      91ff78a2
    • dpsutton's avatar
      Adds dev/src/dev/nocommit to ignore file (#13353) · 1ab05174
      dpsutton authored
      * Adds dev/src/dev/nocommit to ignore file [ci skip]
      
      now you can create a folder nocommit/ under the dev classpath root so
      you can keep some namespaces around as you work on features.
      
      Ex:
      
      ```clojure
      (ns dev.nocommit.oom
        (:require [metabase.models
                   [database :refer [Database]]
                   [field :refer [Field]]
                   [table :refer [Table]]]
                  [metabase.sync.analyze
                   [fingerprint :as analyze.fingerprint]]
                  [metabase.sync :as sync]
                  [metabase.sync
                   [field-values :as sync.field-values]]
                  [metabase.models.field-values :as field-values]
                  [metabase.sync.analyze.fingerprint.fingerprinters :as fingerprinters]
                  [metabase
                   [util :as u]]
                  [metabase.sync.sync-metadata.fields :as metadata.fields]
                  [metabase.sync.sync-metadata.fields.fetch-metadata :as fetch-metadata]
                  [metabase.query-processor :as qp]
                  [toucan.db :as db]
                  [metabase.db
                   [metadata-queries :as metadata-queries]]))
      
      (def pg (Database 4))
      
      (comment
        (fetch-metadata/db-metadata pg emails-table)
        (metadata.fields/sync-fields! pg)
      
        (sync/sync-database! pg))
      
      (clojure.test/run-tests 'whatever-namespace)
      
      ```
      
      I ended up with lots of `(comment ...)` blocks in lots of different
      namespaces and this has helped keep my worktree clean.
      
      * Empty commit to trigger CI [ci skip]
      
      skipping ci thought so hopefully the checks on Github are satisified.
      Unverified
      1ab05174
    • Kyle Doherty's avatar
  5. Oct 24, 2020
  6. Oct 23, 2020
  7. Oct 22, 2020
Loading