Skip to content
Snippets Groups Projects
user avatar
Kamil Mielnik authored
* Make NativeQueryEditor testable
- Mock just NativeQueryEditor.prototype.loadAceEditor instead of entire NativeQueryEditor

* Fix invalid propTypes

* Fix DatasetQueryEditor not re-rendering when props change
- remove custom arePropsEqual argument from React.memo() on NativeQueryEditor
- Fixes #30680

* Add a dirty initial NativeQueryEditor test setup

* Add DatasetQueryEditor tests

* Revert "Add a dirty initial NativeQueryEditor test setup"

This reverts commit 0f985db272a2e8f1be755bda07c3b642fdf90f83.

* Get rid of test errors

* Clean up DatasetQueryEditor test

* Add a test case for re-rendering of DatasetQueryEditor

* Make setup function more reusable

* Add 2 more test cases

* Bring back global NativeQueryEditor mock as many tests depend on it

* Add an e2e test for #30680

* Optimize DatasetEditor by conditionally rendering DatasetQueryEditor only when it can be seen

* Remove redundant code

* ESLint

* Use createMockCollection instead of a cast

* Move all Native Query creation to createMockNativeDatasetQuery

* Use setupCollectionsEndpoints

* Introduce setupNativeQuerySnippetEndpoints and use it in DatasetQueryEditor.unit.spec.tsx

* Extract explanatory importDatasetQueryEditor

* Remove file accidentally added when merging master

* Add missing data-testid that got lost during a merge
f7377e8b
History
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
Name Last commit Last update
..