Fix subdimensions for a joined/FK dimension (#15530)

This restores the behavior just like before MBQL field refactoring (back
when the specialized class JoinedDimension and FKDimension still
existed): the subdimensions for a joined/FK dimension are exactly those
of the parent class, Dimension.dimensions(), and not more.  Also, each
subdimension must still carry the join alias/source field option.

frontend/src/metabase-lib/lib/Dimension.js

@@ -722,8 +722,19 @@ export class FieldDimension extends Dimension {
     );
   }
 
-  dimensions(): FieldDimension[] {
-    let dimensions = super.dimensions();
+  dimensions(DimensionTypes?: typeof Dimension[]): FieldDimension[] {
+    let dimensions = super.dimensions(DimensionTypes);
+
+    const joinAlias = this.joinAlias();
+    if (joinAlias) {
+      return dimensions.map(d => d.withJoinAlias(joinAlias));
+    }
+
+    const sourceField = this.getOption("source-field");
+    if (sourceField) {
+      return dimensions.map(d => d.withOption("source-field", sourceField));
+    }
+
     const field = this.field();
 
     // Add FK dimensions if this field is an FK

frontend/test/metabase/scenarios/question/notebook.cy.spec.js

@@ -535,7 +535,7 @@ describe("scenarios > question > notebook", () => {
       cy.get(".DashCard");
     });
 
-    it.skip("binning for a date column on a joined table should offer only a single set of values (metabase#15446)", () => {
+    it("binning for a date column on a joined table should offer only a single set of values (metabase#15446)", () => {
       cy.createQuestion({
         name: "15446",
         query: {
@@ -577,7 +577,7 @@ describe("scenarios > question > notebook", () => {
       popover()
         .last()
         .within(() => {
-          cy.findByText("Hour of Day").scrollIntoView();
+          cy.findByText("Hour of day").scrollIntoView();
           // This is an implicit assertion - test fails when there is more than one string when using `findByText` instead of `findAllByText`
           cy.findByText("Minute").click();
         });