This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 09, 2021
-
-
Ariya Hidayat authored
This restores the behavior just like before MBQL field refactoring (back when the specialized class JoinedDimension and FKDimension still existed): the subdimensions for a joined/FK dimension are exactly those of the parent class, Dimension.dimensions(), and not more. Also, each subdimension must still carry the join alias/source field option.
-
- Apr 08, 2021
-
-
Nemanja Glumac authored
- Fixes a flake in scatter.cy.spec.js that started appearing after throttle was introduced to the ExplicitSize component in #15235 - Also fixes a flake with brush filter that apparently wasn't fully fixed in the previous attempt ## Additional Info: - Stress testing this fix in isolation with GitHub actions shows 20/20 runs passing
- Stress testing "brush date filter" revealed that it still fails approximately 4-5x out of 20! - The reason seems to be that `mouseup` event doesn't always happen at the same time so the resulting filter doesn't have the same ending month every time (for example I've seen: "Created At between May, 2016 September, 2016", "Created At between May, 2016 July, 2016" and even "Created At between May, 2016 May, 2016") - It is more than enough that we assert that this filter exists in the first place so I changed the assertion to: `cy.contains(/^Created At between May, 2016/);` since the beginning of this string is the only thing we care about
-
- Apr 07, 2021
-
-
Dalton authored
* fix subscription cy test * wait for PUT completion for checking string
-
Dalton authored
* Don't normalize template-tag default values * treat location/category as string under the hood and rmv them from native query builder * unskip cy test * fix tests * rmv unused type import Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Nemanja Glumac authored
-
Dalton authored
* hide field search when using non-exact operator * Use parameter's combinedName when setting initial widget name * Hide search for lists
-
Alexander Lesnenko authored
* normalize serialized adhoc questions to support old syntax * JS version of normalize should preserve keyword namespaces * #15372 Repro: Visiting old hash results in a blank screen (#15512) Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Nemanja Glumac authored
* Add Cypress custom command `isInViewport` * Add repro for #15502 (2 variants)
-
Nemanja Glumac authored
* Add repro for #15445 * Add custom command `isVisibleInPopover` * Refactor the test to use new custom command
-
- Apr 06, 2021
-
-
dpsutton authored
* (#15460) Correct field names in native field filters ```sql select p.created_at, products.category from products left join products p on p.id=products.id where {{category}} ``` field filter is a string/= on category, a column in this twice due to the self join. Just mimic how the rest of this emits a column name * Unskip tests added in #15468 * Include fully qualified names in tests
-
Tim Macdonald authored
* Backend for dashboard sub filters, including EE implementation * Fix pulse/update-notification! to respect parameters * Add some tests * add FE EE parameter section to dashboard subscriptions * fix improper filter counting for label * hide parameters section when dashboard has none * fix thrown errorin pulses list sidebar * fix linting error * add cypress tests * rmv describe.only from test * refactor FE code a little * Merge pulse/dashboard parameters correctly for dashboard subs * fix issues with getting list of active pulse parameters * update formatting of multi value parameters * fix cypress test * tweak pulse details styling * move ParametersSection to enterprise tree Co-authored-by:
Dalton Johnson <daltojohnso@users.noreply.github.com>
-
Nemanja Glumac authored
* Quarantine possible offenders behind CI timeouts * Fix brush date filter test (#15505)
-
Nemanja Glumac authored
-
Tim Macdonald authored
-
Tim Macdonald authored
- Apr 05, 2021
-
-
Cam Saul authored
* Repro for #15118 * Revert demo tests
-
Cam Saul authored
* Send email when a user logs in from a new device for the first time * Test fixes
* Remove stray printlns * Test fix * Don't send email on the very first login. * Test fix * Update src/metabase/email/login_from_new_device.mustache Co-authored-by:Walter Leibbrandt <23798+walterl@users.noreply.github.com> * Remove unused u/prog1 * PR feedback * Add IP address geocode timeout * Geocode all IP addresses at once * Update tests for updated email template * Use built-in localized DateTimeFormatters per @walterl suggestion * Test fixes
* Remove extra is Co-authored-by:Walter Leibbrandt <23798+walterl@users.noreply.github.com>
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Paul Rosenzweig authored
This reverts commit c34fa2c0.
-
Cam Saul authored
-
Nemanja authored
-
Nemanja authored
-
Nemanja authored
-
Nemanja authored
-
Nemanja Glumac authored
-
- Apr 04, 2021
-
-
Luis Paolini authored
* Fix EE Dockerhub for once and for all * Try to overload the ARG attribute * Kick the CI
-
- Apr 02, 2021
-
-
Cam Saul authored
-
dpsutton authored
* Throw an error if a setting already exists ```clojure setting-test=> (defsetting site-name (deferred-tru "A testing setting") :visibility :public) Execution error (ExceptionInfo) at metabase.models.setting/register-setting! (setting.clj:464). Setting :site-name already registered in metabase.public-settings setting-test=> (pprint (ex-data *e)) {:existing-setting {:description "The name used for this instance of Metabase.", :cache? true, :default "Metabase", :name :site-name, :type :string, :sensitive? false, :tag java.lang.String, :namespace metabase.public-settings, :visibility :admin}} nil ``` * Tests in ci are run from user * Appease eastwood; don't shadow function `setting-name` this pattern is exactly what the helpful protocol does. i actually wanted to call that protocol but it throws an error if it doesn't exist which is a bit much for our purposes * Move namespace name into setting information
-
Paul Rosenzweig authored
-
Tim Macdonald authored
-
Jeff Evans authored
Only attempt to sync schemas that have some/any possible permissions Make syncable-schemas multimethod, whose base implementation is the same as the previous private fn Override syncable-schemas for Redshift to add a filtering step to the transducer pipeline to check for the schema privilege, by calling the HAS_SCHEMA_PRIVILEGE Redshift function to check for USAGE permission Making all-schemas function public since it's now invoked from the Redshift driver Fixing redshift-types-test to remove order flakiness Adding test that confirms that a real schemas with no permissions aren't synced
-
dpsutton authored
```clojure schema=> (->> (ns-publics 'metabase.mbql.schema) (keep (fn [[s v]] (:clause-form (meta v)))) (run! pprint)) [:not-null :field Field] [:interval :n s/Int :unit RelativeDatetimeUnit] [:regex-match-first :s StringExpressionArg :pattern s/Str] [:var :field-or-expression FieldOrExpressionDef] [:does-not-contain :field StringExpressionArg :string-or-field StringExpressionArg :options (optional StringFilterOptions)] [:= :field EqualityComparable :value-or-field EqualityComparable :more-values-or-fields (rest EqualityComparable)] [:log :x NumericExpressionArg] [:< :field OrderComparable :value-or-field OrderComparable] [:floor :x NumericExpressionArg] [:metric :metric-id (s/cond-pre helpers/IntGreaterThanZero helpers/NonBlankString)] [:ends-with :field StringExpressionArg :string-or-field StringExpressionArg :options (optional StringFilterOptions)] [:relative-datetime :n (s/cond-pre (s/eq :current) s/Int) :unit (optional RelativeDatetimeUnit)] [:sum :field-or-expression FieldOrExpressionDef] [:time-interval :field field :n (s/cond-pre s/Int (s/enum :current :last :next)) :unit RelativeDatetimeUnit :options (optional TimeIntervalOptions)] [:rtrim :s StringExpressionArg] [:ceil :x NumericExpressionArg] [:starts-with :field StringExpressionArg :string-or-field StringExpressionArg :options (optional StringFilterOptions)] [:<= :field OrderComparable :value-or-field OrderComparable] [:upper :s StringExpressionArg] [:* :x NumericExpressionArg :y NumericExpressionArg :more (rest NumericExpressionArg)] [:min :field-or-expression FieldOrExpressionDef] [:inside :lat-field OrderComparable :lon-field OrderComparable :lat-max OrderComparable :lon-min OrderComparable :lat-min OrderComparable :lon-max OrderComparable] [:ltrim :s StringExpressionArg] [:desc :field FieldOrAggregationReference] [:contains :field StringExpressionArg :string-or-field StringExpressionArg :options (optional StringFilterOptions)] [:expression :expression-name helpers/NonBlankString] [:is-empty :field Field] [:substring :s StringExpressionArg :start NumericExpressionArg :length (optional NumericExpressionArg)] [:stddev :field-or-expression FieldOrExpressionDef] [:> :field OrderComparable :value-or-field OrderComparable] [:replace :s StringExpressionArg :match s/Str :replacement s/Str] [:sqrt :x NumericExpressionArg] [:concat :a StringExpressionArg :b StringExpressionArg :more (rest StringExpressionArg)] [:count-where :pred Filter] [:- :x NumericExpressionArg :y NumericExpressionArgOrInterval :more (rest NumericExpressionArgOrInterval)] [:asc :field FieldOrAggregationReference] [:cum-count :field (optional Field)] [:value :value s/Any :type-info (s/maybe ValueTypeInfo)] [:or :first-clause (s/recursive #'Filter) :second-clause (s/recursive #'Filter) :other-clauses (rest (s/recursive #'Filter))] [:exp :x NumericExpressionArg] [:time :time (s/cond-pre java.time.LocalTime java.time.OffsetTime) :unit TimeUnit] [:between :field OrderComparable :min OrderComparable :max OrderComparable] [:sum-where :field-or-expression FieldOrExpressionDef :pred Filter] [:not :clause (s/recursive #'Filter)] [:cum-sum :field-or-expression FieldOrExpressionDef] [:coalesce :a ExpressionArg :b ExpressionArg :more (rest ExpressionArg)] [:is-null :field Field] [:/ :x NumericExpressionArg :y NumericExpressionArg :more (rest NumericExpressionArg)] [:>= :field OrderComparable :value-or-field OrderComparable] [:not-empty :field Field] [:distinct :field-or-expression FieldOrExpressionDef] [:percentile :field-or-expression FieldOrExpressionDef :percentile NumericExpressionArg] [:round :x NumericExpressionArg] [:power :x NumericExpressionArg :y NumericExpressionArg] [:aggregation-options :aggregation UnnamedAggregation :options AggregationOptions] [:+ :x NumericExpressionArg :y NumericExpressionArgOrInterval :more (rest NumericExpressionArgOrInterval)] [:abs :x NumericExpressionArg] [:median :field-or-expression FieldOrExpressionDef] [:share :pred Filter] [:case :clauses CaseClauses :options (optional CaseOptions)] [:segment :segment-id (s/cond-pre helpers/IntGreaterThanZero helpers/NonBlankString)] [:max :field-or-expression FieldOrExpressionDef] [:!= :field EqualityComparable :value-or-field EqualityComparable :more-values-or-fields (rest EqualityComparable)] [:count :field (optional Field)] [:lower :s StringExpressionArg] [:length :s StringExpressionArg] [:trim :s StringExpressionArg] [:and :first-clause (s/recursive #'Filter) :second-clause (s/recursive #'Filter) :other-clauses (rest (s/recursive #'Filter))] [:avg :field-or-expression FieldOrExpressionDef] [:aggregation :aggregation-clause-index s/Int] nil schema=> ```
-
Nemanja Glumac authored
-
Luis Paolini authored
* Add Kyrgyz Som to currency list * Show currency selector in Native Queries
-
Nemanja Glumac authored
* Switch the rule to "error" * Disable linting for `prop-types` in unit tests * Disable linting for `prop-types` in all affected files
-
Nemanja Glumac authored
* Upgrade Cypress to v6.8.0 (latest) * Fix failing test in CI * Fix the problem where Cypress does not render Nav bar locally More info: - https://www.eliostruyf.com/tests-running-iframe-cypress-e2e-tests/ - https://docs.cypress.io/faq/questions/using-cypress-faq#Is-there-any-way-to-detect-if-my-app-is-running-under-Cypress
-
Robert Roland authored
To address connection pools that go beyond the maxPoolSize of 15, reduce the maxIdleTimeExcessConnections so it'll start to pare back the pool towards minPoolSize sooner. See swaldman/c3p0#65 for an explanation. Resolves metabase/metabase#8679
-
Howon Lee authored
-