Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 09, 2022
  2. Feb 08, 2022
  3. Feb 07, 2022
  4. Feb 06, 2022
  5. Feb 05, 2022
  6. Feb 04, 2022
    • dpsutton's avatar
      Prevent flaky tests based on contents of TaskHistory (#20240) · b307a288
      dpsutton authored
      * Prevent flaky tests based on contents of TaskHistory
      
      Just check for subsets since we sometimes encounter fingerprint-fields
      and analyze information
      
      Output from CI:
      ```
      task_history_cleanup_test.clj:35
      Basic run of the cleanup task when it needs to remove rows. Should also add a TaskHistory row once complete
      expected: #{"task-history-cleanup"
                  "metabase.task.task-history-cleanup-test/task-3"
                  "metabase.task.task-history-cleanup-test/task-2"}
        actual: #{"classify-fields"
                  "analyze"
                  "fingerprint-fields"
                  "task-history-cleanup"
                  "metabase.task.task-history-cleanup-test/task-3"
                  "metabase.task.task-history-cleanup-test/task-2"}
          diff: + #{"classify-fields" "analyze" "fingerprint-fields"}
      ```
      
      * fix ns
      Unverified
      b307a288
    • chπ's avatar
    • Jeff Evans's avatar
      Retain property file path when revisiting database edit page (#20199) · 23f78db4
      Jeff Evans authored
      * Retain property file path when revisiting database edit page
      
      Ensuring that the file path (if that is the secret type) is returned via the API response to the admin, so the UX on the form edit page is better
      
      This involved a lot of refactoring to clean up some stuff:
      
      * removed the population of inferred secret properties (ex: last updated timestamp and creator ID) from `handle-db-details-secret-prop!`, since that stores those values into the details blob, defeating some of the purpose of normalizing secrets into a separate table
      * moved the logic for injecting such inferred values to a new function, `expand-inferred-secret-values`, which lives within the secret model namespace
      * delegating existing calls that require such expansion to the new function
      * adding a new helper function, `reduce-over-details-secret-values`, to handle some common logic that is now showing up in a few places (reducing over db-details on secret values and doing some kind of manipulation)
      
      Adding new database API test to ensure that the file path value is, in fact, returned from the API
      Unverified
      23f78db4
    • dpsutton's avatar
      Ignore hidden/archived tables cards and dashboards in recent list (#20238) · 977841b0
      dpsutton authored
      *** Code:
      - ignore hidden tables and archived cards/dashboards
      - correct docstring to indicate we are only getting 5 not 10 as
      previously claimed
      - in query, set limit to 8 in the case we get archived or non-existing
      things and then take 5 in memory
      - select extra properties from models that we need for this
      determination
      
      *** Tests:
      - for mysql we were inserting views with a thread/sleep of one second
      between each. Just compute timestamps seconds apart and do them all at
      once. Should save 7 seconds off mysql test runs. verified temporal
      spacing works with
      
      ```
       MB_DB_CONNECTION_URI="mysql://username:password@localhost:3306/cli" \
       clj -X:dev:test :only metabase.api.activity-test
      ```
      - cleanup these activities we were creating with `mt/with-model-cleanup`
      which introduces a big looking diff. But checking diff with whitespace
      shows its just an indentation and then add the extra keys needed for
      identifying which are archived (:archived and :visibility_type for cards
      and tables respectively)
      Unverified
      977841b0
    • Dalton's avatar
      Hide pin action button when user can't pin (#20272) · f2ce41a0
      Dalton authored
      * Hide pin action button when user can't pin
      
      * unskip repro
      
      * add a new boolean
      Unverified
      f2ce41a0
    • Dalton's avatar
    • Anton Kulyk's avatar
      Allow to unmap native model column from a real one (#20219) · b0b8bc80
      Anton Kulyk authored
      * Add clear behavior to `SelectButton`
      
      * Removed redundant type
      
      * Allow unmapping model column from a real one
      Unverified
      b0b8bc80
Loading