This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 24, 2023
-
-
Nemanja Glumac authored
-
- Feb 23, 2023
-
-
Gustavo Saiani authored
-
Nemanja Glumac authored
-
Ryan Laurie authored
* add basic implicit action e2e tests * DRY up the actions tests
-
Aleksandr Lesnenko authored
-
Case Nelson authored
-
Jeff Bruemmer authored
-
Ryan Laurie authored
-
Case Nelson authored
Fixes #22872 In #21839, all order-bys were removed from pivot queries because columns in `ORDER BY` had to appear in `GROUP BY` clauses. Unfortunately that removed legal order by columns (e.g. count) from being applied. This now keeps aggregation columns in field defs to restore the sorting behaviour.
-
Nemanja Glumac authored
[ci skip]
-
Ryan Laurie authored
-
Cam Saul authored
* Snowflake Honey SQL 2 * Test fix
* Use Honey SQL 2 for GTAP compilation in sandboxing tests * Test fix -
Noah Moss authored
* new clojure migration for v1->v2 permissions * updates * fix rebase issue * fix reflection warning * fix final test and address comment about macro name * fix indentation * revert changes to defmigration macro to try to fix final test
-
Ryan Laurie authored
-
Cal Herries authored
* Decouple checking ddl from classifying h2 stmts - should enable followup for easily blocking more kinds of queries - check all statements to make sure they aren't "ddl". * fix classify-query * linter fixes + get-field refactor * return the CommandInterface values as ints Reach into the CommandList when needed * docstring wording * catch invalid queries -- they can't be classified * Remove action subtypes from inlined-models * Add ddl check for `execute-write-query!` * Remove ACCESS_MODE_DATA * Check queries are single select statements * Add test for sample database privileges * Fix single-select check * Add single-select test * Rename and add more tests for checking read only commands * commands -> statements * Fix check-disallow-ddl-commands * new line * Add more read-only statements to the tests * Update error text * Use are * Add integration test for executing actions with disallowed commands * Add test before inserting row * Run GRANT ALL ON SCHEMA "PUBLIC" TO GUEST * Restore classify-query * whitespace --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Alexander Polyankin authored
-
Tim Macdonald authored
* Make LinkViz search test more robust It was flaking on CI due to the race described in the comment * More sensible implementation courtesy of AlexP
-
Ngoc Khuat authored
* add logics to skip generate subscription contents for link cards and actions
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Limit the number of results for better performance * Set the viewport dimensions in the test config This prevents window resizing and reduces or completely removes the flake, which was Cypress complaining that the icon "pencil" is still animating when it tries to click on it. https://docs.cypress.io/guides/references/error-messages#cy-failed-because-the-element-is-currently-animating * Fix test titles to match the assertion * Remove suprefluous search for a string * Use `editDashboard` helper
-
Tim Macdonald authored
* Add `model_id` to action search results so that URLs can be made [Fixes #28565] * Fix typo in Cypress filename
-
Ngoc Khuat authored
* set action.model_id to cascade on delete * add rollback
-
Jeff Bruemmer authored
-
Anton Kulyk authored
* Clean up tests * Improve popover a11y * Allow testing sequenced setting changes * Fix `NaN` being a default numeric parameter value * Allow no default value
-
Anton Kulyk authored
-
Anton Kulyk authored
* Update empty state * Clean up layout * Bring back sticky headers
-
Anton Kulyk authored
* Move `ace` element ID to constants * Close ace popover before opening the save modal * Change name * Workaround type warning
-
Anton Kulyk authored
* Wrap things with `useMemo` and `useCallback` * Hide dbs without actions if `requireWriteback` * Add e2e check
-
Alexander Polyankin authored
-
Case Nelson authored
* Strip semicolons from card refs in native queries Fixes #28218 While source-query substitution handled semicolons in native questions within outer mbql queries, we used a different code path when splicing into native queries. This brings the two paths inline. * Reference issue in testing * Add docstring
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
Case Nelson authored
* Convert sqlite driver to honey-sql-2 * Fix bad case statement * We can't run native queries with AS for oracle * Dont call ->honeysql on a honeysql-expr * Fix bad call to h2x * Identifier needs to be wrapped * Update kondo config * Fix test * Remove hformat fn handler * Rotate the Snowflake DB prefix AGAIN * `sql.qp/format-honeysql` needs to wrap stuff in parens when generating SQL snippets * Update tests to match new expected SQL format * Sort namespaces * Fix the flaky paging test * Fix flaky `metabase.query-processor-test.timezones-test/filter-datetime-by-date-in-timezone-test` * MySQL test fix
* Try running Redshift with a beefier runner --------- Co-authored-by:Cam Saul <github@camsaul.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
- Feb 22, 2023
-
-
Case Nelson authored
Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by:
Cam Saul <github@camsaul.com>
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
-
Nick Fitzpatrick authored
* behavior logic * restructure Chart Settings HTML * adjusting e2e tests * adjusting unit tests * Removing pivot-grouping column when checking isSensible * fixing footer button sizing, unit test * adjusting e2e tests
-
Jeff Bruemmer authored
[ci skip]
-
Luis Paolini authored
-
Jeff Bruemmer authored
-