Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 13, 2023
  2. Mar 30, 2023
  3. Mar 28, 2023
  4. Mar 21, 2023
  5. Mar 20, 2023
  6. Mar 13, 2023
  7. Mar 08, 2023
    • dpsutton's avatar
      Fix flaky json test (#29048) · fd5bd5e0
      dpsutton authored
      Occasionally in CI we get
      
      ```
      “Syntax error compiling at (release/version_info_test.clj:46:26).\nNo such var: json/read-json\n”,
      ```
      
      from `release.version-info-test`.
      This namespace requires `[clojure.data.json :as json]` and uses the
      function `json/read-json` which is deprecated since version 2.x.
      
      The way that deprecated function is defined in version 2.0.2 is
      
      ```clojure
      (ns clojure.data.json)
      ...
      (load "json_compat_0_1")
      ```
      
      and in `clojure/data/json_compat_0_1.clj`:
      
      ```clojure
      (in-ns 'clojure.data.json)
      
      (defn read-json
        "DEPRECATED; replaced by read-str.
        ...)
      ```
      
      And I guess the way that hawk requires some namespaces we can get into
      this half loaded, half not finished state and the var is not (yet)
      defined.
      
      So we can just put aside this nonsense and use a non-deprecated var that
      isn't defined with a `load` statement but in the regular namespace we
      require.
      Unverified
      fd5bd5e0
  8. Mar 07, 2023
    • dpsutton's avatar
      Update tools.build and usage (#28977) · b549b291
      dpsutton authored
      Calling our basis function with just :oss or :ee we don't end up with an
      `:argmap` key.
      
      ```clojure
      uberjar=> (def basis (create-basis :oss))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      nil          ;; nothing extra in oss
      
      uberjar=> (def basis (create-basis :ee))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      {:extra-paths ["enterprise/backend/src"]}
      
      ;; and if other aliases are used:
      uberjar=> (def basis' (b/create-basis {:project "deps.edn" :aliases [:dev :test]}))
      ,#'build.uberjar/basis'
      uberjar=> (:argmap basis')
      {:extra-deps {lambdaisland/deep-diff2 {:mvn/version "2.7.169"},
                    methodical/methodical {:mvn/version "0.15.1"},
                    io.github.metabase/hawk {:sha
                    "45ed36008014f9ac1ea66beb56fb1c4c39f8342b"},
                    ....}
       :extra-paths ["dev/src"...]
       :jvm-opts ["-Dmb.run.mode=dev" ...]
       :exec-fn metabase.test-runner/find-and-run-tests-cli}
      ```
      Unverified
      b549b291
  9. Mar 01, 2023
  10. Feb 27, 2023
  11. Feb 23, 2023
  12. Feb 21, 2023
    • dpsutton's avatar
      Custom migrations (#28175) · 30e731e3
      dpsutton authored
      
      * Custom migrations
      
      Current syntax:
      
      specify the migration with
      ```
        - changeSet:
            id: v46.00-080
            author: dpsutton
            comment: Uppercases all Card names
            changes:
              - customChange:
                  class: "metabase.db.custom_migrations.ReversibleUppercaseCards"
      ```
      
      and in the new namespace metabase.db.custom-migrations:
      
      ```clojure
      (defmigration UppercaseCards
        (db/execute! {:update :report_card
                      :set    {:name :%upper.name}}))
      
      (def-reversible-migration ReversibleUppercaseCards
        (db/execute! {:update :report_card
                      :set    {:name :%upper.name}})
        (db/execute! {:update :report_card
                      :set    {:name :%lower.name}}))
      ```
      
      * Use db provided by liquibase
      
      * edit docstring
      
      * set *warn-on-reflection* to fix lint error & rebase
      
      ---------
      
      Co-authored-by: default avatarNoah Moss <noahbmoss@gmail.com>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      Unverified
      30e731e3
    • Nemanja Glumac's avatar
      Fix and expand `verify-doc-links` logic (#28482) · 309b8e0a
      Nemanja Glumac authored
      * Expand the glob to include TS(X) files
      
      * Use console error
      
      * Re-order imports
      
      * Print the missing files in red
      
      * Fix glob pattern
      
      * Add script to pre-commit hooks
      
      * Remove the check from CI
      Unverified
      309b8e0a
  13. Feb 20, 2023
  14. Feb 17, 2023
  15. Feb 09, 2023
  16. Feb 08, 2023
  17. Jan 27, 2023
  18. Jan 23, 2023
  19. Dec 29, 2022
  20. Dec 21, 2022
    • john-metabase's avatar
      Start-of-cycle 46 basic dependency version bump (#27332) · 704a1c54
      john-metabase authored
      * Start-of-cycle 46 basic dependency version bump
      
      Some dependencies with available major version bumps are only updated
      to the latest minor version of the current major version. Some
      additional dependencies will be updated in future PRs.
      
      * Removes commons-lang from sparksql deps exceptions
      
      * Fixes MongoDB SRV test for monger 3.6.0
      
      * fixes SQLite datetime tests for new driver version 3.40
      Unverified
      704a1c54
  21. Dec 15, 2022
  22. Dec 11, 2022
  23. Dec 09, 2022
    • Cam Saul's avatar
      Make Dimension unique on `field_id` and deduplicate (#27062) · 622558a1
      Cam Saul authored
      * Make Dimension unique on `field_id` and deduplicate
      
      * Fix rollback for new migrations
      
      * Don't require migration comments to contain 'added' anymore since it's part of the version ID now
      
      * Don't require 'Added <version>' in migration comments anymore
      
      * Fix SerDes test that created duplicate dimensions for one Field
      
      * Silly fix to fix MySQL 5.7
      Unverified
      622558a1
  24. Dec 08, 2022
    • Cam Saul's avatar
      Add `=?` test expression type (#23982) · 43236c0a
      Cam Saul authored
      
      * ≈ [WIP] [ci skip]
      
      * Minor cleanup [ci skip]
      
      * Code cleanup. [ci skip]
      
      * Kondo in CI should fetch library configs
      
      * Bump Methodical version
      
      * Change name to `=?`
      
      * Add `#exactly` reader tag
      
      * Add `#schema` data reader
      
      * Fix dev deps indentation and add `algo.generic`
      
      * Add `approx=`
      
      * Improved version of `#approx`
      
      * Just check in third party Kondo config for now instead of fighting CI
      
      * Update test/metabase/test_runner/assert_exprs/approximately_equal_test.clj
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      * Address PR feedback and fix sequence comparison
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      Unverified
      43236c0a
  25. Nov 30, 2022
  26. Nov 29, 2022
    • Cam Saul's avatar
      Athena driver (#26301) · a32bb77b
      Cam Saul authored
      * Include Amazon Athena support for dacort/metabase-athena-driver
      
      * Use Metabase Maven repo to fetch Athena driver
      
      * Copy test extensions from Damon's Athena driver repo
      
      * Some code cleanup.
      
      * Move namespaces => metabase.driver.athena
      
      * Clean up the test extensions namespace
      
      * 42 failures, 16 errors
      
      * Fix regex support; disable a few tests
      
      * Minor tweaks
      
      * Fix data-source-name
      
      * Fix :week and :day-of-week impls (mostly): 2 failures, 3 errors
      
      * Fix OFFSET, :week-of-year; skip test that has TIME column
      
      * Add Athena to CircleCI config. Don't wait for Java 11 tests to finish before driver tests.
      
      * ALL TESTS ARE PASSING! <3
      
      * Copy fixes for https://github.com/dacort/metabase-athena-driver/issues/115;
      
       add test
      
      * We don't need to prep source files or fetch dependencies before running backend tests.
      
      * Fix Eastwood error.
      
      * Tweak CircleCI config.
      
      * Fix TIMESTAMP WITH TIME ZONE
      
      * Include the Athena/Redshift repos in the build-drivers deps.edn
      
      * Build and release scripts need to have the :mvn/repos as well
      
      * Revert change that enabled test for Presto
      
      * Un-enable failing test for Snowflake as well.
      
      * moves all is clauses into the test
      
      - previously only the first few tests were being run
      
      * Sort ns in `metabase.driver.athena-test`
      
      * Prevent athena's log4j2.properties file from becoming log config
      
      athena includes log4j2.properties top-level with the properties:
      
      ```
      status = debug
      rootLogger.level=debug
      ```
      
      And this kills our beautifully crafted logging. Set
      "log4j2.configurationFile" in bootstrap to our own log4j2.xml.
      
      Log4j2 looks in a few places for its logging config, the first of which
      is the properties file. So when the jar is loaded, log4j2 considers this
      a logging config change and we lose our logging.
      
      Co-authored-by: default avatarDamon P. Cortesi <d.lifehacker@gmail.com>
      Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      a32bb77b
    • Luis Paolini's avatar
  27. Nov 28, 2022
  28. Nov 08, 2022
  29. Oct 20, 2022
  30. Oct 17, 2022
  31. Sep 27, 2022
  32. Sep 22, 2022
  33. Aug 22, 2022
  34. Aug 03, 2022
Loading