This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 08, 2024
-
-
Raphael Krut-Landau authored
This PR * mocks audit requests in tests of `DashboardInfoSidebar` and `QuestionInfoSidebar` (these tests were flaking) * introduces a helper, `setupAuditEndpoints`, to facilitate this in the future * uses the helper in one other place where audit requests were getting mocked
-
Nicolò Pretto authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Phoomparin Mano authored
-
Cam Saul authored
* Parallel driver tests PoC * Set fail-fast to false for now * Try splitting up non-driver tests to see how broken tests are * Whoops fix plain BE tests * Ok nvm I'll test this in another branch * Fix fail-fast * Experiment with the improved Hawk split logic * Fix some broken/flaky tests * Experiment: try splitting MySQL 8 tests into FOUR jobs * Divide other Postgres and MySQL tests up and use num-partitions = 2 * Another test fix
* Flaky test fix * Try making more stuff fast * Make athena fast?? * Fix a few more things * Test fixes? * Fix configs * Fix Mongo job syntax * Fix busted test from #46942 * Fix Mongo config again * wait-for-port needs to specify shell I guess * More cleanup * await-port can't have a timeout-minutes I guess * Let's only parallelize MySQL for now. * Cleanup action * Cleanup wait-for-port action * Fix another flaky test * NOW driver tests will be FAST * Need to mark driver tests too * Fix wrong tag * Use Hawk 1.0.5 * Fix busted metabase.public-settings-test/landing-page-setting-test * Fix busted `metabase.api.database-test/get-database-test` etc. (hopefully) * Fix busted `metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test` for Oracle * Maybe this fixed `metabase.query-processor.middleware.permissions-test/e2e-ignore-user-supplied-perms-test` maybe not * Fix busted metabase.api.dashboard-test/dependent-metadata-test because endpoint had differemt sort order than test * Ok my test fix did not work * Fix metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test for Redshift * Better test name * More test fixes * Schema fix * PR feedback * Split off test partitioning into separate PR * Fix failing Oracle tests * Another round of test fixes, hopefully * Fix failing Redshift tests * Maybe the last round of test fixes * Fix Oracle * Fix stray line
-
- Oct 07, 2024
-
-
metamben authored
Implement better partitioning and sorting in window functions
-
Case Nelson authored
* feat: move auth providers behind ee token Fixes #48235 Introduces new premium feature `database-auth-providers`. Moves fetch-auth behind defenterprise - oss will always return an empty map. Add metabase.util.http to test outbound http requests. * Fix broken refs * Drop defmethod as adhoc overrides aren't desirable outside ee * Drop unessary require * Fix token and tests * Fix tests * Fix formatting * Fix var cast exception * Fix connection test * Move test to ee namespace * Move more tests behind enterprise * Fix checked-section hiding
-
Ryan Laurie authored
* look I did a clojure! * only show entity ids when serialization is enabled * update tests * ok fine typescript * fix test
-
- Oct 05, 2024
-
-
Raphael Krut-Landau authored
-
- Oct 03, 2024
-
-
Nicolò Pretto authored
* wip locale header middleware * wip fe code for the locale provider for both public/static and sdk * clean up code * move api.baseurl assignment outside of useEffect to make it work on first render * e2e test for locale * Revert "wip locale header middleware" This reverts commit c215eac3. * remove public/static code as we want to focus on the sdk * adds docs for `X-Metabase-Locale` header and for why we don't use I18NApi.locale * Update frontend/src/metabase/lib/api.js * doc: explain why we have the unused state
-
- Oct 02, 2024
-
-
github-automation-metabase authored
-
Alberto Perdomo authored
* Improvements to SDK readme * Add live demo site to SDK readme * Remove suggested workarounds for SSR * Use - for bullets for consistency * Remove Loom * Update enterprise/frontend/src/embedding-sdk/README.md Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Nicolò Pretto authored
* fix(sdk): fix zindex issues after switch to portals * Target portal to a different root than popovers and co --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Oct 01, 2024
-
-
Nicolò Pretto authored
* fix(sdk): modal pushing content below when opened * render the portal below the content so we don't need the zIndex Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Uladzimir Havenchyk authored
* add eslint plugin for storybook * fixup * fixup * fixup
-
Noah Moss authored
-
Romeo Van Snick authored
* Simplify browse components imports * Move metrics-related browse components to separate folder * Move models related browse components to separate subdir * Split up browse/test-utils * Move schemas related browse code to separate folder * Move databases related browse code to separate folder * Move tables related browse code to separate folder * Fix import paths * Avoid drilling into metric module * Avoid drilling into models module * Move enterprise tests for browse models * Format comments * Remove unused sortModelsByVerification plugin helper * Support skipToken in useFetchModels * Simplify models content verification * Fix filter button query * Do not filter recent models if there are no verified models * Use filterButton helper everywhere * Fixup comment * Use new var-style color
-
Nicolò Pretto authored
-
- Sep 30, 2024
-
-
Luiz Arakaki authored
* rename usage analytics and few fixes * update e2e tests * update some other strings too --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Uladzimir Havenchyk authored
* refactor: rework stories from MDX to MDX + CSF * short syntax * fix or bypass typescript errors * fix leftovers * cleanup leftovers * convert js stories to tsx * restore some comments * fix linting
-
- Sep 27, 2024
-
-
Braden Shepherdson authored
This was old logic to support certain drivers (eg. pre-JDBC Druid) and isn't required for most. It's perfectly sound to filter or even break out on a datetime column without bucketing. Adds a new `:temporal/requires-default-unit` driver feature, and enables it only for the legacy Druid driver. Fixes #47341
-
Nicolò Pretto authored
-
- Sep 26, 2024
-
-
Nicolò Pretto authored
* IS_EMBEDDING_SDK_BUILD -> IS_EMBEDDING_SDK to keep things simple, as we already have that name in other places * don't load metabase css in sdk stories * first two stories * make the store not a global "singleton" anymore * basic test for font-family styles in the SDK * allow any custom font in theme.fontFamily as we actually support it * fix tests using hardcoded default font family
-
lbrdnk authored
* Databricks JDBC driver base * Add databricks CI job * WIP data loading -- it works, further cleanup needed * Cleanup * Implement ->honeysql to enable data loading * Hardcode catalog job var * Implement driver methods and update tests * Derive hive instead of sql-jdbc * Cleanup leftovers after deriving hive * Run databricks tests on push * Cleanp and enable set-timezone * Disable database creation by tests * Add Databricks to broken drivers for timezone tests * Exclude Databricks from test * Enable have-select-privilege?-test * Restore sql-jdbc-drivers-using-default-describe-table-or-fields-impl post rebase * Restore joined-date-filter-test * Adjust to work with dataset definition tests * Adjust alternative date tests * Remove leftover reflecttion warning set * Update test exts * cljfmt vscode * Add databricks to kondo drivers * Update metabase-plugin.yaml * Update databricks_jdbc.clj * Rework test extensions * Update general data loading code to work with Databricks * Reset tests to orig * Use DateTimeWithLocalTZ for TIMESTAMP database type * Convert to LocalDateTime for set-parameter * Update test extensions field-base-type->sql-tyoe * Update database-type->base-type * Enable creation of time columns in test data even though not supported * Fix typo * Update tests * Udpate tests * Update drivers.yml * Disable dynamic dataset loading tests * Adjust the iso-8601-text-fields-should-be-queryable-date-test * Update load-data/row-xform * Add time type exception to test * Update test data loading and enable test * Whitespace * Enable all driver jobs * Update comment * Make catalog mandatory * Remove comment * Remove log level from spec generation * Update sql.qp/datetime-diff * Update read-column-thunk * Remove comment * Simplify date-time->results-local-date-time * Update comment * Move definitions * Update test extension types mapping * Remove now obsolete ddl/insert-rows-honeysql-form implementation * Update sql-jdbc.conn/connection-details->spec for perturb-db-details * Update load-data/do-insert! * Remove ssh tunnel from driver as tests do not work with it * Update test * Promote ::dynamic-dataset-loading to :test/dynamic-dataset-loading and modify corresponding tests * Adjust to broken TIMESTAMP_NTZ sync * Update read-column-thunk to return timestamps always in Z * Comment * Disable tests for dynamic datasets * Return spark jobs into drivers.yml * Update Databricks CI catalog * Remove vscode cljfmt tweak * Update iso-8601-text-fields-expected-rows * Update datetime-diff * Formatting * cljfmt * Add placeholder test * Remove comment * cljfmt * Use EnableArrow=0 connection param * Remove comment * Comment * Update tests * cljfmt * Update driver's deps.edn * Update tests * Implement alternative `describe-table` * WIP Workaround for timestamp_ntz sync, will be thrown away probably * Update metabase-plugin.yaml with schema filters * Update driver to use schema filters and remove now redundant sync implemnetations * Update tests * Update tests extensions * Update test * Add feature flags for fast sync * Implement describe-fields * Implement describe-fks-sql * Enable fast sync features * Use full_data_type * Comment * Add exception for timestamp_ntz columns to new sync code * Implement db-default-timezone * Add timestamp_ntz ignored test * Add db-default-timezone-test * Fix typo * Update setReadOnly * Add comment on setAutoCommit * Update chunk-size * Add timezone-in-set-and-read-functions-test * Drop Athena from driver exceptions * Use set/intersection instead of a filter * Add explicit fast-sync tests * Update describe-fields-sql and add comment * Add preprocess-additional-options * Add leading semicolon test * Disable dataset creation and update comment * Rename driver to `databricks` * Use old secret names * Fix wrongly copied hsql list * Temporarily allow database creation * Add *allow-database-deletion* * Temporarily allow database creation * Disable database creation * cljfmt * cljfmt
-
Oisin Coveney authored
-
- Sep 25, 2024
-
-
Noah Moss authored
Co-authored-by:
Thomas Schmidt <thomas@metabase.com>
-
John Swanson authored
* Require `:encryption` for string settings For settings that are not typed as JSON, CSV, or strings, encryption now defaults to `:no` (*except* if you have explicitly marked your setting as `:sensitive?` - these will default to `:when-encryption-key-set`). I went through all our settings and provided what I think are reasonable values here. I tried to be conservative - when I wasn't sure whether a stored setting was sensitive, I kept it as encrypted. For example, the `ldap-port` setting is probably non-sensitive but theoretically someone could be using a weird port for security-by-obscurity, so I kept that encrypted. * Change possible values for `:encryption` `:maybe` was confusing: let's be more explicit that the value will be encrypted `:when-encryption-key-set` to make it obvious what actually turns encryption on and off.
-
Nick Fitzpatrick authored
* test with disabled query analysis and feature disabled in token * types * useSetting
-
Oisin Coveney authored
-
Oisin Coveney authored
-
- Sep 24, 2024
-
-
Romeo Van Snick authored
* Support skipToken in useFetchMetrics * WIP * Add user setting for verified metrics * Add verified metrics to the VERIFIED_CONTENT plugin * Use metric plugins for verified metrics * Move helpers down * Do not filter for verified metrics if there are none, regardless of user setting * Add label to filter button * Revalidate search when card gets (un-)verified * Add e2e test for verified metrics * Avoid checking for verified metrics on when content-verification is not enabled * Fix broken test * Simplify content verification plugin structure for metrics * Add content moderation types and API helpers * Update content moderation plugin to make use of the moderation api in metabase/api * Fix lint * Fix missing list tag * Store verified metric filter preference * Move all helpers to the bottom * Ensure the user setting gets updated when chaning the filter * Add comment about component similarity * Undo changes to embedding-sdk
-
Chris Truter authored
-
Ryan Laurie authored
* create dashboard settings sidebar * update e2e tests fix * only show settings to dashboard editors * update copy * update e2e test * fix types * update tests for new copy * fix import
-
Ryan Laurie authored
* size and padding fixes * linkify and align stuff in question details * reorganize and divide question overflow menu * hide history for analytics content * fix verification icon alignment * whoopsie lets commit all the files * fix css file name
-
- Sep 20, 2024
-
-
Chris Truter authored
* Return the table id from csv upload (as a header) * Add date format that google sheets uses * Smuggle id * done? * comment * with empty h2 db * dashing * fix flaky test * Parse the correct date class --------- Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
- Sep 13, 2024
-
-
Phoomparin Mano authored
* add license problem hook * add warning banner * style cue component * update cue component * report issue to console * report issue to console * use sdk loader for pre-initialization * extract print problem method * use non-standard shadows * add unit tests * prevent console log spam during tests * mock the embedding token feature * mock the embedding token feature by default * add more test cases * add test case * add test cases * increase popover z-index * simplify test setup * simplify test setup * do not load individual component when a license error happens * move SdkLicenseProblemDisplay component out * replace colors with color-mix * replace colors with color-mix * make the text unthemed to ensure legibility * hard-code colors to prevent them from being themed * hard-code colors to prevent them from being themed * update border styles * make the chevron unthemed * unset console text color * only set stroke on errors * optimistic query settings * document the sdk license condition * remove redundant condition * add notes on api keys always being allowed on localhost * move the no auth method message to warning component * rename sdk license problem to usage problem * add eslint rule for stories * rename sdk license problem to usage problem * move sdk usage problem display out of the init controller * specify fallback font if instance is down or CORS error * add comments on conditions pending on the CORS PR * add notes on non-localhost checks * make test ids constant * add test case for neither provided * fix types * address code reviews * pass `embedding-sdk` flag in `token-features` * address code review Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * remove appName from console logs * rename embedding-sdk to embedding_sdk * add the embedding_sdk premium token feature * do not setup enterprise plugin in sdk test * do not localize visual cue messages * fix unit test in setup-sdk-auth * rename tests * remove unused eslint-disable * enable embedding_sdk premium feature for sdk unit tests * revert security_test.clj to use embedding instead of embedding-sdk * remove unneeded test * changes to support the style leak fixes --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Nicolò Pretto authored
* first iteration to scope sdk styles to our components * basic css reset for buttons * clean up duplicated css * make sdk components use instance font if no font is passed * cleanin up and remove defaultProps not needed * fix tests * adds EMBEDDING_SDK_PORTAL_CONTAINER_ELEMENT_ID * Update enterprise/frontend/src/embedding-sdk/components/public/MetabaseProvider.tsx * Update enterprise/frontend/src/embedding-sdk/components/public/MetabaseProvider.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * fix import * prettier --write * we don't need theme.fontFamily, added a comment * rename EMBEDDING_SDK_PORTAL_CONTAINER_ELEMENT_ID to EMBEDDING_SDK_PORTAL_ROOT_ELEMENT_ID * fix unit test --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Ryan Laurie authored
* Dashboard Info Sidebar * e2e test updates * add unit tests * e2e test updates * fix e2e tests * fix more e2e tests * update back behavior
-
Alexander Solovyov authored
so we need to account for that in serialization paths, storage paths and when exporting/importing foreign keys
-
- Sep 12, 2024
-
-
Ryan Laurie authored
* remove more metabse settings * fix missing update for latest version check * test updates * fix setting selectors
-
Phoomparin Mano authored
* remove the unknown premium feature warning * remove ee-plugins from sdk * remove ee-overrides from sdk
-