Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 15, 2021
  2. Feb 13, 2021
  3. Feb 12, 2021
  4. Feb 11, 2021
  5. Feb 10, 2021
  6. Feb 09, 2021
    • Cam Saul's avatar
      Make sure field refs returned by sandboxing middleware match non-sandboxed field refs (#14719) · 1b382854
      Cam Saul authored
      * Quick sync
      
      * Try reducing -Xmx for :ci profile a bit to prevent random test failures
      
      * Reenable test
      
      * Query results metadata should include field refs (Fixes #10474)
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Try unskipping some EE tests, let's see what gets fixed
      
      * Try lowering heap size limits on CI a bit to see if things will actually run.
      
      * Test fix
      
      * Re-skip 13641 and 13642 tests
      
      * Make sure resolve-joined-fields works on all levels (fixes #13642)
      
      * Fix missing :require
      
      * Remove logging
      
      * Re-enable test
      
      * Add ->$ids and ->query-shorthand test util macros
      
      * Fix 13641
      
      * Text fix
      
      * Revert changes to backend.js
      
      * Test fixes :wrench:
      
      * Remove stray printlns
      
      * Test fix :wrench:
      
      * Fix saving a Card, add test
      
      * Fix saving a Card, add test
      
      * Test fix for non-H2 drivers
      
      * Test fixes :wrench:
      
      * Revert accidental commit of experimental test macros
      
      * Fix occasional test failure :wrench:
      
      * Fix occasional test failures with metabase.api.dataset-test/basic-test
      
      * Fix occasional test failure :wrench:
      
      * Another driver test fix :wrench:
      
      * Re-enable test for #14724
      
      * Extract remap logic into a separate function
      
      * Run repro for #13642 in 2 versions: "remapped" and "default"
      
      * Update repro for #14724
      
      * Run repro for #13641 in 2 versions: "remapped" and "default"
      
      * Fix 13642 with FK remaps in place
      
      * Test fix :wrench:
      
      
      
      Co-authored-by: default avatarNemanja <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      1b382854
    • Cam Saul's avatar
      Make sure resolve-joined-fields works on all levels (fixes #13642) (#14717) · 90595bb2
      Cam Saul authored
      * Quick sync
      
      * Try reducing -Xmx for :ci profile a bit to prevent random test failures
      
      * Reenable test
      
      * Query results metadata should include field refs (Fixes #10474)
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Try unskipping some EE tests, let's see what gets fixed
      
      * Try lowering heap size limits on CI a bit to see if things will actually run.
      
      * Test fix
      
      * Re-skip 13641 and 13642 tests
      
      * Make sure resolve-joined-fields works on all levels (fixes #13642)
      
      * Fix missing :require
      
      * Remove logging
      
      * Text fix
      
      * Revert changes to backend.js
      
      * Test fixes :wrench:
      
      * Remove stray printlns
      
      * Test fix :wrench:
      
      * Fix saving a Card, add test
      
      * Fix saving a Card, add test
      
      * Test fix for non-H2 drivers
      
      * Fix occasional test failures with metabase.api.dataset-test/basic-test
      
      * Fix occasional test failure :wrench:
      
      * Another driver test fix :wrench:
      
      * Extract remap logic into a separate function
      
      * Run repro for #13642 in 2 versions: "remapped" and "default"
      
      * Fix 13642 with FK remaps in place
      
      * Test fix :wrench:
      
      
      
      Co-authored-by: default avatarNemanja <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      90595bb2
    • dpsutton's avatar
      Mb db connection uri parsing (#14716) · b779333f
      dpsutton authored
      * Parse mb-db-connection-uri when it contains a password
      
      Using the raw jdbc string when its of the form
      `username:password@host:port` causes problems if passed directly to
      jdbc. Clojure.java.jdbc has some special handling for username and
      passwords
      
      ```clojure
      (if-let [user-info (.getUserInfo uri)]
        {:user (first (str/split user-info #":"))
         :password (second (str/split user-info #":"))})
      ```
      
      Our logic here is:
      1. if mb-db-connection-uri is set and not an older style password,
      return that, possibly prepending jdbc: to it
      2. if mb-db-connection-uri is set and is an older style passowrd, then
      we use the old parsing code which doesn't support all of the crazy
      stuff individual connection strings may offer and return a db-spec
      3. if all the individual parts are supplied (mb-db-host, mb-db-port,
      etc) are used to construct a db-spec
      
      * Correct what old style means for conn-uri
      
      accidentally thought user@host/metabase?password=password was ok. Any
      credentially in the host spot is not supported
      
      * Cleanup documentation
      
      don't refer to old password style but call it inline credentials
      
      * Fixups for connection parsing
      
      - ensure we turn postgres: to postgresql: in connection string
      - ensure we warn about postgres ssl edge case when using raw
        connection string
      - make warnings testable
      
      * Space in inline credentials warning
      
      * Strip jdbc from connection when checking if inline credentials
      
      * Fix for old credential style
      Unverified
      b779333f
    • Cam Saul's avatar
      Use log instead of printf/println for copy (#14692) · 9c3cb39e
      Cam Saul authored
      * Use log instead of printf/println for copy
      
      * Use log/warn for the message about H2 database already existing
      
      * Remove compare-h2-dbs -main entrypoint
      
      * Clean namespace decl
      
      * Feedback from @walterl
      
      * Fix occasional test failures with metabase.api.dataset-test/basic-test
      
      * Fix occasional test failure :wrench:
      Unverified
      9c3cb39e
    • Nemanja Glumac's avatar
    • Cam Saul's avatar
      Query results metadata should include field refs (#14695) · a20f9370
      Cam Saul authored
      * Quick sync
      
      * Try reducing -Xmx for :ci profile a bit to prevent random test failures
      
      * Reenable test
      
      * Query results metadata should include field refs (Fixes #10474)
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Try unskipping some EE tests, let's see what gets fixed
      
      * Try lowering heap size limits on CI a bit to see if things will actually run.
      
      * Test fix
      
      * Re-skip 13641 and 13642 tests
      
      * Revert changes to backend.js
      
      * Fix saving a Card, add test
      Unverified
      a20f9370
    • Nemanja Glumac's avatar
      #14726 Repro: Custom filter expression does not show original editor on... · bf754e31
      Nemanja Glumac authored
      #14726 Repro: Custom filter expression does not show original editor on subsequent click [ci skip] (#14728)
      
      Unverified
      bf754e31
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
      #14649 Repro: Cannot add subsequent aggregation on a custom expression in... · d3705748
      Nemanja Glumac authored
      #14649 Repro: Cannot add subsequent aggregation on a custom expression in notebook (#14723) [ci skip]
      
      Unverified
      d3705748
    • Raimon Grau's avatar
    • Paul Rosenzweig's avatar
      unskip repro for 13415 (#14715) · 1c048e54
      Paul Rosenzweig authored
      Unverified
      1c048e54
    • Paul Rosenzweig's avatar
Loading