This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 06, 2024
-
-
Noah Moss authored
-
Alexander Solovyov authored
previously import would return 200 w/o regard if it was successful or not fixes #49602
-
Ngoc Khuat authored
-
- Nov 05, 2024
-
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
- Nov 01, 2024
-
-
Nick Fitzpatrick authored
* Adding moderation status to Dashboards * react sins * verification coll: subselect on card + dashboard * fix the 3 failing BE tests * add an api test for dashboard verification * verified dashboards are never stale * e2e tests * code cleanup * unit test and e2e test cleanup * PR Feedback * backend test fixes * Nick shouldn't touch clojure * type fix * indent * fix last 2 BE tests --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
- Oct 30, 2024
-
-
Noah Moss authored
-
- Oct 28, 2024
-
-
John Swanson authored
The audit collection is a bit weird. Users have permissions on the collection but even superusers don't actually have write permissions on the elements within it. For now, I'm just excluding anything in the audit collection from the "stale" endpoint, so we won't suggest cleaning these up, but I wonder if maybe there's a cleaner way here. It feels weird to fake permissions like this. Fixes https://github.com/metabase/metabase/issues/49164
-
- Oct 24, 2024
-
-
bryan authored
* upgrades is-airgapped? defn to defsetting airgap-enabled - uses the airgap-enabled settings value to remove Cloud section in SettingsEditor - "Metabase Enterprise Airgap" -> "Enterprise Airgap" * hide still need help section in airgap mode * move flag checking into selectors * fe lint * ts type check * use optional chaining and nullish coalescing * hide StillNeedHelp in ag mode * adding airgap-enabled to createMockSettings --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
- Oct 22, 2024
-
-
Oisin Coveney authored
-
- Oct 18, 2024
-
-
Cam Saul authored
* Modularize metabase.pulse; add metabase.pulse.core API namespace * Rename metabase.pulse.send-test * Split email result attachment stuff into its own namespace * Update dashboard-subscription-test * Allow metabase.email.result-attachment externally... for now * More code cleanup * Decouple models.card and email.messages * Decouple models.collection and metabase.email.messages * Hopefully the last fix
* Fix #48647 * Fix event handler * :render/text, not :pulse/text * Test fixes * Test fix * RESPECT the modules * Remove unused namespace -
Dennis Schridde authored
Store API can handle higher load and customers might want to see changes earlier. Fixes: cc28ee60
-
- Oct 17, 2024
-
-
Noah Moss authored
-
Alexander Solovyov authored
-
- Oct 15, 2024
-
-
Ngoc Khuat authored
-
- Oct 14, 2024
-
-
Ngoc Khuat authored
* [Notification] Migrate user invited email (#48215) * [Notification] Migrate alert create email (#48292) * [Notification] Migrate slack token error email (#48333)
-
bryan authored
-
Cam Saul authored
* Collapse `metabase.shared.*` namespaces * Fix Kondo warnings * Does updating the stories-data keys fix the failing tests? * Appease msgcat * Appease msgcat * Fix typo * Make the build happy * Appease fslint
-
- Oct 11, 2024
-
-
Noah Moss authored
-
- Oct 10, 2024
-
-
Ngoc Khuat authored
* [Notification] Notification and subscription (#47707) * [Notification] Notification and subscription (#47707) * [Notification] Handlers + recipients (#47759) * [Notification] Channel template table and model (#47782) * [Notification] Render system event emails (#47859) * [Notification] Strict type for channel template and notification recipient (#47910) * [Notification] Event hydration (#47953) * [Notification] Send asynchronously (#48200)
-
- Oct 08, 2024
-
-
Nicolò Pretto authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Cam Saul authored
* Parallel driver tests PoC * Set fail-fast to false for now * Try splitting up non-driver tests to see how broken tests are * Whoops fix plain BE tests * Ok nvm I'll test this in another branch * Fix fail-fast * Experiment with the improved Hawk split logic * Fix some broken/flaky tests * Experiment: try splitting MySQL 8 tests into FOUR jobs * Divide other Postgres and MySQL tests up and use num-partitions = 2 * Another test fix
* Flaky test fix * Try making more stuff fast * Make athena fast?? * Fix a few more things * Test fixes? * Fix configs * Fix Mongo job syntax * Fix busted test from #46942 * Fix Mongo config again * wait-for-port needs to specify shell I guess * More cleanup * await-port can't have a timeout-minutes I guess * Let's only parallelize MySQL for now. * Cleanup action * Cleanup wait-for-port action * Fix another flaky test * NOW driver tests will be FAST * Need to mark driver tests too * Fix wrong tag * Use Hawk 1.0.5 * Fix busted metabase.public-settings-test/landing-page-setting-test * Fix busted `metabase.api.database-test/get-database-test` etc. (hopefully) * Fix busted `metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test` for Oracle * Maybe this fixed `metabase.query-processor.middleware.permissions-test/e2e-ignore-user-supplied-perms-test` maybe not * Fix busted metabase.api.dashboard-test/dependent-metadata-test because endpoint had differemt sort order than test * Ok my test fix did not work * Fix metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test for Redshift * Better test name * More test fixes * Schema fix * PR feedback * Split off test partitioning into separate PR * Fix failing Oracle tests * Another round of test fixes, hopefully * Fix failing Redshift tests * Maybe the last round of test fixes * Fix Oracle * Fix stray line
-
- Oct 07, 2024
-
-
metamben authored
Implement better partitioning and sorting in window functions
-
Case Nelson authored
* feat: move auth providers behind ee token Fixes #48235 Introduces new premium feature `database-auth-providers`. Moves fetch-auth behind defenterprise - oss will always return an empty map. Add metabase.util.http to test outbound http requests. * Fix broken refs * Drop defmethod as adhoc overrides aren't desirable outside ee * Drop unessary require * Fix token and tests * Fix tests * Fix formatting * Fix var cast exception * Fix connection test * Move test to ee namespace * Move more tests behind enterprise * Fix checked-section hiding
-
Ryan Laurie authored
* look I did a clojure! * only show entity ids when serialization is enabled * update tests * ok fine typescript * fix test
-
- Oct 01, 2024
-
-
Noah Moss authored
-
- Sep 27, 2024
-
-
Braden Shepherdson authored
This was old logic to support certain drivers (eg. pre-JDBC Druid) and isn't required for most. It's perfectly sound to filter or even break out on a datetime column without bucketing. Adds a new `:temporal/requires-default-unit` driver feature, and enables it only for the legacy Druid driver. Fixes #47341
-
- Sep 26, 2024
-
-
lbrdnk authored
* Databricks JDBC driver base * Add databricks CI job * WIP data loading -- it works, further cleanup needed * Cleanup * Implement ->honeysql to enable data loading * Hardcode catalog job var * Implement driver methods and update tests * Derive hive instead of sql-jdbc * Cleanup leftovers after deriving hive * Run databricks tests on push * Cleanp and enable set-timezone * Disable database creation by tests * Add Databricks to broken drivers for timezone tests * Exclude Databricks from test * Enable have-select-privilege?-test * Restore sql-jdbc-drivers-using-default-describe-table-or-fields-impl post rebase * Restore joined-date-filter-test * Adjust to work with dataset definition tests * Adjust alternative date tests * Remove leftover reflecttion warning set * Update test exts * cljfmt vscode * Add databricks to kondo drivers * Update metabase-plugin.yaml * Update databricks_jdbc.clj * Rework test extensions * Update general data loading code to work with Databricks * Reset tests to orig * Use DateTimeWithLocalTZ for TIMESTAMP database type * Convert to LocalDateTime for set-parameter * Update test extensions field-base-type->sql-tyoe * Update database-type->base-type * Enable creation of time columns in test data even though not supported * Fix typo * Update tests * Udpate tests * Update drivers.yml * Disable dynamic dataset loading tests * Adjust the iso-8601-text-fields-should-be-queryable-date-test * Update load-data/row-xform * Add time type exception to test * Update test data loading and enable test * Whitespace * Enable all driver jobs * Update comment * Make catalog mandatory * Remove comment * Remove log level from spec generation * Update sql.qp/datetime-diff * Update read-column-thunk * Remove comment * Simplify date-time->results-local-date-time * Update comment * Move definitions * Update test extension types mapping * Remove now obsolete ddl/insert-rows-honeysql-form implementation * Update sql-jdbc.conn/connection-details->spec for perturb-db-details * Update load-data/do-insert! * Remove ssh tunnel from driver as tests do not work with it * Update test * Promote ::dynamic-dataset-loading to :test/dynamic-dataset-loading and modify corresponding tests * Adjust to broken TIMESTAMP_NTZ sync * Update read-column-thunk to return timestamps always in Z * Comment * Disable tests for dynamic datasets * Return spark jobs into drivers.yml * Update Databricks CI catalog * Remove vscode cljfmt tweak * Update iso-8601-text-fields-expected-rows * Update datetime-diff * Formatting * cljfmt * Add placeholder test * Remove comment * cljfmt * Use EnableArrow=0 connection param * Remove comment * Comment * Update tests * cljfmt * Update driver's deps.edn * Update tests * Implement alternative `describe-table` * WIP Workaround for timestamp_ntz sync, will be thrown away probably * Update metabase-plugin.yaml with schema filters * Update driver to use schema filters and remove now redundant sync implemnetations * Update tests * Update tests extensions * Update test * Add feature flags for fast sync * Implement describe-fields * Implement describe-fks-sql * Enable fast sync features * Use full_data_type * Comment * Add exception for timestamp_ntz columns to new sync code * Implement db-default-timezone * Add timestamp_ntz ignored test * Add db-default-timezone-test * Fix typo * Update setReadOnly * Add comment on setAutoCommit * Update chunk-size * Add timezone-in-set-and-read-functions-test * Drop Athena from driver exceptions * Use set/intersection instead of a filter * Add explicit fast-sync tests * Update describe-fields-sql and add comment * Add preprocess-additional-options * Add leading semicolon test * Disable dataset creation and update comment * Rename driver to `databricks` * Use old secret names * Fix wrongly copied hsql list * Temporarily allow database creation * Add *allow-database-deletion* * Temporarily allow database creation * Disable database creation * cljfmt * cljfmt
-
- Sep 25, 2024
-
-
Noah Moss authored
Co-authored-by:
Thomas Schmidt <thomas@metabase.com>
-
John Swanson authored
* Require `:encryption` for string settings For settings that are not typed as JSON, CSV, or strings, encryption now defaults to `:no` (*except* if you have explicitly marked your setting as `:sensitive?` - these will default to `:when-encryption-key-set`). I went through all our settings and provided what I think are reasonable values here. I tried to be conservative - when I wasn't sure whether a stored setting was sensitive, I kept it as encrypted. For example, the `ldap-port` setting is probably non-sensitive but theoretically someone could be using a weird port for security-by-obscurity, so I kept that encrypted. * Change possible values for `:encryption` `:maybe` was confusing: let's be more explicit that the value will be encrypted `:when-encryption-key-set` to make it obvious what actually turns encryption on and off.
-
- Sep 24, 2024
-
-
Chris Truter authored
-
- Sep 20, 2024
-
-
Chris Truter authored
* Return the table id from csv upload (as a header) * Add date format that google sheets uses * Smuggle id * done? * comment * with empty h2 db * dashing * fix flaky test * Parse the correct date class --------- Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
- Sep 13, 2024
-
-
Phoomparin Mano authored
* add license problem hook * add warning banner * style cue component * update cue component * report issue to console * report issue to console * use sdk loader for pre-initialization * extract print problem method * use non-standard shadows * add unit tests * prevent console log spam during tests * mock the embedding token feature * mock the embedding token feature by default * add more test cases * add test case * add test cases * increase popover z-index * simplify test setup * simplify test setup * do not load individual component when a license error happens * move SdkLicenseProblemDisplay component out * replace colors with color-mix * replace colors with color-mix * make the text unthemed to ensure legibility * hard-code colors to prevent them from being themed * hard-code colors to prevent them from being themed * update border styles * make the chevron unthemed * unset console text color * only set stroke on errors * optimistic query settings * document the sdk license condition * remove redundant condition * add notes on api keys always being allowed on localhost * move the no auth method message to warning component * rename sdk license problem to usage problem * add eslint rule for stories * rename sdk license problem to usage problem * move sdk usage problem display out of the init controller * specify fallback font if instance is down or CORS error * add comments on conditions pending on the CORS PR * add notes on non-localhost checks * make test ids constant * add test case for neither provided * fix types * address code reviews * pass `embedding-sdk` flag in `token-features` * address code review Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * remove appName from console logs * rename embedding-sdk to embedding_sdk * add the embedding_sdk premium token feature * do not setup enterprise plugin in sdk test * do not localize visual cue messages * fix unit test in setup-sdk-auth * rename tests * remove unused eslint-disable * enable embedding_sdk premium feature for sdk unit tests * revert security_test.clj to use embedding instead of embedding-sdk * remove unneeded test * changes to support the style leak fixes --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Alexander Solovyov authored
so we need to account for that in serialization paths, storage paths and when exporting/importing foreign keys
-
- Sep 10, 2024
-
-
John Swanson authored
* Move stale endpoint to /ee/stale/${collection-id} It's an enterprise-only endpoint, so it makes sense to put the whole thing under enterprise. * refactors ui to use ee stale endpoint lint fixes, change endpoint location fix failure e2e test * Fix endpoint location --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- Sep 09, 2024
-
-
Alexander Solovyov authored
-
- Sep 06, 2024
-
-
Noah Moss authored
-
Alexander Solovyov authored
-
- Sep 05, 2024
-
-
Alexander Solovyov authored
-
- Sep 04, 2024
-
-
Cam Saul authored
* Bump Kondo version to 2024.08.29 * Fix Kondo warnings from new version of Kondo * Fix failing tests because schema was broken
-