Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 05, 2021
  2. Aug 04, 2021
  3. Aug 03, 2021
    • dpsutton's avatar
      correct moderation review hydration (#17311) · 84f4509d
      dpsutton authored
      * remove moderation reviews hydration
      
      * Restore hydration of moderation_reviews and handle correctly
      
      nested hydration is (i think) positional. So if you get something
      handed to you you must return something in that position. Prevoiusly
      was removing nils and then returning a smaller collection of hydrated
      items (cards here). But this meant input might look like this
      
      [card1 nil card2] and return [card1 card2] and in the nested hierarchy
      things didn't get matched up correctly.
      
      In the real world application it might look like this:
      
      ```clojure
      {:ordered-cards
       [{:card-id 1}
        {:card-id nil
         :viz-settings {info-for text-card}}
        {:card-id 2}]}
      ```
      
      And the nil card comes into this function and we return them in a
      strange manner things get wonky
      Unverified
      84f4509d
    • Maz Ameli's avatar
      update strings for 0.40.2 · 730cb591
      Maz Ameli authored
      730cb591
    • Nemanja Glumac's avatar
      Update `project.clj` references (#17294) · af99fc02
      Nemanja Glumac authored
      * Remove `project.clj` from Percy workflows
      
      * Replace `project.clj` with `deps.edn` in `build-for-test` script
      
      * Update reference to the `project.clj` in the comment
      Unverified
      af99fc02
    • Howon Lee's avatar
      Make the field search do limits (whacks #17228) (#17283) · 6331c3b1
      Howon Lee authored
      We're playing this whackamole because we added the middleware to universally sorta stomp on any `limit` or `offset` params, and they got stomped on. Which, in turn, led to my PR to make the default not limited. Which, in turn, led to the other issue this PR solves which makes the search things we relied upon to not have a limit, have a limit.
      Unverified
      6331c3b1
    • Nemanja Glumac's avatar
      Use `jest-dom/extend-expect` library globally (#17292) · 84a6abd1
      Nemanja Glumac authored
      * Register `@testing-library/jest-dom/extend-expect` globally
      
      * Remove unnecessary imports from unit tests
      Unverified
      84a6abd1
    • Luis Paolini's avatar
    • Cam Saul's avatar
    • Cam Saul's avatar
      :race_car::race_car::race_car: test runner improvements :race_car::race_car::race_car: (#17286) · e1e815f8
      Cam Saul authored
      * Add some dox
      
      * Rename test-runner & cloverage -> metabase.test-runner & metabase.cloverage-runner
      
      * Move JUnit-related test runner code to separate namespace
      
      * Bespoke JUnit-output code
      
      * Delete unused .lein-classpath file
      
      * Do JUnit writes in a cached thread pool
      
      * Add failing test to make sure JUnit output works as expected...
      
      * Move bad-test to metabase.bad-test so the FAILING tests actually run
      
      * FASTER TEST LOADING :race_car:
      
      * Test CircleCI :system-out
      
      * Final cleanup (hopefully)
      
      * Sort some namespaces; allow initializing :plugins when namespaces get loaded for now.
      
      * Need those [[tags]] in docstrings
      
      * Fix bad docstring
      Unverified
      e1e815f8
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
    • Alexander Lesnenko's avatar
    • Dalton's avatar
      Add the ability to verify/unverify questions (#17030) · b7fa2f34
      Dalton authored
      * rmv old bucm icons and remove verified fill color
      
      * add moderation action section to sidebar
      
      * add moderation review icon to the saved question header button
      
      * hide moderation section when is not a moderator
      
      * add UI for ModerationReviewBanner
      
      * Backend for moderation-review
      
      - create table moderation_review. Same as before but also has a
        "most_recent" boolean flag for the most recent moderation for easy
        lookup
      - POST /moderation-review/ . Status can be "verified" or nil
      - must be an admin to post
      - No PUT or edit route yet. Not sure if this is even
        necessary. _MAYBE_ to edit the text, but certainly not for the
        status, ids, etc. If there's to be history, let's build some history
      - Ensure we never have more than 10 reviews. Adding a new review will
        delete the older ones, mark all old ones as not `most_recent`, and
        add the newest one as `most_recent true`
      - Ensure the card actually exists before creating the mod review
      - Since admin only at this time, don't need to check moderate
        permission or view permission
      - When hydrating ensure reviews are ordered by id desc. Should mimic
        the created_at desc
      
      * fix moderation review banner tooltip offset
      
      * disable verification button when already verified
      
      * rmv iconOnly prop because it seems to do nothing
      
      * update getLatestModerationReview to rely on most_recent boolean
      
      * Return 400 on invalid status to post /moderation-review
      
      the schema was using keywords on the left hand side rather than the
      symbols. Required a change to the docstring generator, when it made a
      docstring for enums, it would call (sort (:vs enum)) and need to
      string em.
      
      * Add ModerationReview model to models.clj and copy infra
      
      * hydrate moderation reviews on cards
      
      * clean up + wire up to BE + ensure mod buttons don't show for normal users
      
      * rmv unused moderation redux logic from QuestionDetailsSidebarPanel
      
      * finish writing unit tests for FE
      
      * ensure getIconForReview returns an object
      
      * enable/disable verify button tooltip when unverified/verified
      
      * add e2e tests
      
      * fix tests
      
      * styling tweaks
      
      * more styling on moderationReviewBanner
      
      * add function for abbreviated timestamp
      
      * increase fontsize of timestamp back to 12
      
      * fix tooltip offset
      
      * ensure custom locale is separate from 'en' and not used for other languages
      
      * Deletion moderation reviews when deleting cards
      
      i had actually thought this was a much larger problem. But it turns
      out we almost never delete cards (thanks comment!). And so we won't
      really generate a lot of garbage.
      
      I was worried that since we aren't using actual foreign keys but just
      `moderated_item_type "card"` and `moderated_item_id 2` we would have
      deleted cards with these moderation reviews but that is not the case
      as the cards aren't deleted.
      
      * hide verify disabled button when a question is verified
      
      * update test to use queryByTestId
      
      * Hydrate moderation reviews on cards on ordered cards
      
      * Handle mysql's lack of offset functionality
      
      mysql cannot handle just a `offset` clause, it also needs a limit
      
      clause grammar from
      https://dev.mysql.com/doc/refman/8.0/en/select.html:
      
      [LIMIT {[offset,] row_count | row_count OFFSET offset}]
      
      select id, name from metabase_field offset 5;         -- errors
      select id, name from metabase_field limit 2 offset 5; -- works
      
      Since our numbers are so small here there is no worry and just do the
      offset in memory rather than jump through hoops for different dbs.
      
      * Batch hydrate moderation reviews
      
      * Don't let /api/user/:userId failure conceal moderation banner
      
      * fix moderation cy tests
      
      * work around possible bug in toucan hydration
      
      dashboards hydrate ordered cards
      (hydrate [:ordered_cards [:card :moderation_reviews] :series])
      
      Ordered_cards are dashboard_cards which have an optional card_id. But
      toucan hydration doesn't filter out the nils as they go down. It seems
      toucan returns a nil card, and then when hydrating the
      moderation_review, passes the collection of all "cards" including the
      nil ones into the hydration function for moderation_reviews
      
      This feels like a bug to me
      
      * Cleanup moderation warnings
      
      * Docstring in moderation review
      
      * include hoisted moderated_status on cards in collections api
      
      * Expect unverified in test :wrench:
      
      
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Co-authored-by: default avataralxnddr <alxnddr@gmail.com>
      Unverified
      b7fa2f34
    • Dalton's avatar
      Handle mutation of vizSetting column when syncing columns in a native question (#17279) · dee19dfb
      Dalton authored
      * Handle mutation of vizSetting column when syncing columns of a native question
      
      When calling Question's _syncNativeQuerySettings method we need to treat
      existing, mutated columns as invalid so that they are filtered out and a
      new column takes the existing column's place.
      
      The function we use to find valid columns, findColumnIndexForColumnSetting,
      will return true if it finds a matching field_ref OR a matching name, so we
      also need to check the addedColumns array we just created in order to remove
      any columns from vizSettings that also exist there, since we combine the two
      at the end of this method.
      
      * add unit tests for _syncNativeQuerySettings
      Unverified
      dee19dfb
    • Nemanja Glumac's avatar
      Update lein references in scripts (#17291) · c4d777ac
      Nemanja Glumac authored
      * Remove `yarn start` script
      
      * Remove `lein docstring-checker` and `lein-bikeshed` scripts
      
      * Update `lein` references in `ci-backend` script
      Unverified
      c4d777ac
    • Luis Paolini's avatar
      Fix Elastic Beanstalk deployment in v40 (#17261) · d5b89f66
      Luis Paolini authored
      * Intermediate commit
      
      * Add the step to include .platform dir into the bundle
      Unverified
      d5b89f66
  4. Aug 02, 2021
  5. Jul 30, 2021
Loading