* Full support for all dimension types in expression editor (field-id, field-literal, fk->, joined-field, expression)

* Fix various bugs in metabase-lib

* Limit 'card-has-ambiguous-columns?' to native queries + use real DB id in composeThisQuery

* replace metadata.database[...] etc with metadata.database(...)

* Fix and add to tests

* Revert "replace metadata.database[...] etc with metadata.database(...)"

This reverts commit 0f5aa69be184a1a767675e253eace47a419d970a.

* Fix joined dimension options, e.x. custom field from a saved query

* don't run native queries with invalid template tags

* fix test

* Fix drill through actions not working with joins

* QuickFilterDrill unit test

* Add Dimension and Field 'foreign' methods, fix Dimension and Field 'column' methods

* Update sample dataset test fixtures with convienent aliases

* More fixture cleanup

* Fix lint and flow

* more fixture cleanup

* fix e2e test

* Fix drill through to question user doesn't have all data permissions for. Resolves #7928

* Fix flow

* Fix #10656

* Tests

* Fix lint + add a couple cute aliases

* fix object detail logic + add test

* Misc fixes for when the user doesn't have data permissions for the current question

* fix prettier error

* Fix additional fields with joined columns
* Put 'joined-field' fields in join's 'fields'

* Fix default dimension for joined dimensions. Resolves #10441

* Fix default joined dimension + improved join alias

* Joined fields: use FK name (implicit) or join alias (explict)
[ci drivers]

* Use join alias as display name

* Only use fk fields for join alias

* Special case setDefaultAlias for 'Saved Questions' tables. Resolves #10548

* Fix query cleaning when switching out of notebook mode

* Fix NestedStructuredQuery::question()

Use underlying db id for saved questions 'tables' in order to show correct notebook options + joinable questions

* Misc layout polish. Resolves #10448

* Improve table scrolling performance

* Fix double scroll issue in data selector

* Flow

* Fix button snapshot test

* Fix e2e test

* comments

* replace accordian with accordion everywhere (#10449)

* a game of tag tagging untagged strings

Notebook Mode + View Mode + Joins + etc

Dimension: normalize fk->, use normalized .mbql() in isEqual, fix render for DateTime/Binned, add tests

Add a function to entities to consistently get the correct object from the result of an entities action.

* Reenable comparisons

* Color by segment, add segment names to legends

* Add provisional API endpoint and UI hook via related

* Reorder defns

* Remove unneeded requires

* Ensure all segment components are present in the comparison

* Don't inherit `query-filter`

* Change api endpoint argument name to avoid broken magic

* Manually cast ids to int

* Don't try to recast ints to int

* Don't split Y axis for overlay cards

* Add segment descriptions where possible. Move segment summary up top

* Add backend tests, factor out common utilites for testing xrays

* Add frontend tests

* Add "compare with entire dataset" related for segments.

* Account for description row height

* Add related

* Don't use u/get-id where we might be dealing with adhoc queries

* Improve copy. Make cell titles more sensible

* Split cases where we have query-filter and cell-query

* Introduce [[this.foo]] syntax and make GenericTable and segments nice

* Alow acces to both root and what's binded to this via dot notation

* Don't stuff filter clauses into `cell-query`.

* small tweaks and fixes

* fix typo short-title -> short-name

* Change cell xray to be based off card xray

* downsize titles when merging dashboards

* Fix enumeration of field names in titles

* Correctly handle cell xrays of questions with multiple breakout dims

* Fix regression in candidates

* Fix broken url generation

* Test for more working correctly

* Don't show cards and filters where breakdown dim is a cell dim

* don't explode if cell-query is nil

* Correct title for questions with no breakout dimension

* tests: set up collection for cards so that permissions work

* entry action

* remove use of 'these'

* explicitly test for show=1

* fix indentation

* Appease the defendpoint gods

* update url

* drill entry points

* Don't throw away :query-filter for adhocs; expand segment macros

* Add docstring

* Don't skip small categories in GenericTable

* correctly flow query-filter to aggregate card constituents

* more robust save dashboard test

* Fix nested cards and improve filter merging

* Fix a bunch of bugs

* remove unneeded require

* Flatten filters where possible

* Discard cell-query for comparison side

* upgrade all calls to the new api

* Fix drill through links

* Fix cell comparisons. This time for real :(

* Flatten filter clause

* Don't show superfluous datetime components

* update tests

* fix tiny typo

* reorder minute and hour titles, remove comma from year titles

* Humanize periodical datetime components nicer

* Fix related

* fix regression

* Properly handle timezone

* Add type hint

* fix wrong arg order. ADD TESTS for datetime humanization

* Fix type hint

* fix dangling  in day-of-week xrays

* Add day-of-year and test for all the available units

* Retain structure (provisional)

* Update test

* address sameer's feedback

* Fix bad merge

* Add comparison_title

* better distribution comparison title

* Top align titles

* Better cell titles; skip redundant titles

* Add comparison_title to heursitics

* Make flow happy

* Generate correct title for cells of row questions

* Shorter names for segments, don't split Y axis in overlays