This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 21, 2022
-
-
Braden Shepherdson authored
-
- Jul 19, 2022
-
-
Cam Saul authored
* Fix CircleCI job skipping magic: `$CIRCLE_STAGE` has been renamed to `$CIRCLE_JOB` * Bust cache if `$CIRCLE_JOB` is unset * Print message if `$CIRCLE_JOB` is unset and we're busting the cache * Fix GoogleAnalytics status code
-
- Jun 27, 2022
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Run the remaining E2E groups using GitHub Actions * Remove Snowplow from CCI * Remove waiting for databases from CCI * Remove Cypress jobs from CCI * Remove `fe-deps` from CCI * Remove `tester` executor from CCI * Remove all frontend-related from CCI * Remove static viz bundle from CCI * Remove E2E checksum from CCI * Remove frontend checksum from CCI * Trigger CI run #1 * Trigger CI run #2 * Trigger CI run #3 * Trigger CI run #4 * Trigger CI run #5
-
- Jun 24, 2022
-
-
Diogo Mendes authored
-
- Jun 21, 2022
-
-
Nemanja Glumac authored
-
- Jun 20, 2022
-
-
Nemanja Glumac authored
-
- Jun 17, 2022
-
-
Nemanja Glumac authored
-
- Jun 15, 2022
-
-
Nemanja Glumac authored
-
- Jun 13, 2022
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Jun 08, 2022
-
-
metamben authored
We have already had support for server authentication based on custom certificates. This change adds support for authenticating the client based on custom client key and certificate.
-
Nemanja Glumac authored
-
- Jun 06, 2022
-
-
Nemanja Glumac authored
-
- Jun 03, 2022
-
-
Nemanja Glumac authored
-
- Jun 02, 2022
-
-
Nemanja Glumac authored
-
- May 28, 2022
-
-
Nemanja Glumac authored
-
- May 27, 2022
-
-
Diogo Mendes authored
-
- May 26, 2022
-
-
Nemanja Glumac authored
-
- May 24, 2022
-
-
Nemanja Glumac authored
-
- May 23, 2022
-
-
Ariya Hidayat authored
-
- May 17, 2022
-
-
Bryan Maass authored
* bumps outdated deps versions to be current * un-upgrade h2 and jetty * un-upgrade joda-time and kixi/stats * drop Java 8 support in circle CI config - things that used to rely on be-tests-java-8-ee now rely on be-tests-java-11-ee * remove java 8 from github health check matrix * revert toucan to 1.17.0 * revert mariadb java client to 2.7.5 * Back to 18, and handle new behavior toucan used to just look in *.models.<model-name> for models and just give up apparently. I made a feature that toucan will look in a model registry to create models rather than using the convention https://github.com/metabase/toucan/commit/762ad69defc1477423fa9423e9320ed318f7cfe7 but now we're getting errors in these tests about maps vs models. ```clojure revision_test.clj:154 Check that revisions+details pulls in user info and adds description expected: [#metabase.models.revision.RevisionInstance{:is_reversion false, :is_creation false, :message nil, :user {:id 1, :common_name "Rasta Toucan", :first_name "Rasta", :last_name "Toucan"}, :diff {:o1 nil, :o2 {:name "Tips Created by Day", :serialized true}}, :description nil}] actual: (#metabase.models.revision.RevisionInstance{:description nil, :is_creation false, :is_reversion false, :user {:id 1, :first_name "Rasta", :last_name "Toucan", :common_name "Rasta Toucan"}, :message nil, :diff {:o1 nil, :o2 #metabase.models.revision_test.FakedCardInstance{:name "Tips Created by Day", :serialized true}}}) ``` The only difference here is `:o2` is a `metabase.models.revision_test.FakedCardInstance` but still has the same keys, `:name`, and `:serialized`. So all is well, we're just able to make the model. So a few different fixes. Some are use `partial=` which doesn't care about record/map distinction. Some are just make the model, and some are turning them into maps for revision strings (which more closely mimics what the real revision stuff does): ```clojure (defn default-diff-map "Default implementation of `diff-map` which simply uses clojures `data/diff` function and sets the keys `:before` and `:after`." [_ o1 o2] (when o1 (let [[before after] (data/diff o1 o2)] {:before before :after after}))) (defn default-diff-str "Default implementation of `diff-str` which simply uses clojures `data/diff` function and passes that on to `diff-string`." [entity o1 o2] (when-let [[before after] (data/diff o1 o2)] (diff-string (:name entity) before after))) ``` So all in all this change impacts nothing in the app itself, because those models follow convention and are correct in `metabase.models.<model-name>` and are thus "modelified": ```clojure revision-test=> (revision/revisions Card 1) [#metabase.models.revision.RevisionInstance{:is_creation true, :model_id 1, :id 1, :is_reversion false, :user_id 2, :timestamp #object[java.time.OffsetDateTime "0x77e037f" "2021-10-28T15:10:19.828539Z"], :object #metabase.models.card.CardInstance {:description nil, :archived false, :collection_position nil, :table_id 5, :database_id 2, :enable_embedding false, :collection_id nil, :query_type :query, :name "ECVYUHSWQJYMSOCIFHQC", :creator_id 2, :made_public_by_id nil, :embedding_params nil, :cache_ttl 1234, :dataset_query {:database 2, :type :query, :query {:source-table 5, :aggregation [[:count]]}}, :id 1, :display :scalar, :visualization_settings {:global {:title nil}}, :dataset false, :public_uuid nil}, :message nil, :model "Card"}] ``` so the model/no-model is just arbitrary distinction in the test. All of them in the actual app are turned into models: ```clojure (defn- do-post-select-for-object "Call the appropriate `post-select` methods (including the type functions) on the `:object` this Revision recorded. This is important for things like Card revisions, where the `:dataset_query` property needs to be normalized when coming out of the DB." [{:keys [model], :as revision}] ;; in some cases (such as tests) we have 'fake' models that cannot be resolved normally; don't fail entirely in ;; those cases (let [model (u/ignore-exceptions (db/resolve-model (symbol model)))] (cond-> revision ;; this line would not find a model previously for FakedCard and ;; just return the map. But now the registry in toucan _finds_ the ;; model defintion and returns the model'd map model (update :object (partial models/do-post-select model))))) (u/strict-extend (class Revision) models/IModel (merge models/IModelDefaults {:types (constantly {:object :json}) :pre-insert pre-insert :pre-update (fn [& _] (throw (Exception. (tru "You cannot update a Revision!")))) :post-select do-post-select-for-object})) ``` * try using mssql-jdbc 10.2.1.jre11 - Important that we get off the jre8 version * various fixes that needn't be reverted * Revert "various fixes that needn't be reverted" This reverts commit 2a820db0743d0062eff63366ebe7bc78b852e81f. * go back to using circle ci's java 11 docker image * java-16 (?) -> java-17 * Revert "go back to using circle ci's java 11 docker image" This reverts commit b9b14c535a689f701d7e2541081164288c988c4e. Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- May 16, 2022
-
-
Luis Paolini authored
* New CI image * Upgrade to new Clojure CLI version + multi arch images + add git to Builder images [ci nocache]
-
- May 10, 2022
-
-
Diogo Mendes authored
-
- May 04, 2022
-
-
Nemanja Glumac authored
-
- Apr 27, 2022
-
-
Nemanja Glumac authored
* [E2E] Create and run new `organization` CI group * Run `organization` group in CI * Remove `moderation` from the PR check
-
Nemanja Glumac authored
* Extract specs related to `fitlers` in a separate folder * Run new `filters` E2E group in CI
-
- Apr 25, 2022
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Merge dashboard filters * Run merged dashboard filters in CI * Remove `dashboard-filters-sql` from E2E on `master`
-
- Apr 19, 2022
-
-
Nemanja Glumac authored
-
- Apr 14, 2022
-
-
Nemanja Glumac authored
-
- Apr 12, 2022
-
-
Nemanja Glumac authored
* Rename `test-cypress-no-build` to `test-cypress-run` * Rename `test-visual-no-build` to `test-visual-run` * Reorder scripts * Remove yarn (install) from the Cypress run script
-
- Mar 31, 2022
-
-
Nemanja Glumac authored
This reverts commit 160c3c7231cb1340ee19b98b16937d90828a8b94.
-
- Mar 29, 2022
-
-
Pawit Pornkitprasan authored
New releases of maildev were recently made which has UI changes as well as changing the default port from 25 to 1025, causing tests to fail. While we may want to upgrade maildev in the future, let's stick to the old version first to unbreak all the tests.
-
- Mar 26, 2022
-
-
Diogo Mendes authored
* Removing from CCI * Adding Currents to GHA * Let there be run * Returning to master * Adding new key to new project on Currents * Adding --ci-build-id to support GHA Re-Runs * Returning to branch to test it more * Removing not needed info (repo) * Returning to master
-
- Mar 23, 2022
-
-
Diogo Mendes authored
* Running Currents only on Master * [ci noskip] Ident * [ci noskip] ident comment * [ci noskip] Fixing yaml * [ci noskip] creating forlders * [ci noskip] space
-
Diogo Mendes authored
-
- Mar 18, 2022
-
-
Diogo Mendes authored
* Adding currents * Update .circleci/config.yml Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 17, 2022
-
-
Diogo Mendes authored
-
- Mar 16, 2022
-
-
Diogo Mendes authored
-