This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 16, 2020
-
-
Damon P. Cortesi authored
* Add repro for #8472 * Update test file location * Add additional XHR assertion for "nodata" user Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Lewis J Ellis authored
-
Nemanja Glumac authored
* Add repro for #13469 * Simplify test We don't need to test for numeric values, so the second check (loop) was unnecessary.
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Oct 15, 2020
-
-
Cam Saul authored
-
Cam Saul authored
Merge release 0.36.x into master 10-14-2020
-
Tim Macdonald authored
-
Kyle Doherty authored
-
Paul Rosenzweig authored
-
Nemanja Glumac authored
* Add Cypress metadata test for custom remapping * Delete older, less complete test
-
Cam Saul authored
-
Nemanja Glumac authored
* Convert `drillthroughs.e2e` tests to Cypress (#13128) [ci skip] Convert e2e tests from drillthroughs.e2e.spec.js to Cypress tests: - frontend/test/metabase/scenarios/visualizations/drillthroughs/chart_drill.cy.spec.js - frontend/test/metabase/scenarios/visualizations/drillthroughs/dash_drill.cy.spec.js Note:Squashed all previous commits in a branch for cleaner output. Co-authored-by: @nemanjaglumac * Convert `Visualization.e2e` tests to Cypress (#13021) [ci skip] Convert e2e tests from Visualization.e2e.spec.js to Cypress tests: - frontend/test/metabase/scenarios/dashboard/text-box.cy.spec.js Original note by @Opalevanescence : "Some of these tests weren't in Cypress yet, so I added them in." Note: Squashed all previous commits in a branch for cleaner output. Co-authored-by: @nemanjaglumac * E2e to cy/port/dashboard (#13013) [ci skip] Convert e2e tests from dashboard.e2e.spec.js to Cypress tests: - frontend/test/metabase/scenarios/dashboard/dashboard.cy.spec.js Affected files: - frontend/test/metabase/scenarios/dashboard/parameters-embedded.cy.spec.js - frontend/test/metabase/scenarios/dashboard/parameters.cy.spec.js * Quarantined breaking Cypress tests (breaking changes introduced with the work on the dashboard UI) Note: Squashed all previous commits in a branch for cleaner output. Co-authored-by: @nemanjaglumac * Convert `alert.e2e` tests to Cypress (#12969) [ci skip] Convert e2e tests from alert.e2e.spec.js to Cypress tests: - frontend/test/metabase/scenarios/alert/alert.cy.spec.js - frontend/test/metabase/scenarios/alert/alert_auth.cy.spec.js * Quarantined breaking Cypress tests (cannot use email setup in CI) Note: Squashed all previous commits in a branch for cleaner output. Co-authored-by: @nemanjaglumac * Convert `initial_collection.e2e` tests to Cypress (#12968) Convert e2e tests from initial_collection.e2e.spec.js to Cypress tests: - frontend/test/metabase/scenarios/collection_defaults.cy.spec.js * Quarantined breaking Cypress tests (cannot use email setup in CI) Note: Squashed all previous commits in a branch for cleaner output. Co-authored-by: @nemanjaglumac * Delete `PivotByCategoryDrill` e2e test [ci skip] * Delete `metadata` e2e tests * Add `metadata` Cypress test [ci skip] - remapped column value (Product ID => Title) * Delete `SettingsAuthenticationOptions` e2e test [ci skip] NOTE: we already have similar CY test in `frontend/test/metabase/scenarios/admin/settings/settings.cy.spec.js`: - `it("should render the proper auth options", () => {...})` * Delete `segments` e2e test [ci skip] existing CY test file: `frontend/test/metabase/scenarios/admin/datamodel/segments.cy.spec.js` * Delete end-to-end related support and helper files * Remove e2e tests from CircleCI config [ci skip] * Delete references of e2e tests in documentation and replace them with Cypress [ci skip] * Fix and update dashboard related Cypress tests * Fix `parameters` cy test * Fix `metadata` failing test * Fix `parameters` failing test Note: - Asserting on "Rows 1-1 of 2000" was bad idea because card is different size in CI. - The number of visible rows directly depend on the card size Co-authored-by:
Jessica DeWitt <58329466+Opalevanescence@users.noreply.github.com>
-
Kyle Doherty authored
* Fix tooltip sizing + document component (#555) * document Tooltip component * move styling to css, drop conditional based on w/c * set noSnapShotTest true since tooltips use popovers * remove max-width to fix issue with chart popover scrolling * add constrained prop to tooltip, turn off for charts * clearer prop name * only use smaller font on constrainedWidth tooltips
-
dpsutton authored
following template too closely with the `(parent-thunk)` call and forgot it was wrapped in its own thunk so i was calling it before we were using the result set.
-
- Oct 14, 2020
-
-
Cam Saul authored
-
Cam Saul authored
-
Cam Saul authored
-
Cam Saul authored
-
Cam Saul authored
-
dpsutton authored
* First simple pass over sync tests these tests are largely in namespaces that correspond to the source files * Fix ns for the linter gods * Fix ns alias * Goodbye expectations test * Autoresolve keywords to keep in lockstep * Migrates field-value-tests to clojure.test benefit we get far fewer test dbs created * Move tests into `sync_instances_test.clj`
-
Paul Rosenzweig authored
-
Tim Macdonald authored
* Fix a few typos in Pulse-related docstrings * Give `metabot list` special language when there are no results
-
Paul Rosenzweig authored
-
Paul Rosenzweig authored
-
- Oct 13, 2020
-
-
Cam Saul authored
-
Cam Saul authored
* Feature/postgres cypress tests (#13311) Add Postgress tests to Cypress test suite This commit is introducing a new feature by adding a possibility to test Postgress related issues. It adds an updated CI configuration that plays nice with [Docker QA database](https://github.com/metabase/metabase-qa ) (postgress-12). It also adds a few repros, listed below: * Add repro for #12762 * Add repro for #13263 (#13303) --- * Add an example for how to run metabase-qa postgres in CI * Add e2e test for adding/connecting PostgreSQL database (#13296) Co-authored-by: @dacort * Enable test for #13263 * Better error handling for API database list endpoint for invalid drivers * Backport auto-parse-filter-values middleware [ci all] * Parse integers to Longs [ci postgres] Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
dpsutton authored
* Handle mysql YEAR column types (Fixes #13203) [ci drivers] - year columns are very small in the db. The tricky part is how the driver hands them back: either as shorts or as java.sql.Dates. Our standard trick of reading them right into the java.time.LocalDate doesn't work and we instead get the java.sql.Date (which the driver converts from the short internal representation) or the short if `yearIsDateType` is configured to false. It seems to be an open question if Metabase should always consume this as a Date. That seems most likely but I have no idea how often this comes up in practice. * Add typehints [ci drivers] * Consume metadata immediately when checking for YEAR mysql column don't want to access the metadata outside of a `jdbc/with-db-metadata` * Clean up logic for YEAR column types [ci drivers] the `:else` is actually bad syntax. And handle explicitly the nil case and the two types it can be from getObject * Mark YEAR as :type/Date, make tests more reliable column ordering was messing up testing, so ignore the PK and just select the YEAR column * Use `when-let` when checking YEAR column [ci drivers] * Add tests for `table-rows-sample` really just to appease the Book of Cam® for test coverage
-
Nemanja Glumac authored
-
- Oct 12, 2020
-
-
Paul Rosenzweig authored
-
Paul Rosenzweig authored
* add some tests for value formatting * use parameter slugs rather than ids for dashboard links * add test of dashboard -> dashboard linking * add chained filter cypress test * don't go to collection when cancelling dashboard archive * eslint * don't crash when parameter mapping is undefined * use current, unsaved dashboard for crossfilter options * restore feature names to choropleth tooltips * more comments
-
Nemanja Glumac authored
-
dpsutton authored
* Only get substrings in fingerprinting when supported [ci drivers] failing tests in bigquery and mongo as they don't support expressions. * Corrects ns form and gets driver from table def [ci drivers] getting driver from dynamic var was not reliable at this place * Move expression check into `metadata-queries/table-row-sample` debated whether caller should know that whether to pass in truncation options or they might "silently" be ignored. Probably best this way and added that information to docstring.
-
dpsutton authored
* Handle slashes in oracle schema/table names #13225 [ci drivers] table names like `table_slash/` are valid in our normal query apparatus but are invalid in the calls to `.getColumns` and `.getTables` when determining the shape of the database. In these contexts it needs to be `table_slash//` - also get fix TODO to reduce over the list of tables rather than realizing entire result set and then reducing * Test slashes in oracle tablenames [ci drivers] (#13225) * Add test for schema slashes in oracle, stylistic changes [ci drivers] * Oracle db in test suite can't handle 42 character usernames [ci drivers]
-
Paul Rosenzweig authored
-
Nemanja Glumac authored
-
Tim Macdonald authored
-
Robert Roland authored
We should not be logging to a file by default, this was an oversight in the migration to log4j2 Resolves #13422
-
Nemanja Glumac authored
-
Tim Macdonald authored
It wasn't used elsewhere in the codebase and was generating incorrect output in /api/pulse/form_input (spuriously adding #general as a channel when Slack wasn't configured)
-