Co-authored-by: Emmad Usmani <emmadusmani@berkeley.edu>
Co-authored-by: Adam James <adam.vermeer2@gmail.com>
Co-authored-by: Mark Bastian <markbastian@gmail.com>
Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

* prioritize recent items, do not filter search results

* fixing unit test

* temp

* rework DatasetFieldMetadataSidebar to use new form components

* temp

* removing unneeded import

* fixing display name form field

* temp

* more temp

* onChange for form elements

* e2e adjustment

* Add subTitle to ClickActions

* Add examples to column extractions

* Add test for examples

* Add test for examples

* Use rem helper

* Use JSDoc for todo

* Disambiguate between ColumnExtraction and ColumnExtractionInfo

* Update type of getExample

* Use rem helper

* Notebook combine columns (#41379)

* Add CombineColumns dialog component

* Add combine columns to the expression editor widget

* Add placeholder for empty and space to the input

* Drop the first separator

* Remove empty string from eventual concat

* Add example to Combine Colunmns builder

* Show example in monospace

* Do not collapse spaces in example

* Use monospace in separator input

* Reorganise column flatten helper

* Add back button on combine buttons modal

* Select text when focussing separator input

* Add minimum height to example

* Use that same separator as the last row

* Use ExpressionWidgetHeader instead of hand-rolled header

* Fix type when generating example

* Correctly update default separator when a url column gets set

* Swap url and email checks

* Move column input into separate component

* Use QuerySelector for column select

* WIP: customise dropdown

* Export Input

* Use a button to render the column selector

* Add combine icon

* Use shortcut suggestion shortcut for combine columns

* Allow interacting with buttons inside the popover

* Use longDisplayName for button label

* Add asReturned

* Use asReturned in CombineColumns modal

* Make faux-select button styles match normal input

* Return focus to button when select closes

* Fix type of focus event

* Move ColumnInput component to a separate file

* Only show combine column shortcut on custom column

* Add missing test ids

* Add e2e test for combine column shortcut

* Remove white fill from paths

* Add color to combine icon

* Use function expression, not declaration

* Remove comment

* Move initial default separator to constant

* Remove unused select option helpers

* Add isInteger helper to Lib

* Add case for integer columns

* Add unit tests for util

* Add SuggestionShortcut type to props for Suggestions

* Remove {enter} which broke test

* Do not use !important

* Simplify classname into object-style

Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>

* Use direct override on Button instead of class

* Fix formatting issue

* Use .select() to select input

* Avoid selecting placeholder text

* Avoid losing focus when window loses focus

* Rename evt to event

* Add monospace variant to Text

* Use monospace variant in Example

* Use monospace font from theme

* Match faux-select label styles to our TextInput label styles

* Remove empty default variant

* Add limit to the test case

* Remove unnecessary within wrapper

* Use rem

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

---------

Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* Remove intercept we're not waiting for

* Use have.text instead of contain

* Use cy.button

* Expand cancel test

* Remove duplicate title

---------

Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* Re-write E2E repro for 39221

* Convert to TS

Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.

* fix queries being re-run because parameters were being compared with different sorts

* add test to validate and enforce behavior

* CopyQuestionForm

* CopyDashboardForm

* inital values adjustment, e2e tests

* FormObserver

* Fix not sending necessary HTTP headers when downloading results

* Fix fail E2E tests

* Add E2E test

* Fix failed tests

* Fix unit tests

* Fix download on subpath

* Fix unit tests for subpath

* Reset mapping after change of operator for native questions

* Add a basic test

* Better name for a test

Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Co-authored-by: John Swanson <john.swanson@metabase.com>
Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
Co-authored-by: Sloan Sparger <sloansparger@gmail.com>

* Fix parameters parse

* Add e2e test

* Add e2e test

* WIP questionpicker

* use to replace dashcard content

* much better stuff

* question picker

* values source card modal

* create action form

* awesome hacky fix for crashing model detail page

* use entity picker in sandboxing modal

* deprecate ye olde question picker

* keep old question picker in add-card dashboard sidebar

* better last level check

* update types

* make stuff better

* fix rebase conflicts

* better initial value handling

* update e2e tests

* sweet sweet unit tests

* fix sandbox tests

* fix tests

* type fix

* fixes

* search style improvements

* remove unused prop

* safer path detection

* delayed loading spinner

* change confirm default

* set default collection for placeholder card

* address review comments

* update unit tests

* update e2e tests

* fix re-rebase

* add some happy little comments

This reverts commit e0e4ade0.

Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Co-authored-by: John Swanson <john.swanson@metabase.com>
Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
Co-authored-by: Sloan Sparger <sloansparger@gmail.com>

* Add list of most popular functions and aggregations

* Render 'All functions' link on expression dropdown

* Suggest popular functions when no input is given

* Do not return focus to search bar

* Default to not matching any substring

* Open suggestions when the expression editor opens

* Group expressions by group

* Render group titles in dropdown

* Match the expression suggestions height to the design

* Add tests for popular functions

* Convert tests to it-style

* Only return supported popular functions

* Limit most used functions group to 5 items

* Make the suggestion footer keyboard-accessible

* Make a different group for popular aggregations

* Remove padding on suggestion list

* Resize list

* Add test for popular functions in suggest

* Move showMetabaseLinks into args

* Remove unneeded optional chain

* Clarify popup issue in ACE hack

* Use correct target for links

* Reference correct method in comment

* Split up popular expressions

* Remove Set around popular functions/aggregations

* Do not allow interacting with suggestion header

* Do not use _ prefix for variable

* Add verb in test

* Remove unused async in test

* Test if functions are in document

* Move tests for suggestWithFooter to separate file

* Use correct target in link

* Fix typo in key

* Allow picking suggestion when textbox is empty

* Remove unnecessary cast

* Avoid double scroll bars

* Only show link to all functions when editor is empty

* Split up popular functions between expressions and filters

* Fix type of popular variable

* Use the same heuristic for footer as for popular expressions

* Close suggestions when the editor is not focused

* Add missing open prop in test

* Simplify test

* Add selector for expression editor widget

* Fix e2e tests

Fix e2e tests

* Avoid non-interactive clicks from closing the dropdown

* Use custom expression helpers in broken test

* Fix test

* Remove should exist check for selector

* fix progress bar in query builder

* add spec to verify regression fix

* Add help text icon in expression editor suggestions (#41092)

* Add helptext to expression suggestions

* Deduplicate getDatabase calls

* Allow customising popover width

* Split out help text content component

* Render an info icon with the help text

* Remove duplicated defaults for popover

* Explicitly wait for suggestion items in test

* Remove commented out code

* Use React imports directly

* Rename e to evt

* Inline getHelpText when creating suggestions

* Avoid overlapping content

* Remove unnecessary Fragment

* Avoid selecting item when clicking link or button inside element

* Allow shifting popover

* Stop Popover mouse events for bubbling

* Use onMouseDown instead of onMouseDownCapture to avoid clicks inside popover from triggering select

* Add help text to all suggestions that are know mbql functions

* Expression suggestions clean up (#41236)

* Move ExpressionEditorSuggestions to tsx

* Convert ExpressionEditorSuggestions to functional component

* Simplify suggestion match component

* Move ExpressionEditorSuggestions a separate folder

* Remove default export

* Use Popover instead of Tippy for suggestions list

* Fix suggestions tests

* Remove data-ignore-outside-clicks

* Add default for suggestions

* Fix e2e test

* Move helptext wrapper to ExpressionEditorTextfield

* Switch to metabase/ui for Button

* Use arrow function

* collection and db breadcrumbs

* compact breadcrumbs

* adding navigation keybindings

* recent_views and search changes to always include collection or db name

* removing breadcrumbs, display parent name

* removing unneeded components

* e2e and FE unit tests

* waitFor

* e2e tests for keybindings

* help

* be tests passing

* PR feedback and type adjustments

* unit test adjustment

* Keep the original question name in the save modal where possible

Resolves #41196

* Update tests

* Append "- Modified" to a suggested question name

* Preserve the original question description

* Address reviews - adjust the translation string

* Add E2E reproduction

* Remove extra space

* Improve assertions

* increase activation distance for dashboard parameter dragging

* updating drag sensitivity for other places

* adjusting e2e tests

* Remove unused CSS custom properties

* Migrate .ModalContainer

* Migrate .Modal

* Migrate .ModalBackdrop

* Migrate Modal transition classes

* Migrate modal sizes

* Fix tests

* Add missing classes from migration

* Address review: use `data-testid`

* Remove unused classes

* Revert the util that selects Mantine modal

* Improve the fetching logic in a notebook native preview

* Rely on `isFetching` always

* Show a disabled convert button when there's no query

* Add new user-local setting `notebook-native-preview-preferences`

* Update user settings on FE

* Use two distinct setting entries

* Update FE types

* More explicit `notebook-native-preview-sidebar-width` definition

* Add selectors

* Initialize QB uiControls based on the BE settings

* Rename QB store entry

`isNativePreviewSidebarOpen` -> `isShowingNotebookNativePreview`

* Rename QB store entry

`nativePreviewSidebarWidth` -> `notebookNativePreviewSidebarWidth`

* Add Redux actions

* Dispatch user settings on top of Redux store

* Fix test title typo

* Add E2E test to make sure sidebar is resizable

* Expand the E2E test to cover persisting settings across sessions

* Be more explicit that we're resizing along x axis

* Store window breakpoint as a variable

* Calculate handle's left position more explicitly

* make collectionpicker child-aware

* update unit tests

* add another unit test

* move test some place more sensible

* fix rebase