This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 22, 2024
-
-
Aleksandr Lesnenko authored
* fix auto y-axis split on native queries * specs
-
Nemanja Glumac authored
* Fix wrong `target` prop type on `DashCardParameterMapper` * Remove unneeded prop from the test setup
-
bryan authored
* Filter out audit tables in search results * add test
-
Anton Kulyk authored
* Use ASCII arrow characters instead of SVG icons * Increase comparison text font size
-
Chris Truter authored
* Fix salt in pulse unsub hash * Workaround for read-only settings not supporting temp overrides yet
-
Chris Truter authored
-
Chris Truter authored
Ensure we read and update nested JSON in a transaction
-
Chris Truter authored
-
Chris Truter authored
- Introduce an "init" hook for application settings. - Add guards against introducing race conditions again in other ways. - Fix the usage of hygienic scope macros with read only settings. - Lots of misc improvements to settings API and implementation. This init hooks better ergonomics, and protects against race conditions. The previous pattern of calling setters inside getters almost caused a P0. See https://github.com/metabase/metabase/issues/37801.
-
Nemanja Glumac authored
* Migrate Question `isNative` and `isStructured` methods to MLv2 * Mark methods as deprecated * Add the guard to the `isNativeDashCard` util * Add additional guard to the `buildFieldFilterUiParameter` helper * Update all `isNative` method instances to MLv2 * Fix the negation logic
* Remove `isNative()` method altogether * Simplify the `shouldResolveFkField` check Co-authored-by:Kamil Mielnik <kamil@kamilmielnik.com> * Remove explicit Boolean conversion * Simplify conditional logic for `getTargetsForQuestion` --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Ngoc Khuat authored
-
- Jan 19, 2024
-
-
adam-james authored
To prevent ambiguous dashboard URLs, labels should not be called 'tab'.
-
Mark Bastian authored
* Enabling dragging of long-named TabButtons The primary change needed to support rearranging of tabs with super long names is the to shorten the names only when dragging. This was achieved by exposing the `isDragging` prop of the `useSortable` hook in the `RenameableTabButtonStyled` component. The label of this component is dynamically shortened if it is very long on a drag operation by the following logic and function: ``` // Update the label prop when dragging label={isDragging ? dragLabel(label) : label} ``` The `dragLabel` function is as follows: ``` const dragLabel = (s: string) => { if (s.length < 20) { return s; } else { return `${s.slice(0, 17)}...`; } }; ``` The other change needed to support e2e testing for this operation was the addition of the `MouseSensor` hook to the DnDContext. See [this issue comment](https://github.com/clauderic/dnd-kit/issues/208#issuecomment-824469766) for explanation. Once that change was in place it was possible to do a drag and drop rearrange test in the "should allow me to rearrange long tabs (#34970)" spec. This test: - Creates a dashboard with 3 tabs - Ensures their order - Gives the last tab a super long name that would not be rearrangeable before fix - Drags that tab to the first position - Saves the dashboard - Asserts the new tab order is saved Fixes #34970 * Fixing type from T to unknown to satisfy the type of the render function in TabButton.unit.spec.ts * Fixing type from T to any to satisfy the type of the render function in TabButton.unit.spec.ts * Fixing divergent tests The tests to ensure DnD works required the addition of the `mouseSensor` in TabRow.tsx. This, in turn, broke the tests in DashboardTabs.unit.spec.tsx. Adding in the `activationConstraint: { distance: 10 }` prop to the mouseSensor fixed the DashboardTabs.unit.spec.tsx tests, but broke the DnD tests. Based on the docs [here](https://docs.dndkit.com/api-documentation/sensors/mouse) it looks like you need to move a "distance, in pixels, by which the mouse needs to be moved before a drag start event is emitted." So, the DnD test in tabs.cy.spec.js added an addtional mousemove trigger of 11 pixels to activate the mouseSensor. Yeah, it totally makes sense.
* prettier -
metamben authored
Part of #37173.
-
Jeff Bruemmer authored
-
Oisin Coveney authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* Cleanup component * Replace filters with MLv2 methods * Cleanup unused functions * Make filter work * Make filter work * Fix rebase issues * Update ML methods usage * pass params in the correct order * pass params in the correct order * Fix argumetns order * Remove duplicated test and unskip correct one * [Leaflet] Replace brush filter with MLv2 alternative (#37295) * Update ML methods usage * Fix argumetns order * Unskip test * Pass metadata * Pass metadata
-
Nick Fitzpatrick authored
* add force render to auth settings, read only auth card * adding footer prop to auth cards, force render differt auth cards
-
Nemanja Glumac authored
This reverts commit a5dd4444.
-
Braden Shepherdson authored
These are helpers for going from an aggregation or breakout clause to the relevant `:metadata/column`. (Nil for top-level aggregations like `:count`.) Fixes #37120.
-
Cal Herries authored
-
Braden Shepherdson authored
That applies to both freestanding temporal buckets and to breakouts with `:temporal-unit` set. Fixes #36978.
-
Braden Shepherdson authored
Because aggregation refs are based on `:source-uuid` they are not comparable between queries, which breaks some logic to find columns added and removed between two versions of a query. This adds a fallback based on the newly added `:source-name` option on aggregation refs. Fixes #37851.
-
Nemanja Glumac authored
* Introduce a `queryDisplayInfo` abstraction * Address review comments Call `ML.display_info` directly in a new abstraction, and remove the additional function overload. * Tidy up comments
-
Cam Saul authored
-
Anton Kulyk authored
* Turn `Dashboard` into a functional component * Fix loading * Fix loading * Properly type `fetchDashboard` result * Update `tabHasCards` check * Group data fetching `useEffects` into one
-
Ngoc Khuat authored
-
Anton Kulyk authored
* Convert `DashboardApp` to TypeScript * Convert `Dashboard` to TypeScript * Convert `DashboardGrid` to TypeScript * Convert `DashboardHeader` to TypeScript * Bind `setDashboardAttribute` method * Fix adding dashcards * Fix question's "Add to dashboard" flow * Remove `fetchCardData` prop from `DashCard` (not used) * Make `editingTitle` prop optional * Move `fetchPulseFormInput` to `DispatchProps` * Fix TODO types in `DashboardGrid` * Fix error handling * Replace `any` with `unknown` * Fix `any` in `DashboardGrid` * Fix `onMainScroll` type
-
Cal Herries authored
-
- Jan 18, 2024
-
-
Cam Saul authored
* Remove references to shared/ directory which no longer exists * Update shadow-cljs and pinned cider/nrepl versions * Support legacy metadata and raw Dates for brush filter helper functions * Fix fn name * Apply suggestions from code review Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metamben authored
Part of #37173.
-
Jerry Huang authored
* add user-provisioning code * sort namespace * fix linter * fix linter * swap to ee * fix logic * add tests * address comments * fix linter * update tests, address comments
-
lbrdnk authored
* Add timezone to database metadata * Use UTC as _user timezone_ for snowflake driver * Use user timezone as db-default-timezone * Update oracles unprepare-value to handle Z UTC * Update `driver/db-default-timezone :h2` to use jvm timezone * Update containers timezone to match instance timezone and tests * Update modules/drivers/oracle/src/metabase/driver/oracle.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Make unprepare symmetric for offset and zoned datetime --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Jacob Joseph authored
Added MB_JDBC_DATA_WAREHOUSE_UNRETURNED_CONNECTION_TIMEOUT_SECONDS to docs
-
Noah Moss authored
Exclude :card from the parameter types which require defaults to be considered fully parameterized (#37764)
-
Cal Herries authored
-
John Swanson authored
Just add a comment warning that the file is autogenerated and not to edit it by hand.
-
Braden Shepherdson authored
Models can override the `:id` and `:fk-target-field-id` of a column, and can even lie and treat a quantity as a FK. Therefore we have to use the query's view of the column and not the global field from the metadata. This is a speculative fix for #36400, which I can't reproduce locally.
-
Nicolò Pretto authored
-